Update behaviour of PageNavigation.merge
by Matt Wringe
Currently when we are using the extension mechanism, we do not properly
merge the child PageNodes. What happens if that if the child PageNode
already exists it will overwrite the old PageNode with the new one.
Since PageNodes also has children PageNodes we are stuck in a situation
where we can only handle the top level of PageNodes tree. We cannot
currently use the extension mechanism to add a new page node anywhere in
the page node tree.
Jira with patch which merges the child nodes together:
https://jira.jboss.org/browse/GTNPORTAL-1605
I would have committed this, but it does change the behaviour of how
this works. Ie if someone was using the extension mechanism to overwrite
an existing page node.
Is anyone using it in this manner? Do we need to add an extra option to
pageNavigation which will tell it overwrite or not overwrite when
merging?
16 years
Portal url creation with ampersands
by Matt Wringe
We are running into a bunch of problems with ajax requests when the
portal is used to create the urls (this is especially seen when using
wsrp as it needs to rewrite urls). The issue stems from the use of '&'
instead of '&', & alone is not allowed in xhtml/xml.
I have already created a jira (with a patch) for this issue:
https://jira.jboss.org/browse/GTNPORTAL-1597
Is there any objection or reasons why we can't use the proper '&'
instead?
16 years
Re: [gatein-dev] [gatein-commits] gatein SVN: r4869 - in portal/trunk/docs: reference-guide and 1 other directories.
by Arnaud Héritier
Don't you have these modules activated only with a profile ?
If that's the case you have to manually activate this profile in the release:prepare command otherwise maven won't see these modules while releasing the project
Arnaud
On Oct 28, 2010, at 4:27 PM, do-not-reply(a)jboss.org wrote:
> Author: thomas.heute(a)jboss.com
> Date: 2010-10-28 10:27:24 -0400 (Thu, 28 Oct 2010)
> New Revision: 4869
>
> Modified:
> portal/trunk/docs/pom.xml
> portal/trunk/docs/reference-guide/pom.xml
> portal/trunk/docs/user-guide/pom.xml
> Log:
> Parent not in sync for version, not sure why...
>
>
> Modified: portal/trunk/docs/pom.xml
> ===================================================================
> --- portal/trunk/docs/pom.xml 2010-10-28 10:08:10 UTC (rev 4868)
> +++ portal/trunk/docs/pom.xml 2010-10-28 14:27:24 UTC (rev 4869)
> @@ -26,7 +26,7 @@
> <parent>
> <groupId>org.exoplatform.portal</groupId>
> <artifactId>exo.portal.parent</artifactId>
> - <version>3.0.1-GA-SNAPSHOT</version>
> + <version>3.2.0-Beta01-SNAPSHOT</version>
> </parent>
>
> <groupId>org.gatein.doc</groupId>
>
> Modified: portal/trunk/docs/reference-guide/pom.xml
> ===================================================================
> --- portal/trunk/docs/reference-guide/pom.xml 2010-10-28 10:08:10 UTC (rev 4868)
> +++ portal/trunk/docs/reference-guide/pom.xml 2010-10-28 14:27:24 UTC (rev 4869)
> @@ -28,7 +28,7 @@
> <parent>
> <groupId>org.gatein.doc</groupId>
> <artifactId>docs-aggregator</artifactId>
> - <version>3.0.1-GA-SNAPSHOT</version>
> + <version>3.2.0-Beta01-SNAPSHOT</version>
> </parent>
>
> <groupId>org.gatein.doc</groupId>
>
> Modified: portal/trunk/docs/user-guide/pom.xml
> ===================================================================
> --- portal/trunk/docs/user-guide/pom.xml 2010-10-28 10:08:10 UTC (rev 4868)
> +++ portal/trunk/docs/user-guide/pom.xml 2010-10-28 14:27:24 UTC (rev 4869)
> @@ -25,11 +25,10 @@
>
> <modelVersion>4.0.0</modelVersion>
>
> - <!-- FIXME parent not in sync with current hierarchy -->
> <parent>
> <groupId>org.gatein.doc</groupId>
> <artifactId>docs-aggregator</artifactId>
> - <version>3.0.1-GA-SNAPSHOT</version>
> + <version>3.2.0-Beta01-SNAPSHOT</version>
> </parent>
>
> <artifactId>gatein-user-guide-en</artifactId>
>
> _______________________________________________
> gatein-commits mailing list
> gatein-commits(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/gatein-commits
16 years
policy on adding new internationalization tokens
by Matt Wringe
How are we suppose to handle adding new tokens to be internationalized?
Should I just add it in the english properties file and open a jira that
the other languages need to be updated as well?
Add it to the other language properties files as well and add in the
default english spelling (and also open a jira that the other languages
need to be updated).
I just committed a patch that will add the wsrp admin to the
administrator node, but don't know how to handle the naming of the node
(currently its just hardcoded to 'WSRP' which is bad).
Thanks,
Matt Wringe
16 years
Tomcat build
by Julien Viet
we are now able to build the Tomcat package with a build 100% based on Maven (and a bit of Ant) with the following benefits:
- packaging is slightly faster (15s instead of 25s on my machine)
- the build can be executed fully by Maven 3 (although it warns a bit on some stuff that he does not like)
- a more lightweight build (67m instead of 74m according to Arnaud).
This is based on the initial work provided by Martin Podolski, some ideas borrowed from Dimitri, useful help from Arnaud.
The list of dependencies is now fully declared in a pom (which takes version from the parent pom and add some version for runtime specific libraries, we will see how to properly address that later with Thomas).
Initially I used the assembly plugin as done initially by Martin but this has no-go flaws:
- major drain to productivity: 2 minutes to assemble the Tomcat version. (exobuild was 25s)
- no real control over the libraries we want in /libs
- plugin version quirks 2.1 / 2.2beta / 2.2 have differences
So I went for an Ant solution that is better, it uses several trick to assemble the /libs and /webapps.
First of all it uses XSLT to transform the initial pom.xml into an Ant script (code generation basically), for instance:
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
becomes
<copy todir="target/tomcat/lib">
<fileset refid="org.slf4j:slf4j-api:jar"/>
</copy>
which means that we copy exactly what we want.
The second trick is to use XSLT processing instructions to define metadata for the Ant script, in our case for now the main usage is the renaming of the war file so a dependency like:
<dependency>
<?rename portal.war?>
<groupId>org.exoplatform.portal</groupId>
<artifactId>exo.portal.web.portal</artifactId>
<type>war</type>
</dependency>
becomes
<copy tofile="target/tomcat/webapps/portal.war">
<fileset refid="org.exoplatform.portal:exo.portal.web.portal:war"/>
</copy>
The activation is exactly the same as before, the -Ppkg-tomcat is used and replace the previous one. However I understand it may cause unexpected issues so there will be a transition where you can still use the previous packaging with -Ppkg-tomcat-legacy.
The new packaging now is in the folder packaging/tomcat and the generated tomcat is in packaging/tomcat/pkg/target/tomcat .
cheers
Julien
16 years
Build optimization
by Julien Viet
I have made an optimization to bypass some of the samples when the full build is triggered: it will only build the skins sub module that is always required.
This works mostly when building the Tomcat distribution and it allows to save time when the full build is performed.
This trick to activate it is to declare the property "development" to any value when you build (so development=true will work fine :-) ). This trick was provided to me by Arnaud a while ago to circumvent some Maven (in)capabilities to achieve this (it is already used for the hsqldb test profile).
So "mvn install -Ddevelopment=true" builds everything except those samples
cheers
Julien
16 years
WSRP modularization
by Julien Viet
I have made a couple of changes to WSRP configuration:
1/ I moved the wsrp node types and namespaces to the WSRP package thanks to an external component plugin (as they are not needed in Tomcat version that does not provide the WSRP services).
2/ I have added an external component plugin for the application registry that populates the application registry with the WSRP Configuration portlet in a WSRP category to avoid the usage of the "import" in the application registry (I think Chris will like it).
I tested it in JBoss AS and it works fine for me.
cheers
Julien
16 years
No snapshots
by Julien Viet
Hi Chris,
we have forbidden the usage of snapshots in trunk (unless we grant it) and I see you are using a snapshot of PC (in addition of WSRP). Could you fix that asap (either by doing your own branch with as many snapshots as you like or by doing a release) ?
thanks
16 years, 1 month
