Re: [gatein-dev] PortalClusteredSSOSupportValve issue in Tomcat

On 11/03/13 21:25, Julien Viet wrote: > PortalClusteredSSOSupportValve is the only Tomcat valve used in GateIn and it is only used in JBoss AS7 for clustered SSO. > > did you have something else in mind ? yeah, I already mentioned in first mail that I am aware at least about SSODelegateValve. Marek > > On Mar 11, 2013, at 8:32 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: > >> On 11/03/13 18:44, Julien Viet wrote: >>> why wouldn't it be sufficient ? >> Because we have more valve classes, not just PortalClusteredSSOSupportValve. So it's possible that when you fix PortalClusteredSSOSupportValve and move it to packaging/jboss-as7, you will still see same error for some other valve class. But maybe I am wrong, I did not try it... >> >> Marek >>> >>> >>> On Mar 11, 2013, at 6:33 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: >>> >>>> This api inconsistency between Tomcat and JBossWeb really sucks:-( >>>> >>>> I think that PortalClusteredSSOSupportValve is not the only one valve class, which implements start() method. We have more such valve classes (I am aware at least about SSODelegateValve). So it seems that moving single PortalClusteredSSOSupportValve to packaging/jboss-as7 won't be sufficient... >>>> >>>> Can't we do something like override tomcat classloader org.apache.catalina.loader.WebappClassLoader and handle this at classloader level? >>>> >>>> Marek >>>> >>>> On 08/03/13 11:19, Julien Viet wrote: >>>>> Hi, >>>>> >>>>> there is an issue when deploying servlet 3.0 applications on Tomcat with PortalClusteredSSOSupportValve. >>>>> >>>>> The scanning process find this valve and a classloading issue occurs (JBoss AS7 uses a Tomcat fork with slightly different code) and produces this error: >>>>> >>>>> https://gist.github.com/vietj/b35b65f7dbe9d845ddd3 >>>>> >>>>> It would make sense at some point to move this code to gatein-sso (or wci) but I think it would not work at the moment. >>>>> >>>>> An easy solution would be to move this class somewhere in packaging/jboss-as7 . >>>>> >>>>> Would someone mind to have a look at this issue ? >>>>> >>>>> thanks >>>>> >>>>> Julien >>>>> >>>>> >>>>> _______________________________________________ >>>>> gatein-dev mailing list >>>>> gatein-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/gatein-dev