Fwd: Setup Root password feature improvement
by Hai Nguyen
---------- Forwarded message ----------
From: Hai Nguyen <haint(a)exoplatform.com>
Date: Wed, Dec 11, 2013 at 8:39 AM
Subject: Re: [gatein-dev] Setup Root password feature improvement
To: Marek Posolda <mposolda(a)redhat.com>
On Tue, Dec 10, 2013 at 6:08 PM, Marek Posolda <mposolda(a)redhat.com> wrote:
> On 9.12.2013 11:35, Hai Nguyen wrote:
>
>
>
>> > - The SetupOrganizationDatabaseInitializer was clone of
>> > OrganizationDatabaseInitializer (in core service), that is hard for
>> maintain
>>
>> Yes, I agree that clone was not more elegant way, but there was not
>> possibility to extend OrganizationDatabaseInitializer with a custom class,
>> so clone was the only option to add custom behaviour.
>>
>> I would suggest to give the ability to extend this class and override
>> logic from other localization rather that exo.core module.
>>
>> IMO, the new behaviors are not much to introduce a new custom class.
> Beside, I don't know why we need introduce more "updateUsers" property that
> is not necessary. If you looking for my PR, you will see we don't need
> SetupOrganizationDatabaseInitializer for this feature
>
> Property "updateUsers" is another thing unrelated to Root user password
> setup. It's mentioned in this JIRA
> https://issues.jboss.org/browse/GTNPORTAL-3296 . It would be nice if
> OrganizationDatabaseInitializer from eXo core doesn't have all methods
> private, so we don't need to fork whole class into GateIn if some minor
> change is required. I can create JIRA to eXo core for this and also for
> "updateUsers" support. WDYT?
>
>
+1 :)
10 years, 4 months