Hi Juca, PR or your branch does not matter to me, but could you please
squash all those commits into one so that reviewers can overview your
changes more easily? -- Peter
On 2014-01-23 17:00, Juraci Paixão Kröhling wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
@Peter, @Nicolas: thanks for the help and insight, guys! I was able to
implement it and get the old data "migrated" (or, at least,
"accepted").
@Julien: do you want to discuss whether this feature would be accepted
into master? Should I send a PR, or would you prefer to review it on
my repository?
Here's the final diff:
https://github.com/jpkrohling/gatein-portal/compare/BZ794359-HidePageIfPu...
Juca.
On 01/22/2014 05:12 PM, Peter Palaga wrote:
> Hi Juca, this commit of mine used the mixin strategy:
>
https://github.com/gatein/gatein-portal/commit/0ee52c38823b2e3b6eaab3ee9a...
>
>
- -- Peter
On 01/22/2014 04:21 PM, Nicolas Filotto wrote:
> Another approach would be to define a mixin type that only defines
> your property and add this mixin type on demand to your nodes, this
> way the old node type won't be modified
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird -
http://www.enigmail.net/
iQEcBAEBCgAGBQJS4TyVAAoJECKM1e+fkPrXwjwH/AzQUFi0lMAzfYMgwxxHNsAE
hp2XHRs76jWuRBWUm7IYn9e+XLBkNXHbznT/5sjag3rxqt1BHC08Jb5Bp+SJ5LdE
KqP8Y3Ziv11EcFfGVSrzSeRylxPkYh5iJApYfmC9oUqkHwwmoQ31h9tPXN3cnLpq
JUnFNFXvf+5pwzJ4kQGKJd+WtBNN29lremYr+rppe/YklEZFBzKDBHj31KcrzgGQ
+0XmjYrVXPaj0p3Hka9MPBmr1uoGDYKE49DrJ9kshGSsR8sELdOUbv+5BD+2VTqF
x+KJ5Jl11ze5IpXfTby0fcIhPUTqeyimyV8N4cbKqfW99RinakPJBlJT9Izu61c=
=auC7
-----END PGP SIGNATURE-----