Re: [gatein-dev] Merging wsrp-extraction branch back to trunk

On 03/04/2011 12:25 PM, Julien Viet wrote: > what is the licensing issue you are mentioning ? Not really a Licensing issue, it's just that the testsuite depends on "trove" which isn't fully LGPL (Available in our deprecated repo but I'm trying to remove the dependency on the deprecated repo), I am waiting on an answer from Paul to know how we deal with that. It's just a process issue. I'd like to sort this out before we do that coming release. Thomas. > On Mar 4, 2011, at 12:22 PM, Christophe Laprun wrote: > >> On Mar 4, 2011, at 12:01 PM, Julien Viet wrote: >> >>> I don't see problems on my side. >>> >>> can you give an overview of the changes you have to make into gatein that is not specific to wsrp ? >> A quick overview: >> U packaging/module/src/main/javascript/portal.packaging.module.js >> U packaging/jboss-as5/pkg/pom.xml >> C pom.xml >> U component/pom.xml >> D component/wsrp >> A wsrp-integration >> A wsrp-integration/extension-config >> A wsrp-integration/extension-ear >> A wsrp-integration/extension-war >> A wsrp-integration/extension-component >> U web/portal/src/main/webapp/WEB-INF/conf/configuration.xml >> U web/portal/src/main/webapp/WEB-INF/conf/jcr/jcr-configuration.xml >> U web/portal/src/main/webapp/WEB-INF/conf/jcr/repository-configuration.xml >> D web/portal/src/main/webapp/WEB-INF/conf/wsrp >> >> Basically, this extracts the WSRP code into an extension. The only part specific to WSRP that still remains is the ApplicationType stuff… >> >> On the side of the features, apart from having a better code organization, it doesn't bring much to the table because the extension mechanism is currently rather weak. I would have liked to have an EAR that can be added or removed when the server is stopped to add or remove WSRP feature to GateIn. However, this is not currently possible. You can only add the extension when the server is first started *ever* otherwise the page and portlet are not added and never are. On the removal side of things, you can only remove the extension if you deactivate the JCR config persistence otherwise it will crash the server. Even when you remove the JCR config persistence (btw, I don't know what the consequences of this change are on the portal… Nicolas?), the page or portlet are not removed because there's currently no way to remove pages automatically… >> >> So, in summary, the (painful) work that was done to extract the WSRP service into an extension doesn't bring much to the table, apart from the fact that it's better contained and is not deployed by default anymore. It also unfortunately brings some potentially new issues which need to be dealt with, possibly at the kernel level. However, these are "just" runtime management issues and should not affect building/packaging of GateIn at the moment. The only issue that needs to be definitely dealt with now is the JCR config persistence issue and the question of its impact on the rest of the portal. >> >> Since the WSRP release is currently on hold due to license issues, I guess we should take this opportunity to discuss the other issues… :) >> >>> On Mar 4, 2011, at 11:52 AM, Christophe Laprun wrote: >>> >>>> Folks, >>>> >>>> The work on the extraction of the WSRP component into an extension is stable enough to be merged back into trunk even though it doesn't completely fulfill all of the original goals. The remaining issues shouldn't impact the rest of the GateIn build. I will merge the branch back to trunk as soon as I release WSRP 2.1.0-Beta01 if there aren't any objections. >>>> >>>> Cordialement / Best, >>>> Chris >>>> >>>> == >>>> Principal Software Engineer / JBoss Enterprise Middleware Red Hat, Inc. >>>> Follow GateIn: http://blog.gatein.org / http://twitter.com/gatein >>>> Follow me: http://metacosm.codepuccino.com / http://twitter.com/metacosm >>>> >>>> >>>> _______________________________________________ >>>> gatein-dev mailing list >>>> gatein-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/gatein-dev >> Cordialement / Best, >> Chris >> >> == >> Principal Software Engineer / JBoss Enterprise Middleware Red Hat, Inc. >> Follow GateIn: http://blog.gatein.org / http://twitter.com/gatein >> Follow me: http://metacosm.codepuccino.com / http://twitter.com/metacosm >> > > _______________________________________________ > gatein-dev mailing list > gatein-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/gatein-dev