Re: [gatein-dev] GitHub noise

Good job. that's the most important thing to retain : As a gate keeper a PR that passes does not implies it is a valid one. On Sep 26, 2012, at 6:31 PM, Thomas Heute <theute(a)redhat.com&gt; wrote: > > I will try again soon to setup the environment. > > A bot called gatein-bot will say things like: > "Can one of the admins verify this patch?" on pull requests > > It means that a PR request was made by a person who is not whitelisted, > an "admin" would then need to check that there is no malicious code in > the PR and trigger the Jenkins job by commenting "This is ok to test". > > The bot will trigger the job and give results of the testsuite, in the > pull request. > > > For now the jenkins server is my private machine which is not available > outside so you won't be able to see Jenkins results (only if it passed > or failed). If it works ok, I will try to change it to have the job public. > > The configuration is very sensitive and I tried couple of times on test > repositories, I hope that it won't be too noisy... > > You can see here an example that passed: > https://github.com/theute-test/test/pull/1 > > Here if the requester is whitelisted: > https://github.com/theute-test/test/pull/2 > > Thomas > > > On 09/21/2012 03:44 PM, Thomas Heute wrote: >> Deeply sorry about noise on GitHub... >> >> If you see this comment: "Can one of the admins verify this patch?" you can ignore... >> >> I'm trying to setup a machine to trigger the testsuite on each PRs so that we know if it breaks the testsuite before it's applied. >> >> And this bot says this comment... >> >> I'll create a new user to make it clearer.. >> >> Thomas >> _______________________________________________ >> gatein-dev mailing list >> gatein-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/gatein-dev > > _______________________________________________ > gatein-dev mailing list > gatein-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/gatein-dev