Sorry, Juca, I sent the previous message too early. But the point made
there is valid.
Further:
Have you consulted the English text with a native speaker? Jared is
probably the best address.
I see nothing else by merely looking at the code. I'll run it as a part
of the merge process.
Best,
Peter
On 2014-01-23 18:23, Peter Palaga wrote:
Is there a reason to use privateTillPublicationDate here but
restrictOutsidePublicationWindow elsewhere?
https://github.com/jpkrohling/gatein-portal/compare/BZ794359-HidePageIfPu...
On 2014-01-23 18:11, Juraci Paixão Kröhling wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 01/23/2014 05:27 PM, Peter Palaga wrote:
>> Hi Juca, PR or your branch does not matter to me, but could you
>> please squash all those commits into one so that reviewers can
>> overview your changes more easily? -- Peter
>
> Sure thing, the squashed commits are now available as one commit, here:
>
>
https://github.com/jpkrohling/gatein-portal/compare/BZ794359-HidePageIfPu...
>
> Juca.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.22 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird -
http://www.enigmail.net/
>
> iQEcBAEBCgAGBQJS4U1HAAoJECKM1e+fkPrXqlcIAJg0iUDyMulienr3r9FF+Tyu
> IS9sch3/uEtqaD3jXFQNc5beKoKuegxCs4/x6B/a4W8Jum5SnhctjqIomcAScdR/
> 1OkX/hAQVNvFToqD9d0ExQ5y80SyH87eATQorT0hBixYIe2/s5qYvs1h/Jlvvtd9
> vdfxgRZ3xiK29xZFoPErOjOkneTXETtIOybR79fBEuZfB1C0A9aY8BVO42Oz2DI2
> cmmqRN6SiHIgeQbo//C1ke9AIKn5mJliQFuK+Xc4tj2jC69DCM8DCAy87ue9TCPD
> h9uRk3pX4BfF0yIxLeO1ZvbhloJTRm7OCMhpH4KJJF5EoVwnctC1KQCwOWAIhCk=
> =cnaR
> -----END PGP SIGNATURE-----
>
_______________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/gatein-dev
>
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev