Re: [gatein-dev] exo.kernel.container changes for JBoss AS7 support

WCI changes introduce a jboss7 module which is only used if explicitly referenced in configuration - no impact on anything there. It also introduces a deadlock patch in wci-wci which adds an extra synchronized block. Without this patch a deadlock can occur (and often does occur on JBoss AS7) when shutting down the server. No impact on performance or memory usage. Kernel changes are limited to exo.kernel.container module where in two places there was a need to introduce the use of TCCL for classloading instead of using a local ClassLoader. The new classloading uses ‘TCCL first’ approach with fallback to the old behavior. The use of TCCL was necessary to allow GateIn services to properly startup in an environment of isolated classloaders. I added a method: org.exoplatform.container.util.ContainerUtil.class: public static Class loadClass(String type) throws ClassNotFoundException { ClassLoader tccl = Thread.currentThread().getContextClassLoader(); ClassLoader localCl = ContainerUtil.class.getClassLoader(); ClassLoader cl = tccl != null ? tccl : localCl; try { return cl.loadClass(type); } catch (ClassNotFoundException e) { if (cl == tccl) return localCl.loadClass(type); throw e; } } It is used in two places instead of Class.forName(): - org/exoplatform/xml/object/XMLObject.java - org/exoplatform/container/jmx/MX4JComponentAdapter.java It’s possible to imagine a scenario where due to deployment archive packaging the same classes may be available through different .jars, .wars, .ears. In such a situation the new code may load the class from portlet application deployment archive, or portal extension deployment archive instead of gatein portal’s lib/*.jar (gatein.ear/lib on JBossAS5 / JBossAS6, $TOMCAT_HOME/lib on Tomcat). Actually by making it local loader first with TCCL fallback there would be no chance of any side effects. It may even be more appropriate as it prevents the accidental override of GateIn's classes due to packaging. So I'll change the method to: public static Class loadClass(String type) throws ClassNotFoundException { ClassLoader tccl = Thread.currentThread().getContextClassLoader(); ClassLoader localCl = ContainerUtil.class.getClassLoader(); try { return localCl.loadClass(type); } catch (ClassNotFoundException e) { if (tccl != null) return tccl.loadClass(type); throw e; } } I'll prepare a patch against exo.kernel.container trunk and attach it to the issue. On Mon, Oct 10, 2011 at 4:20 PM, Nicolas FILOTTO < nicolas.filotto(a)exoplatform.com&gt; wrote: