Re: [gatein-dev] Impersonation in GateIn Portal

Thanks for the feedback Julien! Some points inline: On 24.1.2014 11:01, Julien Viet wrote: > Hi Marek, > > that looks good to me, there are two things I want to comment: > > 1/ in back/restore of http session you iterate over the > getAttributeNames enumeration and at the same time you modify > session. I think it would be safer that first you copy the attribute > names to avoid potential concurrent modification exception > potentially thrown by enumeration/iteration yeah, I kept this in mind and on both Tomcat7/JBoss7 the httpSesison.getAttributeNames() already returns an "offline" copy of attribute names. So if you have code like have: httpSession.setAttribute("foo", "foo"); httpSession.setAttribute("bar", "bar"); Enumeration<String> attrs = httpSession.getAttributeNames(); httpSession.removeAttribute("foo"); httpSession.removeAttribute("bar"); httpSession.setAttribute("otherFoo", "otherFoo"); while (attrs.hasMoreElements()) { System.out.println(attrs.nextElement()); } The output will still be: foo bar Fact is that javadoc on HttpSession.getAttributeNames() is not clear enough :/ So it's theoretically possible that on some other servlet implemetations it may return persistent copy instead of offline. Just to make sure I changed it per your suggestion: https://github.com/mposolda/gatein-portal/commit/cba19e5e9220f83c60ec2509... > > 2/ we are planning to upgrade soon JCR 1.16 alpha in gatein master, > can you wait the PR until this work is done ? this should be done by > next week. sure, BUT note that I will need also to merge changes into WCI and release WCI and update it's dependency in master. And it seems that exo-kernel is dependent on WCI. So it seems that if we want to keep versions in sync, we need to follow: - Merge my stuff to WCI - Release WCI - Update dependency in kernel - Release JCR+core+kernel - Update JCR and WCI deps in GateIn - Merge impersonation If it's not a big issue that exo-kernel will still have dependency on old WCI, we can obviously skip WCI release. WDYT?

Thanks, Marek > > Julien > > Julien Viet > julienviet.com > > On Thursday 23 January 2014 at 16:46, Marek Posolda wrote: > >> Hi, >> >> so wanted to let you know that I've finished prototype of >> impersonation and want to merge this feature into GateIn master. I >> would like to ask for feedback/check before merging. >> >> So the specs is here: >> https://community.jboss.org/wiki/ImpersonationInGateInPortal . >> >> Working prototype is here: >> https://github.com/mposolda/gatein-portal/tree/impersonation >> There were also some changes needed in WCI (described in more >> details on the specs page): >> https://github.com/mposolda/gatein-wci/commit/06b7d6ae87fb665dfa1996e6410... >> >> WDYT? >> Marek >> >> On 31.5.2013 18:59, Marek Posolda wrote: >>> More likely in 3.7 as it's new feature. >>> >>> On 31.5.2013 18:59, Marek Posolda wrote: >>>> Hi Julien, >>>> >>>> no, seems that it's too late for 3.6.0.Final. So either in 3.6.1 >>>> or 3.7. >>>> >>>> Marek >>>> >>>> On 31.5.2013 18:19, Julien Viet wrote: >>>>> will read it monday :-) >>>>> >>>>> what is the targetted version of this implementation ? 3.6 ? >>>>> >>>>> On May 31, 2013, at 6:01 PM, Marek Posolda <mposolda(a)redhat.com >>>>> <mailto:mposolda@redhat.com>> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> We've been requested several times by our users/customers to add >>>>>> "impersonation" feature. >>>>>> >>>>>> It may be useful for portal administrator to have possibility to >>>>>> temporary login as another user without knowing his password. >>>>>> For example: User /root/ wants to verify that user /mary/ really >>>>>> doesn't have permission to see page X or portlet Y on page Z. >>>>>> >>>>>> I've added specification page here >>>>>> https://community.jboss.org/wiki/ImpersonationInGateInPortal . >>>>>> Feel free to provide feedback here or in comments of specification. >>>>>> >>>>>> Have a nice weekend! >>>>>> Marek >>>>>> _______________________________________________ >>>>>> gatein-dev mailing list >>>>>> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org> >>>>>> https://lists.jboss.org/mailman/listinfo/gatein-dev >>>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> gatein-dev mailing list >>>> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org> >>>> https://lists.jboss.org/mailman/listinfo/gatein-dev >>> >>> >>> >>> _______________________________________________ >>> gatein-dev mailing list >>> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org> >>> https://lists.jboss.org/mailman/listinfo/gatein-dev >> > _______________________________________________ gatein-dev mailing list gatein-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/gatein-dev