On Feb 1, 2012, at 2:51 PM, Julien Viet wrote:
and I think we should make it part of the existing configuration with
proper prefixing in a dedicated section.
The point of having a dedicated configuration file is that:
1. it's easy to change for users as they don't risk messing up the rest of the
configuration
2. it's faster to load since it doesn't need to load things that have nothing to
do with the specific configuration we're interested in
3. it doesn't pollute the more important configuration by avoiding putting the
validation configuration there when it's likely going to be removed when we switch to
Bean Validation (which I understand is the long term goal). The main
configuration.properties file should be used for "vital" configuration things,
not optional ones, in my opinion.
4. it's easier to check whether the default behavior can be used or not (otherwise,
need to check that *all* the possible configuration keys are missing)
That said, if people think it's better to put it in the configuration.properties file,
I'll change the implementation accordingly.
however for the case we need to avoid case like "minLength"
and stick to lower case (except the mistake that was done for gatein.email.smtp.*).
Is there a point to using only lower case (apart from consistency with the other keys,
which will not be an issue if the configuration is made in a separate file)?
Cordialement / Best,
Chris
==
Principal Software Engineer / JBoss Enterprise Middleware Red Hat, Inc.
Follow GateIn:
http://blog.gatein.org /
http://twitter.com/gatein
Follow me:
http://metacosm.info/metacosm /
http://twitter.com/metacosm