Re: [gatein-dev] GateIn Api Discussion
several remarks at first sight:
1/ one thing that was discussed on PL (Project Lead) conf call last time was to have a
typed version of the target on the navigation:
Page getPageTarget();
void setPageTarget(Page page);
as 97% of the time, the target of a navigation will be a Page (most importantly now as we
have no other possible target).
2/ I would like to have the Container interface no use the term "child" as that
would make it more reusable (item or element instead)
3/ a site should not be a Container<Page> for several reasons
- pragmatic : a site can have a large number pages (2000) in some case and the default
method to get children of Container#getChildren() would drain the resource of the server
- conceptual : a site is a container of pages and navigations and in the future it could
contain other things (like web resource for instance)
On Jul 7, 2011, at 12:49 PM, Christophe Laprun wrote:
On Jul 7, 2011, at 12:42 PM, Christophe Laprun wrote:
>
> On Jul 7, 2011, at 12:11 PM, Julien Viet wrote:
>
>> I don't understand :
>>
>> Navigation sub = nav.getChild("sub");
>> Navigation navigation = portal.createNavigationTo(sub,
portal.getNavigation());
>>
>> in creatingANavigationShouldLinkNavigationAndNode() method
>
> It basically creates a new Navigation pointing to the existing sub navigation, using
the root navigation of the portal as parent.
> I can remove Targetable altogether if needed.
Looking at it some more, it really didn't make sense. I've removed Targetable
from Navigation and Portal and fixed the test accordingly.
Cordialement / Best,
Chris
==
Principal Software Engineer / JBoss Enterprise Middleware Red Hat, Inc.
Follow GateIn: http://blog.gatein.org / http://twitter.com/gatein
Follow me: http://metacosm.info/metacosm / http://twitter.com/metacosm
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev