8:05 a.m.
On 02/18/2011 02:57 PM, Julien Viet wrote:
On Feb 18, 2011, at 2:54 PM, Thomas Heute wrote:
> On 02/14/2011 09:03 PM, Thomas Heute wrote:
>> To the Maven expert(s), i plan to do some update in our GateIn parent:
>>
>> - Upgrade org.codehaus.mojo:jboss-packaging-maven-plugin upgrade to
>> 2.0-beta1 => 2.1.1: Upgraditis + we were using a Beta. Not sure if we
>> are ever using it.
>> - Remove repositories + pluginRepositories definitions, it's
>> supposed to be a best practice, correct me if I'm wrong (But will
>> require people to have those defined in their local installation)
>>
>> Anything I missed/got wrong ?
>> _______________________________________________
>> gatein-dev mailing list
>> gatein-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/gatein-dev
> I actually removed the jboss-packaging-maven-plugin as we don't need it
> in all components:
what does the jboss-packaging-maven-plugin do ?
I think it is used to create
"sar" archives, which may still be used by
PC testsuite only (so we can add it there)
> I will remove repository declarations from the parent but may add
it
> back into gatein root pom.xml to make it easy for contributors (and also
> easy to remove).
arnaud is in vacation currently so he cannot give us his feedback :-\
Ah ok, I was
hoping feedback from him on my first email. There is no hurry
personally I don't know what is good and what is bad, so my POV
is neutral (as long as it works and it is easy to make it work).
Same for me, the
main goal is to have everything from one repository (or
proxied) so we avoid to have Maven trying from multiple repos.
I understand the risks of importing repositories though, which is why it
would be preferred to have it declared in GateIn directly or in our
settings.xml (for people working on components). We will have to add a
README for components if we don't declare the repo.
Thomas
> Next step would be to make sure all dependencies can be obtained
from:
> http://repository.jboss.org/nexus/content/groups/developer
>
> Below is what I'm about to commit for the new parent to all GateIn
> components and portal:
>
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 5914)
> +++ pom.xml (working copy)
> @@ -14,7 +14,7 @@
>
> <groupId>org.gatein</groupId>
> <artifactId>gatein-parent</artifactId>
> -<version>1.0.3-GA-SNAPSHOT</version>
> +<version>1.1.0-GA-SNAPSHOT</version>
> <packaging>pom</packaging>
>
> <scm>
> @@ -40,11 +40,13 @@
> <!-- maven-enforcer-plugin -->
> <maven.min.version>2.2.1</maven.min.version>
>
> +<jdk.min.version>1.6</jdk.min.version>
> +
> <!-- maven-release-plugin -->
> <autoVersionSubmodules>true</autoVersionSubmodules>
>
> <!-- maven-release-plugin -->
> -<arguments>-Prelease,pkg-tomcat,pkg-jbossas -DskipTests</arguments>
> +<arguments>-Prelease -DskipTests</arguments>
>
> <!-- cf http://jira.codehaus.org/browse/MRELEASE-3 -->
> <preparationGoals>clean install</preparationGoals>
> @@ -60,11 +62,6 @@
> <!-- Plugins are sorted by shortname : clean, deploy, ... -->
> <plugins>
> <plugin>
> -<groupId>org.codehaus.mojo</groupId>
> -<artifactId>jboss-packaging-maven-plugin</artifactId>
> -<version>2.0-beta-1</version>
> -</plugin>
> -<plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <configuration>
> @@ -167,43 +164,6 @@
> </profiles>
>
> <!-- **************** -->
> -<!-- Repositiories -->
> -<!-- **************** -->
> -<repositories>
> -<repository>
> -<id>jboss-public-repository-group</id>
> -<name>JBoss Public Maven Repository Group</name>
> -<url>https://repository.jboss.org/nexus/content/groups/public/</url>
> -<layout>default</layout>
> -<releases>
> -<enabled>true</enabled>
> -<updatePolicy>never</updatePolicy>
> -</releases>
> -<snapshots>
> -<enabled>true</enabled>
> -<updatePolicy>never</updatePolicy>
> -</snapshots>
> -</repository>
> -</repositories>
> -
> -<pluginRepositories>
> -<pluginRepository>
> -<id>jboss-public-repository-group</id>
> -<name>JBoss Public Maven Repository Group</name>
> -<url>https://repository.jboss.org/nexus/content/groups/public/</url>
> -<layout>default</layout>
> -<releases>
> -<enabled>true</enabled>
> -<updatePolicy>never</updatePolicy>
> -</releases>
> -<snapshots>
> -<enabled>true</enabled>
> -<updatePolicy>never</updatePolicy>
> -</snapshots>
> -</pluginRepository>
> -</pluginRepositories>
> -
> -<!-- **************** -->
> <!-- Reporting -->
> <!-- **************** -->
>
>
> _______________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/gatein-dev