Re: [gatein-dev] Change to WCI registration proposal

WCI 2.1.1-Beta02 released On Thu, 2012-02-02 at 14:05 -0500, Matt Wringe wrote: > On Thu, 2012-02-02 at 19:42 +0100, Julien Viet wrote: >> I had issues today and could not release PC as the EndPointServlet was >> trying to validate the web.xml file when parsing it and causing the >> build to fail. I suspect that a DTD or XSD to validate was not >> available on the official URI (not the first time ORA would do that). > > Ok, thanks for looking into that, I was really confused why it only > started to fail today after the release. Note that the tests don't > always fail, it only fails sometimes (well most of the time now, so the > DTD/XSD file is sometimes being resolved I guess). > >> I commited a patch that inhibits schema validation and made the PC >> testsuite pass : https://issues.jboss.org/browse/GTNWCI-31 >> >> I resolved the issue but could not set the fix version to Beta02 since >> it does not exist already. >> >> Could you make a release of Beta02 in order to make the PC release ? > > Ok, added Beta02 to the list and forced a build in Hudson to make sure > all the test now pass. Will release Beta02 when tests have completed. > >> thanks >> >> Julien >> >> On Feb 1, 2012, at 11:46 PM, Matt Wringe wrote: >> >>> Ok, I pushed WCI 2.1.1-Beta01 (if there is no objection or issues >>> brought up with it soon, I would like to release it as 2.1.1). >>> >>> Info on how to use it here: >>> https://community.jboss.org/wiki/AdvancedWCIRegistrationFeatures >>> >>> >>> On Wed, 2012-02-01 at 09:07 -0500, Matt Wringe wrote: >>>> On Wed, 2012-02-01 at 14:58 +0100, Julien Viet wrote: >>>>> On Feb 1, 2012, at 3:40 AM, Matt Wringe wrote: >>>>> >>>>>> On Thu, 2012-01-12 at 15:22 +0100, Julien Viet wrote: >>>>>>> I like it, it's simple and easy to use. >>>>>>> >>>>>>> a couple of questions: >>>>>>> >>>>>>> 1/ are you able to test it ? >>>>>> >>>>>> As part of the automated tests, I am able to test that you can disable >>>>>> the registration of certain web applications, and that you can manually >>>>>> add the disabled web applications using the GateInServlet. >>>>>> >>>>>> I have wasted a lot of time trying to get a test written that will >>>>>> compare when any normal servlet is started and when the webapplication >>>>>> gets registered (ie this basically just tests load-on-startup between >>>>>> the normal servlet and when the gateinservlet does its registration). No >>>>>> luck here so far. >>>>> >>>>> you mean the order ? >>>> >>>> yes, the order between when a servlet in the war starts and when the war >>>> gets registered is not tested. It should be easy to test (static event >>>> registration class), but there are a bunch of classpath issues which >>>> makes it difficult with the current test setup. >>>> >>>>> well testing the inhibition is already cool. >>>>> >>>>>> >>>>>>> 2/ it would be part of the next minor wci release ? >>>>>> >>>>>> If everything is ok, I would like to release a new version of wci as >>>>>> soon as possible with this feature. >>>>> >>>>> ok thanks. >>>>> >>>>>> >>>>>>> On Jan 11, 2012, at 8:37 PM, Matt Wringe wrote: >>>>>>> >>>>>>>> There have been a couple of issues arising from the ordering of portlets >>>>>>>> and servlets being out of sync. For example see >>>>>>>> https://issues.jboss.org/browse/GTNPC-76 >>>>>>>> >>>>>>>> This isn't really a bug, since the ordering of when portlets and >>>>>>>> servlets are initialized is not suppose to be guaranteed. But I have a >>>>>>>> couple of changes to wci which will allow for this behaviour (see patch >>>>>>>> attached to GTNPC-76) >>>>>>>> >>>>>>>> Basically there are 2 new features which when used together will provide >>>>>>>> ordering between portlets and servlets. >>>>>>>> >>>>>>>> 1) by using a context-parameter in the web.xml, we can tell the native >>>>>>>> wci implementation to not register the specific webapp. >>>>>>>> >>>>>>>> 2) you can now manually add an application to the wci native >>>>>>>> implementation. >>>>>>>> >>>>>>>> To control ordering: >>>>>>>> - add in the context-parameter so the native implementation doesn't >>>>>>>> register the webapplication (and therefor PC doesn't know about it) >>>>>>>> - specify the generic GateInServlet in the web.xml and use the >>>>>>>> load-on-startup value to control ordering against other servlets. The >>>>>>>> GateInServlet will manually register itself to the native >>>>>>>> implementation. >>>>>>>> >>>>>>>> Any objections? >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> gatein-dev mailing list >>>>>>>> gatein-dev(a)lists.jboss.org >>>>>>>> https://lists.jboss.org/mailman/listinfo/gatein-dev >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> >>>> _______________________________________________ >>>> gatein-dev mailing list >>>> gatein-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/gatein-dev >>> >>> >> > > > _______________________________________________ > gatein-dev mailing list > gatein-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/gatein-dev