Re: [gatein-dev] New field on node type gtn:visible - how to migrate the data?

Sorry, Juca, I sent the previous message too early. But the point made there is valid. Further: Have you consulted the English text with a native speaker? Jared is probably the best address. https://github.com/jpkrohling/gatein-portal/compare/BZ794359-HidePageIfPu... I see nothing else by merely looking at the code. I'll run it as a part of the merge process. Best, Peter On 2014-01-23 18:23, Peter Palaga wrote: > Is there a reason to use privateTillPublicationDate here but > restrictOutsidePublicationWindow elsewhere? > https://github.com/jpkrohling/gatein-portal/compare/BZ794359-HidePageIfPu... > > On 2014-01-23 18:11, Juraci Paixão Kröhling wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA512 > > > > On 01/23/2014 05:27 PM, Peter Palaga wrote: > > > Hi Juca, PR or your branch does not matter to me, but could you > > > please squash all those commits into one so that reviewers can > > > overview your changes more easily? -- Peter > > > > > > > > > Sure thing, the squashed commits are now available as one commit, here: > > > > https://github.com/jpkrohling/gatein-portal/compare/BZ794359-HidePageIfPu... > > > > Juca. > > > > _______________________________________________ > > gatein-dev mailing list > > gatein-dev(a)lists.jboss.org (mailto:gatein-dev@lists.jboss.org) > > https://lists.jboss.org/mailman/listinfo/gatein-dev > > > > > _______________________________________________ > gatein-dev mailing list > gatein-dev(a)lists.jboss.org (mailto:gatein-dev@lists.jboss.org) > https://lists.jboss.org/mailman/listinfo/gatein-dev > _______________________________________________ gatein-dev mailing list gatein-dev(a)lists.jboss.org (mailto:gatein-dev@lists.jboss.org) https://lists.jboss.org/mailman/listinfo/gatein-dev