Hi Marek,
that looks good to me, there are two things I want to comment:
1/ in back/restore of http session you iterate over the getAttributeNames enumeration and
at the same time you modify session. I think it would be safer that first you copy the
attribute names to avoid potential concurrent modification exception potentially thrown by
enumeration/iteration
2/ we are planning to upgrade soon JCR 1.16 alpha in gatein master, can you wait the PR
until this work is done ? this should be done by next week.
Julien
Julien Viet
Hi,
so wanted to let you know that I've finished prototype of impersonation and want to
merge this feature into GateIn master. I would like to ask for feedback/check before
merging.
So the specs is here:
https://community.jboss.org/wiki/ImpersonationInGateInPortal .
Working prototype is here:
https://github.com/mposolda/gatein-portal/tree/impersonation
There were also some changes needed in WCI (described in more details on the specs page):
https://github.com/mposolda/gatein-wci/commit/06b7d6ae87fb665dfa1996e6410...
WDYT?
Marek
On 31.5.2013 18:59, Marek Posolda wrote:
> More likely in 3.7 as it's new feature.
>
> On 31.5.2013 18:59, Marek Posolda wrote:
> > Hi Julien,
> >
> > no, seems that it's too late for 3.6.0.Final. So either in 3.6.1 or 3.7.
> >
> > Marek
> >
> > On 31.5.2013 18:19, Julien Viet wrote:
> > > will read it monday :-)
> > >
> > > what is the targetted version of this implementation ? 3.6 ?
> > >
> > > On May 31, 2013, at 6:01 PM, Marek Posolda <mposolda(a)redhat.com
(mailto:mposolda@redhat.com)> wrote:
> > > > Hi all,
> > > >
> > > > We've been requested several times by our users/customers to add
"impersonation" feature.
> > > >
> > > > It may be useful for portal administrator to have possibility to
temporary login as another user without knowing his password. For example: User root wants
to verify that user mary really doesn't have permission to see page X or portlet Y on
page Z.
> > > >
> > > > I've added specification page here
https://community.jboss.org/wiki/ImpersonationInGateInPortal . Feel free to provide
feedback here or in comments of specification.
> > > >
> > > > Have a nice weekend!
> > > > Marek
> > > > _______________________________________________
> > > > gatein-dev mailing list
> > > > gatein-dev(a)lists.jboss.org (mailto:gatein-dev@lists.jboss.org)
> > > >
https://lists.jboss.org/mailman/listinfo/gatein-dev
> >
> >
> >
> > _______________________________________________ gatein-dev mailing list
gatein-dev(a)lists.jboss.org (mailto:gatein-dev@lists.jboss.org)
https://lists.jboss.org/mailman/listinfo/gatein-dev
>
>
> _______________________________________________ gatein-dev mailing list
gatein-dev(a)lists.jboss.org (mailto:gatein-dev@lists.jboss.org)
https://lists.jboss.org/mailman/listinfo/gatein-dev