10:11 a.m.
Hi *,
It is quite an extensive patch. Could please somebody have a look at it?
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
It implements a requirement from a customer as described in
https://community.jboss.org/wiki/RestrictedPageEditor
To see the behavior requested by the customer, you should build the
portal from my GTNPORTAL-3263.3 branch and run AS with this extension:
https://github.com/ppalaga/gatein-restricted-page-editor-extension
Thanks,
Peter
3:45 a.m.
Hi *,
it would be nice if someone from eXo could have a look at this. Please
note that we cannot wait for long. We have decided to do a RH-internal
cross-checking with Lucas and if there is no message from eXo after we
are finished with the checks, I'll merge it without waiting for eXo.
Thanks,
Peter
On 2013-10-04 17:11, Peter Palaga wrote:
Hi *,
It is quite an extensive patch. Could please somebody have a look at it?
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
It implements a requirement from a customer as described in
https://community.jboss.org/wiki/RestrictedPageEditor
To see the behavior requested by the customer, you should build the
portal from my GTNPORTAL-3263.3 branch and run AS with this extension:
https://github.com/ppalaga/gatein-restricted-page-editor-extension
Thanks,
Peter
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev
9:36 a.m.
Hi Peter,
Sorry for this miss.
Julien will manage quickly this review on eXo side.
Regards
--
*Frédéric DROUET*
eXo VP Engineering
On Thu, Oct 10, 2013 at 10:45 AM, Peter Palaga <ppalaga(a)redhat.com> wrote:
Hi *,
it would be nice if someone from eXo could have a look at this. Please
note that we cannot wait for long. We have decided to do a RH-internal
cross-checking with Lucas and if there is no message from eXo after we
are finished with the checks, I'll merge it without waiting for eXo.
Thanks,
Peter
On 2013-10-04 17:11, Peter Palaga wrote:
> Hi *,
>
> It is quite an extensive patch. Could please somebody have a look at it?
>
> https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
>
> It implements a requirement from a customer as described in
>
> https://community.jboss.org/wiki/RestrictedPageEditor
>
> To see the behavior requested by the customer, you should build the
> portal from my GTNPORTAL-3263.3 branch and run AS with this extension:
>
> https://github.com/ppalaga/gatein-restricted-page-editor-extension
>
> Thanks,
>
> Peter
> _______________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/gatein-dev
>
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev
11:05 p.m.
Hi,
We are going to take a look at this and will give you feedback on Monday
Thanks,
On 10 October 2013 15:45, Peter Palaga <ppalaga(a)redhat.com> wrote:
Hi *,
it would be nice if someone from eXo could have a look at this. Please
note that we cannot wait for long. We have decided to do a RH-internal
cross-checking with Lucas and if there is no message from eXo after we
are finished with the checks, I'll merge it without waiting for eXo.
Thanks,
Peter
On 2013-10-04 17:11, Peter Palaga wrote:
> Hi *,
>
> It is quite an extensive patch. Could please somebody have a look at it?
>
> https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
>
> It implements a requirement from a customer as described in
>
> https://community.jboss.org/wiki/RestrictedPageEditor
>
> To see the behavior requested by the customer, you should build the
> portal from my GTNPORTAL-3263.3 branch and run AS with this extension:
>
> https://github.com/ppalaga/gatein-restricted-page-editor-extension
>
> Thanks,
>
> Peter
> _______________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/gatein-dev
>
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev
--
*Trong Tran*
*(+84) 983841909 | *trongtt(a)gmail.com
Twitter: http://twitter.com/trongtt**
10 a.m.
Thanks Trong.
Please note that there is a small update in
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3 : The new
permissions are enforced also during deletions now.
Best,
Peter
On 2013-10-11 06:05, Trong Tran wrote:
Hi,
We are going to take a look at this and will give you feedback on Monday
Thanks,
On 10 October 2013 15:45, Peter Palaga <ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>> wrote:
Hi *,
it would be nice if someone from eXo could have a look at this. Please
note that we cannot wait for long. We have decided to do a RH-internal
cross-checking with Lucas and if there is no message from eXo after we
are finished with the checks, I'll merge it without waiting for eXo.
Thanks,
Peter
On 2013-10-04 17:11, Peter Palaga wrote:
> Hi *,
>
> It is quite an extensive patch. Could please somebody have a look
at it?
>
> https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
>
> It implements a requirement from a customer as described in
>
> https://community.jboss.org/wiki/RestrictedPageEditor
>
> To see the behavior requested by the customer, you should build the
> portal from my GTNPORTAL-3263.3 branch and run AS with this
extension:
>
> https://github.com/ppalaga/gatein-restricted-page-editor-extension
>
> Thanks,
>
> Peter
> _______________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/gatein-dev
>
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/gatein-dev
--
*Trong Tran*
/(+84) 983841909 | /trongtt(a)gmail.com <mailto:trongtt@gmail.com>
Twitter: http://twitter.com/trongtt//
4:17 a.m.
Hi, I'm trying "Restricted" page editor feature (build with tomcat7 -->
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3)
I tried GateIn without the extension (
https://github.com/ppalaga/gatein-restricted-page-editor-extension) --> It
should works the same as before this feature, right ?
1. After login as root, go to home page, edit portal layout --> I can't DnD
page-body to another place, it always stay in the same place
2. Try to drop new Row container, and new application to the page, then
move them around --> Exception in the console
143469 [http-bio-8080-exec-6] ERROR portal:UIPortalApplication - Error
during the processAction phase
java.lang.NullPointerException
at
org.exoplatform.portal.webui.portal.UIPortalComponentActionListener$MoveChildActionListener.prepareUiSource(UIPortalComponentActionListener.java:300)
at
org.exoplatform.portal.webui.portal.UIPortalComponentActionListener$MoveChildActionListener.execute(UIPortalComponentActionListener.java:239)
at org.exoplatform.webui.event.Event.broadcast(Event.java:97)
at
org.exoplatform.webui.core.lifecycle.Lifecycle.processAction(Lifecycle.java:51)
at
org.exoplatform.webui.core.UIComponent.processAction(UIComponent.java:119)
at
org.exoplatform.portal.webui.workspace.UIPortalApplicationLifecycle.processAction(UIPortalApplicationLifecycle.java:73)
at
org.exoplatform.portal.webui.workspace.UIPortalApplicationLifecycle.processAction(UIPortalApplicationLifecycle.java:36)
On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga <ppalaga(a)redhat.com> wrote:
Thanks Trong.
Please note that there is a small update in
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3 : The new
permissions are enforced also during deletions now.
Best,
Peter
On 2013-10-11 06:05, Trong Tran wrote:
> Hi,
>
> We are going to take a look at this and will give you feedback on Monday
>
> Thanks,
>
>
> On 10 October 2013 15:45, Peter Palaga <ppalaga(a)redhat.com
> <mailto:ppalaga@redhat.com>> wrote:
>
> Hi *,
>
> it would be nice if someone from eXo could have a look at this.
Please
> note that we cannot wait for long. We have decided to do a
RH-internal
> cross-checking with Lucas and if there is no message from eXo after
we
> are finished with the checks, I'll merge it without waiting for eXo.
>
> Thanks,
>
> Peter
>
> On 2013-10-04 17:11, Peter Palaga wrote:
> > Hi *,
> >
> > It is quite an extensive patch. Could please somebody have a look
> at it?
> >
> > https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
> >
> > It implements a requirement from a customer as described in
> >
> > https://community.jboss.org/wiki/RestrictedPageEditor
> >
> > To see the behavior requested by the customer, you should build
the
> > portal from my GTNPORTAL-3263.3 branch and run AS with this
> extension:
> >
> >
https://github.com/ppalaga/gatein-restricted-page-editor-extension
> >
> > Thanks,
> >
> > Peter
> > _______________________________________________
> > gatein-dev mailing list
> > gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
> > https://lists.jboss.org/mailman/listinfo/gatein-dev
> >
>
> _______________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/gatein-dev
>
>
>
>
> --
> *Trong Tran*
> /(+84) 983841909 | /trongtt(a)gmail.com <mailto:trongtt@gmail.com>
> Twitter: http://twitter.com/trongtt//
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev
4:28 a.m.
Thanks for the message, Phuong. I'll have a look what is the problem. -- PP
On 2013-10-14 11:17, Phuong Viet VU wrote:
Hi, I'm trying "Restricted" page editor feature (build
with tomcat7 -->
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3)
I tried GateIn without the extension
(https://github.com/ppalaga/gatein-restricted-page-editor-extension) -->
It should works the same as before this feature, right ?
1. After login as root, go to home page, edit portal layout --> I can't
DnD page-body to another place, it always stay in the same place
2. Try to drop new Row container, and new application to the page, then
move them around --> Exception in the console
143469 [http-bio-8080-exec-6] ERROR portal:UIPortalApplication - Error
during the processAction phase
java.lang.NullPointerException
at
org.exoplatform.portal.webui.portal.UIPortalComponentActionListener$MoveChildActionListener.prepareUiSource(UIPortalComponentActionListener.java:300)
at
org.exoplatform.portal.webui.portal.UIPortalComponentActionListener$MoveChildActionListener.execute(UIPortalComponentActionListener.java:239)
at org.exoplatform.webui.event.Event.broadcast(Event.java:97)
at
org.exoplatform.webui.core.lifecycle.Lifecycle.processAction(Lifecycle.java:51)
at
org.exoplatform.webui.core.UIComponent.processAction(UIComponent.java:119)
at
org.exoplatform.portal.webui.workspace.UIPortalApplicationLifecycle.processAction(UIPortalApplicationLifecycle.java:73)
at
org.exoplatform.portal.webui.workspace.UIPortalApplicationLifecycle.processAction(UIPortalApplicationLifecycle.java:36)
On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga <ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>> wrote:
Thanks Trong.
Please note that there is a small update in
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3 : The new
permissions are enforced also during deletions now.
Best,
Peter
On 2013-10-11 06:05, Trong Tran wrote:
> Hi,
>
> We are going to take a look at this and will give you feedback on
Monday
>
> Thanks,
>
>
> On 10 October 2013 15:45, Peter Palaga <ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>> wrote:
>
> Hi *,
>
> it would be nice if someone from eXo could have a look at
this. Please
> note that we cannot wait for long. We have decided to do a
RH-internal
> cross-checking with Lucas and if there is no message from eXo
after we
> are finished with the checks, I'll merge it without waiting
for eXo.
>
> Thanks,
>
> Peter
>
> On 2013-10-04 17:11, Peter Palaga wrote:
> > Hi *,
> >
> > It is quite an extensive patch. Could please somebody have
a look
> at it?
> >
> > https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
> >
> > It implements a requirement from a customer as described in
> >
> > https://community.jboss.org/wiki/RestrictedPageEditor
> >
> > To see the behavior requested by the customer, you should
build the
> > portal from my GTNPORTAL-3263.3 branch and run AS with this
> extension:
> >
> >
https://github.com/ppalaga/gatein-restricted-page-editor-extension
> >
> > Thanks,
> >
> > Peter
> > _______________________________________________
> > gatein-dev mailing list
> > gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.jboss.org <mailto:gatein-dev@lists.jboss.org>>
> > https://lists.jboss.org/mailman/listinfo/gatein-dev
> >
>
> _______________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.jboss.org <mailto:gatein-dev@lists.jboss.org>>
> https://lists.jboss.org/mailman/listinfo/gatein-dev
>
>
>
>
> --
> *Trong Tran*
> /(+84) 983841909 | /trongtt(a)gmail.com <mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>>
> Twitter:http://twitter.com/trongtt//
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/gatein-dev
6:46 a.m.
ok, I have some more comments:
1. I see that "root" user can do anything, even when we set "nobody"
for
move*-application and move*-container. But the specification say that it
can prevent "root" user.
2. I can't DnD new App and Container to portal-layout (run gatein with
extension).
When I create page with "Add page" wizard, choose "Two columns" layout
-->
Can't DnD new container to the Page, even there is
"HasMoveContainersPermissions" class
3. The feature only work if we create page from templates. But GateIn also
allow to create page with-out template:
by using "Page management" portlet, or when using navigation editor -->
create node --> create page. It create a page with-out template, and the
move* permission is null --> no way to DnD Apps and Container to the newly
created page. And we don't have UI support to set the move* permission
On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga <ppalaga(a)redhat.com> wrote:
Thanks for the message, Phuong. I'll have a look what is the
problem. -- PP
On 2013-10-14 11:17, Phuong Viet VU wrote:
> Hi, I'm trying "Restricted" page editor feature (build with tomcat7
-->
>
https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**3263.3<htt...
> )
> I tried GateIn without the extension
>
(https://github.com/ppalaga/**gatein-restricted-page-editor-**extension<...)
> -->
> It should works the same as before this feature, right ?
>
> 1. After login as root, go to home page, edit portal layout --> I can't
> DnD page-body to another place, it always stay in the same place
> 2. Try to drop new Row container, and new application to the page, then
> move them around --> Exception in the console
> 143469 [http-bio-8080-exec-6] ERROR portal:UIPortalApplication - Error
> during the processAction phase
> java.lang.NullPointerException
> at
> org.exoplatform.portal.webui.**portal.**UIPortalComponentActionListene**
> r$MoveChildActionListener.**prepareUiSource(**
> UIPortalComponentActionListene**r.java:300)
> at
> org.exoplatform.portal.webui.**portal.**UIPortalComponentActionListene**
> r$MoveChildActionListener.**execute(**UIPortalComponentActionListene**
> r.java:239)
> at org.exoplatform.webui.event.**Event.broadcast(Event.java:97)
> at
> org.exoplatform.webui.core.**lifecycle.Lifecycle.**
> processAction(Lifecycle.java:**51)
> at
> org.exoplatform.webui.core.**UIComponent.processAction(**
> UIComponent.java:119)
> at
> org.exoplatform.portal.webui.**workspace.**UIPortalApplicationLifecycle.*
> *processAction(**UIPortalApplicationLifecycle.**java:73)
> at
> org.exoplatform.portal.webui.**workspace.**UIPortalApplicationLifecycle.*
> *processAction(**UIPortalApplicationLifecycle.**java:36)
>
>
>
> On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga <ppalaga(a)redhat.com
> <mailto:ppalaga@redhat.com>> wrote:
>
> Thanks Trong.
>
> Please note that there is a small update in
>
https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**3263.3<htt...;:
The new
> permissions are enforced also during deletions now.
>
> Best,
>
> Peter
>
> On 2013-10-11 06:05, Trong Tran wrote:
> > Hi,
> >
> > We are going to take a look at this and will give you feedback on
> Monday
> >
> > Thanks,
> >
> >
> > On 10 October 2013 15:45, Peter Palaga <ppalaga(a)redhat.com
> <mailto:ppalaga@redhat.com>
> > <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>>
wrote:
> >
> > Hi *,
> >
> > it would be nice if someone from eXo could have a look at
> this. Please
> > note that we cannot wait for long. We have decided to do a
> RH-internal
> > cross-checking with Lucas and if there is no message from eXo
> after we
> > are finished with the checks, I'll merge it without waiting
> for eXo.
> >
> > Thanks,
> >
> > Peter
> >
> > On 2013-10-04 17:11, Peter Palaga wrote:
> > > Hi *,
> > >
> > > It is quite an extensive patch. Could please somebody have
> a look
> > at it?
> > >
> > > https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-*
> *3263.3 <https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
> > >
> > > It implements a requirement from a customer as described in
> > >
> > >
https://community.jboss.org/**wiki/RestrictedPageEditor<https://commun...
> > >
> > > To see the behavior requested by the customer, you should
> build the
> > > portal from my GTNPORTAL-3263.3 branch and run AS with this
> > extension:
> > >
> > >
> https://github.com/ppalaga/**gatein-restricted-page-editor-**
> extension<https://github.com/ppalaga/gatein-restricted-page-editor-ext...
> > >
> > > Thanks,
> > >
> > > Peter
> > > ______________________________**_________________
> > > gatein-dev mailing list
> > > gatein-dev(a)lists.jboss.org
> <mailto:gatein-dev@lists.**jboss.org <gatein-dev(a)lists.jboss.org>>
> <mailto:gatein-dev@lists.**jboss.org
<gatein-dev(a)lists.jboss.org><mailto:
> gatein-dev(a)lists.**jboss.org <gatein-dev(a)lists.jboss.org>>>
>
> > >
https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
> > >
> >
> > ______________________________**_________________
> > gatein-dev mailing list
> > gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
> >
> <mailto:gatein-dev@lists.**jboss.org
<gatein-dev(a)lists.jboss.org><mailto:
> gatein-dev(a)lists.**jboss.org <gatein-dev(a)lists.jboss.org>>>
>
> >
https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
> >
> >
> >
> >
> > --
> > *Trong Tran*
> > /(+84) 983841909 | /trongtt(a)gmail.com <mailto:trongtt@gmail.com>
> <mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>>
>
> > Twitter:http://twitter.com/**trongtt//<http://twitter.com/trongtt//>
>
> ______________________________**_________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
> >
>
https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>
>
>
10:15 a.m.
On 2013-10-14 13:46, Phuong Viet VU wrote:
ok, I have some more comments:
1. I see that "root" user can do anything, even when we set "nobody"
for
move*-application and move*-container. But the specification say that it
can prevent "root" user.
No, the spec says that <move-*-permissions>Nobody</move-*-permissions>
forbids the actions to everyone _except for_ root. So, the present
implementation works as specified.
2. I can't DnD new App and Container to portal-layout (run gatein
with
extension).
When I create page with "Add page" wizard, choose "Two columns"
layout
--> Can't DnD new container to the Page, even there is
"HasMoveContainersPermissions" class
Sorry, this part of JavaScript was broken since Friday. It must work now.
3. The feature only work if we create page from templates. But
GateIn
also allow to create page with-out template:
by using "Page management" portlet, or when using navigation editor -->
create node --> create page. It create a page with-out template, and the
move* permission is null --> no way to DnD Apps and Container to the
newly created page. And we don't have UI support to set the move* permission
I agree that at some point, we need to add a UI for the management of
the new permissions. But it is out of scope ATM.
With the present spec, I guess, the customer will be able to hide the
alternative ways to create pages from user groups that are supposed to
use the "template way". Thomas?
And finally, I agree that the page creation with null move* permissions
from Page management and navigation editor is not correct. I have
changed it to use ProtectedContainer.DEFAULT_MOVE_*_PERMISSIONS, see []
Do you know of other places where I should do the same?
[1] https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
Thanks,
Peter
On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga <ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>> wrote:
Thanks for the message, Phuong. I'll have a look what is the
problem. -- PP
On 2013-10-14 11:17, Phuong Viet VU wrote:
Hi, I'm trying "Restricted" page editor feature (build with
tomcat7 -->
https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>)
I tried GateIn without the extension
(https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>)
-->
It should works the same as before this feature, right ?
1. After login as root, go to home page, edit portal layout -->
I can't
DnD page-body to another place, it always stay in the same place
2. Try to drop new Row container, and new application to the
page, then
move them around --> Exception in the console
143469 [http-bio-8080-exec-6] ERROR portal:UIPortalApplication -
Error
during the processAction phase
java.lang.NullPointerException
at
org.exoplatform.portal.webui.__portal.__UIPortalComponentActionListene__r$MoveChildActionListener.__prepareUiSource(__UIPortalComponentActionListene__r.java:300)
at
org.exoplatform.portal.webui.__portal.__UIPortalComponentActionListene__r$MoveChildActionListener.__execute(__UIPortalComponentActionListene__r.java:239)
at org.exoplatform.webui.event.__Event.broadcast(Event.java:97)
at
org.exoplatform.webui.core.__lifecycle.Lifecycle.__processAction(Lifecycle.java:__51)
at
org.exoplatform.webui.core.__UIComponent.processAction(__UIComponent.java:119)
at
org.exoplatform.portal.webui.__workspace.__UIPortalApplicationLifecycle.__processAction(__UIPortalApplicationLifecycle.__java:73)
at
org.exoplatform.portal.webui.__workspace.__UIPortalApplicationLifecycle.__processAction(__UIPortalApplicationLifecycle.__java:36)
On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga
<ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>> wrote:
Thanks Trong.
Please note that there is a small update in
https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
: The new
permissions are enforced also during deletions now.
Best,
Peter
On 2013-10-11 06:05, Trong Tran wrote:
> Hi,
>
> We are going to take a look at this and will give you
feedback on
Monday
>
> Thanks,
>
>
> On 10 October 2013 15:45, Peter Palaga
<ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>
> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>>>
wrote:
>
> Hi *,
>
> it would be nice if someone from eXo could have a
look at
this. Please
> note that we cannot wait for long. We have decided
to do a
RH-internal
> cross-checking with Lucas and if there is no message
from eXo
after we
> are finished with the checks, I'll merge it without
waiting
for eXo.
>
> Thanks,
>
> Peter
>
> On 2013-10-04 17:11, Peter Palaga wrote:
> > Hi *,
> >
> > It is quite an extensive patch. Could please
somebody have
a look
> at it?
> >
> >
https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
> >
> > It implements a requirement from a customer as
described in
> >
> >
https://community.jboss.org/__wiki/RestrictedPageEditor
<https://community.jboss.org/wiki/RestrictedPageEditor>
> >
> > To see the behavior requested by the customer,
you should
build the
> > portal from my GTNPORTAL-3263.3 branch and run AS
with this
> extension:
> >
> >
https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>
> >
> > Thanks,
> >
> > Peter
> > _________________________________________________
> > gatein-dev mailing list
> > gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
> >
https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>
> >
>
> _________________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
> https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>
>
>
>
>
> --
> *Trong Tran*
> /(+84) 983841909 | /trongtt(a)gmail.com
<mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>>>
> Twitter:http://twitter.com/__trongtt//
<http://twitter.com/trongtt//>
_________________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>
10:22 a.m.
On 10/14/2013 05:15 PM, Peter Palaga wrote:
On 2013-10-14 13:46, Phuong Viet VU wrote:
> ok, I have some more comments:
> 1. I see that "root" user can do anything, even when we set
"nobody" for
> move*-application and move*-container. But the specification say that it
> can prevent "root" user.
No, the spec says that <move-*-permissions>Nobody</move-*-permissions>
forbids the actions to everyone _except for_ root. So, the present
implementation works as specified.
> 2. I can't DnD new App and Container to portal-layout (run gatein with
> extension).
> When I create page with "Add page" wizard, choose "Two columns"
layout
> --> Can't DnD new container to the Page, even there is
> "HasMoveContainersPermissions" class
Sorry, this part of JavaScript was broken since Friday. It must work now.
> 3. The feature only work if we create page from templates. But GateIn
> also allow to create page with-out template:
> by using "Page management" portlet, or when using navigation editor -->
> create node --> create page. It create a page with-out template, and the
> move* permission is null --> no way to DnD Apps and Container to the
> newly created page. And we don't have UI support to set the move*
> permission
I agree that at some point, we need to add a UI for the management of
the new permissions. But it is out of scope ATM.
With the present spec, I guess, the customer will be able to hide the
alternative ways to create pages from user groups that are supposed to
use the "template way". Thomas?
I will need to give it a try, I don't think that I understand why it is
different.
Thomas
And finally, I agree that the page creation with null move*
permissions
from Page management and navigation editor is not correct. I have
changed it to use ProtectedContainer.DEFAULT_MOVE_*_PERMISSIONS, see []
Do you know of other places where I should do the same?
[1] https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
Thanks,
Peter
> On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga <ppalaga(a)redhat.com
> <mailto:ppalaga@redhat.com>> wrote:
>
> Thanks for the message, Phuong. I'll have a look what is the
> problem. -- PP
>
>
> On 2013-10-14 11:17, Phuong Viet VU wrote:
>
> Hi, I'm trying "Restricted" page editor feature (build with
> tomcat7 -->
>
> https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
> <https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>)
> I tried GateIn without the extension
>
> (https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
>
> <https://github.com/ppalaga/gatein-restricted-page-editor-extension>)
> -->
> It should works the same as before this feature, right ?
>
> 1. After login as root, go to home page, edit portal layout -->
> I can't
> DnD page-body to another place, it always stay in the same place
> 2. Try to drop new Row container, and new application to the
> page, then
> move them around --> Exception in the console
> 143469 [http-bio-8080-exec-6] ERROR portal:UIPortalApplication -
> Error
> during the processAction phase
> java.lang.NullPointerException
> at
>
>
org.exoplatform.portal.webui.__portal.__UIPortalComponentActionListene__r$MoveChildActionListener.__prepareUiSource(__UIPortalComponentActionListene__r.java:300)
>
> at
>
>
org.exoplatform.portal.webui.__portal.__UIPortalComponentActionListene__r$MoveChildActionListener.__execute(__UIPortalComponentActionListene__r.java:239)
>
> at org.exoplatform.webui.event.__Event.broadcast(Event.java:97)
> at
>
>
org.exoplatform.webui.core.__lifecycle.Lifecycle.__processAction(Lifecycle.java:__51)
>
> at
>
> org.exoplatform.webui.core.__UIComponent.processAction(__UIComponent.java:119)
>
> at
>
>
org.exoplatform.portal.webui.__workspace.__UIPortalApplicationLifecycle.__processAction(__UIPortalApplicationLifecycle.__java:73)
>
> at
>
>
org.exoplatform.portal.webui.__workspace.__UIPortalApplicationLifecycle.__processAction(__UIPortalApplicationLifecycle.__java:36)
>
>
>
>
> On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga
> <ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>>
wrote:
>
> Thanks Trong.
>
> Please note that there is a small update in
>
> https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
> <https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
> : The new
> permissions are enforced also during deletions now.
>
> Best,
>
> Peter
>
> On 2013-10-11 06:05, Trong Tran wrote:
> > Hi,
> >
> > We are going to take a look at this and will give you
> feedback on
> Monday
> >
> > Thanks,
> >
> >
> > On 10 October 2013 15:45, Peter Palaga
> <ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>
> > <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>>>
wrote:
> >
> > Hi *,
> >
> > it would be nice if someone from eXo could have a
> look at
> this. Please
> > note that we cannot wait for long. We have decided
> to do a
> RH-internal
> > cross-checking with Lucas and if there is no message
> from eXo
> after we
> > are finished with the checks, I'll merge it without
> waiting
> for eXo.
> >
> > Thanks,
> >
> > Peter
> >
> > On 2013-10-04 17:11, Peter Palaga wrote:
> > > Hi *,
> > >
> > > It is quite an extensive patch. Could please
> somebody have
> a look
> > at it?
> > >
> > >
>
> https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
> <https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
> > >
> > > It implements a requirement from a customer as
> described in
> > >
> > >
> https://community.jboss.org/__wiki/RestrictedPageEditor
> <https://community.jboss.org/wiki/RestrictedPageEditor>
> > >
> > > To see the behavior requested by the customer,
> you should
> build the
> > > portal from my GTNPORTAL-3263.3 branch and run AS
> with this
> > extension:
> > >
> > >
>
> https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
>
> <https://github.com/ppalaga/gatein-restricted-page-editor-extension>
> > >
> > > Thanks,
> > >
> > > Peter
> > > _________________________________________________
> > > gatein-dev mailing list
> > > gatein-dev(a)lists.jboss.org
> <mailto:gatein-dev@lists.jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>
>
> > >
> https://lists.jboss.org/__mailman/listinfo/gatein-dev
> <https://lists.jboss.org/mailman/listinfo/gatein-dev>
> > >
> >
> > _________________________________________________
> > gatein-dev mailing list
> > gatein-dev(a)lists.jboss.org
> <mailto:gatein-dev@lists.jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>
>
> > https://lists.jboss.org/__mailman/listinfo/gatein-dev
> <https://lists.jboss.org/mailman/listinfo/gatein-dev>
> >
> >
> >
> >
> > --
> > *Trong Tran*
> > /(+84) 983841909 | /trongtt(a)gmail.com
> <mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>>
> <mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>
> <mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>>>
>
> > Twitter:http://twitter.com/__trongtt//
> <http://twitter.com/trongtt//>
>
> _________________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>
> https://lists.jboss.org/__mailman/listinfo/gatein-dev
> <https://lists.jboss.org/mailman/listinfo/gatein-dev>
>
>
>
>
7:55 a.m.
Do you know of other places where I should do the same?
--> I think there is no more other place to fix
- I see that we need "Has*Permission" in each groovy templates:
https://github.com/ppalaga/gatein-portal/blob/GTNPORTAL-3263.3/web/portal...
So any extension project that overwrite default template of portal, will
need to be migrated to have code snipet like this:
if (uicomponent.hasMoveAppsPermission()) {
permissionClasses.append(" HasMoveAppsPermissions");
}
if (uicomponent.hasMoveContainersPermission()) {
permissionClasses.append(" HasMoveContainersPermissions");
}
I means if customer has their extension project, they may need to migrate
their code
- Pls correct me if i'm wrong, but I don't see the code to marsall and
unmarsall the "Move*Permission" for portal-layout and page-layout when
Import and Exporting site. Reproduce:
+ Create a page name "Test" by using Page Wizard --> choose 3 columns
layout (running GateIn with extension that config 3 columns page template
with "move-apps-permission : nobody" for page
+ Go to Import-Export page --> export current Site
+ Import that Site with "Overwrite" mode
--> User can now DnD container and apps to "Test" page --> The problem
is:
missing code for marsalling and unmarsalling move*permission, then now the
page "Test" loose setting for move*permission after being exported and
re-imported
On Mon, Oct 14, 2013 at 10:22 PM, Thomas Heute <theute(a)redhat.com> wrote:
On 10/14/2013 05:15 PM, Peter Palaga wrote:
> On 2013-10-14 13:46, Phuong Viet VU wrote:
>
>> ok, I have some more comments:
>> 1. I see that "root" user can do anything, even when we set
"nobody" for
>> move*-application and move*-container. But the specification say that it
>> can prevent "root" user.
>>
>
> No, the spec says that <move-*-permissions>Nobody</**move-*-permissions>
> forbids the actions to everyone _except for_ root. So, the present
> implementation works as specified.
>
> 2. I can't DnD new App and Container to portal-layout (run gatein with
>> extension).
>> When I create page with "Add page" wizard, choose "Two
columns" layout
>> --> Can't DnD new container to the Page, even there is
>> "HasMoveContainersPermissions" class
>>
>
> Sorry, this part of JavaScript was broken since Friday. It must work now.
>
> 3. The feature only work if we create page from templates. But GateIn
>> also allow to create page with-out template:
>> by using "Page management" portlet, or when using navigation editor
-->
>> create node --> create page. It create a page with-out template, and the
>> move* permission is null --> no way to DnD Apps and Container to the
>> newly created page. And we don't have UI support to set the move*
>> permission
>>
>
> I agree that at some point, we need to add a UI for the management of
> the new permissions. But it is out of scope ATM.
>
> With the present spec, I guess, the customer will be able to hide the
> alternative ways to create pages from user groups that are supposed to
> use the "template way". Thomas?
>
I will need to give it a try, I don't think that I understand why it is
different.
Thomas
And finally, I agree that the page creation with null move* permissions
> from Page management and navigation editor is not correct. I have
> changed it to use ProtectedContainer.DEFAULT_**MOVE_*_PERMISSIONS, see []
> Do you know of other places where I should do the same?
>
> [1]
https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**3263.3<htt...
>
> Thanks,
>
> Peter
>
> On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga <ppalaga(a)redhat.com
>> <mailto:ppalaga@redhat.com>> wrote:
>>
>> Thanks for the message, Phuong. I'll have a look what is the
>> problem. -- PP
>>
>>
>> On 2013-10-14 11:17, Phuong Viet VU wrote:
>>
>> Hi, I'm trying "Restricted" page editor feature (build
with
>> tomcat7 -->
>>
>>
https://github.com/ppalaga/__**gatein-portal/tree/GTNPORTAL-_**_3263.3<...
>> <https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**
>> 3263.3 <https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
>> >)
>> I tried GateIn without the extension
>>
>> (https://github.com/ppalaga/__**gatein-restricted-page-editor-**
>>
__extension<https://github.com/ppalaga/__gatein-restricted-page-editor...
>>
>>
<https://github.com/ppalaga/**gatein-restricted-page-editor-**extension<...
>> >)
>> -->
>> It should works the same as before this feature, right ?
>>
>> 1. After login as root, go to home page, edit portal layout -->
>> I can't
>> DnD page-body to another place, it always stay in the same place
>> 2. Try to drop new Row container, and new application to the
>> page, then
>> move them around --> Exception in the console
>> 143469 [http-bio-8080-exec-6] ERROR portal:UIPortalApplication -
>> Error
>> during the processAction phase
>> java.lang.NullPointerException
>> at
>>
>> org.exoplatform.portal.webui._**_portal.__**
>> UIPortalComponentActionListene**__r$MoveChildActionListener.__**
>> prepareUiSource(__**UIPortalComponentActionListene**__r.java:300)
>>
>> at
>>
>> org.exoplatform.portal.webui._**_portal.__**
>> UIPortalComponentActionListene**__r$MoveChildActionListener.__**
>> execute(__**UIPortalComponentActionListene**__r.java:239)
>>
>> at org.exoplatform.webui.event.__**
>> Event.broadcast(Event.java:97)
>> at
>>
>> org.exoplatform.webui.core.__**lifecycle.Lifecycle.__**
>> processAction(Lifecycle.java:_**_51)
>>
>> at
>>
>> org.exoplatform.webui.core.__**UIComponent.processAction(__**
>> UIComponent.java:119)
>>
>> at
>>
>> org.exoplatform.portal.webui._**_workspace.__**
>> UIPortalApplicationLifecycle._**_processAction(__**
>> UIPortalApplicationLifecycle._**_java:73)
>>
>> at
>>
>> org.exoplatform.portal.webui._**_workspace.__**
>> UIPortalApplicationLifecycle._**_processAction(__**
>> UIPortalApplicationLifecycle._**_java:36)
>>
>>
>>
>>
>> On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga
>> <ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>>
wrote:
>>
>> Thanks Trong.
>>
>> Please note that there is a small update in
>>
>>
https://github.com/ppalaga/__**gatein-portal/tree/GTNPORTAL-_**_3263.3<...
>> <https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**
>> 3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>
>> : The new
>> permissions are enforced also during deletions now.
>>
>> Best,
>>
>> Peter
>>
>> On 2013-10-11 06:05, Trong Tran wrote:
>> > Hi,
>> >
>> > We are going to take a look at this and will give you
>> feedback on
>> Monday
>> >
>> > Thanks,
>> >
>> >
>> > On 10 October 2013 15:45, Peter Palaga
>> <ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>
>> > <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>> wrote:
>> >
>> > Hi *,
>> >
>> > it would be nice if someone from eXo could have a
>> look at
>> this. Please
>> > note that we cannot wait for long. We have decided
>> to do a
>> RH-internal
>> > cross-checking with Lucas and if there is no message
>> from eXo
>> after we
>> > are finished with the checks, I'll merge it without
>> waiting
>> for eXo.
>> >
>> > Thanks,
>> >
>> > Peter
>> >
>> > On 2013-10-04 17:11, Peter Palaga wrote:
>> > > Hi *,
>> > >
>> > > It is quite an extensive patch. Could please
>> somebody have
>> a look
>> > at it?
>> > >
>> > >
>>
>>
https://github.com/ppalaga/__**gatein-portal/tree/GTNPORTAL-_**_3263.3<...
>> <https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**
>> 3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>
>> > >
>> > > It implements a requirement from a customer as
>> described in
>> > >
>> > >
>>
https://community.jboss.org/__**wiki/RestrictedPageEditor<https://comm...
>>
<https://community.jboss.org/**wiki/RestrictedPageEditor<https://commun...
>> >
>> > >
>> > > To see the behavior requested by the customer,
>> you should
>> build the
>> > > portal from my GTNPORTAL-3263.3 branch and run AS
>> with this
>> > extension:
>> > >
>> > >
>>
>> https://github.com/ppalaga/__**gatein-restricted-page-editor-**
>>
__extension<https://github.com/ppalaga/__gatein-restricted-page-editor...
>>
>>
<https://github.com/ppalaga/**gatein-restricted-page-editor-**extension<...
>> >
>> > >
>> > > Thanks,
>> > >
>> > > Peter
>> > > ______________________________**
>> ___________________
>> > > gatein-dev mailing list
>> > > gatein-dev(a)lists.jboss.org
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >
>> <mailto:gatein-dev@lists.__jbo**ss.org <http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>
>> <mailto:gatein-dev@lists.__jbo**ss.org <http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >
>> <mailto:gatein-dev@lists.__jbo**ss.org <http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>
>>
>> > >
>>
https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>>
<https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>> >
>> > >
>> >
>> > ______________________________**___________________
>> > gatein-dev mailing list
>> > gatein-dev(a)lists.jboss.org
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >
>> <mailto:gatein-dev@lists.__jbo**ss.org <http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>
>> <mailto:gatein-dev@lists.__jbo**ss.org <http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >
>> <mailto:gatein-dev@lists.__jbo**ss.org <http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>
>>
>> >
https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>>
<https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>> >
>> >
>> >
>> >
>> >
>> > --
>> > *Trong Tran*
>> > /(+84) 983841909 | /trongtt(a)gmail.com
>> <mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>>
>> <mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>
>> <mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>>>
>>
>> >
Twitter:http://twitter.com/__**trongtt//<http://twitter.com/__trongtt/...
>> <http://twitter.com/trongtt//>
>>
>> ______________________________**___________________
>> gatein-dev mailing list
>> gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >
>> <mailto:gatein-dev@lists.__jbo**ss.org <http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>
>>
https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>>
<https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>> >
>>
>>
>>
>>
>>
>
7:45 a.m.
Hi Phuong,
On 2013-10-15 14:55, Phuong Viet VU wrote:
Do you know of other places where I should do the same?
--> I think there is no more other place to fix
- I see that we need "Has*Permission" in each groovy templates:
https://github.com/ppalaga/gatein-portal/blob/GTNPORTAL-3263.3/web/portal...
So any extension project that overwrite default template of portal, will
need to be migrated to have code snipet like this:
if (uicomponent.hasMoveAppsPermission()) {
permissionClasses.append(" HasMoveAppsPermissions");
}
if (uicomponent.hasMoveContainersPermission()) {
permissionClasses.append(" HasMoveContainersPermissions");
}
I means if customer has their extension project, they may need to
migrate their code
Yes, this is a valid concern, but what else can we do?
One could perhaps work with negative markers - e.g.
"CannotMoveContainers" on containers where the current user is *not
allowed* to move child containers instead of using positive
"HasMoveContainersPermissions" on containers where he can. In this way,
the legacy Groovy templates would not be hardly broken just after the
migration. More precisely, the drop feedback in browser would not be
100% accurate but one could work at least. Actually the
non-100%-acurateness holds only for containers using non-default move-*
permissions. Hence portal owners who would not touch move-* permissions
would not need to touch their custom Groovy templates as well. I guess
this idea is worth pursuing in detail. WDYT?
- Pls correct me if i'm wrong, but I don't see the code to
marsall and
unmarsall the "Move*Permission" for portal-layout and page-layout when
Import and Exporting site.
Yes, they both were missing and I have added them now (I have not pushed
yet). Thanks for noticing! -- PP
Reproduce:
+ Create a page name "Test" by using Page Wizard -->
choose 3 columns
layout (running GateIn with extension that config 3 columns page
template with "move-apps-permission : nobody" for page
+ Go to Import-Export page --> export current Site
+ Import that Site with "Overwrite" mode
--> User can now DnD container and apps to "Test" page --> The problem
is: missing code for marsalling and unmarsalling move*permission, then
now the page "Test" loose setting for move*permission after being
exported and re-imported
On Mon, Oct 14, 2013 at 10:22 PM, Thomas Heute <theute(a)redhat.com
<mailto:theute@redhat.com>> wrote:
On 10/14/2013 05:15 PM, Peter Palaga wrote:
On 2013-10-14 13:46, Phuong Viet VU wrote:
ok, I have some more comments:
1. I see that "root" user can do anything, even when we set
"nobody" for
move*-application and move*-container. But the specification
say that it
can prevent "root" user.
No, the spec says that
<move-*-permissions>Nobody</__move-*-permissions>
forbids the actions to everyone _except for_ root. So, the present
implementation works as specified.
2. I can't DnD new App and Container to portal-layout (run
gatein with
extension).
When I create page with "Add page" wizard, choose "Two
columns" layout
--> Can't DnD new container to the Page, even there is
"HasMoveContainersPermissions" class
Sorry, this part of JavaScript was broken since Friday. It must
work now.
3. The feature only work if we create page from templates.
But GateIn
also allow to create page with-out template:
by using "Page management" portlet, or when using navigation
editor -->
create node --> create page. It create a page with-out
template, and the
move* permission is null --> no way to DnD Apps and
Container to the
newly created page. And we don't have UI support to set the
move*
permission
I agree that at some point, we need to add a UI for the
management of
the new permissions. But it is out of scope ATM.
With the present spec, I guess, the customer will be able to
hide the
alternative ways to create pages from user groups that are
supposed to
use the "template way". Thomas?
I will need to give it a try, I don't think that I understand why it
is different.
Thomas
And finally, I agree that the page creation with null move*
permissions
from Page management and navigation editor is not correct. I have
changed it to use
ProtectedContainer.DEFAULT___MOVE_*_PERMISSIONS, see []
Do you know of other places where I should do the same?
[1]
https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
Thanks,
Peter
On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga
<ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>>
wrote:
Thanks for the message, Phuong. I'll have a look what
is the
problem. -- PP
On 2013-10-14 11:17, Phuong Viet VU wrote:
Hi, I'm trying "Restricted" page editor feature
(build with
tomcat7 -->
https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>)
I tried GateIn without the extension
(https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>>)
-->
It should works the same as before this feature,
right ?
1. After login as root, go to home page, edit
portal layout -->
I can't
DnD page-body to another place, it always stay in
the same place
2. Try to drop new Row container, and new
application to the
page, then
move them around --> Exception in the console
143469 [http-bio-8080-exec-6] ERROR
portal:UIPortalApplication -
Error
during the processAction phase
java.lang.NullPointerException
at
org.exoplatform.portal.webui.____portal.____UIPortalComponentActionListene____r$MoveChildActionListener.____prepareUiSource(____UIPortalComponentActionListene____r.java:300)
at
org.exoplatform.portal.webui.____portal.____UIPortalComponentActionListene____r$MoveChildActionListener.____execute(____UIPortalComponentActionListene____r.java:239)
at
org.exoplatform.webui.event.____Event.broadcast(Event.java:97)
at
org.exoplatform.webui.core.____lifecycle.Lifecycle.____processAction(Lifecycle.java:____51)
at
org.exoplatform.webui.core.____UIComponent.processAction(____UIComponent.java:119)
at
org.exoplatform.portal.webui.____workspace.____UIPortalApplicationLifecycle.____processAction(____UIPortalApplicationLifecycle.____java:73)
at
org.exoplatform.portal.webui.____workspace.____UIPortalApplicationLifecycle.____processAction(____UIPortalApplicationLifecycle.____java:36)
On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga
<ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>> wrote:
Thanks Trong.
Please note that there is a small update in
https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>
: The new
permissions are enforced also during deletions
now.
Best,
Peter
On 2013-10-11 06:05, Trong Tran wrote:
> Hi,
>
> We are going to take a look at this and
will give you
feedback on
Monday
>
> Thanks,
>
>
> On 10 October 2013 15:45, Peter Palaga
<ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>
> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>>> wrote:
>
> Hi *,
>
> it would be nice if someone from eXo
could have a
look at
this. Please
> note that we cannot wait for long. We
have decided
to do a
RH-internal
> cross-checking with Lucas and if there
is no message
from eXo
after we
> are finished with the checks, I'll
merge it without
waiting
for eXo.
>
> Thanks,
>
> Peter
>
> On 2013-10-04 17:11, Peter Palaga wrote:
> > Hi *,
> >
> > It is quite an extensive patch.
Could please
somebody have
a look
> at it?
> >
> >
https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>
> >
> > It implements a requirement from a
customer as
described in
> >
> >
https://community.jboss.org/____wiki/RestrictedPageEditor
<https://community.jboss.org/__wiki/RestrictedPageEditor>
<https://community.jboss.org/__wiki/RestrictedPageEditor
<https://community.jboss.org/wiki/RestrictedPageEditor>>
> >
> > To see the behavior requested by the
customer,
you should
build the
> > portal from my GTNPORTAL-3263.3
branch and run AS
with this
> extension:
> >
> >
https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>>
> >
> > Thanks,
> >
> > Peter
> >
___________________________________________________
> > gatein-dev mailing list
> > gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>
> >
https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>
<https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>>
> >
>
>
___________________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>
>
https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>
<https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>>
>
>
>
>
> --
> *Trong Tran*
> /(+84) 983841909 | /trongtt(a)gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>>
> Twitter:http://twitter.com/____trongtt//
<http://twitter.com/__trongtt//>
<http://twitter.com/trongtt//>
___________________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>
<https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>>
4:28 a.m.
Hi Phuong,
I fixed the import/export and I changed the CSS markers to negative
"CannotMove*" ones. Could you please check if this version succeeds in
all your scenarios?
https://github.com/ppalaga/gatein-portal/blob/GTNPORTAL-3263.3
Thanks,
Peter
On 2013-10-16 14:45, Peter Palaga wrote:
Hi Phuong,
On 2013-10-15 14:55, Phuong Viet VU wrote:
> Do you know of other places where I should do the same?
> --> I think there is no more other place to fix
>
> - I see that we need "Has*Permission" in each groovy templates:
>
https://github.com/ppalaga/gatein-portal/blob/GTNPORTAL-3263.3/web/portal...
>
> So any extension project that overwrite default template of portal, will
> need to be migrated to have code snipet like this:
> if (uicomponent.hasMoveAppsPermission()) {
> permissionClasses.append(" HasMoveAppsPermissions");
> }
> if (uicomponent.hasMoveContainersPermission()) {
> permissionClasses.append(" HasMoveContainersPermissions");
> }
> I means if customer has their extension project, they may need to
> migrate their code
Yes, this is a valid concern, but what else can we do?
One could perhaps work with negative markers - e.g.
"CannotMoveContainers" on containers where the current user is *not
allowed* to move child containers instead of using positive
"HasMoveContainersPermissions" on containers where he can. In this way,
the legacy Groovy templates would not be hardly broken just after the
migration. More precisely, the drop feedback in browser would not be
100% accurate but one could work at least. Actually the
non-100%-acurateness holds only for containers using non-default move-*
permissions. Hence portal owners who would not touch move-* permissions
would not need to touch their custom Groovy templates as well. I guess
this idea is worth pursuing in detail. WDYT?
> - Pls correct me if i'm wrong, but I don't see the code to marsall and
> unmarsall the "Move*Permission" for portal-layout and page-layout when
> Import and Exporting site.
Yes, they both were missing and I have added them now (I have not pushed
yet). Thanks for noticing! -- PP
Reproduce:
> + Create a page name "Test" by using Page Wizard --> choose 3
columns
> layout (running GateIn with extension that config 3 columns page
> template with "move-apps-permission : nobody" for page
> + Go to Import-Export page --> export current Site
> + Import that Site with "Overwrite" mode
> --> User can now DnD container and apps to "Test" page --> The
problem
> is: missing code for marsalling and unmarsalling move*permission, then
> now the page "Test" loose setting for move*permission after being
> exported and re-imported
>
>
> On Mon, Oct 14, 2013 at 10:22 PM, Thomas Heute <theute(a)redhat.com
> <mailto:theute@redhat.com>> wrote:
>
>
>
> On 10/14/2013 05:15 PM, Peter Palaga wrote:
>
> On 2013-10-14 13:46, Phuong Viet VU wrote:
>
> ok, I have some more comments:
> 1. I see that "root" user can do anything, even when we set
> "nobody" for
> move*-application and move*-container. But the specification
> say that it
> can prevent "root" user.
>
>
> No, the spec says that
> <move-*-permissions>Nobody</__move-*-permissions>
> forbids the actions to everyone _except for_ root. So, the present
> implementation works as specified.
>
> 2. I can't DnD new App and Container to portal-layout (run
> gatein with
> extension).
> When I create page with "Add page" wizard, choose "Two
> columns" layout
> --> Can't DnD new container to the Page, even there is
> "HasMoveContainersPermissions" class
>
>
> Sorry, this part of JavaScript was broken since Friday. It must
> work now.
>
> 3. The feature only work if we create page from templates.
> But GateIn
> also allow to create page with-out template:
> by using "Page management" portlet, or when using navigation
> editor -->
> create node --> create page. It create a page with-out
> template, and the
> move* permission is null --> no way to DnD Apps and
> Container to the
> newly created page. And we don't have UI support to set the
> move*
> permission
>
>
> I agree that at some point, we need to add a UI for the
> management of
> the new permissions. But it is out of scope ATM.
>
> With the present spec, I guess, the customer will be able to
> hide the
> alternative ways to create pages from user groups that are
> supposed to
> use the "template way". Thomas?
>
>
> I will need to give it a try, I don't think that I understand why it
> is different.
>
> Thomas
>
>
> And finally, I agree that the page creation with null move*
> permissions
> from Page management and navigation editor is not correct. I have
> changed it to use
> ProtectedContainer.DEFAULT___MOVE_*_PERMISSIONS, see []
> Do you know of other places where I should do the same?
>
> [1]
> https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
> <https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
>
> Thanks,
>
> Peter
>
> On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga
> <ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>>
wrote:
>
> Thanks for the message, Phuong. I'll have a look what
> is the
> problem. -- PP
>
>
> On 2013-10-14 11:17, Phuong Viet VU wrote:
>
> Hi, I'm trying "Restricted" page editor feature
> (build with
> tomcat7 -->
>
> https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
>
> <https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
>
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>)
> I tried GateIn without the extension
>
>
(https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>
>
>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
>
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>>)
> -->
> It should works the same as before this feature,
> right ?
>
> 1. After login as root, go to home page, edit
> portal layout -->
> I can't
> DnD page-body to another place, it always stay in
> the same place
> 2. Try to drop new Row container, and new
> application to the
> page, then
> move them around --> Exception in the console
> 143469 [http-bio-8080-exec-6] ERROR
> portal:UIPortalApplication -
> Error
> during the processAction phase
> java.lang.NullPointerException
> at
>
>
org.exoplatform.portal.webui.____portal.____UIPortalComponentActionListene____r$MoveChildActionListener.____prepareUiSource(____UIPortalComponentActionListene____r.java:300)
>
> at
>
>
org.exoplatform.portal.webui.____portal.____UIPortalComponentActionListene____r$MoveChildActionListener.____execute(____UIPortalComponentActionListene____r.java:239)
>
> at
> org.exoplatform.webui.event.____Event.broadcast(Event.java:97)
> at
>
>
org.exoplatform.webui.core.____lifecycle.Lifecycle.____processAction(Lifecycle.java:____51)
>
> at
>
>
org.exoplatform.webui.core.____UIComponent.processAction(____UIComponent.java:119)
>
> at
>
>
org.exoplatform.portal.webui.____workspace.____UIPortalApplicationLifecycle.____processAction(____UIPortalApplicationLifecycle.____java:73)
>
> at
>
>
org.exoplatform.portal.webui.____workspace.____UIPortalApplicationLifecycle.____processAction(____UIPortalApplicationLifecycle.____java:36)
>
>
>
>
> On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga
> <ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>>> wrote:
>
> Thanks Trong.
>
> Please note that there is a small update in
>
> https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
>
> <https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
>
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>
> : The new
> permissions are enforced also during deletions
> now.
>
> Best,
>
> Peter
>
> On 2013-10-11 06:05, Trong Tran wrote:
> > Hi,
> >
> > We are going to take a look at this and
> will give you
> feedback on
> Monday
> >
> > Thanks,
> >
> >
> > On 10 October 2013 15:45, Peter Palaga
> <ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>>
> > <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>>>> wrote:
> >
> > Hi *,
> >
> > it would be nice if someone from eXo
> could have a
> look at
> this. Please
> > note that we cannot wait for long. We
> have decided
> to do a
> RH-internal
> > cross-checking with Lucas and if there
> is no message
> from eXo
> after we
> > are finished with the checks, I'll
> merge it without
> waiting
> for eXo.
> >
> > Thanks,
> >
> > Peter
> >
> > On 2013-10-04 17:11, Peter Palaga wrote:
> > > Hi *,
> > >
> > > It is quite an extensive patch.
> Could please
> somebody have
> a look
> > at it?
> > >
> > >
>
> https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
>
> <https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
>
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>
> > >
> > > It implements a requirement from a
> customer as
> described in
> > >
> > >
> https://community.jboss.org/____wiki/RestrictedPageEditor
> <https://community.jboss.org/__wiki/RestrictedPageEditor>
>
> <https://community.jboss.org/__wiki/RestrictedPageEditor
> <https://community.jboss.org/wiki/RestrictedPageEditor>>
> > >
> > > To see the behavior requested by the
> customer,
> you should
> build the
> > > portal from my GTNPORTAL-3263.3
> branch and run AS
> with this
> > extension:
> > >
> > >
>
>
https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>
>
>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
>
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>>
> > >
> > > Thanks,
> > >
> > > Peter
> > >
> ___________________________________________________
> > > gatein-dev mailing list
> > > gatein-dev(a)lists.jboss.org
> <mailto:gatein-dev@lists.jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>>
>
> > >
> https://lists.jboss.org/____mailman/listinfo/gatein-dev
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev>
>
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev
> <https://lists.jboss.org/mailman/listinfo/gatein-dev>>
> > >
> >
> >
> ___________________________________________________
> > gatein-dev mailing list
> > gatein-dev(a)lists.jboss.org
> <mailto:gatein-dev@lists.jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>>
>
> >
> https://lists.jboss.org/____mailman/listinfo/gatein-dev
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev>
>
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev
> <https://lists.jboss.org/mailman/listinfo/gatein-dev>>
> >
> >
> >
> >
> > --
> > *Trong Tran*
> > /(+84) 983841909 | /trongtt(a)gmail.com
> <mailto:trongtt@gmail.com>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>
> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>>>>
>
> > Twitter:http://twitter.com/____trongtt//
> <http://twitter.com/__trongtt//>
> <http://twitter.com/trongtt//>
>
>
> ___________________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
> <mailto:gatein-dev@lists.jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>
> https://lists.jboss.org/____mailman/listinfo/gatein-dev
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev>
>
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev
> <https://lists.jboss.org/mailman/listinfo/gatein-dev>>
>
>
>
>
>
>
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev
4:26 a.m.
Hi Peter, I've just check your fix, and it works :)
But I have other cases:
1. I can move app to Container, but it can't be saved. It seems there is an
issue with MoveChildActionListener. Steps to reproduce: Edit a page --> Add
a container, then move exists app into that container, now refresh --> the
App is not in the Container
2. I can't move App and Container to Portal layout. I see that it unmarsall
the portal-layout correctly, maybe there is an issue when it map the config
model object to UI
On Thu, Oct 17, 2013 at 4:28 PM, Peter Palaga <ppalaga(a)redhat.com> wrote:
Hi Phuong,
I fixed the import/export and I changed the CSS markers to negative
"CannotMove*" ones. Could you please check if this version succeeds in all
your scenarios?
https://github.com/ppalaga/**gatein-portal/blob/GTNPORTAL-**3263.3<htt...
Thanks,
Peter
On 2013-10-16 14:45, Peter Palaga wrote:
> Hi Phuong,
>
> On 2013-10-15 14:55, Phuong Viet VU wrote:
>
>> Do you know of other places where I should do the same?
>> --> I think there is no more other place to fix
>>
>> - I see that we need "Has*Permission" in each groovy templates:
>> https://github.com/ppalaga/**gatein-portal/blob/GTNPORTAL-**
>> 3263.3/web/portal/src/main/**webapp/groovy/portal/webui/**
>>
container/UIContainer.gtmpl<https://github.com/ppalaga/gatein-portal/b...
>>
>> So any extension project that overwrite default template of portal, will
>> need to be migrated to have code snipet like this:
>> if (uicomponent.**hasMoveAppsPermission()) {
>> permissionClasses.append(" HasMoveAppsPermissions");
>> }
>> if (uicomponent.**hasMoveContainersPermission()) {
>> permissionClasses.append(" HasMoveContainersPermissions")**;
>> }
>> I means if customer has their extension project, they may need to
>> migrate their code
>>
>
> Yes, this is a valid concern, but what else can we do?
>
> One could perhaps work with negative markers - e.g.
> "CannotMoveContainers" on containers where the current user is *not
> allowed* to move child containers instead of using positive
> "HasMoveContainersPermissions" on containers where he can. In this way,
> the legacy Groovy templates would not be hardly broken just after the
> migration. More precisely, the drop feedback in browser would not be
> 100% accurate but one could work at least. Actually the
> non-100%-acurateness holds only for containers using non-default move-*
> permissions. Hence portal owners who would not touch move-* permissions
> would not need to touch their custom Groovy templates as well. I guess
> this idea is worth pursuing in detail. WDYT?
>
> - Pls correct me if i'm wrong, but I don't see the code to marsall and
>> unmarsall the "Move*Permission" for portal-layout and page-layout when
>> Import and Exporting site.
>>
>
> Yes, they both were missing and I have added them now (I have not pushed
> yet). Thanks for noticing! -- PP
>
> Reproduce:
>
>> + Create a page name "Test" by using Page Wizard --> choose 3
columns
>> layout (running GateIn with extension that config 3 columns page
>> template with "move-apps-permission : nobody" for page
>> + Go to Import-Export page --> export current Site
>> + Import that Site with "Overwrite" mode
>> --> User can now DnD container and apps to "Test" page --> The
problem
>> is: missing code for marsalling and unmarsalling move*permission, then
>> now the page "Test" loose setting for move*permission after being
>> exported and re-imported
>>
>>
>> On Mon, Oct 14, 2013 at 10:22 PM, Thomas Heute <theute(a)redhat.com
>> <mailto:theute@redhat.com>> wrote:
>>
>>
>>
>> On 10/14/2013 05:15 PM, Peter Palaga wrote:
>>
>> On 2013-10-14 13:46, Phuong Viet VU wrote:
>>
>> ok, I have some more comments:
>> 1. I see that "root" user can do anything, even when we
set
>> "nobody" for
>> move*-application and move*-container. But the specification
>> say that it
>> can prevent "root" user.
>>
>>
>> No, the spec says that
>> <move-*-permissions>Nobody</__**move-*-permissions>
>> forbids the actions to everyone _except for_ root. So, the
>> present
>> implementation works as specified.
>>
>> 2. I can't DnD new App and Container to portal-layout (run
>> gatein with
>> extension).
>> When I create page with "Add page" wizard, choose
"Two
>> columns" layout
>> --> Can't DnD new container to the Page, even there is
>> "HasMoveContainersPermissions" class
>>
>>
>> Sorry, this part of JavaScript was broken since Friday. It must
>> work now.
>>
>> 3. The feature only work if we create page from templates.
>> But GateIn
>> also allow to create page with-out template:
>> by using "Page management" portlet, or when using
navigation
>> editor -->
>> create node --> create page. It create a page with-out
>> template, and the
>> move* permission is null --> no way to DnD Apps and
>> Container to the
>> newly created page. And we don't have UI support to set the
>> move*
>> permission
>>
>>
>> I agree that at some point, we need to add a UI for the
>> management of
>> the new permissions. But it is out of scope ATM.
>>
>> With the present spec, I guess, the customer will be able to
>> hide the
>> alternative ways to create pages from user groups that are
>> supposed to
>> use the "template way". Thomas?
>>
>>
>> I will need to give it a try, I don't think that I understand why it
>> is different.
>>
>> Thomas
>>
>>
>> And finally, I agree that the page creation with null move*
>> permissions
>> from Page management and navigation editor is not correct. I
>> have
>> changed it to use
>> ProtectedContainer.DEFAULT___**MOVE_*_PERMISSIONS, see []
>> Do you know of other places where I should do the same?
>>
>> [1]
>> https://github.com/ppalaga/__**gatein-portal/tree/GTNPORTAL-_**
>>
_3263.3<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__32...
>> <https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**
>> 3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>
>>
>> Thanks,
>>
>> Peter
>>
>> On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga
>> <ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>
>> wrote:
>>
>> Thanks for the message, Phuong. I'll have a look what
>> is the
>> problem. -- PP
>>
>>
>> On 2013-10-14 11:17, Phuong Viet VU wrote:
>>
>> Hi, I'm trying "Restricted" page editor
feature
>> (build with
>> tomcat7 -->
>>
>> https://github.com/ppalaga/___**
>>
_gatein-portal/tree/GTNPORTAL-**____3263.3<https://github.com/ppalaga/...
>> <https://github.com/ppalaga/__**
>>
gatein-portal/tree/GTNPORTAL-_**_3263.3<https://github.com/ppalaga/__g...
>> >
>>
>> <https://github.com/ppalaga/__**
>>
gatein-portal/tree/GTNPORTAL-_**_3263.3<https://github.com/ppalaga/__g...
>> <https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-
>> **3263.3<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
>> >>)
>> I tried GateIn without the extension
>>
>> (https://github.com/ppalaga/__**__gatein-restricted-page-**
>>
editor-____extension<https://github.com/ppalaga/____gatein-restricted-...
>> <https://github.com/ppalaga/__**
>>
gatein-restricted-page-editor-**__extension<https://github.com/ppalaga...
>> >
>>
>> <https://github.com/ppalaga/__**
>>
gatein-restricted-page-editor-**__extension<https://github.com/ppalaga...
>> <https://github.com/ppalaga/**
>>
gatein-restricted-page-editor-**extension<https://github.com/ppalaga/g...
>> >>)
>> -->
>> It should works the same as before this feature,
>> right ?
>>
>> 1. After login as root, go to home page, edit
>> portal layout -->
>> I can't
>> DnD page-body to another place, it always stay in
>> the same place
>> 2. Try to drop new Row container, and new
>> application to the
>> page, then
>> move them around --> Exception in the console
>> 143469 [http-bio-8080-exec-6] ERROR
>> portal:UIPortalApplication -
>> Error
>> during the processAction phase
>> java.lang.NullPointerException
>> at
>>
>> org.exoplatform.portal.webui._**___portal.____**
>> UIPortalComponentActionListene**____r$MoveChildActionListener.**
>> ____prepareUiSource(____**UIPortalComponentActionListene**
>> ____r.java:300)
>>
>> at
>>
>> org.exoplatform.portal.webui._**___portal.____**
>> UIPortalComponentActionListene**____r$MoveChildActionListener.**
>> ____execute(____**UIPortalComponentActionListene**____r.java:239)
>>
>> at
>> org.exoplatform.webui.event.__**
>> __Event.broadcast(Event.java:**97)
>> at
>>
>> org.exoplatform.webui.core.___**_lifecycle.Lifecycle.____**
>> processAction(Lifecycle.java:_**___51)
>>
>> at
>>
>> org.exoplatform.webui.core.___**
>> _UIComponent.processAction(___**_UIComponent.java:119)
>>
>> at
>>
>> org.exoplatform.portal.webui._**___workspace.____**
>> UIPortalApplicationLifecycle._**___processAction(____**
>> UIPortalApplicationLifecycle._**___java:73)
>>
>> at
>>
>> org.exoplatform.portal.webui._**___workspace.____**
>> UIPortalApplicationLifecycle._**___processAction(____**
>> UIPortalApplicationLifecycle._**___java:36)
>>
>>
>>
>>
>> On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga
>> <ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>>> wrote:
>>
>> Thanks Trong.
>>
>> Please note that there is a small update in
>>
>> https://github.com/ppalaga/___**
>>
_gatein-portal/tree/GTNPORTAL-**____3263.3<https://github.com/ppalaga/...
>> <https://github.com/ppalaga/__**
>>
gatein-portal/tree/GTNPORTAL-_**_3263.3<https://github.com/ppalaga/__g...
>> >
>>
>> <https://github.com/ppalaga/__**
>>
gatein-portal/tree/GTNPORTAL-_**_3263.3<https://github.com/ppalaga/__g...
>> <https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-
>> **3263.3<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
>> >>
>> : The new
>> permissions are enforced also during deletions
>> now.
>>
>> Best,
>>
>> Peter
>>
>> On 2013-10-11 06:05, Trong Tran wrote:
>> > Hi,
>> >
>> > We are going to take a look at this and
>> will give you
>> feedback on
>> Monday
>> >
>> > Thanks,
>> >
>> >
>> > On 10 October 2013 15:45, Peter Palaga
>> <ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>>
>> > <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>>>**> wrote:
>> >
>> > Hi *,
>> >
>> > it would be nice if someone from eXo
>> could have a
>> look at
>> this. Please
>> > note that we cannot wait for long. We
>> have decided
>> to do a
>> RH-internal
>> > cross-checking with Lucas and if there
>> is no message
>> from eXo
>> after we
>> > are finished with the checks, I'll
>> merge it without
>> waiting
>> for eXo.
>> >
>> > Thanks,
>> >
>> > Peter
>> >
>> > On 2013-10-04 17:11, Peter Palaga
>> wrote:
>> > > Hi *,
>> > >
>> > > It is quite an extensive patch.
>> Could please
>> somebody have
>> a look
>> > at it?
>> > >
>> > >
>>
>> https://github.com/ppalaga/___**
>>
_gatein-portal/tree/GTNPORTAL-**____3263.3<https://github.com/ppalaga/...
>> <https://github.com/ppalaga/__**
>>
gatein-portal/tree/GTNPORTAL-_**_3263.3<https://github.com/ppalaga/__g...
>> >
>>
>> <https://github.com/ppalaga/__**
>>
gatein-portal/tree/GTNPORTAL-_**_3263.3<https://github.com/ppalaga/__g...
>> <https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-
>> **3263.3<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
>> >>
>> > >
>> > > It implements a requirement from a
>> customer as
>> described in
>> > >
>> > >
>>
https://community.jboss.org/__**__wiki/RestrictedPageEditor<https://co...
>>
<https://community.jboss.org/_**_wiki/RestrictedPageEditor<https://comm...
>> >
>>
>>
<https://community.jboss.org/_**_wiki/RestrictedPageEditor<https://comm...
>>
<https://community.jboss.org/**wiki/RestrictedPageEditor<https://commun...
>> >>
>> > >
>> > > To see the behavior requested by the
>> customer,
>> you should
>> build the
>> > > portal from my GTNPORTAL-3263.3
>> branch and run AS
>> with this
>> > extension:
>> > >
>> > >
>>
>> https://github.com/ppalaga/___**_gatein-restricted-page-**
>>
editor-____extension<https://github.com/ppalaga/____gatein-restricted-...
>> <https://github.com/ppalaga/__**
>>
gatein-restricted-page-editor-**__extension<https://github.com/ppalaga...
>> >
>>
>> <https://github.com/ppalaga/__**
>>
gatein-restricted-page-editor-**__extension<https://github.com/ppalaga...
>> <https://github.com/ppalaga/**
>>
gatein-restricted-page-editor-**extension<https://github.com/ppalaga/g...
>> >>
>> > >
>> > > Thanks,
>> > >
>> > > Peter
>> > >
>> ______________________________**_____________________
>> > > gatein-dev mailing list
>> > > gatein-dev(a)lists.jboss.org
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>>
>>
>> > >
>>
https://lists.jboss.org/____**mailman/listinfo/gatein-dev<https://list...
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>> >
>>
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>>
<https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>> >>
>> > >
>> >
>> >
>> ______________________________**_____________________
>> > gatein-dev mailing list
>> > gatein-dev(a)lists.jboss.org
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>>
>>
>> >
>>
https://lists.jboss.org/____**mailman/listinfo/gatein-dev<https://list...
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>> >
>>
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>>
<https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>> >>
>> >
>> >
>> >
>> >
>> > --
>> > *Trong Tran*
>> > /(+84) 983841909 | /trongtt(a)gmail.com
>> <mailto:trongtt@gmail.com>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>
>> <mailto:trongtt@gmail.com <mailto:
>> trongtt(a)gmail.com>>>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>>>>
>>
>> >
Twitter:http://twitter.com/___**_trongtt//<http://twitter.com/____tron...
>>
<http://twitter.com/__trongtt/**/<http://twitter.com/__trongtt//>
>> >
>> <http://twitter.com/trongtt//>
>>
>>
>> ______________________________**_____________________
>> gatein-dev mailing list
>> gatein-dev(a)lists.jboss.org
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >
>> <mailto:gatein-dev@lists.__jbo**ss.org <http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>
>>
https://lists.jboss.org/____**mailman/listinfo/gatein-dev<https://list...
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>> >
>>
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>>
<https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>> >>
>>
>>
>>
>>
>>
>>
>>
> ______________________________**_________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
>
https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>
>
7:07 a.m.
Hi Phuong,
I fixed some issues with requirement 3272 and rebased on the present
master https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3-3272
On 2013-10-21 11:26, Phuong Viet VU wrote:
Hi Peter, I've just check your fix, and it works :)
But I have other cases:
1. I can move app to Container, but it can't be saved. It seems there is
an issue with MoveChildActionListener. Steps to reproduce: Edit a page
--> Add a container, then move exists app into that container, now
refresh --> the App is not in the Container
I cannot reproduce this with the above branch.
2. I can't move App and Container to Portal layout. I see that
it
unmarsall the portal-layout correctly, maybe there is an issue when it
map the config model object to UI
Cannot reproduce this too.
Could you please try with the above branch whether you can still
reproduce them both?
Thanks,
Peter
On Thu, Oct 17, 2013 at 4:28 PM, Peter Palaga <ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>> wrote:
Hi Phuong,
I fixed the import/export and I changed the CSS markers to negative
"CannotMove*" ones. Could you please check if this version succeeds
in all your scenarios?
https://github.com/ppalaga/__gatein-portal/blob/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/blob/GTNPORTAL-3263.3>
Thanks,
Peter
On 2013-10-16 14:45, Peter Palaga wrote:
Hi Phuong,
On 2013-10-15 14:55, Phuong Viet VU wrote:
Do you know of other places where I should do the same?
--> I think there is no more other place to fix
- I see that we need "Has*Permission" in each groovy templates:
https://github.com/ppalaga/__gatein-portal/blob/GTNPORTAL-__3263.3/web/po...
<https://github.com/ppalaga/gatein-portal/blob/GTNPORTAL-3263.3/web/portal...
So any extension project that overwrite default template of
portal, will
need to be migrated to have code snipet like this:
if (uicomponent.__hasMoveAppsPermission()) {
permissionClasses.append(" HasMoveAppsPermissions");
}
if (uicomponent.__hasMoveContainersPermission()) {
permissionClasses.append(" HasMoveContainersPermissions")__;
}
I means if customer has their extension project, they may
need to
migrate their code
Yes, this is a valid concern, but what else can we do?
One could perhaps work with negative markers - e.g.
"CannotMoveContainers" on containers where the current user is *not
allowed* to move child containers instead of using positive
"HasMoveContainersPermissions" on containers where he can. In
this way,
the legacy Groovy templates would not be hardly broken just
after the
migration. More precisely, the drop feedback in browser would not be
100% accurate but one could work at least. Actually the
non-100%-acurateness holds only for containers using non-default
move-*
permissions. Hence portal owners who would not touch move-*
permissions
would not need to touch their custom Groovy templates as well. I
guess
this idea is worth pursuing in detail. WDYT?
- Pls correct me if i'm wrong, but I don't see the code to
marsall and
unmarsall the "Move*Permission" for portal-layout and
page-layout when
Import and Exporting site.
Yes, they both were missing and I have added them now (I have
not pushed
yet). Thanks for noticing! -- PP
Reproduce:
+ Create a page name "Test" by using Page Wizard -->
choose 3 columns
layout (running GateIn with extension that config 3 columns page
template with "move-apps-permission : nobody" for page
+ Go to Import-Export page --> export current Site
+ Import that Site with "Overwrite" mode
--> User can now DnD container and apps to "Test" page -->
The problem
is: missing code for marsalling and unmarsalling
move*permission, then
now the page "Test" loose setting for move*permission after
being
exported and re-imported
On Mon, Oct 14, 2013 at 10:22 PM, Thomas Heute
<theute(a)redhat.com <mailto:theute@redhat.com>
<mailto:theute@redhat.com <mailto:theute@redhat.com>>> wrote:
On 10/14/2013 05:15 PM, Peter Palaga wrote:
On 2013-10-14 13:46, Phuong Viet VU wrote:
ok, I have some more comments:
1. I see that "root" user can do anything,
even when we set
"nobody" for
move*-application and move*-container. But the
specification
say that it
can prevent "root" user.
No, the spec says that
<move-*-permissions>Nobody</____move-*-permissions>
forbids the actions to everyone _except for_ root.
So, the present
implementation works as specified.
2. I can't DnD new App and Container to
portal-layout (run
gatein with
extension).
When I create page with "Add page" wizard,
choose "Two
columns" layout
--> Can't DnD new container to the Page, even
there is
"HasMoveContainersPermissions" class
Sorry, this part of JavaScript was broken since
Friday. It must
work now.
3. The feature only work if we create page
from templates.
But GateIn
also allow to create page with-out template:
by using "Page management" portlet, or when
using navigation
editor -->
create node --> create page. It create a page
with-out
template, and the
move* permission is null --> no way to DnD
Apps and
Container to the
newly created page. And we don't have UI
support to set the
move*
permission
I agree that at some point, we need to add a UI
for the
management of
the new permissions. But it is out of scope ATM.
With the present spec, I guess, the customer will
be able to
hide the
alternative ways to create pages from user groups
that are
supposed to
use the "template way". Thomas?
I will need to give it a try, I don't think that I
understand why it
is different.
Thomas
And finally, I agree that the page creation with
null move*
permissions
from Page management and navigation editor is not
correct. I have
changed it to use
ProtectedContainer.DEFAULT_____MOVE_*_PERMISSIONS,
see []
Do you know of other places where I should do the
same?
[1]
https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>
Thanks,
Peter
On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga
<ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>> wrote:
Thanks for the message, Phuong. I'll have
a look what
is the
problem. -- PP
On 2013-10-14 11:17, Phuong Viet VU wrote:
Hi, I'm trying "Restricted" page
editor feature
(build with
tomcat7 -->
https://github.com/ppalaga/______gatein-portal/tree/GTNPORTAL-______3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>>)
I tried GateIn without the extension
(https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extensio...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>>...)
-->
It should works the same as before
this feature,
right ?
1. After login as root, go to home
page, edit
portal layout -->
I can't
DnD page-body to another place, it
always stay in
the same place
2. Try to drop new Row container, and new
application to the
page, then
move them around --> Exception in the
console
143469 [http-bio-8080-exec-6] ERROR
portal:UIPortalApplication -
Error
during the processAction phase
java.lang.NullPointerException
at
org.exoplatform.portal.webui.______portal.______UIPortalComponentActionListene______r$MoveChildActionListener.______prepareUiSource(______UIPortalComponentActionListene______r.java:300)
at
org.exoplatform.portal.webui.______portal.______UIPortalComponentActionListene______r$MoveChildActionListener.______execute(______UIPortalComponentActionListene______r.java:239)
at
org.exoplatform.webui.event.______Event.broadcast(Event.java:__97)
at
org.exoplatform.webui.core.______lifecycle.Lifecycle.______processAction(Lifecycle.java:______51)
at
org.exoplatform.webui.core.______UIComponent.processAction(______UIComponent.java:119)
at
org.exoplatform.portal.webui.______workspace.______UIPortalApplicationLifecycle.______processAction(______UIPortalApplicationLifecycle.______java:73)
at
org.exoplatform.portal.webui.______workspace.______UIPortalApplicationLifecycle.______processAction(______UIPortalApplicationLifecycle.______java:36)
On Fri, Oct 11, 2013 at 10:00 PM,
Peter Palaga
<ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>>> wrote:
Thanks Trong.
Please note that there is a
small update in
https://github.com/ppalaga/______gatein-portal/tree/GTNPORTAL-______3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>>
: The new
permissions are enforced also
during deletions
now.
Best,
Peter
On 2013-10-11 06:05, Trong Tran
wrote:
> Hi,
>
> We are going to take a look
at this and
will give you
feedback on
Monday
>
> Thanks,
>
>
> On 10 October 2013 15:45,
Peter Palaga
<ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>>
> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>>>__> wrote:
>
> Hi *,
>
> it would be nice if
someone from eXo
could have a
look at
this. Please
> note that we cannot wait
for long. We
have decided
to do a
RH-internal
> cross-checking with Lucas
and if there
is no message
from eXo
after we
> are finished with the
checks, I'll
merge it without
waiting
for eXo.
>
> Thanks,
>
> Peter
>
> On 2013-10-04 17:11,
Peter Palaga wrote:
> > Hi *,
> >
> > It is quite an
extensive patch.
Could please
somebody have
a look
> at it?
> >
> >
https://github.com/ppalaga/______gatein-portal/tree/GTNPORTAL-______3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>>
> >
> > It implements a
requirement from a
customer as
described in
> >
> >
https://community.jboss.org/______wiki/RestrictedPageEditor
<https://community.jboss.org/____wiki/RestrictedPageEditor>
<https://community.jboss.org/____wiki/RestrictedPageEditor
<https://community.jboss.org/__wiki/RestrictedPageEditor>>
<https://community.jboss.org/____wiki/RestrictedPageEditor
<https://community.jboss.org/__wiki/RestrictedPageEditor>
<https://community.jboss.org/__wiki/RestrictedPageEditor
<https://community.jboss.org/wiki/RestrictedPageEditor>>>
> >
> > To see the behavior
requested by the
customer,
you should
build the
> > portal from my
GTNPORTAL-3263.3
branch and run AS
with this
> extension:
> >
> >
https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extensio...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>>...
> >
> > Thanks,
> >
> > Peter
> >
_____________________________________________________
> > gatein-dev mailing list
> >
gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>>
> >
https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>
<https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>>>
> >
>
>
_____________________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>>
>
https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>
<https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>>>
>
>
>
>
> --
> *Trong Tran*
> /(+84) 983841909 |
/trongtt(a)gmail.com <mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>>>
>
Twitter:http://twitter.com/______trongtt//
<http://twitter.com/____trongtt//>
<http://twitter.com/__trongtt/__/
<http://twitter.com/__trongtt//>>
<http://twitter.com/trongtt//>
_____________________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>
https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>
<https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>>>
_________________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>
1:50 p.m.
Hi again, Phuong and Lucas,
the issue found by Lucas - the visible header and footer portlets in
block page edit mode - is fixed in
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3-3272
Thanks,
Peter
On 2013-10-24 14:07, Peter Palaga wrote:
Hi Phuong,
I fixed some issues with requirement 3272 and rebased on the present
master https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3-3272
On 2013-10-21 11:26, Phuong Viet VU wrote:
> Hi Peter, I've just check your fix, and it works :)
> But I have other cases:
>
> 1. I can move app to Container, but it can't be saved. It seems there is
> an issue with MoveChildActionListener. Steps to reproduce: Edit a page
> --> Add a container, then move exists app into that container, now
> refresh --> the App is not in the Container
I cannot reproduce this with the above branch.
> 2. I can't move App and Container to Portal layout. I see that it
> unmarsall the portal-layout correctly, maybe there is an issue when it
> map the config model object to UI
Cannot reproduce this too.
Could you please try with the above branch whether you can still
reproduce them both?
Thanks,
Peter
>
>
>
> On Thu, Oct 17, 2013 at 4:28 PM, Peter Palaga <ppalaga(a)redhat.com
> <mailto:ppalaga@redhat.com>> wrote:
>
> Hi Phuong,
>
> I fixed the import/export and I changed the CSS markers to negative
> "CannotMove*" ones. Could you please check if this version succeeds
> in all your scenarios?
>
> https://github.com/ppalaga/__gatein-portal/blob/GTNPORTAL-__3263.3
> <https://github.com/ppalaga/gatein-portal/blob/GTNPORTAL-3263.3>
>
> Thanks,
>
> Peter
>
>
>
> On 2013-10-16 14:45, Peter Palaga wrote:
>
> Hi Phuong,
>
> On 2013-10-15 14:55, Phuong Viet VU wrote:
>
> Do you know of other places where I should do the same?
> --> I think there is no more other place to fix
>
> - I see that we need "Has*Permission" in each groovy
templates:
>
https://github.com/ppalaga/__gatein-portal/blob/GTNPORTAL-__3263.3/web/po...
>
<https://github.com/ppalaga/gatein-portal/blob/GTNPORTAL-3263.3/web/portal...
>
> So any extension project that overwrite default template of
> portal, will
> need to be migrated to have code snipet like this:
> if (uicomponent.__hasMoveAppsPermission()) {
> permissionClasses.append(" HasMoveAppsPermissions");
> }
> if (uicomponent.__hasMoveContainersPermission()) {
> permissionClasses.append(" HasMoveContainersPermissions")__;
> }
> I means if customer has their extension project, they may
> need to
> migrate their code
>
>
> Yes, this is a valid concern, but what else can we do?
>
> One could perhaps work with negative markers - e.g.
> "CannotMoveContainers" on containers where the current user is
*not
> allowed* to move child containers instead of using positive
> "HasMoveContainersPermissions" on containers where he can. In
> this way,
> the legacy Groovy templates would not be hardly broken just
> after the
> migration. More precisely, the drop feedback in browser would not be
> 100% accurate but one could work at least. Actually the
> non-100%-acurateness holds only for containers using non-default
> move-*
> permissions. Hence portal owners who would not touch move-*
> permissions
> would not need to touch their custom Groovy templates as well. I
> guess
> this idea is worth pursuing in detail. WDYT?
>
> - Pls correct me if i'm wrong, but I don't see the code to
> marsall and
> unmarsall the "Move*Permission" for portal-layout and
> page-layout when
> Import and Exporting site.
>
>
> Yes, they both were missing and I have added them now (I have
> not pushed
> yet). Thanks for noticing! -- PP
>
> Reproduce:
>
> + Create a page name "Test" by using Page Wizard -->
> choose 3 columns
> layout (running GateIn with extension that config 3 columns page
> template with "move-apps-permission : nobody" for page
> + Go to Import-Export page --> export current Site
> + Import that Site with "Overwrite" mode
> --> User can now DnD container and apps to "Test" page
-->
> The problem
> is: missing code for marsalling and unmarsalling
> move*permission, then
> now the page "Test" loose setting for move*permission after
> being
> exported and re-imported
>
>
> On Mon, Oct 14, 2013 at 10:22 PM, Thomas Heute
> <theute(a)redhat.com <mailto:theute@redhat.com>
> <mailto:theute@redhat.com <mailto:theute@redhat.com>>>
wrote:
>
>
>
> On 10/14/2013 05:15 PM, Peter Palaga wrote:
>
> On 2013-10-14 13:46, Phuong Viet VU wrote:
>
> ok, I have some more comments:
> 1. I see that "root" user can do anything,
> even when we set
> "nobody" for
> move*-application and move*-container. But the
> specification
> say that it
> can prevent "root" user.
>
>
> No, the spec says that
>
<move-*-permissions>Nobody</____move-*-permissions>
> forbids the actions to everyone _except for_ root.
> So, the present
> implementation works as specified.
>
> 2. I can't DnD new App and Container to
> portal-layout (run
> gatein with
> extension).
> When I create page with "Add page" wizard,
> choose "Two
> columns" layout
> --> Can't DnD new container to the Page, even
> there is
> "HasMoveContainersPermissions" class
>
>
> Sorry, this part of JavaScript was broken since
> Friday. It must
> work now.
>
> 3. The feature only work if we create page
> from templates.
> But GateIn
> also allow to create page with-out template:
> by using "Page management" portlet, or when
> using navigation
> editor -->
> create node --> create page. It create a page
> with-out
> template, and the
> move* permission is null --> no way to DnD
> Apps and
> Container to the
> newly created page. And we don't have UI
> support to set the
> move*
> permission
>
>
> I agree that at some point, we need to add a UI
> for the
> management of
> the new permissions. But it is out of scope ATM.
>
> With the present spec, I guess, the customer will
> be able to
> hide the
> alternative ways to create pages from user groups
> that are
> supposed to
> use the "template way". Thomas?
>
>
> I will need to give it a try, I don't think that I
> understand why it
> is different.
>
> Thomas
>
>
> And finally, I agree that the page creation with
> null move*
> permissions
> from Page management and navigation editor is not
> correct. I have
> changed it to use
> ProtectedContainer.DEFAULT_____MOVE_*_PERMISSIONS,
> see []
> Do you know of other places where I should do the
> same?
>
> [1]
> https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
>
> <https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>
>
> Thanks,
>
> Peter
>
> On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga
> <ppalaga(a)redhat.com
> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>>> wrote:
>
> Thanks for the message, Phuong. I'll have
> a look what
> is the
> problem. -- PP
>
>
> On 2013-10-14 11:17, Phuong Viet VU wrote:
>
> Hi, I'm trying "Restricted" page
> editor feature
> (build with
> tomcat7 -->
>
>
https://github.com/ppalaga/______gatein-portal/tree/GTNPORTAL-______3263.3
>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
>
>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>
>
>
>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
>
> <https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>>)
> I tried GateIn without the extension
>
>
>
(https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extensio...
>
>
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>...
>
>
>
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>
>
>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>>...)
> -->
> It should works the same as before
> this feature,
> right ?
>
> 1. After login as root, go to home
> page, edit
> portal layout -->
> I can't
> DnD page-body to another place, it
> always stay in
> the same place
> 2. Try to drop new Row container, and new
> application to the
> page, then
> move them around --> Exception in the
> console
> 143469 [http-bio-8080-exec-6] ERROR
> portal:UIPortalApplication -
> Error
> during the processAction phase
> java.lang.NullPointerException
> at
>
>
>
org.exoplatform.portal.webui.______portal.______UIPortalComponentActionListene______r$MoveChildActionListener.______prepareUiSource(______UIPortalComponentActionListene______r.java:300)
>
> at
>
>
>
org.exoplatform.portal.webui.______portal.______UIPortalComponentActionListene______r$MoveChildActionListener.______execute(______UIPortalComponentActionListene______r.java:239)
>
> at
>
> org.exoplatform.webui.event.______Event.broadcast(Event.java:__97)
> at
>
>
>
org.exoplatform.webui.core.______lifecycle.Lifecycle.______processAction(Lifecycle.java:______51)
>
> at
>
>
>
org.exoplatform.webui.core.______UIComponent.processAction(______UIComponent.java:119)
>
> at
>
>
>
org.exoplatform.portal.webui.______workspace.______UIPortalApplicationLifecycle.______processAction(______UIPortalApplicationLifecycle.______java:73)
>
> at
>
>
>
org.exoplatform.portal.webui.______workspace.______UIPortalApplicationLifecycle.______processAction(______UIPortalApplicationLifecycle.______java:36)
>
>
>
>
> On Fri, Oct 11, 2013 at 10:00 PM,
> Peter Palaga
> <ppalaga(a)redhat.com
> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>>>> wrote:
>
> Thanks Trong.
>
> Please note that there is a
> small update in
>
>
https://github.com/ppalaga/______gatein-portal/tree/GTNPORTAL-______3263.3
>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
>
>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>
>
>
>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
>
> <https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>>
> : The new
> permissions are enforced also
> during deletions
> now.
>
> Best,
>
> Peter
>
> On 2013-10-11 06:05, Trong Tran
> wrote:
> > Hi,
> >
> > We are going to take a look
> at this and
> will give you
> feedback on
> Monday
> >
> > Thanks,
> >
> >
> > On 10 October 2013 15:45,
> Peter Palaga
> <ppalaga(a)redhat.com
> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>>>
> > <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com
> <mailto:ppalaga@redhat.com>>>>>__> wrote:
> >
> > Hi *,
> >
> > it would be nice if
> someone from eXo
> could have a
> look at
> this. Please
> > note that we cannot wait
> for long. We
> have decided
> to do a
> RH-internal
> > cross-checking with Lucas
> and if there
> is no message
> from eXo
> after we
> > are finished with the
> checks, I'll
> merge it without
> waiting
> for eXo.
> >
> > Thanks,
> >
> > Peter
> >
> > On 2013-10-04 17:11,
> Peter Palaga wrote:
> > > Hi *,
> > >
> > > It is quite an
> extensive patch.
> Could please
> somebody have
> a look
> > at it?
> > >
> > >
>
>
https://github.com/ppalaga/______gatein-portal/tree/GTNPORTAL-______3263.3
>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
>
>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>
>
>
>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
>
> <https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>>
> > >
> > > It implements a
> requirement from a
> customer as
> described in
> > >
> > >
> https://community.jboss.org/______wiki/RestrictedPageEditor
> <https://community.jboss.org/____wiki/RestrictedPageEditor>
>
> <https://community.jboss.org/____wiki/RestrictedPageEditor
> <https://community.jboss.org/__wiki/RestrictedPageEditor>>
>
>
> <https://community.jboss.org/____wiki/RestrictedPageEditor
> <https://community.jboss.org/__wiki/RestrictedPageEditor>
>
> <https://community.jboss.org/__wiki/RestrictedPageEditor
> <https://community.jboss.org/wiki/RestrictedPageEditor>>>
> > >
> > > To see the behavior
> requested by the
> customer,
> you should
> build the
> > > portal from my
> GTNPORTAL-3263.3
> branch and run AS
> with this
> > extension:
> > >
> > >
>
>
https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
>
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extensio...
>
>
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>...
>
>
>
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>
>
>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>>...
> > >
> > > Thanks,
> > >
> > > Peter
> > >
>
> _____________________________________________________
> > > gatein-dev mailing list
> > >
> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.>__jb__o__ss.org
> <http://jbo__ss.org> <http://jboss.org>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>>
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.>__jb__o__ss.org
> <http://jbo__ss.org> <http://jboss.org>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.>__jb__o__ss.org
> <http://jbo__ss.org> <http://jboss.org>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>>>
>
> > >
> https://lists.jboss.org/______mailman/listinfo/gatein-dev
> <https://lists.jboss.org/____mailman/listinfo/gatein-dev>
>
> <https://lists.jboss.org/____mailman/listinfo/gatein-dev
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev>>
>
>
> <https://lists.jboss.org/____mailman/listinfo/gatein-dev
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev>
>
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev
> <https://lists.jboss.org/mailman/listinfo/gatein-dev>>>
> > >
> >
> >
>
> _____________________________________________________
> > gatein-dev mailing list
> > gatein-dev(a)lists.jboss.org
> <mailto:gatein-dev@lists.jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.>__jb__o__ss.org
> <http://jbo__ss.org> <http://jboss.org>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>>
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.>__jb__o__ss.org
> <http://jbo__ss.org> <http://jboss.org>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.>__jb__o__ss.org
> <http://jbo__ss.org> <http://jboss.org>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>>>
>
> >
> https://lists.jboss.org/______mailman/listinfo/gatein-dev
> <https://lists.jboss.org/____mailman/listinfo/gatein-dev>
>
> <https://lists.jboss.org/____mailman/listinfo/gatein-dev
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev>>
>
>
> <https://lists.jboss.org/____mailman/listinfo/gatein-dev
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev>
>
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev
> <https://lists.jboss.org/mailman/listinfo/gatein-dev>>>
> >
> >
> >
> >
> > --
> > *Trong Tran*
> > /(+84) 983841909 |
> /trongtt(a)gmail.com <mailto:trongtt@gmail.com>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>>> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>>>>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>>>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>
> <mailto:trongtt@gmail.com
> <mailto:trongtt@gmail.com>>>>>
>
> >
> Twitter:http://twitter.com/______trongtt//
> <http://twitter.com/____trongtt//>
> <http://twitter.com/__trongtt/__/
> <http://twitter.com/__trongtt//>>
> <http://twitter.com/trongtt//>
>
>
>
> _____________________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.
> <mailto:gatein-dev@lists
> <mailto:gatein-dev@lists>.>__jb__o__ss.org
> <http://jbo__ss.org> <http://jboss.org>
> <mailto:gatein-dev@lists.
> <mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
> <mailto:gatein-dev@lists.__jboss.org
> <mailto:gatein-dev@lists.jboss.org>>>>
> https://lists.jboss.org/______mailman/listinfo/gatein-dev
> <https://lists.jboss.org/____mailman/listinfo/gatein-dev>
>
> <https://lists.jboss.org/____mailman/listinfo/gatein-dev
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev>>
>
>
> <https://lists.jboss.org/____mailman/listinfo/gatein-dev
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev>
>
> <https://lists.jboss.org/__mailman/listinfo/gatein-dev
> <https://lists.jboss.org/mailman/listinfo/gatein-dev>>>
>
>
>
>
>
>
>
> _________________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
> https://lists.jboss.org/__mailman/listinfo/gatein-dev
> <https://lists.jboss.org/mailman/listinfo/gatein-dev>
>
>
>
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev
2:10 a.m.
I've built and tested the new branch
GTNPORTAL-**3263.3-3272<https://github.com/ppalaga/gatein-portal/tree/...
(Also
deploy Peter's example extension for page editor)
It's strange, I can still reproduce those issues, let me give more details
on how to reproduce it:
1. Login as John, edit "Home" page --> Drop a "One Row" container
to the
page, then drop "Sitemap" portlet to the page (not the container).
Now DnD "Sitemap" portlet (in the page) into the "One row" container
--> F5
refesh page --> the app is not in the container. If we try to move
"Sitemap" to container --> save, now let edit that page again, the portlet
is not in the Container
---> It seems there is an issue with MoveChildActionListener
2. Login as John, edit site (classic) layout --> Can't DnD any portlet or
container to the page (there are "CannotMoveApps CannotMoveContainers"
classes on UIPortal dom element)
--> I see that it unmarsall the portal-layout correctly, maybe there is an
issue when it map the config model object to UI
On Fri, Oct 25, 2013 at 1:50 AM, Peter Palaga <ppalaga(a)redhat.com> wrote:
Hi again, Phuong and Lucas,
the issue found by Lucas - the visible header and footer portlets in block
page edit mode - is fixed in
https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**3263.3-3272&l...
Thanks,
Peter
On 2013-10-24 14:07, Peter Palaga wrote:
> Hi Phuong,
>
> I fixed some issues with requirement 3272 and rebased on the present
> master https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**
>
3263.3-3272<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-32...
>
> On 2013-10-21 11:26, Phuong Viet VU wrote:
>
>> Hi Peter, I've just check your fix, and it works :)
>> But I have other cases:
>>
>> 1. I can move app to Container, but it can't be saved. It seems there is
>> an issue with MoveChildActionListener. Steps to reproduce: Edit a page
>> --> Add a container, then move exists app into that container, now
>> refresh --> the App is not in the Container
>>
>
> I cannot reproduce this with the above branch.
>
> 2. I can't move App and Container to Portal layout. I see that it
>> unmarsall the portal-layout correctly, maybe there is an issue when it
>> map the config model object to UI
>>
>
> Cannot reproduce this too.
>
> Could you please try with the above branch whether you can still
> reproduce them both?
>
> Thanks,
>
> Peter
>
>
>>
>>
>> On Thu, Oct 17, 2013 at 4:28 PM, Peter Palaga <ppalaga(a)redhat.com
>> <mailto:ppalaga@redhat.com>> wrote:
>>
>> Hi Phuong,
>>
>> I fixed the import/export and I changed the CSS markers to negative
>> "CannotMove*" ones. Could you please check if this version
succeeds
>> in all your scenarios?
>>
>> https://github.com/ppalaga/__**gatein-portal/blob/GTNPORTAL-_**
>>
_3263.3<https://github.com/ppalaga/__gatein-portal/blob/GTNPORTAL-__32...
>>
<https://github.com/ppalaga/**gatein-portal/blob/GTNPORTAL-**3263.3<htt...
>> >
>>
>> Thanks,
>>
>> Peter
>>
>>
>>
>> On 2013-10-16 14:45, Peter Palaga wrote:
>>
>> Hi Phuong,
>>
>> On 2013-10-15 14:55, Phuong Viet VU wrote:
>>
>> Do you know of other places where I should do the same?
>> --> I think there is no more other place to fix
>>
>> - I see that we need "Has*Permission" in each groovy
>> templates:
>> https://github.com/ppalaga/__**
>> gatein-portal/blob/GTNPORTAL-_**_3263.3/web/portal/src/main/__**
>>
webapp/groovy/portal/webui/__**container/UIContainer.gtmpl<https://git...
>> <https://github.com/ppalaga/**gatein-portal/blob/GTNPORTAL-
>> **3263.3/web/portal/src/main/**webapp/groovy/portal/webui/**
>>
container/UIContainer.gtmpl<https://github.com/ppalaga/gatein-portal/b...
>> >
>>
>> So any extension project that overwrite default template of
>> portal, will
>> need to be migrated to have code snipet like this:
>> if (uicomponent.__**hasMoveAppsPermission()) {
>> permissionClasses.append(" HasMoveAppsPermissions");
>> }
>> if (uicomponent.__**hasMoveContainersPermission()) {
>> permissionClasses.append("
HasMoveContainersPermissions")**
>> __;
>> }
>> I means if customer has their extension project, they may
>> need to
>> migrate their code
>>
>>
>> Yes, this is a valid concern, but what else can we do?
>>
>> One could perhaps work with negative markers - e.g.
>> "CannotMoveContainers" on containers where the current user
is
>> *not
>> allowed* to move child containers instead of using positive
>> "HasMoveContainersPermissions" on containers where he can. In
>> this way,
>> the legacy Groovy templates would not be hardly broken just
>> after the
>> migration. More precisely, the drop feedback in browser would
>> not be
>> 100% accurate but one could work at least. Actually the
>> non-100%-acurateness holds only for containers using non-default
>> move-*
>> permissions. Hence portal owners who would not touch move-*
>> permissions
>> would not need to touch their custom Groovy templates as well. I
>> guess
>> this idea is worth pursuing in detail. WDYT?
>>
>> - Pls correct me if i'm wrong, but I don't see the code to
>> marsall and
>> unmarsall the "Move*Permission" for portal-layout and
>> page-layout when
>> Import and Exporting site.
>>
>>
>> Yes, they both were missing and I have added them now (I have
>> not pushed
>> yet). Thanks for noticing! -- PP
>>
>> Reproduce:
>>
>> + Create a page name "Test" by using Page Wizard
-->
>> choose 3 columns
>> layout (running GateIn with extension that config 3 columns
>> page
>> template with "move-apps-permission : nobody" for page
>> + Go to Import-Export page --> export current Site
>> + Import that Site with "Overwrite" mode
>> --> User can now DnD container and apps to "Test" page
-->
>> The problem
>> is: missing code for marsalling and unmarsalling
>> move*permission, then
>> now the page "Test" loose setting for move*permission
after
>> being
>> exported and re-imported
>>
>>
>> On Mon, Oct 14, 2013 at 10:22 PM, Thomas Heute
>> <theute(a)redhat.com <mailto:theute@redhat.com>
>> <mailto:theute@redhat.com
<mailto:theute@redhat.com>>>
>> wrote:
>>
>>
>>
>> On 10/14/2013 05:15 PM, Peter Palaga wrote:
>>
>> On 2013-10-14 13:46, Phuong Viet VU wrote:
>>
>> ok, I have some more comments:
>> 1. I see that "root" user can do anything,
>> even when we set
>> "nobody" for
>> move*-application and move*-container. But the
>> specification
>> say that it
>> can prevent "root" user.
>>
>>
>> No, the spec says that
>> <move-*-permissions>Nobody</__**
>> __move-*-permissions>
>> forbids the actions to everyone _except for_ root.
>> So, the present
>> implementation works as specified.
>>
>> 2. I can't DnD new App and Container to
>> portal-layout (run
>> gatein with
>> extension).
>> When I create page with "Add page" wizard,
>> choose "Two
>> columns" layout
>> --> Can't DnD new container to the Page, even
>> there is
>> "HasMoveContainersPermissions" class
>>
>>
>> Sorry, this part of JavaScript was broken since
>> Friday. It must
>> work now.
>>
>> 3. The feature only work if we create page
>> from templates.
>> But GateIn
>> also allow to create page with-out template:
>> by using "Page management" portlet, or when
>> using navigation
>> editor -->
>> create node --> create page. It create a page
>> with-out
>> template, and the
>> move* permission is null --> no way to DnD
>> Apps and
>> Container to the
>> newly created page. And we don't have UI
>> support to set the
>> move*
>> permission
>>
>>
>> I agree that at some point, we need to add a UI
>> for the
>> management of
>> the new permissions. But it is out of scope ATM.
>>
>> With the present spec, I guess, the customer will
>> be able to
>> hide the
>> alternative ways to create pages from user groups
>> that are
>> supposed to
>> use the "template way". Thomas?
>>
>>
>> I will need to give it a try, I don't think that I
>> understand why it
>> is different.
>>
>> Thomas
>>
>>
>> And finally, I agree that the page creation with
>> null move*
>> permissions
>> from Page management and navigation editor is not
>> correct. I have
>> changed it to use
>> ProtectedContainer.DEFAULT____**
>> _MOVE_*_PERMISSIONS,
>> see []
>> Do you know of other places where I should do the
>> same?
>>
>> [1]
>> https://github.com/ppalaga/___**
>>
_gatein-portal/tree/GTNPORTAL-**____3263.3<https://github.com/ppalaga/...
>> <https://github.com/ppalaga/__**
>>
gatein-portal/tree/GTNPORTAL-_**_3263.3<https://github.com/ppalaga/__g...
>> >
>>
>> <https://github.com/ppalaga/__**
>>
gatein-portal/tree/GTNPORTAL-_**_3263.3<https://github.com/ppalaga/__g...
>>
https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**3263.3<htt...
>> >>
>>
>> Thanks,
>>
>> Peter
>>
>> On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga
>> <ppalaga(a)redhat.com
>> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>>> wrote:
>>
>> Thanks for the message, Phuong. I'll have
>> a look what
>> is the
>> problem. -- PP
>>
>>
>> On 2013-10-14 11:17, Phuong Viet VU
>> wrote:
>>
>> Hi, I'm trying "Restricted"
page
>> editor feature
>> (build with
>> tomcat7 -->
>>
>> https://github.com/ppalaga/___**___gatein-portal/tree/**
>>
GTNPORTAL-______3263.3<https://github.com/ppalaga/______gatein-portal/...
>> <https://github.com/ppalaga/__**__gatein-portal/tree/**
>>
GTNPORTAL-____3263.3<https://github.com/ppalaga/____gatein-portal/tree...
>> >
>>
>> <https://github.com/ppalaga/__**__gatein-portal/tree/**
>>
GTNPORTAL-____3263.3<https://github.com/ppalaga/____gatein-portal/tree...
>>
https://github.com/ppalaga/__**gatein-portal/tree/GTNPORTAL-_**_3263.3<...
>> >>
>>
>>
>> <https://github.com/ppalaga/__**__gatein-portal/tree/**
>>
GTNPORTAL-____3263.3<https://github.com/ppalaga/____gatein-portal/tree...
>>
https://github.com/ppalaga/__**gatein-portal/tree/GTNPORTAL-_**_3263.3<...
>> >
>>
>> <https://github.com/ppalaga/__**
>>
gatein-portal/tree/GTNPORTAL-_**_3263.3<https://github.com/ppalaga/__g...
>>
https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**3263.3<htt...
>> >>>)
>> I tried GateIn without the extension
>>
>>
>> (https://github.com/ppalaga/__**
>>
____gatein-restricted-page-__**editor-____extension<https://github.com...
>> https://github.com/ppalaga/__**__gatein-restricted-page-**
>>
editor-____extension<https://github.com/ppalaga/____gatein-restricted-...
>> >
>>
>> <https://github.com/ppalaga/__**__gatein-restricted-page-
>>
**editor-____extension<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension><
>> https://github.com/ppalaga/__**gatein-restricted-page-editor-**
>>
__extension<https://github.com/ppalaga/__gatein-restricted-page-editor...
>> >>
>>
>>
>> <https://github.com/ppalaga/__**__gatein-restricted-page-
>>
**editor-____extension<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension><
>> https://github.com/ppalaga/__**gatein-restricted-page-editor-**
>>
__extension<https://github.com/ppalaga/__gatein-restricted-page-editor...
>> >
>>
>> <https://github.com/ppalaga/__**
>>
gatein-restricted-page-editor-**__extension<https://github.com/ppalaga...
>>
https://github.com/ppalaga/**gatein-restricted-page-editor-**extension<...
>> >>>)
>> -->
>> It should works the same as before
>> this feature,
>> right ?
>>
>> 1. After login as root, go to home
>> page, edit
>> portal layout -->
>> I can't
>> DnD page-body to another place, it
>> always stay in
>> the same place
>> 2. Try to drop new Row container,
>> and new
>> application to the
>> page, then
>> move them around --> Exception in the
>> console
>> 143469 [http-bio-8080-exec-6] ERROR
>> portal:UIPortalApplication -
>> Error
>> during the processAction phase
>> java.lang.NullPointerException
>> at
>>
>>
>> org.exoplatform.portal.webui._**_____portal.______**
>> UIPortalComponentActionListene**______r$**MoveChildActionListener.______
>> **prepareUiSource(______**UIPortalComponentActionListene**
>> ______r.java:300)
>>
>> at
>>
>>
>> org.exoplatform.portal.webui._**_____portal.______**
>> UIPortalComponentActionListene**______r$**MoveChildActionListener.______
>> **execute(______**UIPortalComponentActionListene**______r.java:239)
>>
>> at
>>
>> org.exoplatform.webui.event.__**
>> ____Event.broadcast(Event.**java:__97)
>> at
>>
>>
>> org.exoplatform.webui.core.___**
>> ___lifecycle.Lifecycle.______**processAction(Lifecycle.java:_**_____51)
>>
>> at
>>
>>
>> org.exoplatform.webui.core.___**
>> ___UIComponent.processAction(_**_____UIComponent.java:119)
>>
>> at
>>
>>
>> org.exoplatform.portal.webui._**_____workspace.______**
>> UIPortalApplicationLifecycle._**_____processAction(______**
>> UIPortalApplicationLifecycle._**_____java:73)
>>
>> at
>>
>>
>> org.exoplatform.portal.webui._**_____workspace.______**
>> UIPortalApplicationLifecycle._**_____processAction(______**
>> UIPortalApplicationLifecycle._**_____java:36)
>>
>>
>>
>>
>> On Fri, Oct 11, 2013 at 10:00 PM,
>> Peter Palaga
>> <ppalaga(a)redhat.com
>> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>>>**> wrote:
>>
>> Thanks Trong.
>>
>> Please note that there is a
>> small update in
>>
>> https://github.com/ppalaga/___**___gatein-portal/tree/**
>>
GTNPORTAL-______3263.3<https://github.com/ppalaga/______gatein-portal/...
>> <https://github.com/ppalaga/__**__gatein-portal/tree/**
>>
GTNPORTAL-____3263.3<https://github.com/ppalaga/____gatein-portal/tree...
>> >
>>
>> <https://github.com/ppalaga/__**__gatein-portal/tree/**
>>
GTNPORTAL-____3263.3<https://github.com/ppalaga/____gatein-portal/tree...
>>
https://github.com/ppalaga/__**gatein-portal/tree/GTNPORTAL-_**_3263.3<...
>> >>
>>
>>
>> <https://github.com/ppalaga/__**__gatein-portal/tree/**
>>
GTNPORTAL-____3263.3<https://github.com/ppalaga/____gatein-portal/tree...
>>
https://github.com/ppalaga/__**gatein-portal/tree/GTNPORTAL-_**_3263.3<...
>> >
>>
>> <https://github.com/ppalaga/__**
>>
gatein-portal/tree/GTNPORTAL-_**_3263.3<https://github.com/ppalaga/__g...
>>
https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**3263.3<htt...
>> >>>
>> : The new
>> permissions are enforced also
>> during deletions
>> now.
>>
>> Best,
>>
>> Peter
>>
>> On 2013-10-11 06:05, Trong Tran
>> wrote:
>> > Hi,
>> >
>> > We are going to take a look
>> at this and
>> will give you
>> feedback on
>> Monday
>> >
>> > Thanks,
>> >
>> >
>> > On 10 October 2013 15:45,
>> Peter Palaga
>> <ppalaga(a)redhat.com
>> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>>>
>> > <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>
>> <mailto:ppalaga@redhat.com
>> <mailto:ppalaga@redhat.com>>>>**>__> wrote:
>> >
>> > Hi *,
>> >
>> > it would be nice if
>> someone from eXo
>> could have a
>> look at
>> this. Please
>> > note that we cannot wait
>> for long. We
>> have decided
>> to do a
>> RH-internal
>> > cross-checking with Lucas
>> and if there
>> is no message
>> from eXo
>> after we
>> > are finished with the
>> checks, I'll
>> merge it without
>> waiting
>> for eXo.
>> >
>> > Thanks,
>> >
>> > Peter
>> >
>> > On 2013-10-04 17:11,
>> Peter Palaga wrote:
>> > > Hi *,
>> > >
>> > > It is quite an
>> extensive patch.
>> Could please
>> somebody have
>> a look
>> > at it?
>> > >
>> > >
>>
>> https://github.com/ppalaga/___**___gatein-portal/tree/**
>>
GTNPORTAL-______3263.3<https://github.com/ppalaga/______gatein-portal/...
>> <https://github.com/ppalaga/__**__gatein-portal/tree/**
>>
GTNPORTAL-____3263.3<https://github.com/ppalaga/____gatein-portal/tree...
>> >
>>
>> <https://github.com/ppalaga/__**__gatein-portal/tree/**
>>
GTNPORTAL-____3263.3<https://github.com/ppalaga/____gatein-portal/tree...
>>
https://github.com/ppalaga/__**gatein-portal/tree/GTNPORTAL-_**_3263.3<...
>> >>
>>
>>
>> <https://github.com/ppalaga/__**__gatein-portal/tree/**
>>
GTNPORTAL-____3263.3<https://github.com/ppalaga/____gatein-portal/tree...
>>
https://github.com/ppalaga/__**gatein-portal/tree/GTNPORTAL-_**_3263.3<...
>> >
>>
>> <https://github.com/ppalaga/__**
>>
gatein-portal/tree/GTNPORTAL-_**_3263.3<https://github.com/ppalaga/__g...
>>
https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**3263.3<htt...
>> >>>
>> > >
>> > > It implements a
>> requirement from a
>> customer as
>> described in
>> > >
>> > >
>> https://community.jboss.org/__**
>>
____wiki/RestrictedPageEditor<https://community.jboss.org/______wiki/R...
>> <https://community.jboss.org/_**
>>
___wiki/RestrictedPageEditor<https://community.jboss.org/____wiki/Rest...
>> >
>>
>> <https://community.jboss.org/_**
>>
___wiki/RestrictedPageEditor<https://community.jboss.org/____wiki/Rest...
>>
<https://community.jboss.org/_**_wiki/RestrictedPageEditor<https://comm...
>> >>
>>
>>
>> <https://community.jboss.org/_**
>>
___wiki/RestrictedPageEditor<https://community.jboss.org/____wiki/Rest...
>>
<https://community.jboss.org/_**_wiki/RestrictedPageEditor<https://comm...
>> >
>>
>> <https://community.jboss.org/_**
>>
_wiki/RestrictedPageEditor<https://community.jboss.org/__wiki/Restrict...
>>
<https://community.jboss.org/**wiki/RestrictedPageEditor<https://commun...
>> >>>
>> > >
>> > > To see the behavior
>> requested by the
>> customer,
>> you should
>> build the
>> > > portal from my
>> GTNPORTAL-3263.3
>> branch and run AS
>> with this
>> > extension:
>> > >
>> > >
>>
>> https://github.com/ppalaga/___**
>>
___gatein-restricted-page-__**editor-____extension<https://github.com/...
>> <https://github.com/ppalaga/__**__gatein-restricted-page-**
>>
editor-____extension<https://github.com/ppalaga/____gatein-restricted-...
>> >
>>
>> <https://github.com/ppalaga/__**__gatein-restricted-page-
>>
**editor-____extension<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension><
>> https://github.com/ppalaga/__**gatein-restricted-page-editor-**
>>
__extension<https://github.com/ppalaga/__gatein-restricted-page-editor...
>> >>
>>
>>
>> <https://github.com/ppalaga/__**__gatein-restricted-page-
>>
**editor-____extension<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension><
>> https://github.com/ppalaga/__**gatein-restricted-page-editor-**
>>
__extension<https://github.com/ppalaga/__gatein-restricted-page-editor...
>> >
>>
>> <https://github.com/ppalaga/__**
>>
gatein-restricted-page-editor-**__extension<https://github.com/ppalaga...
>>
https://github.com/ppalaga/**gatein-restricted-page-editor-**extension<...
>> >>>
>> > >
>> > > Thanks,
>> > >
>> > > Peter
>> > >
>>
>> ______________________________**_______________________
>> > > gatein-dev mailing
>> list
>> > >
>> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.**
>> jboss.org <gatein-dev(a)lists.jboss.org>>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>
>> <mailto:gatein-dev@lists
>> <mailto:gatein-dev@lists>.
>> <mailto:gatein-dev@lists
>>
<mailto:gatein-dev@lists>.>__j**b__o__ss.org<http://jb__o__ss.org>
>> <http://jbo__ss.org> <http://jboss.org>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>>
>> <mailto:gatein-dev@lists
>> <mailto:gatein-dev@lists>.
>> <mailto:gatein-dev@lists
>>
<mailto:gatein-dev@lists>.>__j**b__o__ss.org<http://jb__o__ss.org>
>> <http://jbo__ss.org> <http://jboss.org>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>
>> <mailto:gatein-dev@lists
>> <mailto:gatein-dev@lists>.
>> <mailto:gatein-dev@lists
>>
<mailto:gatein-dev@lists>.>__j**b__o__ss.org<http://jb__o__ss.org>
>> <http://jbo__ss.org> <http://jboss.org>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>>>
>>
>> > >
>>
https://lists.jboss.org/______**mailman/listinfo/gatein-dev<https://li...
>>
<https://lists.jboss.org/____**mailman/listinfo/gatein-dev<https://list...
>> >
>>
>> <https://lists.jboss.org/____**
>>
mailman/listinfo/gatein-dev<https://lists.jboss.org/____mailman/listin...
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>> >>
>>
>>
>> <https://lists.jboss.org/____**
>>
mailman/listinfo/gatein-dev<https://lists.jboss.org/____mailman/listin...
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>> >
>>
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>>
<https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>> >>>
>> > >
>> >
>> >
>>
>> ______________________________**_______________________
>> > gatein-dev mailing list
>> > gatein-dev(a)lists.jboss.org
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>
>> <mailto:gatein-dev@lists
>> <mailto:gatein-dev@lists>.
>> <mailto:gatein-dev@lists
>>
<mailto:gatein-dev@lists>.>__j**b__o__ss.org<http://jb__o__ss.org>
>> <http://jbo__ss.org> <http://jboss.org>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>>
>> <mailto:gatein-dev@lists
>> <mailto:gatein-dev@lists>.
>> <mailto:gatein-dev@lists
>>
<mailto:gatein-dev@lists>.>__j**b__o__ss.org<http://jb__o__ss.org>
>> <http://jbo__ss.org> <http://jboss.org>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>
>> <mailto:gatein-dev@lists
>> <mailto:gatein-dev@lists>.
>> <mailto:gatein-dev@lists
>>
<mailto:gatein-dev@lists>.>__j**b__o__ss.org<http://jb__o__ss.org>
>> <http://jbo__ss.org> <http://jboss.org>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>>>
>>
>> >
>>
https://lists.jboss.org/______**mailman/listinfo/gatein-dev<https://li...
>>
<https://lists.jboss.org/____**mailman/listinfo/gatein-dev<https://list...
>> >
>>
>> <https://lists.jboss.org/____**
>>
mailman/listinfo/gatein-dev<https://lists.jboss.org/____mailman/listin...
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>> >>
>>
>>
>> <https://lists.jboss.org/____**
>>
mailman/listinfo/gatein-dev<https://lists.jboss.org/____mailman/listin...
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>> >
>>
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>>
<https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>> >>>
>> >
>> >
>> >
>> >
>> > --
>> > *Trong Tran*
>> > /(+84) 983841909 |
>> /trongtt(a)gmail.com <mailto:trongtt@gmail.com>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>>>
<mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>>>>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>>>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>
>> <mailto:trongtt@gmail.com
>> <mailto:trongtt@gmail.com>>>>>
>>
>> >
>>
Twitter:http://twitter.com/___**___trongtt//<http://twitter.com/______...
>>
<http://twitter.com/____**trongtt//<http://twitter.com/____trongtt//>
>> >
>>
<http://twitter.com/__trongtt/**__/<http://twitter.com/__trongtt/__/>
>>
<http://twitter.com/__trongtt/**/<http://twitter.com/__trongtt//>
>> >>
>> <http://twitter.com/trongtt//>
>>
>>
>>
>> ______________________________**_______________________
>> gatein-dev mailing list
>> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.**
>> jboss.org <gatein-dev(a)lists.jboss.org>>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>
>> <mailto:gatein-dev@lists
>> <mailto:gatein-dev@lists>.
>> <mailto:gatein-dev@lists
>>
<mailto:gatein-dev@lists>.>__j**b__o__ss.org<http://jb__o__ss.org>
>> <http://jbo__ss.org> <http://jboss.org>
>> <mailto:gatein-dev@lists.
>>
<mailto:gatein-dev@lists.>__jb**o__ss.org<http://jbo__ss.org><
>> http://jboss.org>
>>
<mailto:gatein-dev@lists.__jbo**ss.org<http://jboss.org>
>>
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >>>>
>>
https://lists.jboss.org/______**mailman/listinfo/gatein-dev<https://li...
>>
<https://lists.jboss.org/____**mailman/listinfo/gatein-dev<https://list...
>> >
>>
>> <https://lists.jboss.org/____**
>>
mailman/listinfo/gatein-dev<https://lists.jboss.org/____mailman/listin...
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>> >>
>>
>>
>> <https://lists.jboss.org/____**
>>
mailman/listinfo/gatein-dev<https://lists.jboss.org/____mailman/listin...
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>> >
>>
>>
<https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>>
<https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>> >>>
>>
>>
>>
>>
>>
>>
>>
>> ______________________________**___________________
>> gatein-dev mailing list
>> gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.**jboss.org<gatein-dev@lists.jboss.org>
>> >
>>
https://lists.jboss.org/__**mailman/listinfo/gatein-dev<https://lists....
>>
<https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>> >
>>
>>
>>
>>
> ______________________________**_________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
>
https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jb...
>
>
6:27 a.m.
Hi Phuong, please see inline.
On 2013-10-25 09:10, Phuong Viet VU wrote:
I've built and tested the new branch GTNPORTAL-__3263.3-3272
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3-3272> (Also
deploy Peter's example extension for page editor)
It's strange, I can still reproduce those issues, let me give more
details on how to reproduce it:
1. Login as John, edit "Home" page --> Drop a "One Row" container
to the
page, then drop "Sitemap" portlet to the page (not the container).
Now DnD "Sitemap" portlet (in the page) into the "One row" container
-->
F5 refesh page --> the app is not in the container. If we try to move
"Sitemap" to container --> save, now let edit that page again, the
portlet is not in the Container
---> It seems there is an issue with MoveChildActionListener
I could not reproduce this. What you have seen was perhaps a consequence
of your issue no. 2.
2. Login as John, edit site (classic) layout --> Can't DnD any
portlet
or container to the page (there are "CannotMoveApps
CannotMoveContainers" classes on UIPortal dom element)
--> I see that it unmarsall the portal-layout correctly, maybe there is
an issue when it map the config model object to UI
Yes, this issue was valid and is fixed now in my branch
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3-3272
As this change set is quite extensive and I do not want to risk further
rebases with conflicts, I am going to merge it into master. I hope that
it is OK for everybody to handle further issues related to this as
separate Jiras.
Best,
Peter
On Fri, Oct 25, 2013 at 1:50 AM, Peter Palaga <ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>> wrote:
Hi again, Phuong and Lucas,
the issue found by Lucas - the visible header and footer portlets in
block page edit mode - is fixed in
https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3-3272
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3-3272>
Thanks,
Peter
On 2013-10-24 14:07, Peter Palaga wrote:
Hi Phuong,
I fixed some issues with requirement 3272 and rebased on the present
master
https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3-3272
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3-3272>
On 2013-10-21 11:26, Phuong Viet VU wrote:
Hi Peter, I've just check your fix, and it works :)
But I have other cases:
1. I can move app to Container, but it can't be saved. It
seems there is
an issue with MoveChildActionListener. Steps to reproduce:
Edit a page
--> Add a container, then move exists app into that
container, now
refresh --> the App is not in the Container
I cannot reproduce this with the above branch.
2. I can't move App and Container to Portal layout. I see
that it
unmarsall the portal-layout correctly, maybe there is an
issue when it
map the config model object to UI
Cannot reproduce this too.
Could you please try with the above branch whether you can still
reproduce them both?
Thanks,
Peter
On Thu, Oct 17, 2013 at 4:28 PM, Peter Palaga
<ppalaga(a)redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>>
wrote:
Hi Phuong,
I fixed the import/export and I changed the CSS
markers to negative
"CannotMove*" ones. Could you please check if this
version succeeds
in all your scenarios?
https://github.com/ppalaga/____gatein-portal/blob/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/blob/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/blob/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/blob/GTNPORTAL-3263.3>>
Thanks,
Peter
On 2013-10-16 14:45, Peter Palaga wrote:
Hi Phuong,
On 2013-10-15 14:55, Phuong Viet VU wrote:
Do you know of other places where I should do
the same?
--> I think there is no more other place to fix
- I see that we need "Has*Permission" in each
groovy templates:
https://github.com/ppalaga/____gatein-portal/blob/GTNPORTAL-____3263.3/we...
<https://github.com/ppalaga/__gatein-portal/blob/GTNPORTAL-__3263.3/web/po...
<https://github.com/ppalaga/__gatein-portal/blob/GTNPORTAL-__3263.3/web/po...
<https://github.com/ppalaga/gatein-portal/blob/GTNPORTAL-3263.3/web/portal...
So any extension project that overwrite
default template of
portal, will
need to be migrated to have code snipet like this:
if (uicomponent.____hasMoveAppsPermission()) {
permissionClasses.append("
HasMoveAppsPermissions");
}
if
(uicomponent.____hasMoveContainersPermission()) {
permissionClasses.append("
HasMoveContainersPermissions")____;
}
I means if customer has their extension
project, they may
need to
migrate their code
Yes, this is a valid concern, but what else can we do?
One could perhaps work with negative markers - e.g.
"CannotMoveContainers" on containers where the
current user is *not
allowed* to move child containers instead of using
positive
"HasMoveContainersPermissions" on containers where
he can. In
this way,
the legacy Groovy templates would not be hardly
broken just
after the
migration. More precisely, the drop feedback in
browser would not be
100% accurate but one could work at least.
Actually the
non-100%-acurateness holds only for containers
using non-default
move-*
permissions. Hence portal owners who would not
touch move-*
permissions
would not need to touch their custom Groovy
templates as well. I
guess
this idea is worth pursuing in detail. WDYT?
- Pls correct me if i'm wrong, but I don't see
the code to
marsall and
unmarsall the "Move*Permission" for
portal-layout and
page-layout when
Import and Exporting site.
Yes, they both were missing and I have added them
now (I have
not pushed
yet). Thanks for noticing! -- PP
Reproduce:
+ Create a page name "Test" by using Page
Wizard -->
choose 3 columns
layout (running GateIn with extension that
config 3 columns page
template with "move-apps-permission : nobody"
for page
+ Go to Import-Export page --> export
current Site
+ Import that Site with "Overwrite" mode
--> User can now DnD container and apps to
"Test" page -->
The problem
is: missing code for marsalling and unmarsalling
move*permission, then
now the page "Test" loose setting for
move*permission after
being
exported and re-imported
On Mon, Oct 14, 2013 at 10:22 PM, Thomas Heute
<theute(a)redhat.com <mailto:theute@redhat.com>
<mailto:theute@redhat.com <mailto:theute@redhat.com>>
<mailto:theute@redhat.com
<mailto:theute@redhat.com> <mailto:theute@redhat.com
<mailto:theute@redhat.com>>>> wrote:
On 10/14/2013 05:15 PM, Peter Palaga wrote:
On 2013-10-14 13:46, Phuong Viet VU
wrote:
ok, I have some more comments:
1. I see that "root" user can do
anything,
even when we set
"nobody" for
move*-application and
move*-container. But the
specification
say that it
can prevent "root" user.
No, the spec says that
<move-*-permissions>Nobody</______move-*-permissions>
forbids the actions to everyone
_except for_ root.
So, the present
implementation works as specified.
2. I can't DnD new App and
Container to
portal-layout (run
gatein with
extension).
When I create page with "Add
page" wizard,
choose "Two
columns" layout
--> Can't DnD new container to
the Page, even
there is
"HasMoveContainersPermissions" class
Sorry, this part of JavaScript was
broken since
Friday. It must
work now.
3. The feature only work if we
create page
from templates.
But GateIn
also allow to create page
with-out template:
by using "Page management"
portlet, or when
using navigation
editor -->
create node --> create page. It
create a page
with-out
template, and the
move* permission is null --> no
way to DnD
Apps and
Container to the
newly created page. And we don't
have UI
support to set the
move*
permission
I agree that at some point, we need
to add a UI
for the
management of
the new permissions. But it is out
of scope ATM.
With the present spec, I guess, the
customer will
be able to
hide the
alternative ways to create pages
from user groups
that are
supposed to
use the "template way". Thomas?
I will need to give it a try, I don't
think that I
understand why it
is different.
Thomas
And finally, I agree that the page
creation with
null move*
permissions
from Page management and navigation
editor is not
correct. I have
changed it to use
ProtectedContainer.DEFAULT_______MOVE_*_PERMISSIONS,
see []
Do you know of other places where I
should do the
same?
[1]
https://github.com/ppalaga/______gatein-portal/tree/GTNPORTAL-______3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>>
Thanks,
Peter
On Mon, Oct 14, 2013 at 4:28 PM,
Peter Palaga
<ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>>> wrote:
Thanks for the message,
Phuong. I'll have
a look what
is the
problem. -- PP
On 2013-10-14 11:17, Phuong
Viet VU wrote:
Hi, I'm trying
"Restricted" page
editor feature
(build with
tomcat7 -->
https://github.com/ppalaga/________gatein-portal/tree/__GTNPORTAL-______3...
<https://github.com/ppalaga/______gatein-portal/tree/GTNPORTAL-______3263....
<https://github.com/ppalaga/______gatein-portal/tree/__GTNPORTAL-____3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>...
<https://github.com/ppalaga/______gatein-portal/tree/__GTNPORTAL-____3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>...
<https://github.com/ppalaga/______gatein-portal/tree/__GTNPORTAL-____3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>>...)
I tried GateIn without
the extension
(https://github.com/ppalaga/________gatein-restricted-page-____editor-____...
<https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
<https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extensio...
<https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extensio...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>...
<https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extensio...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>>...)
-->
It should works the
same as before
this feature,
right ?
1. After login as root,
go to home
page, edit
portal layout -->
I can't
DnD page-body to
another place, it
always stay in
the same place
2. Try to drop new Row
container, and new
application to the
page, then
move them around -->
Exception in the
console
143469
[http-bio-8080-exec-6] ERROR
portal:UIPortalApplication -
Error
during the
processAction phase
java.lang.NullPointerException
at
org.exoplatform.portal.webui.________portal.________UIPortalComponentActionListene________r$__MoveChildActionListener.________prepareUiSource(________UIPortalComponentActionListene________r.java:300)
at
org.exoplatform.portal.webui.________portal.________UIPortalComponentActionListene________r$__MoveChildActionListener.________execute(________UIPortalComponentActionListene________r.java:239)
at
org.exoplatform.webui.event.________Event.broadcast(Event.__java:__97)
at
org.exoplatform.webui.core.________lifecycle.Lifecycle.________processAction(Lifecycle.java:________51)
at
org.exoplatform.webui.core.________UIComponent.processAction(________UIComponent.java:119)
at
org.exoplatform.portal.webui.________workspace.________UIPortalApplicationLifecycle.________processAction(________UIPortalApplicationLifecycle.________java:73)
at
org.exoplatform.portal.webui.________workspace.________UIPortalApplicationLifecycle.________processAction(________UIPortalApplicationLifecycle.________java:36)
On Fri, Oct 11, 2013 at
10:00 PM,
Peter Palaga
<ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>>>__> wrote:
Thanks Trong.
Please note that
there is a
small update in
https://github.com/ppalaga/________gatein-portal/tree/__GTNPORTAL-______3...
<https://github.com/ppalaga/______gatein-portal/tree/GTNPORTAL-______3263....
<https://github.com/ppalaga/______gatein-portal/tree/__GTNPORTAL-____3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>...
<https://github.com/ppalaga/______gatein-portal/tree/__GTNPORTAL-____3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>...
<https://github.com/ppalaga/______gatein-portal/tree/__GTNPORTAL-____3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>>...
: The new
permissions are
enforced also
during deletions
now.
Best,
Peter
On 2013-10-11
06:05, Trong Tran
wrote:
> Hi,
>
> We are going to
take a look
at this and
will give you
feedback on
Monday
>
> Thanks,
>
>
> On 10 October
2013 15:45,
Peter Palaga
<ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>>>
>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>>
<mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>> <mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>
<mailto:ppalaga@redhat.com
<mailto:ppalaga@redhat.com>>>>>__>__> wrote:
>
> Hi *,
>
> it would be
nice if
someone from eXo
could have a
look at
this. Please
> note that
we cannot wait
for long. We
have decided
to do a
RH-internal
>
cross-checking with Lucas
and if there
is no message
from eXo
after we
> are
finished with the
checks, I'll
merge it without
waiting
for eXo.
>
> Thanks,
>
> Peter
>
> On
2013-10-04 17:11,
Peter Palaga wrote:
> > Hi *,
> >
> > It is
quite an
extensive patch.
Could please
somebody have
a look
> at it?
> >
> >
https://github.com/ppalaga/________gatein-portal/tree/__GTNPORTAL-______3...
<https://github.com/ppalaga/______gatein-portal/tree/GTNPORTAL-______3263....
<https://github.com/ppalaga/______gatein-portal/tree/__GTNPORTAL-____3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>...
<https://github.com/ppalaga/______gatein-portal/tree/__GTNPORTAL-____3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>...
<https://github.com/ppalaga/______gatein-portal/tree/__GTNPORTAL-____3263.3
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>>
<https://github.com/ppalaga/____gatein-portal/tree/GTNPORTAL-____3263.3
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3>
<https://github.com/ppalaga/__gatein-portal/tree/GTNPORTAL-__3263.3
<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>>>...
> >
> > It
implements a
requirement from a
customer as
described in
> >
> >
https://community.jboss.org/________wiki/RestrictedPageEditor
<https://community.jboss.org/______wiki/RestrictedPageEditor>
<https://community.jboss.org/______wiki/RestrictedPageEditor
<https://community.jboss.org/____wiki/RestrictedPageEditor>>
<https://community.jboss.org/______wiki/RestrictedPageEditor
<https://community.jboss.org/____wiki/RestrictedPageEditor>
<https://community.jboss.org/____wiki/RestrictedPageEditor
<https://community.jboss.org/__wiki/RestrictedPageEditor>>>
<https://community.jboss.org/______wiki/RestrictedPageEditor
<https://community.jboss.org/____wiki/RestrictedPageEditor>
<https://community.jboss.org/____wiki/RestrictedPageEditor
<https://community.jboss.org/__wiki/RestrictedPageEditor>>
<https://community.jboss.org/____wiki/RestrictedPageEditor
<https://community.jboss.org/__wiki/RestrictedPageEditor>
<https://community.jboss.org/__wiki/RestrictedPageEditor
<https://community.jboss.org/wiki/RestrictedPageEditor>>>>
> >
> > To see
the behavior
requested by the
customer,
you should
build the
> > portal
from my
GTNPORTAL-3263.3
branch and run AS
with this
> extension:
> >
> >
https://github.com/ppalaga/________gatein-restricted-page-____editor-____...
<https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
<https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extensio...
<https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extensio...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>...
<https://github.com/ppalaga/______gatein-restricted-page-__editor-____exte...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extensio...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>...
<https://github.com/ppalaga/____gatein-restricted-page-editor-____extension
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension>
<https://github.com/ppalaga/__gatein-restricted-page-editor-__extension
<https://github.com/ppalaga/gatein-restricted-page-editor-extension>>...
> >
> > Thanks,
> >
> > Peter
> >
_______________________________________________________
> >
gatein-dev mailing list
> >
gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.>__j__b__o__ss.org
<http://jb__o__ss.org>
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.>__j__b__o__ss.org
<http://jb__o__ss.org>
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.>__j__b__o__ss.org
<http://jb__o__ss.org>
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>>>
> >
https://lists.jboss.org/________mailman/listinfo/gatein-dev
<https://lists.jboss.org/______mailman/listinfo/gatein-dev>
<https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>>
<https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>>>
<https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>
<https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>>>>
> >
>
>
_______________________________________________________
> gatein-dev
mailing list
>
gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.>__j__b__o__ss.org
<http://jb__o__ss.org>
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.>__j__b__o__ss.org
<http://jb__o__ss.org>
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.>__j__b__o__ss.org
<http://jb__o__ss.org>
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>>>
>
https://lists.jboss.org/________mailman/listinfo/gatein-dev
<https://lists.jboss.org/______mailman/listinfo/gatein-dev>
<https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>>
<https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>>>
<https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>
<https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>>>>
>
>
>
>
> --
> *Trong Tran*
> /(+84) 983841909 |
/trongtt(a)gmail.com <mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>
<mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>
<mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>>>
<mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>>
<mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>> <mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com
<mailto:trongtt@gmail.com>>>>>>
>
Twitter:http://twitter.com/________trongtt//
<http://twitter.com/______trongtt//>
<http://twitter.com/______trongtt//
<http://twitter.com/____trongtt//>>
<http://twitter.com/__trongtt/____/
<http://twitter.com/__trongtt/__/>
<http://twitter.com/__trongtt/__/
<http://twitter.com/__trongtt//>>>
<http://twitter.com/trongtt//>
_______________________________________________________
gatein-dev mailing
list
gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>>.>__j__b__o__ss.org
<http://jb__o__ss.org>
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists <mailto:gatein-dev@lists>.
<mailto:gatein-dev@lists
<mailto:gatein-dev@lists>.>__jb__o__ss.org
<http://jbo__ss.org> <http://jboss.org>
<mailto:gatein-dev@lists.
<mailto:gatein-dev@lists.>__jbo__ss.org <http://jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>>>>
https://lists.jboss.org/________mailman/listinfo/gatein-dev
<https://lists.jboss.org/______mailman/listinfo/gatein-dev>
<https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>>
<https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>>>
<https://lists.jboss.org/______mailman/listinfo/gatein-dev
<https://lists.jboss.org/____mailman/listinfo/gatein-dev>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>>
<https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>
<https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>>>>
___________________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.__jboss.org
<mailto:gatein-dev@lists.jboss.org>>
https://lists.jboss.org/____mailman/listinfo/gatein-dev
<https://lists.jboss.org/__mailman/listinfo/gatein-dev>
<https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>>
_________________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>
10:15 a.m.
Hi Phuong, both issues were valid. Thanks for reporting! They both are
solved in https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
-- PP
On 2013-10-14 11:17, Phuong Viet VU wrote:
Hi, I'm trying "Restricted" page editor feature (build
with tomcat7 -->
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3)
I tried GateIn without the extension
(https://github.com/ppalaga/gatein-restricted-page-editor-extension) -->
It should works the same as before this feature, right ?
1. After login as root, go to home page, edit portal layout --> I can't
DnD page-body to another place, it always stay in the same place
2. Try to drop new Row container, and new application to the page, then
move them around --> Exception in the console
143469 [http-bio-8080-exec-6] ERROR portal:UIPortalApplication - Error
during the processAction phase
java.lang.NullPointerException
at
org.exoplatform.portal.webui.portal.UIPortalComponentActionListener$MoveChildActionListener.prepareUiSource(UIPortalComponentActionListener.java:300)
at
org.exoplatform.portal.webui.portal.UIPortalComponentActionListener$MoveChildActionListener.execute(UIPortalComponentActionListener.java:239)
at org.exoplatform.webui.event.Event.broadcast(Event.java:97)
at
org.exoplatform.webui.core.lifecycle.Lifecycle.processAction(Lifecycle.java:51)
at
org.exoplatform.webui.core.UIComponent.processAction(UIComponent.java:119)
at
org.exoplatform.portal.webui.workspace.UIPortalApplicationLifecycle.processAction(UIPortalApplicationLifecycle.java:73)
at
org.exoplatform.portal.webui.workspace.UIPortalApplicationLifecycle.processAction(UIPortalApplicationLifecycle.java:36)
On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga <ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>> wrote:
Thanks Trong.
Please note that there is a small update in
https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3 : The new
permissions are enforced also during deletions now.
Best,
Peter
On 2013-10-11 06:05, Trong Tran wrote:
> Hi,
>
> We are going to take a look at this and will give you feedback on
Monday
>
> Thanks,
>
>
> On 10 October 2013 15:45, Peter Palaga <ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>
> <mailto:ppalaga@redhat.com <mailto:ppalaga@redhat.com>>> wrote:
>
> Hi *,
>
> it would be nice if someone from eXo could have a look at
this. Please
> note that we cannot wait for long. We have decided to do a
RH-internal
> cross-checking with Lucas and if there is no message from eXo
after we
> are finished with the checks, I'll merge it without waiting
for eXo.
>
> Thanks,
>
> Peter
>
> On 2013-10-04 17:11, Peter Palaga wrote:
> > Hi *,
> >
> > It is quite an extensive patch. Could please somebody have
a look
> at it?
> >
> > https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3
> >
> > It implements a requirement from a customer as described in
> >
> > https://community.jboss.org/wiki/RestrictedPageEditor
> >
> > To see the behavior requested by the customer, you should
build the
> > portal from my GTNPORTAL-3263.3 branch and run AS with this
> extension:
> >
> >
https://github.com/ppalaga/gatein-restricted-page-editor-extension
> >
> > Thanks,
> >
> > Peter
> > _______________________________________________
> > gatein-dev mailing list
> > gatein-dev(a)lists.jboss.org
<mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.jboss.org <mailto:gatein-dev@lists.jboss.org>>
> > https://lists.jboss.org/mailman/listinfo/gatein-dev
> >
>
> _______________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
<mailto:gatein-dev@lists.jboss.org <mailto:gatein-dev@lists.jboss.org>>
> https://lists.jboss.org/mailman/listinfo/gatein-dev
>
>
>
>
> --
> *Trong Tran*
> /(+84) 983841909 | /trongtt(a)gmail.com <mailto:trongtt@gmail.com>
<mailto:trongtt@gmail.com <mailto:trongtt@gmail.com>>
> Twitter:http://twitter.com/trongtt//
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/gatein-dev
3842
days inactive
3866
days old
18 comments
5 participants
participants (5)
-
Frederic Drouet -
Peter Palaga -
Phuong Viet VU -
Thomas Heute -
Trong Tran