Request for review: GTNPORTAL-3459 Permissions Move Apps, Move Containers are not inherited to a newly created page
3:09 p.m.
Hi *,
from my PoV this is a follow up of GTNPORTAL-3364 "Implement UI part for
Restricted layout setting" done by nttuyen.
The present issue:
https://issues.jboss.org/browse/GTNPORTAL-3459
When creating new portal site, there are 4 permissions to set - Access,
Edit, Move Apps, Move Containers. When I create new portal and set some
permissions, then create new page in this portal, the owner of the new
page is the newly created portal, and Access and Edit permissions are
inherited or "copied" into the permissions of the new page. But Move
Apps, Move Containers permissions are set to "Everyone". This
permissions should probably also inherit the permissions from the owning
portal.
Steps to reproduce:
1. Create new portal site, set some permissions
2. Go to this new portal site, create new page. On the 3rd step of
creating the page, in View Page Properties, Permissions tab are
inherited only Access and Edit permissions.
Could you please review my fix?
https://github.com/gatein/gatein-portal/pull/841
Thanks,
Peter
9:37 a.m.
Hi *, I will merge this today after 16:00 CEST unless somebody raises
his hand. -- PP
On 2014-04-24 15:09, Peter Palaga wrote:
Hi *,
from my PoV this is a follow up of GTNPORTAL-3364 "Implement UI part for
Restricted layout setting" done by nttuyen.
The present issue:
https://issues.jboss.org/browse/GTNPORTAL-3459
When creating new portal site, there are 4 permissions to set - Access,
Edit, Move Apps, Move Containers. When I create new portal and set some
permissions, then create new page in this portal, the owner of the new
page is the newly created portal, and Access and Edit permissions are
inherited or "copied" into the permissions of the new page. But Move
Apps, Move Containers permissions are set to "Everyone". This
permissions should probably also inherit the permissions from the owning
portal.
Steps to reproduce:
1. Create new portal site, set some permissions
2. Go to this new portal site, create new page. On the 3rd step of
creating the page, in View Page Properties, Permissions tab are
inherited only Access and Edit permissions.
Could you please review my fix?
https://github.com/gatein/gatein-portal/pull/841
Thanks,
Peter
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev
10:07 a.m.
Hi, yes, you're right, we should have the move* permission inherited
I've just rebuild and run GateIn master with PR from GTNPORTAL-3459. But
there is NPE in the console. Step to reproduce
- Login as root, create a portal site "TestSite"
- Go to "Page management" page, and Click "Add new page" --> NPE in
the
console
[http-bio-8080-exec-8] ERROR portal:UIPortalApplication - Error during the
processAction phase
java.lang.NullPointerException
at
org.exoplatform.portal.webui.page.UIPageForm$ChangeOwnerTypeActionListener.execute(UIPageForm.java:377)
at org.exoplatform.webui.event.Event.broadcast(Event.java:97)
at
org.exoplatform.portal.webui.page.UIPageBrowser$AddNewActionListener.execute(UIPageBrowser.java:373)
at org.exoplatform.webui.event.Event.broadcast(Event.java:97)
On Mon, Apr 28, 2014 at 2:37 PM, Peter Palaga <ppalaga(a)redhat.com> wrote:
Hi *, I will merge this today after 16:00 CEST unless somebody raises
his
hand. -- PP
On 2014-04-24 15:09, Peter Palaga wrote:
> Hi *,
>
> from my PoV this is a follow up of GTNPORTAL-3364 "Implement UI part for
> Restricted layout setting" done by nttuyen.
>
> The present issue:
> https://issues.jboss.org/browse/GTNPORTAL-3459
>
> When creating new portal site, there are 4 permissions to set - Access,
> Edit, Move Apps, Move Containers. When I create new portal and set some
> permissions, then create new page in this portal, the owner of the new
> page is the newly created portal, and Access and Edit permissions are
> inherited or "copied" into the permissions of the new page. But Move
> Apps, Move Containers permissions are set to "Everyone". This
> permissions should probably also inherit the permissions from the owning
> portal.
> Steps to reproduce:
> 1. Create new portal site, set some permissions
> 2. Go to this new portal site, create new page. On the 3rd step of
> creating the page, in View Page Properties, Permissions tab are
> inherited only Access and Edit permissions.
>
> Could you please review my fix?
> https://github.com/gatein/gatein-portal/pull/841
>
> Thanks,
>
> Peter
> _______________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/gatein-dev
>
>
11:24 a.m.
I have some usecase for this (I hope it's useful for you). Beside creating
page by wizard, we can create page by 2 more ways:
1. Go to "Manage Sites" page, edit navigation --> Create node, choose tab
"Page selector" --> Create Page
2. Go to "Page Management" --> Add new Page
In those 2 case, we also use UIPageForm, and there are tabs to choose
Permissions. To make it consistence, we should have permissions for portal
page inherited here
On Mon, Apr 28, 2014 at 3:07 PM, Phuong Viet VU <phuongvv(a)exoplatform.com>wrote:
Hi, yes, you're right, we should have the move* permission
inherited
I've just rebuild and run GateIn master with PR from GTNPORTAL-3459. But
there is NPE in the console. Step to reproduce
- Login as root, create a portal site "TestSite"
- Go to "Page management" page, and Click "Add new page" --> NPE
in the
console
[http-bio-8080-exec-8] ERROR portal:UIPortalApplication - Error during the
processAction phase
java.lang.NullPointerException
at
org.exoplatform.portal.webui.page.UIPageForm$ChangeOwnerTypeActionListener.execute(UIPageForm.java:377)
at org.exoplatform.webui.event.Event.broadcast(Event.java:97)
at
org.exoplatform.portal.webui.page.UIPageBrowser$AddNewActionListener.execute(UIPageBrowser.java:373)
at org.exoplatform.webui.event.Event.broadcast(Event.java:97)
On Mon, Apr 28, 2014 at 2:37 PM, Peter Palaga <ppalaga(a)redhat.com> wrote:
> Hi *, I will merge this today after 16:00 CEST unless somebody raises his
> hand. -- PP
>
>
> On 2014-04-24 15:09, Peter Palaga wrote:
>
>> Hi *,
>>
>> from my PoV this is a follow up of GTNPORTAL-3364 "Implement UI part for
>> Restricted layout setting" done by nttuyen.
>>
>> The present issue:
>> https://issues.jboss.org/browse/GTNPORTAL-3459
>>
>> When creating new portal site, there are 4 permissions to set - Access,
>> Edit, Move Apps, Move Containers. When I create new portal and set some
>> permissions, then create new page in this portal, the owner of the new
>> page is the newly created portal, and Access and Edit permissions are
>> inherited or "copied" into the permissions of the new page. But Move
>> Apps, Move Containers permissions are set to "Everyone". This
>> permissions should probably also inherit the permissions from the owning
>> portal.
>> Steps to reproduce:
>> 1. Create new portal site, set some permissions
>> 2. Go to this new portal site, create new page. On the 3rd step of
>> creating the page, in View Page Properties, Permissions tab are
>> inherited only Access and Edit permissions.
>>
>> Could you please review my fix?
>> https://github.com/gatein/gatein-portal/pull/841
>>
>> Thanks,
>>
>> Peter
>> _______________________________________________
>> gatein-dev mailing list
>> gatein-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/gatein-dev
>>
>>
>
12:02 p.m.
Hi Phuong,
... there is NPE in the console ...
You are right. Thanks for having a look.
After two days of trying to find a consistent solution, I came to the
conclusion that we should not fix this as proposed in the BZ [0], i.e.
that we should not initialize page creation forms with (a)
move-*-permissions values from the respective sites. The reason is that
we already have one source of defaults, namely (b) the page templates [1].
A third thinkable solution could be (c) to combine (b) the
move-*-permissions from page templates with (a) move-*-permissions from
the parent site, but this is technically not possible.
In the end, I think it would not be wise to change to (a). I see two
reasons for that:
(1) IIRC, we have already advertised the page templates as a way to
customize the move-*-permissions on all container levels (incl. pages)
to our customers.
(2) I'd say that initializing move-*-permissions for all page templates
with the very same permissions given by the site is simply not what a
typical portal owner wants. I believe that the move-*-permissions should
be set depending on the nature of the given page's template. A portal
owner may want to forbid adding portlets at the top level in the three
columns template, but to the contrary, he may want to allow adding
portlets to an empty template containing no containers whatsoever. This
is not possible with the permissions taken from the site.
So, I decided to stay with approach (b) for GateIn 3.8.0.Final that I am
going to tag today. However, there are situations in the portal, where
(b) is not applied consequently and I have prepared a patch [2] that
fixes that.
[0] https://bugzilla.redhat.com/show_bug.cgi?id=1090875
[1]
https://github.com/gatein/gatein-portal/tree/master/web/portal/src/main/w...
[2] https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3459.1
Thanks,
Peter
On 2014-04-28 11:24, Phuong Viet VU wrote:
I have some usecase for this (I hope it's useful for you).
Beside
creating page by wizard, we can create page by 2 more ways:
1. Go to "Manage Sites" page, edit navigation --> Create node, choose
tab "Page selector" --> Create Page
2. Go to "Page Management" --> Add new Page
In those 2 case, we also use UIPageForm, and there are tabs to choose
Permissions. To make it consistence, we should have permissions for
portal page inherited here
On Mon, Apr 28, 2014 at 3:07 PM, Phuong Viet VU
<phuongvv(a)exoplatform.com <mailto:phuongvv@exoplatform.com>> wrote:
Hi, yes, you're right, we should have the move* permission inherited
I've just rebuild and run GateIn master with PR from GTNPORTAL-3459.
But there is NPE in the console. Step to reproduce
- Login as root, create a portal site "TestSite"
- Go to "Page management" page, and Click "Add new page" -->
NPE in
the console
[http-bio-8080-exec-8] ERROR portal:UIPortalApplication - Error
during the processAction phase
java.lang.NullPointerException
at
org.exoplatform.portal.webui.page.UIPageForm$ChangeOwnerTypeActionListener.execute(UIPageForm.java:377)
at org.exoplatform.webui.event.Event.broadcast(Event.java:97)
at
org.exoplatform.portal.webui.page.UIPageBrowser$AddNewActionListener.execute(UIPageBrowser.java:373)
at org.exoplatform.webui.event.Event.broadcast(Event.java:97)
On Mon, Apr 28, 2014 at 2:37 PM, Peter Palaga <ppalaga(a)redhat.com
<mailto:ppalaga@redhat.com>> wrote:
Hi *, I will merge this today after 16:00 CEST unless somebody
raises his hand. -- PP
On 2014-04-24 15:09, Peter Palaga wrote:
Hi *,
from my PoV this is a follow up of GTNPORTAL-3364 "Implement
UI part for
Restricted layout setting" done by nttuyen.
The present issue:
https://issues.jboss.org/__browse/GTNPORTAL-3459
<https://issues.jboss.org/browse/GTNPORTAL-3459>
When creating new portal site, there are 4 permissions to
set - Access,
Edit, Move Apps, Move Containers. When I create new portal
and set some
permissions, then create new page in this portal, the owner
of the new
page is the newly created portal, and Access and Edit
permissions are
inherited or "copied" into the permissions of the new page.
But Move
Apps, Move Containers permissions are set to "Everyone". This
permissions should probably also inherit the permissions
from the owning
portal.
Steps to reproduce:
1. Create new portal site, set some permissions
2. Go to this new portal site, create new page. On the 3rd
step of
creating the page, in View Page Properties, Permissions tab are
inherited only Access and Edit permissions.
Could you please review my fix?
https://github.com/gatein/__gatein-portal/pull/841
<https://github.com/gatein/gatein-portal/pull/841>
Thanks,
Peter
_________________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org <mailto:gatein-dev@lists.jboss.org>
https://lists.jboss.org/__mailman/listinfo/gatein-dev
<https://lists.jboss.org/mailman/listinfo/gatein-dev>
3653
days inactive
3661
days old
4 comments
2 participants
participants (2)
-
Peter Palaga -
Phuong Viet VU