7:43 a.m.
Hi all, I've just seen that we have 2 bugs after GTNPORTAL-2403
1/ currently we have 2 projects (GATEIN/web/redirect and
GATEIN/portlet/redirect) with the same artifactID :
*<artifactId>redirect</artifactId>*
We should have them had difference name
*
*
2/ the GATEIN/portlet/redirect/src/main/webapp/jsp/*redirect.jsp *template
missing and closing tag *</div>*
This will cause all gatein ajax request that *relate* to this portlet fail.
For example, edit page, or edit portal-layout, portal will response and
unwell-form xml that cause problem with many functions of portal
*
*
*
*
1:16 p.m.
On Tue, 2012-07-24 at 19:43 +0700, Phuong Viet VU wrote:
Hi all, I've just seen that we have 2 bugs after GTNPORTAL-2403
1/ currently we have 2 projects (GATEIN/web/redirect and
GATEIN/portlet/redirect) with the same artifactID :
*<artifactId>redirect</artifactId>*
We should have them had difference name
The groupId's are different, so this is a non-issue. Unless we have some
sort of strange requirement on artifact id's having to be the same.
2/ the GATEIN/portlet/redirect/src/main/webapp/jsp/*redirect.jsp
*template
missing and closing tag *</div>*
Why are you expecting a template?
Good catch on the open div tag, will submit a pull request to get that
fixed.
This will cause all gatein ajax request that *relate* to this portlet
fail.
For example, edit page, or edit portal-layout, portal will response and
unwell-form xml that cause problem with many functions of portal
*
*
*
*
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev
9:06 p.m.
Hi *Matt Wringe, *thanks for the your PR, now I can do further test on my
branch that base on gatein master
About the artifactID, I also saw that they have difference groupID, but I
still think we should have difference artifactID for 2 difference sub
projects of GateIn
As I know, ppl have discussed about this and we'll use the same groupID for
projects in GateIn.
An artifactId should tell some thing about the meaning of a project, for
example, we can have redirectPortlet and redirectService (just a thought)
And btw, the redirect.jsp doesn't pass the w3c, <ul> tag can't contain
<a>
9:36 p.m.
Notice that we are having an effort to address the renaming all modules to
be the same as *org.gatein.portal*. So for me, using the same artifactId is
prone to an error AND I don't think it is a good practice as the packaging
name relies on artifactId by default
On 25 July 2012 01:16, Matt Wringe <mwringe(a)redhat.com> wrote:
On Tue, 2012-07-24 at 19:43 +0700, Phuong Viet VU wrote:
> Hi all, I've just seen that we have 2 bugs after GTNPORTAL-2403
>
> 1/ currently we have 2 projects (GATEIN/web/redirect and
> GATEIN/portlet/redirect) with the same artifactID :
> *<artifactId>redirect</artifactId>*
> We should have them had difference name
The groupId's are different, so this is a non-issue. Unless we have some
sort of strange requirement on artifact id's having to be the same.
> 2/ the GATEIN/portlet/redirect/src/main/webapp/jsp/*redirect.jsp
*template
> missing and closing tag *</div>*
Why are you expecting a template?
Good catch on the open div tag, will submit a pull request to get that
fixed.
> This will cause all gatein ajax request that *relate* to this portlet
fail.
> For example, edit page, or edit portal-layout, portal will response and
> unwell-form xml that cause problem with many functions of portal
> *
> *
> *
> *
> _______________________________________________
> gatein-dev mailing list
> gatein-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/gatein-dev
_______________________________________________
gatein-dev mailing list
gatein-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/gatein-dev
4549
days inactive
4550
days old
3 comments
3 participants
participants (3)
-
Matt Wringe -
Phuong Viet VU -
Trong Tran