This api inconsistency between Tomcat and JBossWeb really sucks:-( I think that PortalClusteredSSOSupportValve is not the only one valve class, which implements start() method. We have more such valve classes (I am aware at least about SSODelegateValve). So it seems that moving single PortalClusteredSSOSupportValve to packaging/jboss-as7 won't be sufficient... Can't we do something like override tomcat classloader org.apache.catalina.loader.WebappClassLoader and handle this at classloader level? Marek On 08/03/13 11:19, Julien Viet wrote: > Hi, > > there is an issue when deploying servlet 3.0 applications on Tomcat with PortalClusteredSSOSupportValve. > > The scanning process find this valve and a classloading issue occurs (JBoss AS7 uses a Tomcat fork with slightly different code) and produces this error: > > https://gist.github.com/vietj/b35b65f7dbe9d845ddd3 > > It would make sense at some point to move this code to gatein-sso (or wci) but I think it would not work at the moment. > > An easy solution would be to move this class somewhere in packaging/jboss-as7 . > > Would someone mind to have a look at this issue ? > > thanks > > Julien > > > _______________________________________________ > gatein-dev mailing list > gatein-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/gatein-dev

On 11/03/13 18:44, Julien Viet wrote: > why wouldn't it be sufficient ? Because we have more valve classes, not just PortalClusteredSSOSupportValve. So it's possible that when you fix PortalClusteredSSOSupportValve and move it to packaging/jboss-as7, you will still see same error for some other valve class. But maybe I am wrong, I did not try it... Marek > > > > On Mar 11, 2013, at 6:33 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: > >> This api inconsistency between Tomcat and JBossWeb really sucks:-( >> >> I think that PortalClusteredSSOSupportValve is not the only one valve class, which implements start() method. We have more such valve classes (I am aware at least about SSODelegateValve). So it seems that moving single PortalClusteredSSOSupportValve to packaging/jboss-as7 won't be sufficient... >> >> Can't we do something like override tomcat classloader org.apache.catalina.loader.WebappClassLoader and handle this at classloader level? >> >> Marek >> >> On 08/03/13 11:19, Julien Viet wrote: >>> Hi, >>> >>> there is an issue when deploying servlet 3.0 applications on Tomcat with PortalClusteredSSOSupportValve. >>> >>> The scanning process find this valve and a classloading issue occurs (JBoss AS7 uses a Tomcat fork with slightly different code) and produces this error: >>> >>> https://gist.github.com/vietj/b35b65f7dbe9d845ddd3 >>> >>> It would make sense at some point to move this code to gatein-sso (or wci) but I think it would not work at the moment. >>> >>> An easy solution would be to move this class somewhere in packaging/jboss-as7 . >>> >>> Would someone mind to have a look at this issue ? >>> >>> thanks >>> >>> Julien >>> >>> >>> _______________________________________________ >>> gatein-dev mailing list >>> gatein-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/gatein-dev

On 11/03/13 21:25, Julien Viet wrote: > PortalClusteredSSOSupportValve is the only Tomcat valve used in GateIn and it is only used in JBoss AS7 for clustered SSO. > > did you have something else in mind ? yeah, I already mentioned in first mail that I am aware at least about SSODelegateValve. Marek > > On Mar 11, 2013, at 8:32 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: > >> On 11/03/13 18:44, Julien Viet wrote: >>> why wouldn't it be sufficient ? >> Because we have more valve classes, not just PortalClusteredSSOSupportValve. So it's possible that when you fix PortalClusteredSSOSupportValve and move it to packaging/jboss-as7, you will still see same error for some other valve class. But maybe I am wrong, I did not try it... >> >> Marek >>> >>> >>> On Mar 11, 2013, at 6:33 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: >>> >>>> This api inconsistency between Tomcat and JBossWeb really sucks:-( >>>> >>>> I think that PortalClusteredSSOSupportValve is not the only one valve class, which implements start() method. We have more such valve classes (I am aware at least about SSODelegateValve). So it seems that moving single PortalClusteredSSOSupportValve to packaging/jboss-as7 won't be sufficient... >>>> >>>> Can't we do something like override tomcat classloader org.apache.catalina.loader.WebappClassLoader and handle this at classloader level? >>>> >>>> Marek >>>> >>>> On 08/03/13 11:19, Julien Viet wrote: >>>>> Hi, >>>>> >>>>> there is an issue when deploying servlet 3.0 applications on Tomcat with PortalClusteredSSOSupportValve. >>>>> >>>>> The scanning process find this valve and a classloading issue occurs (JBoss AS7 uses a Tomcat fork with slightly different code) and produces this error: >>>>> >>>>> https://gist.github.com/vietj/b35b65f7dbe9d845ddd3 >>>>> >>>>> It would make sense at some point to move this code to gatein-sso (or wci) but I think it would not work at the moment. >>>>> >>>>> An easy solution would be to move this class somewhere in packaging/jboss-as7 . >>>>> >>>>> Would someone mind to have a look at this issue ? >>>>> >>>>> thanks >>>>> >>>>> Julien >>>>> >>>>> >>>>> _______________________________________________ >>>>> gatein-dev mailing list >>>>> gatein-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/gatein-dev

it looks like the dependency comes from PicketLink artifact picketlink-jbas7 that contains specific code for JBoss AS7 (JBoss Web). we need to come up with a solution that erases this dependency from non JBoss AS7 runtimes :-) On Mar 13, 2013, at 10:10 AM, Julien Viet <julien(a)julienviet.com&gt; wrote: > we need this valve to be moved to a JBoss AS specific jar, can you take care of this ? > > On Mar 11, 2013, at 9:34 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: > >> On 11/03/13 21:25, Julien Viet wrote: >>> PortalClusteredSSOSupportValve is the only Tomcat valve used in GateIn and it is only used in JBoss AS7 for clustered SSO. >>> >>> did you have something else in mind ? >> yeah, I already mentioned in first mail that I am aware at least about SSODelegateValve. >> >> Marek >>> On Mar 11, 2013, at 8:32 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: >>> >>>> On 11/03/13 18:44, Julien Viet wrote: >>>>> why wouldn't it be sufficient ? >>>> Because we have more valve classes, not just PortalClusteredSSOSupportValve. So it's possible that when you fix PortalClusteredSSOSupportValve and move it to packaging/jboss-as7, you will still see same error for some other valve class. But maybe I am wrong, I did not try it... >>>> >>>> Marek >>>>> >>>>> On Mar 11, 2013, at 6:33 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: >>>>> >>>>>> This api inconsistency between Tomcat and JBossWeb really sucks:-( >>>>>> >>>>>> I think that PortalClusteredSSOSupportValve is not the only one valve class, which implements start() method. We have more such valve classes (I am aware at least about SSODelegateValve). So it seems that moving single PortalClusteredSSOSupportValve to packaging/jboss-as7 won't be sufficient... >>>>>> >>>>>> Can't we do something like override tomcat classloader org.apache.catalina.loader.WebappClassLoader and handle this at classloader level? >>>>>> >>>>>> Marek >>>>>> >>>>>> On 08/03/13 11:19, Julien Viet wrote: >>>>>>> Hi, >>>>>>> >>>>>>> there is an issue when deploying servlet 3.0 applications on Tomcat with PortalClusteredSSOSupportValve. >>>>>>> >>>>>>> The scanning process find this valve and a classloading issue occurs (JBoss AS7 uses a Tomcat fork with slightly different code) and produces this error: >>>>>>> >>>>>>> https://gist.github.com/vietj/b35b65f7dbe9d845ddd3 >>>>>>> >>>>>>> It would make sense at some point to move this code to gatein-sso (or wci) but I think it would not work at the moment. >>>>>>> >>>>>>> An easy solution would be to move this class somewhere in packaging/jboss-as7 . >>>>>>> >>>>>>> Would someone mind to have a look at this issue ? >>>>>>> >>>>>>> thanks >>>>>>> >>>>>>> Julien >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> gatein-dev mailing list >>>>>>> gatein-dev(a)lists.jboss.org >>>>>>> https://lists.jboss.org/mailman/listinfo/gatein-dev

On Mar 13, 2013, at 8:17 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: > Hi Julien, > > is there something special which could be done to reproduce the issue? I tried to verify with latest GateIn master and Tomcat 7.0.32 but not seeing any problems. Do I need to use some web application with servlet 3.0 descriptor? Do you have some app to share which could be use to reproduce this? Hoang reported this issue. I will ask him to provide the necessary steps for reproducing (like a war file). > Actually picketlink-jbas7 is not part of Tomcat packaging. I am not seeing it in GATEIN_TOMCAT_HOME/lib/ . But SSODelegateValve is part of sso-integration-1.3.1.Final.jar which is part of Tomcat packaging… > Thing is that signature of PortalClusteredSSOSupportValve is: > {code} > public class PortalClusteredSSOSupportValve extends ValveBase implements Lifecycle { > {code} > > but signature of SSODelegateValve is: > {code} > public class SSODelegateValve implements Valve, Contained, MBeanRegistration, Lifecycle > {code} > > So it seems that your issue with "class org.exoplatform.web.login.PortalClusteredSSOSupportValve overrides final method start.()" really won't happen for SSODelegateValve. Hard to say without being able > to reproduce… That would be a good news. Does the SSODelegateValve also work on Tomcat ? or is it AS7 specific ?

> Marek > > > On 13/03/13 10:16, Julien Viet wrote: >> it looks like the dependency comes from PicketLink artifact picketlink-jbas7 that contains specific code for JBoss AS7 (JBoss Web). >> >> we need to come up with a solution that erases this dependency from non JBoss AS7 runtimes :-) >> >> On Mar 13, 2013, at 10:10 AM, Julien Viet <julien(a)julienviet.com&gt; wrote: >> >>> we need this valve to be moved to a JBoss AS specific jar, can you take care of this ? >>> >>> On Mar 11, 2013, at 9:34 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: >>> >>>> On 11/03/13 21:25, Julien Viet wrote: >>>>> PortalClusteredSSOSupportValve is the only Tomcat valve used in GateIn and it is only used in JBoss AS7 for clustered SSO. >>>>> >>>>> did you have something else in mind ? >>>> yeah, I already mentioned in first mail that I am aware at least about SSODelegateValve. >>>> >>>> Marek >>>>> On Mar 11, 2013, at 8:32 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: >>>>> >>>>>> On 11/03/13 18:44, Julien Viet wrote: >>>>>>> why wouldn't it be sufficient ? >>>>>> Because we have more valve classes, not just PortalClusteredSSOSupportValve. So it's possible that when you fix PortalClusteredSSOSupportValve and move it to packaging/jboss-as7, you will still see same error for some other valve class. But maybe I am wrong, I did not try it... >>>>>> >>>>>> Marek >>>>>>> On Mar 11, 2013, at 6:33 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: >>>>>>> >>>>>>>> This api inconsistency between Tomcat and JBossWeb really sucks:-( >>>>>>>> >>>>>>>> I think that PortalClusteredSSOSupportValve is not the only one valve class, which implements start() method. We have more such valve classes (I am aware at least about SSODelegateValve). So it seems that moving single PortalClusteredSSOSupportValve to packaging/jboss-as7 won't be sufficient... >>>>>>>> >>>>>>>> Can't we do something like override tomcat classloader org.apache.catalina.loader.WebappClassLoader and handle this at classloader level? >>>>>>>> >>>>>>>> Marek >>>>>>>> >>>>>>>> On 08/03/13 11:19, Julien Viet wrote: >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> there is an issue when deploying servlet 3.0 applications on Tomcat with PortalClusteredSSOSupportValve. >>>>>>>>> >>>>>>>>> The scanning process find this valve and a classloading issue occurs (JBoss AS7 uses a Tomcat fork with slightly different code) and produces this error: >>>>>>>>> >>>>>>>>> https://gist.github.com/vietj/b35b65f7dbe9d845ddd3 >>>>>>>>> >>>>>>>>> It would make sense at some point to move this code to gatein-sso (or wci) but I think it would not work at the moment. >>>>>>>>> >>>>>>>>> An easy solution would be to move this class somewhere in packaging/jboss-as7 . >>>>>>>>> >>>>>>>>> Would someone mind to have a look at this issue ? >>>>>>>>> >>>>>>>>> thanks >>>>>>>>> >>>>>>>>> Julien >>>>>>>>> >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> gatein-dev mailing list >>>>>>>>> gatein-dev(a)lists.jboss.org >>>>>>>>> https://lists.jboss.org/mailman/listinfo/gatein-dev

Hi, We can easily reproduce the problem in Tomcat by just reference the PortalClusteredSSOSupportValve class in a Servlet Context listener of a web app, to load it.

I can see that it has been changed in org.apache.catalina.valves.ValveBase since Tomcat API 7.0 which already defined a final *start()* method from its indirect parent class org.apache.catalina.util.LifecycleBase http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/valves/Va... I confirmed that the problem doesn't happen in JBoss, so I guess this api part is not consistent between Tomcat and JBossWeb.

In addition, there is no error in compile time as it is using tomcat catalina version 6.0.29 declared in gatein-dep.

Thanks,

I think it was just a way to reproduce the issue and Trong does not want to use the PortalClusteredSSOSupportValve in Tomcat :-) On Mar 18, 2013, at 5:14 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: Hi Trong, Notes inline. On 18/03/13 12:25, Trong Tran wrote: Hi, We can easily reproduce the problem in Tomcat by just reference the PortalClusteredSSOSupportValve class in a Servlet Context listener of a web app, to load it. yes, I am able to reproduce it with Servlet Context listener. But I am still not sure if I understand the usecase. Why you need to access PortalClusteredSSOSupportValve from some Servlet Context listener on Tomcat? Thing is that PortalClusteredSSOSupportValve is meant to be used only in JBoss because it uses JBoss specific clustered SSO valve. It does not makes sense to use it in Tomcat. And it seems that moving PortalClusteredSSOSupportValve to packaging/jboss7 won't solve your issue, because than you won't be able to compile your listener anyway because PortalClusteredSSOSupportValve won't be available. But maybe I still don't uderstand the usecase... I am able to have listener on Tomcat with code like this and it works without throwing error: public class PortalSSOValveListener implements ServletContextListener { ValveBase portalClusteredSSOSupportValve; public void contextInitialized(ServletContextEvent sce) { if (new J2EEServerInfo().isJBoss()) { PortalClusteredSSOSupportValve casted = (PortalClusteredSSOSupportValve)portalClusteredSSOSupportValve; // Do something with the valve } } public void contextDestroyed(ServletContextEvent sce) { } private ValveBase findValve() { // TODO: Find valve somehow... return null; } } I can see that it has been changed in org.apache.catalina.valves.ValveBase since Tomcat API 7.0 which already defined a final *start()* method from its indirect parent class org.apache.catalina.util.LifecycleBase http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/valves/Va... I confirmed that the problem doesn't happen in JBoss, so I guess this api part is not consistent between Tomcat and JBossWeb. yes, It sucks that this api is changed... In addition, there is no error in compile time as it is using tomcat catalina version 6.0.29 declared in gatein-dep. Hmm... I tried to run "mvn dependency:tree" in module component/web/security where PortalClusteredSSOSupportValve currently is. And I am seeing that it's using jboss.web:jbossweb:jar:2.1.3.GA:provided for compilation. Marek Thanks,

http://static.springsource.org/spring/docs/3.0.0.M3/reference/html/ch04s1... On Mar 19, 2013, at 4:29 AM, Trong Tran <trongtt(a)gmail.com&gt; wrote: > Yes, that was just a way to reproduce the issue. > > About the real usecase that Hoang has reported, it is a Spring 3.x > web app. For a certain reason, Spring auto scans all Valves which > causes the issue. > > On 18 March 2013 23:28, Julien Viet <julien(a)julienviet.com > <mailto:julien@julienviet.com>> wrote: > > I think it was just a way to reproduce the issue and Trong does > not want to use the PortalClusteredSSOSupportValve in Tomcat :-) > > On Mar 18, 2013, at 5:14 PM, Marek Posolda <mposolda(a)redhat.com > <mailto:mposolda@redhat.com>> wrote: > >> Hi Trong, >> >> Notes inline. >> >> On 18/03/13 12:25, Trong Tran wrote: >>> Hi, >>> >>> We can easily reproduce the problem in Tomcat by just reference >>> the PortalClusteredSSOSupportValve class in a Servlet Context >>> listener of a web app, to load it. >> yes, I am able to reproduce it with Servlet Context listener. >> But I am still not sure if I understand the usecase. Why you >> need to access PortalClusteredSSOSupportValve from some Servlet >> Context listener on Tomcat? Thing is that >> PortalClusteredSSOSupportValve is meant to be used only in JBoss >> because it uses JBoss specific clustered SSO valve. It does not >> makes sense to use it in Tomcat. >> >> And it seems that moving PortalClusteredSSOSupportValve to >> packaging/jboss7 won't solve your issue, because than you won't >> be able to compile your listener anyway because >> PortalClusteredSSOSupportValve won't be available. But maybe I >> still don't uderstand the usecase... >> >> >> >> I am able to have listener on Tomcat with code like this and it >> works without throwing error: >> >> public class PortalSSOValveListener implements >> ServletContextListener { >> >> ValveBase portalClusteredSSOSupportValve; >> >> public void contextInitialized(ServletContextEvent sce) { >> >> if (new J2EEServerInfo().isJBoss()) { >> PortalClusteredSSOSupportValve casted = >> (PortalClusteredSSOSupportValve)portalClusteredSSOSupportValve; >> // Do something with the valve >> } >> } >> >> public void contextDestroyed(ServletContextEvent sce) { >> } >> >> private ValveBase findValve() { >> // TODO: Find valve somehow... >> return null; >> } >> } >> >>> >>> I can see that it has been changed in >>> org.apache.catalina.valves.ValveBase since Tomcat API 7.0 which >>> already defined a final *start()* method from its indirect >>> parent class org.apache.catalina.util.LifecycleBase >>> http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/valves/Va... >>> >>> I confirmed that the problem doesn't happen in JBoss, so I >>> guess this api part is not consistent between Tomcat and JBossWeb. >> yes, It sucks that this api is changed... >>> >>> In addition, there is no error in compile time as it is using >>> tomcat catalina version 6.0.29 declared in gatein-dep. >> Hmm... I tried to run "mvn dependency:tree" in module >> component/web/security where PortalClusteredSSOSupportValve >> currently is. And I am seeing that it's using >> jboss.web:jbossweb:jar:2.1.3.GA:provided for compilation. >> >> Marek >>> >>> Thanks, >> > > > > > -- > *Trong Tran* > /(+84) 983841909 | /trongtt(a)gmail.com <mailto:trongtt@gmail.com> > Twitter: http://twitter.com/trongtt// _______________________________________________ gatein-dev mailing list gatein-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/gatein-dev

I've created jira https://issues.jboss.org/browse/GTNPORTAL-2859 and I have fix available in branch https://github.com/mposolda/gatein-portal/tree/sso-valve . It's adding new module security-jboss, which is deployed only in JBoss but on Tomcat. So PortalClusteredSSOSupportValve is not available on classpath on Tomcat anymore. Could you please check it with your Spring application? I will send PR once confirmed from you that it works. Thanks, Marek On 19/03/13 08:22, Julien Viet wrote: > http://static.springsource.org/spring/docs/3.0.0.M3/reference/html/ch04s1... > > On Mar 19, 2013, at 4:29 AM, Trong Tran <trongtt(a)gmail.com&gt; wrote: > >> Yes, that was just a way to reproduce the issue. >> >> About the real usecase that Hoang has reported, it is a Spring 3.x web app. For a certain reason, Spring auto scans all Valves which causes the issue. >> >> On 18 March 2013 23:28, Julien Viet <julien(a)julienviet.com&gt; wrote: >> I think it was just a way to reproduce the issue and Trong does not want to use the PortalClusteredSSOSupportValve in Tomcat :-) >> >> On Mar 18, 2013, at 5:14 PM, Marek Posolda <mposolda(a)redhat.com&gt; wrote: >> >>> Hi Trong, >>> >>> Notes inline. >>> >>> On 18/03/13 12:25, Trong Tran wrote: >>>> Hi, >>>> >>>> We can easily reproduce the problem in Tomcat by just reference the PortalClusteredSSOSupportValve class in a Servlet Context listener of a web app, to load it. >>> yes, I am able to reproduce it with Servlet Context listener. But I am still not sure if I understand the usecase. Why you need to access PortalClusteredSSOSupportValve from some Servlet Context listener on Tomcat? Thing is that PortalClusteredSSOSupportValve is meant to be used only in JBoss because it uses JBoss specific clustered SSO valve. It does not makes sense to use it in Tomcat. >>> >>> And it seems that moving PortalClusteredSSOSupportValve to packaging/jboss7 won't solve your issue, because than you won't be able to compile your listener anyway because PortalClusteredSSOSupportValve won't be available. But maybe I still don't uderstand the usecase... >>> >>> >>> >>> I am able to have listener on Tomcat with code like this and it works without throwing error: >>> >>> public class PortalSSOValveListener implements ServletContextListener { >>> >>> ValveBase portalClusteredSSOSupportValve; >>> >>> public void contextInitialized(ServletContextEvent sce) { >>> >>> if (new J2EEServerInfo().isJBoss()) { >>> PortalClusteredSSOSupportValve casted = (PortalClusteredSSOSupportValve)portalClusteredSSOSupportValve; >>> // Do something with the valve >>> } >>> } >>> >>> public void contextDestroyed(ServletContextEvent sce) { >>> } >>> >>> private ValveBase findValve() { >>> // TODO: Find valve somehow... >>> return null; >>> } >>> } >>> >>>> >>>> I can see that it has been changed in org.apache.catalina.valves.ValveBase since Tomcat API 7.0 which already defined a final start() method from its indirect parent class org.apache.catalina.util.LifecycleBase >>>> http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/valves/Va... >>>> >>>> I confirmed that the problem doesn't happen in JBoss, so I guess this api part is not consistent between Tomcat and JBossWeb. >>> yes, It sucks that this api is changed... >>>> >>>> In addition, there is no error in compile time as it is using tomcat catalina version 6.0.29 declared in gatein-dep. >>> Hmm... I tried to run "mvn dependency:tree" in module component/web/security where PortalClusteredSSOSupportValve currently is. And I am seeing that it's using jboss.web:jbossweb:jar:2.1.3.GA:provided for compilation. >>> >>> Marek >>>> >>>> Thanks, >>> >> >> >> >> >> -- >> Trong Tran >> (+84) 983841909 | trongtt(a)gmail.com >> Twitter: http://twitter.com/trongtt >