[portal-commits] JBoss Portal SVN: r10559 - in branches/JBoss_Portal_Branch_2_7: core-samples/src/main/org/jboss/portal/core/samples/basic and 1 other directory.

Author: julien(a)jboss.com Date: 2008-04-13 15:41:19 -0400 (Sun, 13 Apr 2008) New Revision: 10559 Modified: branches/JBoss_Portal_Branch_2_7/core-samples/src/main/org/jboss/portal/core/samples/basic/PublicParametersPortlet.java branches/JBoss_Portal_Branch_2_7/core/src/main/org/jboss/portal/core/controller/portlet/PortletInvocationFactory.java Log: - bug fix - update public parameter portlet to test public render parameter removal from a render URL Modified: branches/JBoss_Portal_Branch_2_7/core/src/main/org/jboss/portal/core/controller/portlet/PortletInvocationFactory.java =================================================================== --- branches/JBoss_Portal_Branch_2_7/core/src/main/org/jboss/portal/core/controller/portlet/PortletInvocationFactory.java 2008-04-13 17:51:14 UTC (rev 10558) +++ branches/JBoss_Portal_Branch_2_7/core/src/main/org/jboss/portal/core/controller/portlet/PortletInvocationFactory.java 2008-04-13 19:41:19 UTC (rev 10559) @@ -395,7 +395,7 @@ String[] value = publicChanges.get(name); // - if (value.length == 0) + if (value != null && value.length == 0) { continue; } Modified: branches/JBoss_Portal_Branch_2_7/core-samples/src/main/org/jboss/portal/core/samples/basic/PublicParametersPortlet.java =================================================================== --- branches/JBoss_Portal_Branch_2_7/core-samples/src/main/org/jboss/portal/core/samples/basic/PublicParametersPortlet.java 2008-04-13 17:51:14 UTC (rev 10558) +++ branches/JBoss_Portal_Branch_2_7/core-samples/src/main/org/jboss/portal/core/samples/basic/PublicParametersPortlet.java 2008-04-13 19:41:19 UTC (rev 10559) @@ -30,6 +30,8 @@ import javax.portlet.RenderRequest; import javax.portlet.RenderResponse; import javax.portlet.PortletURL; +import javax.portlet.GenericPortlet; +import javax.portlet.ProcessAction; import java.io.IOException; import java.io.PrintWriter; import java.util.Enumeration; @@ -39,20 +41,15 @@ * @author <a href="mailto:julien@jboss-portal.org">Julien Viet</a> * @version $Revision: 630 $ */ -public class PublicParametersPortlet implements Portlet +public class PublicParametersPortlet extends GenericPortlet { - /** . */ - private PortletConfig config; - - public void init(PortletConfig config) throws PortletException + @ProcessAction(name="update") + public void update(ActionRequest req, ActionResponse resp) throws PortletException, IOException { - this.config = config; - } - - public void processAction(ActionRequest req, ActionResponse resp) throws PortletException, IOException - { Map<String, String[]> publicParameters = req.getPublicParameterMap(); + + // for (Map.Entry<String, String[]> actionParameter : req.getPrivateParameterMap().entrySet()) { String parameterName = actionParameter.getKey(); @@ -76,14 +73,15 @@ public void render(RenderRequest req, RenderResponse resp) throws PortletException, IOException { - - PrintWriter writer = resp.getWriter(); - PortletURL actionURL = resp.createActionURL(); + actionURL.setParameter(ActionRequest.ACTION_NAME, "update"); + // + PrintWriter writer = resp.getWriter(); writer.print("<form action=\"" + actionURL + "\" method=\"POST\"><table>"); - for (Enumeration<String> e = config.getPublicRenderParameterNames();e.hasMoreElements();) + // + for (Enumeration<String> e = getPortletConfig().getPublicRenderParameterNames();e.hasMoreElements();) { String parameterName = e.nextElement(); @@ -96,6 +94,11 @@ if (parameterValue != null) { writer.print("<input type=\"text\" name=\"" + parameterName + "\" width=\"36\" value=\"" + parameterValue + "\"/>"); + + // + PortletURL renderURL = resp.createRenderURL(); + renderURL.removePublicRenderParameter(parameterName); + writer.println("<a href=\"" + renderURL + "\">Remove</>"); } else { @@ -114,9 +117,4 @@ // writer.close(); } - - public void destroy() - { - this.config = null; - } }