[
https://issues.jboss.org/browse/SHRINKRES-49?page=com.atlassian.jira.plug...
]
Karel Piwko edited comment on SHRINKRES-49 at 9/6/12 6:30 AM:
--------------------------------------------------------------
The tests are not required unless we port MavenImporter.
MavenImporter reads a pom.xml and thus it is able to import compiled classes, test
classes, dependencies from the location specified in pom.xml. This means that fooling
tests by creating archives themselves does not do the trick, because it simply tests
ShrinkWrap. Right, there might be some libs resolved for wars/ears, but there is a plenty
of such tests already.
I'm rejecting this issue. We need a proper MavenImporter implementation, it is simply
not worth it to migrate current crappy one (read: a one that does not require mvn package
phase to be run before output can be imported or the one which is able to run package
phase itself), because current state does not bring you much over ZipImporter or
ExplodedImporter.
was (Author: kpiwko):
The tests are not required unless we port MavenImporter.
MavenImporter reads a pom.xml and thus it is able to import compiled classes, test
classes, dependencies from the location specified in pom.xml. This means that fooling
tests by creating archives themselves does not do the trick, because it simply tests
ShrinkWrap. Right, there might be some libs resolved for wars/ears, but there is a plenty
of such tests already.
I'm rejecting this issue. We need a proper MavenImporter implementation (read: a one
that does not require mvn package phase to be run before output can be imported or the one
which is able to run it itself), because current state does not bring you much over
ZipImporter or ExplodedImporter.
Port JAR, EAR, WAR Samples and Test Modules to new API
------------------------------------------------------
Key: SHRINKRES-49
URL:
https://issues.jboss.org/browse/SHRINKRES-49
Project: ShrinkWrap Resolvers
Issue Type: Task
Affects Versions: SHRINKRES-39 Unreleased Changes
Reporter: Andrew Rubinger
Assignee: Karel Piwko
Fix For: 2.0.0-alpha-2
Port these modules to use the new API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira