[JBoss JIRA] (SHRINKRES-112) MavenImporter ignores AcceptScopesStrategy for dependency inclusion
by Andrew Rubinger (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-112?page=com.atlassian.jira.plu... ]
Andrew Rubinger commented on SHRINKRES-112:
-------------------------------------------
Thanks for outlining this issue. Will dig in and bring further discussion to the forums if needed.
> MavenImporter ignores AcceptScopesStrategy for dependency inclusion
> -------------------------------------------------------------------
>
> Key: SHRINKRES-112
> URL: https://issues.jboss.org/browse/SHRINKRES-112
> Project: ShrinkWrap Resolvers
> Issue Type: Feature Request
> Components: impl-maven
> Affects Versions: 2.0.0-beta-2
> Reporter: Karel Piwko
> Priority: Blocker
>
> AcceptScopesStrategy is not correctly propagated:
> {code}
> @Deployment(testable = false)
> public static WebArchive createDeployment()
> {
> return ShrinkWrap.create(MavenImporter.class)
> .loadPomFromFile("pom.xml")
> .importBuildOutput(new AcceptScopesStrategy(ScopeType.COMPILE, ScopeType.RUNTIME))
> .as(WebArchive.class);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years
[JBoss JIRA] (SHRINKRES-112) MavenImporter ignores AcceptScopesStrategy for dependency inclusion
by Andrew Rubinger (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-112?page=com.atlassian.jira.plu... ]
Andrew Rubinger commented on SHRINKRES-112:
-------------------------------------------
Blocker for what release? Beta-4, I'm assuming...if so, please set so we don't issue a release without this.
> MavenImporter ignores AcceptScopesStrategy for dependency inclusion
> -------------------------------------------------------------------
>
> Key: SHRINKRES-112
> URL: https://issues.jboss.org/browse/SHRINKRES-112
> Project: ShrinkWrap Resolvers
> Issue Type: Feature Request
> Components: impl-maven
> Affects Versions: 2.0.0-beta-2
> Reporter: Karel Piwko
> Priority: Blocker
>
> AcceptScopesStrategy is not correctly propagated:
> {code}
> @Deployment(testable = false)
> public static WebArchive createDeployment()
> {
> return ShrinkWrap.create(MavenImporter.class)
> .loadPomFromFile("pom.xml")
> .importBuildOutput(new AcceptScopesStrategy(ScopeType.COMPILE, ScopeType.RUNTIME))
> .as(WebArchive.class);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years
[JBoss JIRA] (SHRINKRES-123) Undefined scopes in depMgt via import scope are promoted to "compile"
by Andrew Rubinger (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-123?page=com.atlassian.jira.plu... ]
Andrew Rubinger resolved SHRINKRES-123.
---------------------------------------
Fix Version/s: 2.0.0-beta-3
Resolution: Done
Upstream: https://github.com/shrinkwrap/resolver/commit/4cbcb1338f0cdbedac4dca0076a...
> Undefined scopes in depMgt via import scope are promoted to "compile"
> ---------------------------------------------------------------------
>
> Key: SHRINKRES-123
> URL: https://issues.jboss.org/browse/SHRINKRES-123
> Project: ShrinkWrap Resolvers
> Issue Type: Bug
> Reporter: Andrew Rubinger
> Assignee: Andrew Rubinger
> Priority: Blocker
> Fix For: 2.0.0-beta-3
>
>
> Assume a BOM POM:
> {code}<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
> <!-- Model Version -->
> <modelVersion>4.0.0</modelVersion>
> <!-- Artifact Configuration -->
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-bom-testdeps</artifactId>
> <version>1.0.0</version>
> <packaging>pom</packaging>
> <dependencyManagement>
> <dependencies>
> <dependency>
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-dependency</artifactId>
> <version>1.0.0</version>
> </dependency>
> </dependencies>
> </dependencyManagement>
> <build>
> </build>
> </project>{code}
> ...and a dependency chain POM:
> {code}<?xml version="1.0" encoding="UTF-8"?>
> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
> <!-- Model Version -->
> <modelVersion>4.0.0</modelVersion>
> <!-- Artifact Configuration -->
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-depchain-testdeps</artifactId>
> <version>1.0.0</version>
> <packaging>pom</packaging>
> <dependencies>
> <dependency>
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-dependency</artifactId>
> </dependency>
> </dependencies>
> <build>
> </build>
> </project>{code}
> Placing a direct dependency upon the depchain POM in "test" scope should limit all transitive dependencies to "test" scope.
> {code}<?xml version="1.0" encoding="UTF-8"?>
> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
> <!-- Model Version -->
> <modelVersion>4.0.0</modelVersion>
> <!-- Artifact Configuration -->
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-deps-via-bom-and-depchain</artifactId>
> <version>1.0.0</version>
> <packaging>pom</packaging>
> <dependencyManagement>
> <dependencies>
> <dependency>
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-bom-testdeps</artifactId>
> <scope>import</scope>
> <type>pom</type>
> <version>1.0.0</version>
> </dependency>
> </dependencies>
> </dependencyManagement>
>
> <dependencies>
> <dependency>
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-depchain-testdeps</artifactId>
> <version>1.0.0</version>
> <type>pom</type>
> <scope>test</scope> <!-- These SHOULD be brought in test scope, but are not in SHRINKRES-123 -->
> </dependency>
> </dependencies>
> </project>{code}
> Unfortunately, we currently have no mechanism to denote that a scope in the BOM is intentionally left unspecified, and we incorrectly default this to "compile" in the dependency management section. This leads to leaking when calling upon:
> {code}resolver.loadFromPomFile().importRuntimeDependencies();{code}
> ...which then returns not only the runtime dependencies, but also the test and provided ones as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years
[JBoss JIRA] (SHRINKRES-123) Undefined scopes in depMgt via import scope are promoted to "compile"
by Andrew Rubinger (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-123?page=com.atlassian.jira.plu... ]
Andrew Rubinger commented on SHRINKRES-123:
-------------------------------------------
Partial fix in my fork:
https://github.com/ALRubinger/resolver/tree/SHRINKRES-123
Still TODO:
* Fix newly-added failing case
* Figure a way to not expose ScopeType.UNDEFINED to the user API
> Undefined scopes in depMgt via import scope are promoted to "compile"
> ---------------------------------------------------------------------
>
> Key: SHRINKRES-123
> URL: https://issues.jboss.org/browse/SHRINKRES-123
> Project: ShrinkWrap Resolvers
> Issue Type: Bug
> Reporter: Andrew Rubinger
> Assignee: Andrew Rubinger
> Priority: Blocker
>
> Assume a BOM POM:
> {code}<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
> <!-- Model Version -->
> <modelVersion>4.0.0</modelVersion>
> <!-- Artifact Configuration -->
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-bom-testdeps</artifactId>
> <version>1.0.0</version>
> <packaging>pom</packaging>
> <dependencyManagement>
> <dependencies>
> <dependency>
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-dependency</artifactId>
> <version>1.0.0</version>
> </dependency>
> </dependencies>
> </dependencyManagement>
> <build>
> </build>
> </project>{code}
> ...and a dependency chain POM:
> {code}<?xml version="1.0" encoding="UTF-8"?>
> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
> <!-- Model Version -->
> <modelVersion>4.0.0</modelVersion>
> <!-- Artifact Configuration -->
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-depchain-testdeps</artifactId>
> <version>1.0.0</version>
> <packaging>pom</packaging>
> <dependencies>
> <dependency>
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-dependency</artifactId>
> </dependency>
> </dependencies>
> <build>
> </build>
> </project>{code}
> Placing a direct dependency upon the depchain POM in "test" scope should limit all transitive dependencies to "test" scope.
> {code}<?xml version="1.0" encoding="UTF-8"?>
> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
> <!-- Model Version -->
> <modelVersion>4.0.0</modelVersion>
> <!-- Artifact Configuration -->
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-deps-via-bom-and-depchain</artifactId>
> <version>1.0.0</version>
> <packaging>pom</packaging>
> <dependencyManagement>
> <dependencies>
> <dependency>
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-bom-testdeps</artifactId>
> <scope>import</scope>
> <type>pom</type>
> <version>1.0.0</version>
> </dependency>
> </dependencies>
> </dependencyManagement>
>
> <dependencies>
> <dependency>
> <groupId>org.jboss.shrinkwrap.test</groupId>
> <artifactId>test-depchain-testdeps</artifactId>
> <version>1.0.0</version>
> <type>pom</type>
> <scope>test</scope> <!-- These SHOULD be brought in test scope, but are not in SHRINKRES-123 -->
> </dependency>
> </dependencies>
> </project>{code}
> Unfortunately, we currently have no mechanism to denote that a scope in the BOM is intentionally left unspecified, and we incorrectly default this to "compile" in the dependency management section. This leads to leaking when calling upon:
> {code}resolver.loadFromPomFile().importRuntimeDependencies();{code}
> ...which then returns not only the runtime dependencies, but also the test and provided ones as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years
[JBoss JIRA] (SHRINKRES-123) Undefined scopes in depMgt via import scope are promoted to "compile"
by Andrew Rubinger (JIRA)
Andrew Rubinger created SHRINKRES-123:
-----------------------------------------
Summary: Undefined scopes in depMgt via import scope are promoted to "compile"
Key: SHRINKRES-123
URL: https://issues.jboss.org/browse/SHRINKRES-123
Project: ShrinkWrap Resolvers
Issue Type: Bug
Reporter: Andrew Rubinger
Assignee: Andrew Rubinger
Priority: Blocker
Assume a BOM POM:
{code}<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<!-- Model Version -->
<modelVersion>4.0.0</modelVersion>
<!-- Artifact Configuration -->
<groupId>org.jboss.shrinkwrap.test</groupId>
<artifactId>test-bom-testdeps</artifactId>
<version>1.0.0</version>
<packaging>pom</packaging>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.jboss.shrinkwrap.test</groupId>
<artifactId>test-dependency</artifactId>
<version>1.0.0</version>
</dependency>
</dependencies>
</dependencyManagement>
<build>
</build>
</project>{code}
...and a dependency chain POM:
{code}<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<!-- Model Version -->
<modelVersion>4.0.0</modelVersion>
<!-- Artifact Configuration -->
<groupId>org.jboss.shrinkwrap.test</groupId>
<artifactId>test-depchain-testdeps</artifactId>
<version>1.0.0</version>
<packaging>pom</packaging>
<dependencies>
<dependency>
<groupId>org.jboss.shrinkwrap.test</groupId>
<artifactId>test-dependency</artifactId>
</dependency>
</dependencies>
<build>
</build>
</project>{code}
Placing a direct dependency upon the depchain POM in "test" scope should limit all transitive dependencies to "test" scope.
{code}<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<!-- Model Version -->
<modelVersion>4.0.0</modelVersion>
<!-- Artifact Configuration -->
<groupId>org.jboss.shrinkwrap.test</groupId>
<artifactId>test-deps-via-bom-and-depchain</artifactId>
<version>1.0.0</version>
<packaging>pom</packaging>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.jboss.shrinkwrap.test</groupId>
<artifactId>test-bom-testdeps</artifactId>
<scope>import</scope>
<type>pom</type>
<version>1.0.0</version>
</dependency>
</dependencies>
</dependencyManagement>
<dependencies>
<dependency>
<groupId>org.jboss.shrinkwrap.test</groupId>
<artifactId>test-depchain-testdeps</artifactId>
<version>1.0.0</version>
<type>pom</type>
<scope>test</scope> <!-- These SHOULD be brought in test scope, but are not in SHRINKRES-123 -->
</dependency>
</dependencies>
</project>{code}
Unfortunately, we currently have no mechanism to denote that a scope in the BOM is intentionally left unspecified, and we incorrectly default this to "compile" in the dependency management section. This leads to leaking when calling upon:
{code}resolver.loadFromPomFile().importRuntimeDependencies();{code}
...which then returns not only the runtime dependencies, but also the test and provided ones as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years
[JBoss JIRA] (SHRINKDESC-126) JavaDoc incorrect for parameters
by Andrew Rubinger (JIRA)
[ https://issues.jboss.org/browse/SHRINKDESC-126?page=com.atlassian.jira.pl... ]
Andrew Rubinger commented on SHRINKDESC-126:
--------------------------------------------
Yes, after the API change is good. Bumping.
> JavaDoc incorrect for parameters
> --------------------------------
>
> Key: SHRINKDESC-126
> URL: https://issues.jboss.org/browse/SHRINKDESC-126
> Project: ShrinkWrap Descriptors
> Issue Type: Bug
> Components: metadata-parser
> Affects Versions: 2.0.0-alpha-3
> Reporter: Jesper Pedersen
> Assignee: Michal Matloka
>
> The generated .java files from the metadata-parser gives:
> {noformat}
> [javadoc] /xyz/build/embedded/src/main/java/org/jboss/jca/embedded/dsl/datasources11/impl/ConfigPropertyTypeImpl.java:58: warning - @param argument "configPropertyType" is not a parameter name.
> {noformat}
> for
> {noformat}
> /**
> * Sets the body text for the element <code>config-propertyType</code>
> * @param configPropertyType the value for the body text <code>config-propertyType</code>
> * @return the current instance of <code>ConfigPropertyType<T></code>
> */
> public ConfigPropertyType<T> text(String value)
> {
> childNode.text(value);
> return this;
> }
> {noformat}
> It should be 'value' instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years
[JBoss JIRA] (SHRINKDESC-126) JavaDoc incorrect for parameters
by Andrew Rubinger (JIRA)
[ https://issues.jboss.org/browse/SHRINKDESC-126?page=com.atlassian.jira.pl... ]
Andrew Rubinger updated SHRINKDESC-126:
---------------------------------------
Fix Version/s: (was: 2.0.0-alpha-5)
> JavaDoc incorrect for parameters
> --------------------------------
>
> Key: SHRINKDESC-126
> URL: https://issues.jboss.org/browse/SHRINKDESC-126
> Project: ShrinkWrap Descriptors
> Issue Type: Bug
> Components: metadata-parser
> Affects Versions: 2.0.0-alpha-3
> Reporter: Jesper Pedersen
> Assignee: Michal Matloka
>
> The generated .java files from the metadata-parser gives:
> {noformat}
> [javadoc] /xyz/build/embedded/src/main/java/org/jboss/jca/embedded/dsl/datasources11/impl/ConfigPropertyTypeImpl.java:58: warning - @param argument "configPropertyType" is not a parameter name.
> {noformat}
> for
> {noformat}
> /**
> * Sets the body text for the element <code>config-propertyType</code>
> * @param configPropertyType the value for the body text <code>config-propertyType</code>
> * @return the current instance of <code>ConfigPropertyType<T></code>
> */
> public ConfigPropertyType<T> text(String value)
> {
> childNode.text(value);
> return this;
> }
> {noformat}
> It should be 'value' instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years