[JBoss JIRA] (SHRINKRES-279) There is no easy way to get command that will be used for Maven build invocation
by Matous Jobanek (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-279?page=com.atlassian.jira.plu... ]
Matous Jobanek updated SHRINKRES-279:
-------------------------------------
Description:
The only way is creating my own {{InvokerLogger}} where I set the threshold to {{DEBUG}}. Then set this logger using method: {{setLogger}}
There could be some method: {{setDebugLoggerLevel()}} that would set the threshold automatically.
was:
The only way is creating my own {{InvokerLogger}} where I set the threshold to {{DEBUG}}. Then set this logger using method: {{setLogger}}
There could be some method: {{setDebugLoggerLevel()}} that would set the treshold automaticaly.
> There is no easy way to get command that will be used for Maven build invocation
> --------------------------------------------------------------------------------
>
> Key: SHRINKRES-279
> URL: https://issues.jboss.org/browse/SHRINKRES-279
> Project: ShrinkWrap Resolvers
> Issue Type: Enhancement
> Components: EmbeddedMaven
> Affects Versions: 3.0.0-beta-2
> Reporter: Matous Jobanek
> Assignee: Matous Jobanek
> Fix For: 3.0.0-beta-3
>
>
> The only way is creating my own {{InvokerLogger}} where I set the threshold to {{DEBUG}}. Then set this logger using method: {{setLogger}}
> There could be some method: {{setDebugLoggerLevel()}} that would set the threshold automatically.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 9 months
[JBoss JIRA] (SHRINKRES-279) There is no easy way to get command that will be used for Maven build invocation
by Matous Jobanek (JIRA)
Matous Jobanek created SHRINKRES-279:
----------------------------------------
Summary: There is no easy way to get command that will be used for Maven build invocation
Key: SHRINKRES-279
URL: https://issues.jboss.org/browse/SHRINKRES-279
Project: ShrinkWrap Resolvers
Issue Type: Enhancement
Components: EmbeddedMaven
Affects Versions: 3.0.0-beta-2
Reporter: Matous Jobanek
Assignee: Matous Jobanek
Fix For: 3.0.0-beta-3
The only way is creating my own {{InvokerLogger}} where I set the threshold to {{DEBUG}}. Then set this logger using method: {{setLogger}}
There could be some method: {{setDebugLoggerLevel()}} that would set the treshold automaticaly.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 9 months
[JBoss JIRA] (SHRINKRES-277) Upgrade to maven-invoker 3.0.0
by Matous Jobanek (JIRA)
Matous Jobanek created SHRINKRES-277:
----------------------------------------
Summary: Upgrade to maven-invoker 3.0.0
Key: SHRINKRES-277
URL: https://issues.jboss.org/browse/SHRINKRES-277
Project: ShrinkWrap Resolvers
Issue Type: Component Upgrade
Components: EmbeddedMaven
Affects Versions: 3.0.0-beta-2
Reporter: Matous Jobanek
Assignee: Matous Jobanek
Fix For: 3.0.0-beta-3
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 9 months
[JBoss JIRA] (SHRINKRES-276) Gradle resolver doesn't support custom configurations
by Andreas Klemp (JIRA)
Andreas Klemp created SHRINKRES-276:
---------------------------------------
Summary: Gradle resolver doesn't support custom configurations
Key: SHRINKRES-276
URL: https://issues.jboss.org/browse/SHRINKRES-276
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Components: gradle
Affects Versions: 3.0.0-beta-2
Environment: Windows 7, Gradle 3.4, Eclipse Mars
Reporter: Andreas Klemp
Having a gradle project with additional source set and configurations, the Gradle resolver does not pickup the dependencies in the new configurations.
build.gradle snippet:
{code}
sourceSets {
integrationTest {
java {
compileClasspath += main.output
runtimeClasspath += main.output
srcDir file('src/integrationTest/java')
}
resources.srcDir file('src/integrationTest/resources')
}
}
configurations {
integrationTestCompile.extendsFrom compile
integrationTestRuntime.extendsFrom runtime
}
dependencies {
integrationTestCompile group: 'org.slf4j', name: 'slf4j-api', version: '1.7.7'
integrationTestImplementation group: 'org.slf4j', name: 'slf4j-api', version: '1.7.7'
}
{code}
No matter which of the new configurations is used, the dependecy is not resolved when searching all scopes:
{code}
Gradle.resolver()
.forProjectDirectory(".")
.importDependencies(ScopeType.values())
.resolve()
.asList(JavaArchive.class)
.stream()
.filter(a -> a.getName().contains("slf4j"))
.forEach(System.out::println);
{code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 9 months
[JBoss JIRA] (SHRINKWRAP-517) URLPackageScanner fails to close ZipFile and retains a Windows file lock
by Falko Modler (JIRA)
[ https://issues.jboss.org/browse/SHRINKWRAP-517?page=com.atlassian.jira.pl... ]
Falko Modler commented on SHRINKWRAP-517:
-----------------------------------------
Sounds good!
I want to point out that the {{ZipFile}} fix ([PR 111|https://github.com/shrinkwrap/shrinkwrap/pull/111]) is pretty obvious and does _not_ depend on JRE7+. It should therefore be merged into 1.2.7.
> URLPackageScanner fails to close ZipFile and retains a Windows file lock
> ------------------------------------------------------------------------
>
> Key: SHRINKWRAP-517
> URL: https://issues.jboss.org/browse/SHRINKWRAP-517
> Project: ShrinkWrap
> Issue Type: Bug
> Components: impl-base
> Affects Versions: 1.2.6
> Reporter: Falko Modler
>
> The method {{org.jboss.shrinkwrap.impl.base.URLPackageScanner.handleArchiveByFile(File)}} creates a {{ZipFile}} but never closes it:
> {code:java}
> private void handleArchiveByFile(File file) throws IOException, ClassNotFoundException {
> try {
> log.fine("archive: " + file);
> ZipFile zip = new ZipFile(file);
> Enumeration<? extends ZipEntry> entries = zip.entries();
> while (entries.hasMoreElements()) {
> ZipEntry entry = entries.nextElement();
> String name = entry.getName();
> if (name.startsWith(prefix + packageNamePath) && name.endsWith(SUFFIX_CLASS)
> && (addRecursively || !name.substring((prefix + packageNamePath).length() + 1).contains("/"))) {
> String className = name.replace("/", ".").substring(prefix.length(), name.length() - SUFFIX_CLASS.length());
> foundClass(className, name );
> }
> }
> } catch (ZipException e) {
> throw new RuntimeException("Error handling file " + file, e);
> }
> }
> {code}
> Solution: Close {{zip}} in {{finally}}.
> I found this problem with the help of Eclipse (which showed warning "Resource leak: 'zip' is never closed") while analyzing [why three tests are unable to delete the test archive|https://github.com/shrinkwrap/shrinkwrap/pull/109#discussion_r125...].
> Besides the fix in {{URLPackageScanner}} we need one more change to enable the deletion of the test archive in those tests: All three tests create a cusom {{URLClassLoader}} but they never close it.
> Unfortunately, {{java.net.URLClassLoader.close()}} is a JDK7+ feature but the tests are executed with JDK5.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
6 years, 9 months