[
https://issues.jboss.org/browse/SHRINKWRAP-325?page=com.atlassian.jira.pl...
]
Geoffrey De Smet edited comment on SHRINKWRAP-325 at 9/8/11 5:05 AM:
---------------------------------------------------------------------
Following "configuration by exception":
By default, it might or might include the entire test classpath, so it would includes all
compile, runtime and test dependencies (not scope provided). Note that reusing the
exploded war file will already contain compile and runtime dependencies.
ge0ffrey believes it should include the entire test classpath by default, from the pov
that a "NoClassFoundException MyTestHelper (or Mockito)" is hard to trace to
includeTestDependencies()
kwipko does not (and it's his call :)), from the pov of client-side tests don't
need it
Yet, you can override it of course in both implementations: so either way works.
Originally we thought, but that won't work due to the jars already being in the
WEB-INF/lib dir:
{code}
filterDependencies()
{code}
so it's probably something like this now:
{code}
includeTestDepedencies(
{code}
With sw filtering SHRINKWRAP-326 (a feature for a later version) you can exclude sources
or test sources files too.
was (Author: ge0ffrey):
Following "configuration by exception":
By default, it might or might include the entire test classpath, so it would includes all
compile, runtime and test dependencies (not scope provided). Note that reusing the
exploded war file will already contain compile and runtime dependencies.
ge0ffrey believes it should include the entire test classpath by default, from the pov
that a "NoClassFoundException MyTestHelper (or Mockito)" is hard to trace to
includeTestDependencies()
kwipko does not (and it's his call :)), from the pov of client-side tests don't
need it
Yet, you can override it of course.
Originally we thought, but that won't work due to the jars already being in the
WEB-INF/lib dir:
{code}
filterDependencies()
{code}
so it's probably something like this now:
{code}
includeTestDepedencies(
{code}
With sw filtering SHRINKWRAP-326 (a feature for a later version) you can exclude sources
or test sources files too.
Maven based shrinkwrap WebArchive creator that adds all WEB-INF
descriptors, classes, test classes and webapp resources too (not just dependencies and
test dependencies)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: SHRINKWRAP-325
URL:
https://issues.jboss.org/browse/SHRINKWRAP-325
Project: ShrinkWrap
Issue Type: Feature Request
Reporter: Geoffrey De Smet
Assignee: Karel Piwko
Priority: Critical
The MavenDependencyResolver is nice, but it does only half the job.
We still have to manually add "target/guvnor-webapp-5.3.0-SNAPSHOT/"
or "target/classes" and "target/test-classes" and
"src/webapp/WEB-INF/*" files etc.
But all that info is in the pom model, so it would be nice to have a feature as a facade
for that.
Something like
{code}
ShrinkWrap.createEntirelyFromMavenPom("pom.xml", includeEntireTestClasspath).
{code}
Note that it can include the entire test classpath (for helper classes under
"target/test-classes" and dependencies such as Mockito).
--
This message is automatically generated by JIRA.
For more information on JIRA, see:
http://www.atlassian.com/software/jira