[
https://issues.jboss.org/browse/SHRINKWRAP-325?page=com.atlassian.jira.pl...
]
Marek Schmidt commented on SHRINKWRAP-325:
------------------------------------------
I would say that "importPomFile" is misleading name, as it does too many things
and it is not clear what. Users would especially be confused by the fact that selecting a
different profile will have no effect on the actual imported build output.
I would suggest something like `loadEffectivePom("pom.xml",
"profile1", "profile2")' (or whatever it would be called) which
would only load the effective pom and don't import anything.
then there should be several methods, such as
importBuildOutput()
which would import target/guvnor-webapp-5.3.0-SNAPSHOT.war
and
importTestDependencies(filter)
which would do what Geoffrey wants and perhaps other methods...
ShrinkWrap.create(MavenImporter.class) that creates a WebArchive that
adds all WEB-INF descriptors, classes, test classes and webapp resources too (not just
dependencies and test dependencies)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: SHRINKWRAP-325
URL:
https://issues.jboss.org/browse/SHRINKWRAP-325
Project: ShrinkWrap
Issue Type: Feature Request
Reporter: Geoffrey De Smet
Assignee: Karel Piwko
Priority: Critical
The MavenDependencyResolver is nice, but it does only half the job.
We still have to manually add "target/guvnor-webapp-5.3.0-SNAPSHOT/"
or "target/classes" and "target/test-classes" and
"src/webapp/WEB-INF/*" files etc.
But all that info is in the pom model, so it would be nice to have a feature as a facade
for that.
Something like
{code}
ShrinkWrap.createEntirelyFromMavenPom("pom.xml", includeEntireTestClasspath).
{code}
Note that it can include the entire test classpath (for helper classes under
"target/test-classes" and dependencies such as Mockito).
--
This message is automatically generated by JIRA.
For more information on JIRA, see:
http://www.atlassian.com/software/jira