[
https://issues.jboss.org/browse/SHRINKRES-190?page=com.atlassian.jira.plu...
]
Karel Piwko resolved SHRINKRES-190.
-----------------------------------
Assignee: Karel Piwko
Resolution: Done
Pushed in
https://github.com/shrinkwrap/resolver/commit/6ffc061f4637040ac142559c2c9...
Btw, in next version, there is also support for asList(MavenCoordinate.class);
Alternatively, with JDK8 API this will be a simple lambda :-)
implements equals and hashCode methods in MavenResolvedArtifactImpl /
MavenArtifactInfoImpl
-------------------------------------------------------------------------------------------
Key: SHRINKRES-190
URL:
https://issues.jboss.org/browse/SHRINKRES-190
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.1.1
Reporter: Mathieu Lachance
Assignee: Karel Piwko
Fix For: 2.2.0-alpha-3
I'm currently to find an effective way to filter out many dependencies at once that I
could provide within a "dummy" pom.xml.
I'd like to do the following:
{code:java}
public static List<MavenResolvedArtifact>
resolveAllTestNonTransitiveDependencies() {
return Arrays.asList(
Maven.resolver()
.loadPomFromFile("pom.xml")
.importTestDependencies().resolve()
.withoutTransitivity()
.asResolvedArtifact());
}
public static List<MavenResolvedArtifact> resolveAllArquillianDependencies() {
return Arrays.asList(
Maven.resolver()
.loadPomFromFile("src/test/resources/arquillian.pom.xml")
.importTestDependencies().resolve()
.withoutTransitivity()
.asResolvedArtifact());
}
public static List<MavenResolvedArtifact>
resolveAllTestNonTransitiveNonArquillianDependencies() {
List<MavenResolvedArtifact> testDependencies =
resolveAllTestNonTransitiveDependencies();
List<MavenResolvedArtifact> arquillianDependencies =
resolveAllArquillianDependencies();
List<MavenResolvedArtifact> filteredTestDependencies = new
ArrayList<MavenResolvedArtifact>();
for (MavenResolvedArtifact testDependency : testDependencies) {
if (!arquillianDependencies.contains(testDependency)) {
filteredTestDependencies.add(testDependency);
}
}
return filteredTestDependencies;
}
{code}
The problem is that MavenResolvedArtifactImpl does not implements equals and hashCode
needed for using Collection::contains method.
I think it would be safe to delegate MavenResolvedArtifactImpl / MavenArtifactInfoImpl
equals and hashCode methods to the one defined in MavenCoordinateImpl
Thanks,
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)