5:27 p.m.
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Priority: Critical
Fix For: 1.1.0-alpha-4
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnQuery()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
// this Assert fails
Assert.assertNull(root.get(CHILD_2_NAME));
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:29 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Aslak Knutsen updated SHRINKDESC-84:
------------------------------------
Component/s: spi
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Priority: Critical
Fix For: 1.1.0-alpha-4
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnQuery()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
// this Assert fails
Assert.assertNull(root.get(CHILD_2_NAME));
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:31 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Andrew Rubinger commented on SHRINKDESC-84:
-------------------------------------------
Let's also add tests to ensure that the following methods are not acting in recursive
fashion:
getSingle
getOrCreate
removeChildren
removeChild
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Priority: Critical
Fix For: 1.1.0-alpha-4
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnQuery()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
// this Assert fails
Assert.assertNull(root.get(CHILD_2_NAME));
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:26 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Aslak Knutsen updated SHRINKDESC-84:
------------------------------------
Description:
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
was:
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnQuery()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
// this Assert fails
Assert.assertNull(root.get(CHILD_2_NAME));
}
{code}
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Priority: Critical
Fix For: 1.1.0-alpha-4
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:31 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Aslak Knutsen updated SHRINKDESC-84:
------------------------------------
Description:
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
was:
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Priority: Critical
Fix For: 1.1.0-alpha-4
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:56 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Andrew Rubinger updated SHRINKDESC-84:
--------------------------------------
Fix Version/s: (was: 1.1.0-alpha-4)
Priority: Blocker (was: Critical)
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:02 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Bartosz Majsak commented on SHRINKDESC-84:
------------------------------------------
If no one looked at it yet I can spend some time over the weekend.
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:04 p.m.
New subject: [JBoss JIRA] Assigned: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Bartosz Majsak reassigned SHRINKDESC-84:
----------------------------------------
Assignee: Bartosz Majsak
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:20 p.m.
New subject: [JBoss JIRA] Work started: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Work on SHRINKDESC-84 started by Bartosz Majsak.
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:16 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Bartosz Majsak edited comment on SHRINKDESC-84 at 9/5/11 4:16 AM:
------------------------------------------------------------------
Hi Andy, Aslak,
I worked on this task over the weekend and before making a pull request I just want to get
some kind of the confirmation that my understanding was correct.
The patterns passed to {code}T execute(Node node, Pattern... patterns){code} should form
XPath-like query, shouldn't they?
Considering following tree example:
{code}
root
1
1.1
1.1.1
1.2
2
{code}
Query formed from two node names patterns {{/1/1.1.1}} should result with no match?
I introduced two implementations for {{GetQuery}} type, one dealing with absolute queries
(which is actually desired one for mentioned cases here) and the other for relative paths.
However I haven't seen any usage for the latter yet. Also the implementation is quite
a naive matching algorithm. If you foresee usage on big trees I could introduce some kind
of bottom-up matching algorithm which should perform better.
Looking forward for your feedback.
was (Author: bmajsak):
Hi Andy,
I worked on this task over the weekend and before making a pull request I just want to get
some kind of the confirmation that my understanding was correct.
The patterns passed to {code}T execute(Node node, Pattern... patterns){code} should form
XPath-like query, shouldn't they?
Considering following tree example:
{code}
root
1
1.1
1.1.1
1.2
2
{code}
Query formed from two node names patterns {{/1/1.1.1}} should result with no match?
I introduced two implementations for {{GetQuery}} type, one dealing with absolute queries
(which is actually desired one for mentioned cases here) and the other for relative paths.
However I haven't seen any usage for the latter yet. Also the implementation is quite
a naive matching algorithm. If you foresee usage on big trees I could introduce some kind
of bottom-up matching algorithm which should perform better.
Looking forward for your feedback.
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:16 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Bartosz Majsak commented on SHRINKDESC-84:
------------------------------------------
Hi Andy,
I worked on this task over the weekend and before making a pull request I just want to get
some kind of the confirmation that my understanding was correct.
The patterns passed to {code}T execute(Node node, Pattern... patterns){code} should form
XPath-like query, shouldn't they?
Considering following tree example:
{code}
root
1
1.1
1.1.1
1.2
2
{code}
Query formed from two node names patterns {{/1/1.1.1}} should result with no match?
I introduced two implementations for {{GetQuery}} type, one dealing with absolute queries
(which is actually desired one for mentioned cases here) and the other for relative paths.
However I haven't seen any usage for the latter yet. Also the implementation is quite
a naive matching algorithm. If you foresee usage on big trees I could introduce some kind
of bottom-up matching algorithm which should perform better.
Looking forward for your feedback.
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:05 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Bartosz Majsak edited comment on SHRINKDESC-84 at 9/5/11 6:04 AM:
------------------------------------------------------------------
Hi Andy, Aslak,
I worked on this task over the weekend and before making a pull request I just want to get
some kind of the confirmation that my understanding was correct.
The patterns passed to in {{Query}} {code}T execute(Node node, Pattern... patterns){code}
should form XPath-like query, shouldn't they?
Considering following tree example:
{code}
root
1
1.1
1.1.1
1.2
2
{code}
Query formed from two node names patterns {{/1/1.1.1}} should result with no match?
I introduced two implementations for {{GetQuery}} type, one dealing with absolute queries
(which is actually desired one for mentioned cases here) and the other for relative paths.
However I haven't seen any usage for the latter yet. Also the implementation is quite
a naive matching algorithm. If you foresee usage on big trees I could introduce some kind
of bottom-up matching algorithm which should perform better.
Looking forward for your feedback.
was (Author: bmajsak):
Hi Andy, Aslak,
I worked on this task over the weekend and before making a pull request I just want to get
some kind of the confirmation that my understanding was correct.
The patterns passed to {code}T execute(Node node, Pattern... patterns){code} should form
XPath-like query, shouldn't they?
Considering following tree example:
{code}
root
1
1.1
1.1.1
1.2
2
{code}
Query formed from two node names patterns {{/1/1.1.1}} should result with no match?
I introduced two implementations for {{GetQuery}} type, one dealing with absolute queries
(which is actually desired one for mentioned cases here) and the other for relative paths.
However I haven't seen any usage for the latter yet. Also the implementation is quite
a naive matching algorithm. If you foresee usage on big trees I could introduce some kind
of bottom-up matching algorithm which should perform better.
Looking forward for your feedback.
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:47 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Andrew Rubinger commented on SHRINKDESC-84:
-------------------------------------------
Specified behaviour of GetQuery:
Given:
{code}web-app
servlets
servlet
servlet-name{code}
The following function calls and return values should hold:
{code}Get(servlets,"servlet") > servlet
Get(web-app,"servlet") > null
Get(servlet,"servlet") > null
Get(servlets,"servlet/servlet-name") > servlet-name
Get(web-app,"web-app/servlets") > null
Get(web-app,"servlets/servlet") > servlet{code}
Let's get a simple working algorithm now. The use case is for searching in spec XSDs,
so the trees aren't likely to get more than 4 or 5 levels deep; I don't think we
need to start engineering anything faster at the moment. Already because we have a slim
object model for the XML (instead of carrying around DOM or bothering with XB parsing)
we're well ahead of the speed game in design.
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:20 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Bartosz Majsak commented on SHRINKDESC-84:
------------------------------------------
Thanks,
it's more or less what I implemented now as _absolute_ get query (matching given path
starting from the root). This is used in {{Node.get(Patterns)}}. I will write some more
tests and try to create pull requests this evening CET :)
For _relative_ implementation calling {code}Get(web-app,"servlet") > servlet
{code} since I treat it in the same way as XPath version - "{{//servlet}}".
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:25 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Bartosz Majsak updated SHRINKDESC-84:
-------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/shrinkwrap/descriptors/pull/42
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:25 p.m.
New subject: [JBoss JIRA] Work stopped: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Work on SHRINKDESC-84 stopped by Bartosz Majsak.
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:29 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Bartosz Majsak edited comment on SHRINKDESC-84 at 9/5/11 4:29 PM:
------------------------------------------------------------------
My proposal is available on Github.
However I found at least two shortcomings in the current Pattern/Query approach.
Since attributes are stored as plain String->String map and node name is required in
Pattern, there is no possibility to perform queries such as:
* All nodes with given attribute(s) -> //[@id]
* All nodes with given pair (attribute,value) -> //[@id=value]
If you see such case useful please create separated task and I'll move on with the
implementation. For this issue I simply didn't want to do more speculative programming
:)
was (Author: bmajsak):
My proposal is available on Github.
However I found at least two shortcomings in the current Pattern/Query approach.
Since attributes are stored as plain String->String map there is no possibility to
perform queries such as:
* All nodes with given attribute(s) -> //[@id]
* All nodes with given pair (attribute,value) -> //[@id=value]
If you see such case useful please create separated task and I'll move on with the
implementation. For this issue I simply didn't want to do more speculative programming
:)
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:29 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Bartosz Majsak commented on SHRINKDESC-84:
------------------------------------------
My proposal is available on Github.
However I found at least two shortcomings in the current Pattern/Query approach.
Since attributes are stored as plain String->String map there is no possibility to
perform queries such as:
* All nodes with given attribute(s) -> //[@id]
* All nodes with given pair (attribute,value) -> //[@id=value]
If you see such case useful please create separated task and I'll move on with the
implementation. For this issue I simply didn't want to do more speculative programming
:)
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:49 p.m.
New subject: [JBoss JIRA] Updated: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Andrew Rubinger updated SHRINKDESC-84:
--------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 1.1.0-alpha-5
Resolution: Done
Upstream:
https://github.com/shrinkwrap/descriptors/commit/77be81a477c69d3685656e1d...
https://github.com/shrinkwrap/descriptors/commit/8ed82c896468eab53c3b0a65...
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Fix For: 1.1.0-alpha-5
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:13 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Bartosz Majsak commented on SHRINKDESC-84:
------------------------------------------
Based on our discussion in [this
commit|https://github.com/shrinkwrap/descriptors/commit/8ed82c896468eab53...]
I created two alternative implementation for Query API:
* [based on previously used enum singleton
approach|https://github.com/shrinkwrap/descriptors/pull/43]
* [based on immutable objects created by
factories|https://github.com/shrinkwrap/descriptors/pull/44]
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Fix For: 1.1.0-alpha-5
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:50 a.m.
New subject: [JBoss JIRA] Closed: (SHRINKDESC-84) Node.get(Patterns) matches recursive down the whole tree
[
https://issues.jboss.org/browse/SHRINKDESC-84?page=com.atlassian.jira.plu...
]
Andrew Rubinger closed SHRINKDESC-84.
-------------------------------------
Node.get(Patterns) matches recursive down the whole tree
--------------------------------------------------------
Key: SHRINKDESC-84
URL: https://issues.jboss.org/browse/SHRINKDESC-84
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: spi
Affects Versions: 1.1.0-alpha-3
Reporter: Aslak Knutsen
Assignee: Bartosz Majsak
Priority: Blocker
Fix For: 1.1.0-alpha-5
Node.get should only try to match the first level.
{code}
@Test
public void shouldNotMatchAChildsChildrenOnGet()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.get(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetSingle()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.getSingle(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnGetOrCreate()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME);
Node child1 = root.createChild(CHILD_1_NAME);
Node child2 = child1.createChild(CHILD_2_NAME);
Node createdChild = root.getOrCreate(CHILD_2_NAME);
Assert.assertNotSame(createdChild, child2);
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChild()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
Assert.assertNull(root.removeChild(CHILD_2_NAME));
}
@Test
public void shouldNotMatchAChildsChildrenOnRemoveChildren()
{
// /root/child1/child2
Node root = new Node(ROOT_NAME)
.createChild(CHILD_1_NAME)
.createChild(CHILD_2_NAME).getRoot();
List<Node> removed = root.removeChildren(CHILD_2_NAME);
Assert.assertNotNull(removed);
Assert.assertEquals(0, removed.size());
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4680
days inactive
4685
days old
shrinkwrap-issues@lists.jboss.org
20 comments
3 participants
participants (3)
-
Andrew Rubinger (JIRA) -
Aslak Knutsen (JIRA)
-
Bartosz Majsak (JIRA)