[JBoss JIRA] Created: (SHRINKWRAP-232) Return asset removed by delete method instead of a boolean
by Dan Allen (JIRA)
Return asset removed by delete method instead of a boolean
----------------------------------------------------------
Key: SHRINKWRAP-232
URL: https://jira.jboss.org/browse/SHRINKWRAP-232
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-11
Reporter: Dan Allen
Fix For: 1.0.0-alpha-12
The Archive#delete(ArchivePath) operation should return the Asset (or Node) being removed (at the specified ArchivePath) rather than returning boolean. This both avoids having to have an extra call to get the asset before removing it, and it's consistent with the familiar behavior of the JDK Map API.
// Removes the Asset in the archive at the specified Path and returns the removed Asset
Asset delete(ArchivePath path);
The only thing I'm not sure about is whether the Asset return type is sufficient for when you delete a directory path.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 4 months
[JBoss JIRA] Updated: (SHRINKWRAP-237) ShrinkWrap ClassLoader Caches the read Assets Inputstream
by Andrew Rubinger (JIRA)
[ https://jira.jboss.org/browse/SHRINKWRAP-237?page=com.atlassian.jira.plug... ]
Andrew Rubinger updated SHRINKWRAP-237:
---------------------------------------
Fix Version/s: 1.0.0-alpha-12
> ShrinkWrap ClassLoader Caches the read Assets Inputstream
> ---------------------------------------------------------
>
> Key: SHRINKWRAP-237
> URL: https://jira.jboss.org/browse/SHRINKWRAP-237
> Project: ShrinkWrap
> Issue Type: Bug
> Affects Versions: 1.0.0-alpha-11
> Environment: Weld 1.1.0.Beta1, Arqullian Alpha4, Seam XML Alpha3
> Reporter: Lincoln Baxter III
> Assignee: Aslak Knutsen
> Fix For: 1.0.0-alpha-12
>
>
> http://pastebin.com/3neHZ6BL
> This can be reproduced using Weld 1.1.0.Beta1, Seam XML Alpha3 and Arqullian Alpha4- create a test that attempts to add a Manifest Resources from disk to Beans.xml.
> Seam XML will attempt to load the beans file and complain that the InputStream was closed.
> @RunWith(Arquillian.class)
> public class DefaultTimeZoneTest
> {
> @Deployment
> public static JavaArchive createTestArchive()
> {
> return ShrinkWrap.create(JavaArchive.class, "test.jar")
> .addClass(DefaultTimeZoneProducer.class)
> .addClass(DefaultTimeZoneConfig.class)
> .addManifestResource("org/jboss/seam/international/test/timezone/user-timezone.xml", ArchivePaths.create("beans.xml"));
> }
> @Inject
> DateTimeZone timeZone;
> @Test
> public void testDefaultTimeZoneProducerDirect()
> {
> Assert.assertNotNull(timeZone);
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 6 months
[JBoss JIRA] Commented: (SHRINKWRAP-237) ShrinkWrap ClassLoader Caches the read Assets Inputstream
by Andrew Rubinger (JIRA)
[ https://jira.jboss.org/browse/SHRINKWRAP-237?page=com.atlassian.jira.plug... ]
Andrew Rubinger commented on SHRINKWRAP-237:
--------------------------------------------
Pushed upstream.
> ShrinkWrap ClassLoader Caches the read Assets Inputstream
> ---------------------------------------------------------
>
> Key: SHRINKWRAP-237
> URL: https://jira.jboss.org/browse/SHRINKWRAP-237
> Project: ShrinkWrap
> Issue Type: Bug
> Affects Versions: 1.0.0-alpha-11
> Environment: Weld 1.1.0.Beta1, Arqullian Alpha4, Seam XML Alpha3
> Reporter: Lincoln Baxter III
> Assignee: Aslak Knutsen
> Fix For: 1.0.0-alpha-12
>
>
> http://pastebin.com/3neHZ6BL
> This can be reproduced using Weld 1.1.0.Beta1, Seam XML Alpha3 and Arqullian Alpha4- create a test that attempts to add a Manifest Resources from disk to Beans.xml.
> Seam XML will attempt to load the beans file and complain that the InputStream was closed.
> @RunWith(Arquillian.class)
> public class DefaultTimeZoneTest
> {
> @Deployment
> public static JavaArchive createTestArchive()
> {
> return ShrinkWrap.create(JavaArchive.class, "test.jar")
> .addClass(DefaultTimeZoneProducer.class)
> .addClass(DefaultTimeZoneConfig.class)
> .addManifestResource("org/jboss/seam/international/test/timezone/user-timezone.xml", ArchivePaths.create("beans.xml"));
> }
> @Inject
> DateTimeZone timeZone;
> @Test
> public void testDefaultTimeZoneProducerDirect()
> {
> Assert.assertNotNull(timeZone);
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 6 months
[JBoss JIRA] Assigned: (SHRINKWRAP-237) ShrinkWrap ClassLoader Caches the read Assets Inputstream
by Aslak Knutsen (JIRA)
[ https://jira.jboss.org/browse/SHRINKWRAP-237?page=com.atlassian.jira.plug... ]
Aslak Knutsen reassigned SHRINKWRAP-237:
----------------------------------------
Assignee: Aslak Knutsen
> ShrinkWrap ClassLoader Caches the read Assets Inputstream
> ---------------------------------------------------------
>
> Key: SHRINKWRAP-237
> URL: https://jira.jboss.org/browse/SHRINKWRAP-237
> Project: ShrinkWrap
> Issue Type: Bug
> Affects Versions: 1.0.0-alpha-11
> Environment: Weld 1.1.0.Beta1, Arqullian Alpha4, Seam XML Alpha3
> Reporter: Lincoln Baxter III
> Assignee: Aslak Knutsen
>
> http://pastebin.com/3neHZ6BL
> This can be reproduced using Weld 1.1.0.Beta1, Seam XML Alpha3 and Arqullian Alpha4- create a test that attempts to add a Manifest Resources from disk to Beans.xml.
> Seam XML will attempt to load the beans file and complain that the InputStream was closed.
> @RunWith(Arquillian.class)
> public class DefaultTimeZoneTest
> {
> @Deployment
> public static JavaArchive createTestArchive()
> {
> return ShrinkWrap.create(JavaArchive.class, "test.jar")
> .addClass(DefaultTimeZoneProducer.class)
> .addClass(DefaultTimeZoneConfig.class)
> .addManifestResource("org/jboss/seam/international/test/timezone/user-timezone.xml", ArchivePaths.create("beans.xml"));
> }
> @Inject
> DateTimeZone timeZone;
> @Test
> public void testDefaultTimeZoneProducerDirect()
> {
> Assert.assertNotNull(timeZone);
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 6 months