[JBoss JIRA] Created: (SHRINKDESC-25) Import / Export should be able to handle unmapped entires
by Aslak Knutsen (JIRA)
Import / Export should be able to handle unmapped entires
---------------------------------------------------------
Key: SHRINKDESC-25
URL: https://jira.jboss.org/browse/SHRINKDESC-25
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Reporter: Aslak Knutsen
When using JAXB marshal/unmarshal, things that are not mapped in the JAXB model will not be exported. This means the Descriptors will have to map every possible option which is a bit tedious, and all comments etc will be gone.
The JAXB Binder should fix this according to spec/javadoc, but the RI bundled with JDK does this in a very simple way. It can map partial parts of a xml doc, but that part has to be fully mapped. but even fully mapped, comments are lost. (the complete mapped node is replaced, not merged like in EclipseLink Moxy)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] Created: (SHRINKWRAP-233) addClass with DefaultPackage opens addPackage to null arguments
by Aslak Knutsen (JIRA)
addClass with DefaultPackage opens addPackage to null arguments
---------------------------------------------------------------
Key: SHRINKWRAP-233
URL: https://jira.jboss.org/browse/SHRINKWRAP-233
Project: ShrinkWrap
Issue Type: Bug
Reporter: Aslak Knutsen
When adding a Class in addClass, we do a addPackage with a Filter to match inner classes of that class.
When adding a Class in Default package, the Package we padd to addPackage is null. Meaning addPackage can't verify non null values.
The downside is, if someone happens to add, e.g.
addPakcage(true, Package.get("some-missing-package")), addPackage will be called with null, and null means /, which means all found packages are added.
We need to split addPackage(boolean, Filter, Package...) into two methods, one external which does the null checks from the user and one internal that does not check for null(to support Class in default package).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] Created: (SHRINKWRAP-193) Should be able to 'mount' a added jar
by Aslak Knutsen (JIRA)
Should be able to 'mount' a added jar
-------------------------------------
Key: SHRINKWRAP-193
URL: https://jira.jboss.org/browse/SHRINKWRAP-193
Project: ShrinkWrap
Issue Type: Feature Request
Components: api, impl-base
Reporter: Aslak Knutsen
You can only manipulate on ShrinkWrap(open/uncompressed) archives when they are ArchiveAssets. Some times it can be useful to manipulate an existing(closed/compressed) nested archive. Add something to a library added by 'someone' else... We should support to import/mount a already added compressed library.
[code]
WebArchive war = ShrinkWrap.create(WebArchive.class)
.addLibrary(new File("blag.jar"))
JavaArchive jar = war.as(Importer.class)
.import(
JavaArchive.class,
Archivepaths.create("lib/blag.jar"))
[code]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] Created: (SHRINKWRAP-240) addServiceProvider should add class to archive
by Dan Allen (JIRA)
addServiceProvider should add class to archive
----------------------------------------------
Key: SHRINKWRAP-240
URL: https://jira.jboss.org/browse/SHRINKWRAP-240
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-11
Reporter: Dan Allen
Priority: Minor
My intuition tells me that addServiceProvider should add the service provider classes I specify to the archive. To my surprise, it does not. I can't see any scenario in which you specify a service provider for a class that isn't in the archive. For the edge case, you could always extract it manually after the call to addServiceProvider.
Currently:
addClass(MyServiceImpl.class).addServiceProvider(Service.class, MyServiceImpl.class)
Proposed:
addServiceProvider(Service.class, MyServiceImpl.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months