[JBoss JIRA] Created: (SHRINKDESC-25) Import / Export should be able to handle unmapped entires
by Aslak Knutsen (JIRA)
Import / Export should be able to handle unmapped entires
---------------------------------------------------------
Key: SHRINKDESC-25
URL: https://jira.jboss.org/browse/SHRINKDESC-25
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Reporter: Aslak Knutsen
When using JAXB marshal/unmarshal, things that are not mapped in the JAXB model will not be exported. This means the Descriptors will have to map every possible option which is a bit tedious, and all comments etc will be gone.
The JAXB Binder should fix this according to spec/javadoc, but the RI bundled with JDK does this in a very simple way. It can map partial parts of a xml doc, but that part has to be fully mapped. but even fully mapped, comments are lost. (the complete mapped node is replaced, not merged like in EclipseLink Moxy)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] Created: (SHRINKDESC-47) Support for Java 1.5
by David Allen (JIRA)
Support for Java 1.5
--------------------
Key: SHRINKDESC-47
URL: https://issues.jboss.org/browse/SHRINKDESC-47
Project: ShrinkWrap Descriptors
Issue Type: Feature Request
Components: api
Environment: Release 0.1.4
Java 1.5.0_06 (Sun)
Reporter: David Allen
The compiler plugin was setup to target Java 1.6 only. Despite ShrinkWrap and Arquillian targeting 1.5, with this project included, everything is limited to Java 1.6 environments only.
I have already re-built 0.1.4 locally with 1.5 and everything works fine. Is there some reason why Java 1.6 is required for ShrinkWrap Descriptors?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] Created: (SHRINKWRAP-233) addClass with DefaultPackage opens addPackage to null arguments
by Aslak Knutsen (JIRA)
addClass with DefaultPackage opens addPackage to null arguments
---------------------------------------------------------------
Key: SHRINKWRAP-233
URL: https://jira.jboss.org/browse/SHRINKWRAP-233
Project: ShrinkWrap
Issue Type: Bug
Reporter: Aslak Knutsen
When adding a Class in addClass, we do a addPackage with a Filter to match inner classes of that class.
When adding a Class in Default package, the Package we padd to addPackage is null. Meaning addPackage can't verify non null values.
The downside is, if someone happens to add, e.g.
addPakcage(true, Package.get("some-missing-package")), addPackage will be called with null, and null means /, which means all found packages are added.
We need to split addPackage(boolean, Filter, Package...) into two methods, one external which does the null checks from the user and one internal that does not check for null(to support Class in default package).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] Created: (SHRINKWRAP-193) Should be able to 'mount' a added jar
by Aslak Knutsen (JIRA)
Should be able to 'mount' a added jar
-------------------------------------
Key: SHRINKWRAP-193
URL: https://jira.jboss.org/browse/SHRINKWRAP-193
Project: ShrinkWrap
Issue Type: Feature Request
Components: api, impl-base
Reporter: Aslak Knutsen
You can only manipulate on ShrinkWrap(open/uncompressed) archives when they are ArchiveAssets. Some times it can be useful to manipulate an existing(closed/compressed) nested archive. Add something to a library added by 'someone' else... We should support to import/mount a already added compressed library.
[code]
WebArchive war = ShrinkWrap.create(WebArchive.class)
.addLibrary(new File("blag.jar"))
JavaArchive jar = war.as(Importer.class)
.import(
JavaArchive.class,
Archivepaths.create("lib/blag.jar"))
[code]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] Created: (SHRINKWRAP-268) MavenDependencyResolver.loadReposFromPom and loadDependenciesFromPom methods are missleading
by Karel Piwko (JIRA)
MavenDependencyResolver.loadReposFromPom and loadDependenciesFromPom methods are missleading
--------------------------------------------------------------------------------------------
Key: SHRINKWRAP-268
URL: https://issues.jboss.org/browse/SHRINKWRAP-268
Project: ShrinkWrap
Issue Type: Enhancement
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Karel Piwko
Current state:
{code}
loadReposFromPom(String file)
{code}
Loads a POM file and activates all repositories present there, moreover it loads all <dependencies> into cache so user can omit version
in artifact specification.
=> should be renamed to loadMetadataFromPom(String file) or split to loadReposFromPom(String file), loadDependencyVersionsFromPom(String file) and aggregator loadMetadataFromPom(String file)
{code}
loadDepedenciesFromPom(String file)
{code}
Loads a POM file and adds all dependencies present there to the dependency chain. This means once the resolveXYZ() is called dependencies from POM are resolved.
=> should be renamed to includeDependenciesFromPom(String file)
{code}
loadDependenciesFromPom(String file, MavenResolutionFilter filter)
{code}
Does the same as previous, filter is not used there but during resolveXYZ()
=> should be removed
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] Created: (SHRINKWRAP-275) Adding Resources via Classloader found in packaged jars results in NullPointerException
by Aslak Knutsen (JIRA)
Adding Resources via Classloader found in packaged jars results in NullPointerException
---------------------------------------------------------------------------------------
Key: SHRINKWRAP-275
URL: https://issues.jboss.org/browse/SHRINKWRAP-275
Project: ShrinkWrap
Issue Type: Bug
Components: impl-base
Affects Versions: 1.0.0-alpha-13
Reporter: Aslak Knutsen
Priority: Critical
Adding a Resource via the String representation pointing to a Resource loaded via a ClassLoader and stored in Jar results in NullPoiinterException.
{code:title=StackTrace}
java.lang.NullPointerException
at org.jboss.shrinkwrap.impl.base.container.ContainerBase.addAsManifestResource(ContainerBase.java:608)
at org.jboss.shrinkwrap.impl.base.container.ContainerBase.addAsManifestResource(ContainerBase.java:557)
at org.jboss.shrinkwrap.impl.base.container.ContainerBase.addAsManifestResource(ContainerBase.java:545)
at org.jboss.shrinkwrap.impl.base.test.DynamicContainerTestBase.testAddManifestStringTargetResourceFromJar(DynamicContainerTestBase.java:303)
{code}
{code:title=org.jboss.shrinkwrap.impl.base.test.DynamicContainerTestBase}
@Test
@ArchiveType(ManifestContainer.class)
public void testAddManifestStringTargetResourceFromJar() throws Exception {
getManifestContainer().addAsManifestResource("java/lang/String.class", "String.class");
ArchivePath testPath = new BasicPath(getManifestPath(), "String.class");
Assert.assertTrue(
"Archive should contain " + testPath,
getArchive().contains(testPath));
}
{code}
The faulty logic comes from ContainerBase.fileFromResource(String), a URL returned by CL.getResource when packaged in a Jar is not usable as a new File(url.getFile()), the returned value is in the format: file:/usr/lib/jvm/java-6-openjdk/jre/lib/rt.jar!/java/lang/String.class
The File has the following states:
* !file.isFile,
* !file.isDirectory
* !file.exists,
* file.listFiles == null
* new FileInputStream(file) throws FileNotFoundException
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months