[JBoss JIRA] (SHRINKDESC-140) Improved maven-compiler-configuration
by Michal Matloka (JIRA)
[ https://issues.jboss.org/browse/SHRINKDESC-140?page=com.atlassian.jira.pl... ]
Michal Matloka updated SHRINKDESC-140:
--------------------------------------
Description:
Subprojects override maven-compiler-plugin managed version.
Upgraded jboss-parent to version 9 because it contins upgraded plugin version (which was used by subprojects). Reduced configuration properties - default values, invalid or not needed.
was:
Subprojects override maven-compiler-plugin managed version.
Upgraded jboss-parent to version 9. Reduced configuration properties - default values, invalid or not needed.
> Improved maven-compiler-configuration
> -------------------------------------
>
> Key: SHRINKDESC-140
> URL: https://issues.jboss.org/browse/SHRINKDESC-140
> Project: ShrinkWrap Descriptors
> Issue Type: Enhancement
> Reporter: Michal Matloka
> Assignee: Michal Matloka
> Priority: Minor
>
> Subprojects override maven-compiler-plugin managed version.
> Upgraded jboss-parent to version 9 because it contins upgraded plugin version (which was used by subprojects). Reduced configuration properties - default values, invalid or not needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (SHRINKDESC-140) Improved maven-compiler-configuration
by Michal Matloka (JIRA)
Michal Matloka created SHRINKDESC-140:
-----------------------------------------
Summary: Improved maven-compiler-configuration
Key: SHRINKDESC-140
URL: https://issues.jboss.org/browse/SHRINKDESC-140
Project: ShrinkWrap Descriptors
Issue Type: Enhancement
Reporter: Michal Matloka
Assignee: Michal Matloka
Priority: Minor
Subprojects override maven-compiler-plugin managed version.
Upgraded jboss-parent to version 9. Reduced configuration properties - default values, invalid or not needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (SHRINKDESC-21) descriptor read-only mode
by Michal Matloka (JIRA)
[ https://issues.jboss.org/browse/SHRINKDESC-21?page=com.atlassian.jira.plu... ]
Michal Matloka reassigned SHRINKDESC-21:
----------------------------------------
Assignee: Michal Matloka
> descriptor read-only mode
> -------------------------
>
> Key: SHRINKDESC-21
> URL: https://issues.jboss.org/browse/SHRINKDESC-21
> Project: ShrinkWrap Descriptors
> Issue Type: Feature Request
> Components: api
> Affects Versions: 0.1.0
> Reporter: Dan Allen
> Assignee: Michal Matloka
>
> The import procedure should support a read-only mode. The returned descriptor type would only have the read methods and none of the fluent modifier methods. This would be useful in a framework that is providing access to a descriptor for inspection only (such as a framework consuming a descriptor for the purpose of configuration).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (SHRINKDESC-89) Improve test code readability by introducing assertion DSL
by Michal Matloka (JIRA)
[ https://issues.jboss.org/browse/SHRINKDESC-89?page=com.atlassian.jira.plu... ]
Michal Matloka reassigned SHRINKDESC-89:
----------------------------------------
Assignee: Michal Matloka (was: Bartosz Majsak)
> Improve test code readability by introducing assertion DSL
> ----------------------------------------------------------
>
> Key: SHRINKDESC-89
> URL: https://issues.jboss.org/browse/SHRINKDESC-89
> Project: ShrinkWrap Descriptors
> Issue Type: Task
> Components: test
> Affects Versions: 1.1.0-alpha-5
> Reporter: Bartosz Majsak
> Assignee: Michal Matloka
> Priority: Optional
> Labels: testing
>
> Improving tests assertion might bring few benefits for us, such as:
> * more concise tests focused on the functionality
> * better readability and understanding of the tests (and the way how our tool works in general [which might be really handy for newcomers]), also by using domain-specific assertions
> * easier maintenance
> For instance for Node assertions we could have:
> {code}
> assertThat(root.getChildren()).containsOnly(CHILD_1, CHILD_2)
> {code}
> or even something more fancy
> {code}
> assertThat(node).isAccessibleFrom(otherNode)
> {code}
> Two options worth considering are:
> * [Hamcrest|http://code.google.com/p/hamcrest/] (bundled with JUnit as of 4.4)
> * [FEST-Assert|http://docs.codehaus.org/display/FEST/Fluent+Assertions+Module]
> I would rather go with the latter. Its' fluent interface DSL is somehow easier to use in tests.
> When it comes to dependencies, here's the full list:
> {code}
> org.easytesting:fest-assert:jar:1.3
> org.easytesting:fest-util:jar:1.1.4 (compile)
> org.easytesting:fest-reflect:jar:1.2 (test)
> org.easytesting:fest-test:jar:1.2.1 (test)
> junit:junit:jar:4.7 (test)
> org.easytesting:fest-mocks:jar:1.1.1 (test)
> org.easymock:easymockclassextension:jar:2.4 (test)
> org.easymock:easymock:jar:2.4 (test)
> cglib:cglib-nodep:jar:2.1_3 (test)
> org.easymock:easymock:jar:2.4 (test)
> junit:junit:jar:4.7 (test)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (SHRINKWRAP-243) Dependencies does not find remote repositories set in settings.xml
by jay shaughnessy (JIRA)
[ https://issues.jboss.org/browse/SHRINKWRAP-243?page=com.atlassian.jira.pl... ]
jay shaughnessy commented on SHRINKWRAP-243:
--------------------------------------------
has the fix version been corrected? I have resolver 1.0.0-beta-7 in my M2 repo yet I seem to be hit by this. Or is perhpas because we encounter the problem only on jenkins runs, which has additional proxy situation described here:
http://stackoverflow.com/questions/6291146/arquillian-shrinkwrap-mavendep...
To get around this I was able to add resolver.goOffline() at the problem point, because at that point I am assured of the dep being in the local repo. This seems to work.
> Dependencies does not find remote repositories set in settings.xml
> ------------------------------------------------------------------
>
> Key: SHRINKWRAP-243
> URL: https://issues.jboss.org/browse/SHRINKWRAP-243
> Project: ShrinkWrap
> Issue Type: Feature Request
> Components: ext-resolver
> Reporter: Aslak Knutsen
> Assignee: Karel Piwko
> Fix For: 1.0.0-alpha-12
>
>
> Using activeDefault profiles in settings.xml does not seem to be included in the remote repository resolution in Dependencies.
> e.g.
> .m2/settings.xml
> <profiles>
> <profile>
> <activation>
> <activeByDefault>true</activeByDefault>
> </activation>
> <repositories>
> <repository>
> <id>jboss-public-repository-group</id>
> <name>JBoss Public Repository Group</name>
> <url>http://repository.jboss.org/nexus/content/groups/public/</url>
> <layout>default</layout>
> <releases>
> <enabled>true</enabled>
> <updatePolicy>never</updatePolicy>
> </releases>
> <snapshots>
> <enabled>true</enabled>
> <updatePolicy>never</updatePolicy>
> </snapshots>
> </repository>
> </repositories>
> <pluginRepositories>
> <pluginRepository>
> <id>jboss-public-repository-group</id>
> <name>JBoss Public Repository Group</name>
> <url>http://repository.jboss.org/nexus/content/groups/public/</url>
> <releases>
> <enabled>true</enabled>
> </releases>
> <snapshots>
> <enabled>true</enabled>
> </snapshots>
> </pluginRepository>
> </pluginRepositories>
> </profile>
> </profiles>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (SHRINKRES-93) Tests fails under windows and RHEL 6
by Michal Matloka (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-93?page=com.atlassian.jira.plug... ]
Michal Matloka edited comment on SHRINKRES-93 at 12/20/12 10:57 AM:
--------------------------------------------------------------------
{noformat}
Tests in error:
shouldFailWhileNotReadingReactor(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
packagedArtifactShouldNotContainBackslashes(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
shouldBeAbleToLoadArtifactDirectlyFromClassPath(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
shouldHaveCentralMavenRepositoryDisabled(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
control(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
offlineProgramatically(org.jboss.shrinkwrap.resolver.impl.maven.integration.OfflineRepositoryTestCase): Unable to collect dependency tree for given dependencies, reason: Failed to collect dependencies for [junit:junit:jar:3.8.2 (compile)]
Tests run: 92, Failures: 0, Errors: 6, Skipped: 0
{noformat}
was (Author: mmatloka):
{noformat}
shouldFailWhileNotReadingReactor(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
packagedArtifactShouldNotContainBackslashes(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
shouldBeAbleToLoadArtifactDirectlyFromClassPath(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
shouldHaveCentralMavenRepositoryDisabled(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
control(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
offlineProgramatically(org.jboss.shrinkwrap.resolver.impl.maven.integration.OfflineRepositoryTestCase): Unable to collect dependency tree for given dependencies, reason: Failed to collect dependencies for [junit:junit:jar:3.8.2 (compile)]
{noformat}
> Tests fails under windows and RHEL 6
> ------------------------------------
>
> Key: SHRINKRES-93
> URL: https://issues.jboss.org/browse/SHRINKRES-93
> Project: ShrinkWrap Resolvers
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha-5
> Environment: win7 x64
> RHEL 6
> Reporter: Michal Matloka
> Assignee: Andrew Rubinger
>
> I've tried to build today resolvers from both linux and windows.
>
> On Linux build successfully! On Eclipse on windows all tests passes! but, when building on windows from maven (cmd/cygwin) some tests fails.
> {noformat}
> Tests in error:
> shouldBeAbleToLoadArtifactDirectlyFromClassPath(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
> shouldFailWhileNotReadingReactor(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
> shouldHaveCentralMavenRepositoryDisabled(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
> control(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
> offlineProgramatically(org.jboss.shrinkwrap.resolver.impl.maven.integration.OfflineRepositoryTestCase): Unable to collect dependency tree for given dependencies, reason: Failed to collect dependencies for [junit:junit:jar:3.8.2 (compile)]
> {noformat}
> e.g.
> {noformat}
> shouldBeAbleToLoadArtifactDirectlyFromClassPath(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase) Time elapsed: 0.696 sec <<< ERROR!
> org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException: Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
> 1/ [FATAL] Non-resolvable parent POM for org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-parent:2.0.0-alpha-6-SNAPSHOT: Failed to resolve POM for org.jboss:jboss-parent:8 due to Could not find artifact org.jboss:jboss-parent:pom:8 in central (http://repo1.maven.org/maven2) and 'parent.relativePath' points at wrong local POM @ org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-parent:2.0.0-alpha-6-SNAPSHOT, I:\Dev\JBoss\shrinkwrap resolver\pom.xml
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (SHRINKRES-93) Tests fails under windows and RHEL 6
by Michal Matloka (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-93?page=com.atlassian.jira.plug... ]
Michal Matloka commented on SHRINKRES-93:
-----------------------------------------
{noformat}
shouldFailWhileNotReadingReactor(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
packagedArtifactShouldNotContainBackslashes(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
shouldBeAbleToLoadArtifactDirectlyFromClassPath(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
shouldHaveCentralMavenRepositoryDisabled(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
control(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
offlineProgramatically(org.jboss.shrinkwrap.resolver.impl.maven.integration.OfflineRepositoryTestCase): Unable to collect dependency tree for given dependencies, reason: Failed to collect dependencies for [junit:junit:jar:3.8.2 (compile)]
{noformat}
> Tests fails under windows and RHEL 6
> ------------------------------------
>
> Key: SHRINKRES-93
> URL: https://issues.jboss.org/browse/SHRINKRES-93
> Project: ShrinkWrap Resolvers
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha-5
> Environment: win7 x64
> RHEL 6
> Reporter: Michal Matloka
> Assignee: Andrew Rubinger
>
> I've tried to build today resolvers from both linux and windows.
>
> On Linux build successfully! On Eclipse on windows all tests passes! but, when building on windows from maven (cmd/cygwin) some tests fails.
> {noformat}
> Tests in error:
> shouldBeAbleToLoadArtifactDirectlyFromClassPath(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
> shouldFailWhileNotReadingReactor(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
> shouldHaveCentralMavenRepositoryDisabled(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
> control(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
> offlineProgramatically(org.jboss.shrinkwrap.resolver.impl.maven.integration.OfflineRepositoryTestCase): Unable to collect dependency tree for given dependencies, reason: Failed to collect dependencies for [junit:junit:jar:3.8.2 (compile)]
> {noformat}
> e.g.
> {noformat}
> shouldBeAbleToLoadArtifactDirectlyFromClassPath(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase) Time elapsed: 0.696 sec <<< ERROR!
> org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException: Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
> 1/ [FATAL] Non-resolvable parent POM for org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-parent:2.0.0-alpha-6-SNAPSHOT: Failed to resolve POM for org.jboss:jboss-parent:8 due to Could not find artifact org.jboss:jboss-parent:pom:8 in central (http://repo1.maven.org/maven2) and 'parent.relativePath' points at wrong local POM @ org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-parent:2.0.0-alpha-6-SNAPSHOT, I:\Dev\JBoss\shrinkwrap resolver\pom.xml
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (SHRINKRES-94) Shrinkwrap creates zip files respecting the FileSystem delimiter when resolving dependencies as files
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-94?page=com.atlassian.jira.plug... ]
Karel Piwko resolved SHRINKRES-94.
----------------------------------
Fix Version/s: 2.0.0-alpha-7
Resolution: Done
Fixed in https://github.com/shrinkwrap/resolver/commit/319ccf8341a8219ff1c854755d7...
> Shrinkwrap creates zip files respecting the FileSystem delimiter when resolving dependencies as files
> -----------------------------------------------------------------------------------------------------
>
> Key: SHRINKRES-94
> URL: https://issues.jboss.org/browse/SHRINKRES-94
> Project: ShrinkWrap Resolvers
> Issue Type: Feature Request
> Affects Versions: 2.0.0-alpha-5
> Environment: Windows 7, mvn 3.0.4 and eclipse indigo
> Reporter: José Freitas
> Assignee: Karel Piwko
> Fix For: 2.0.0-alpha-7
>
>
> Shrinkwrap-maven-resolver does a zip file manually when resolving a dependency as a file, and it respect the FS delimiter.
> When the user is on a windows machine and probably gets both \ and / delimeters at the project, the classpath gets wrong and thus the generated file does not work.
> https://github.com/kpiwko/resolver/blob/master/impl-maven/src/main/java/o...
> above you can see the conversation where we found the bug:
> <jose_freitas> kpiwko, I'm using shinrkwrap maven resolver 2.0.0-alpha-1
> <jose_freitas> and I noticed that when it's resolving a workspace dependency
> <jose_freitas> for some reason the generated jar doesn't work as expected
> <jose_freitas> what are you using to generate the archive in the workspace?
> <jose_freitas> when running the test outside eclipse, it works. Inside it, the deployed jar have some weird behaviours
> <jose_freitas> like CNF when class is there, and recently I had a problem when JSFAnnotationProccess run through the assembled class
> <kpiwko> jose_freitas: hello
> <jose_freitas> hello
> <jose_freitas> :)
> <kpiwko> jose_freitas: so your jar depends on other module of a project?
> <jose_freitas> yeah, the @deployment archive is resolving a dependency that's on my workspace
> <kpiwko> shrinkwrap has nothing in common with [x] resolve dependencies from workspace
> <kpiwko> it uses classpath
> <kpiwko> I have no idea how it works in case of eclipse
> <jose_freitas> hm...
> <kpiwko> is it possible that you have your workspace dependency in a local maven repository with a same version but different content?
> <jose_freitas> nope
> <kpiwko> let me guess another try
> <kpiwko> if it works on cli, but not in ide
> <jose_freitas> so the maven-resolver is resolving the snapshot by itself?
> <kpiwko> yes
> <jose_freitas> what's very weird, that apparently, the jar is ok
> <jose_freitas> all the classes are there
> <kpiwko> well, if a snapshot is another module, it goes through classpath trying to find out a pom.xml file and use it
> <kpiwko> in that case, what happens if you disable autocompiling feature?
> <kpiwko> (it works by importing from filesystem and maybe ide accessed the same files during packaging)
> <jose_freitas> I was thinking about the compilation problem, and I was wondering that when publishing to jboss through jbosstools, the jar generation works
> <jose_freitas> I changed the IDE mvn version to the same I use at cli
> <jose_freitas> still, when it generates the jar it's broken
> <jose_freitas> https://dl.dropbox.com/u/3092390/notworking.war
> <jose_freitas> https://dl.dropbox.com/u/3092390/working.war
> <jose_freitas> try it yourself
> <jose_freitas> they are basically the same
> <jose_freitas> with the same files
> <jose_freitas> there are some little differences in size though
> <kpiwko> my jardiff tool says that there's a different z???-faces in there
> <jose_freitas> yes
> <jose_freitas> the z???-faces was generated through maven-resolver
> <jose_freitas> to create the test
> <kpiwko> let me check how z??? faces differ themselves
> <jose_freitas> .addAsLibraries(
> <jose_freitas> DependencyResolvers.use(MavenDependencyResolver.class).loadEffectivePom("pom.xml")
> <jose_freitas> .artifact("br.com.????.pd.z???:z???-faces")
> <jose_freitas> .resolveAsFiles())
> <jose_freitas> notworking.war was generated in IDE
> <jose_freitas> working.war in CLI
> <jose_freitas> the same test
> <kpiwko> damn, my tool is not working
> <kpiwko> it complains jar is using backslashes instead of slashes
> <kpiwko> give me a few secs
> <jose_freitas> yeap
> <jose_freitas> I didn't find why there's a difference though
> <kpiwko> so if you unzip the jar a package it with jar tool, it works?
> <kpiwko> do you have code snippet that generates jar handy?
> <jose_freitas> manually, you mena?
> <jose_freitas> mean*
> <kpiwko> yes
> <jose_freitas> no, but I can generate it through jdk
> <jose_freitas> lemme try
> <kpiwko> jose_freitas: I think this will happen in newer versions as well
> <jose_freitas> kpiwko, I made two tests
> <kpiwko> in alpha-6, there is PackageDirHelper
> <kpiwko> which transform a directory into a jar
> <jose_freitas> hmm
> <kpiwko> a which respects filesystem path delimiter
> <jose_freitas> but then I would need to resolve its dependencies as well
> <kpiwko> which is wrong for jar
> <kpiwko> I have to check where is the impl in alpha-1
> <jose_freitas> ok
> <jose_freitas> I made two tests with it
> <jose_freitas> 1) generated a jar from "eclipse -> export "
> <jose_freitas> and the generated jar worked
> <jose_freitas> 2) I unzipped the jar and then created a new one with extracted folder "jar cvf zf.jar foldername"
> <jose_freitas> it didn't work
> <jose_freitas> and it had a similar error
> <jose_freitas> for some reason, I think that the problem is the generated classes
> <jose_freitas> not the archive
> <jose_freitas> gut feeling
> <kpiwko> jose_freitas: I think that in alpha-1, the problem lies here ./impl-maven/src/main/java/org/jboss/shrinkwrap/resolver/impl/maven/util/IOUtil.java
> <kpiwko> jose_freitas: we do a zip file manually, but we respect fs delimiter
> <jose_freitas> hm...
> <kpiwko> as you get both \ and / delimeters in your project, the classpath is wrong and thus the war does not wrong
> <kpiwko> *work
> <kpiwko> (my suggestion)
> <kpiwko> your test case 2) actually confirms my suggestion
> <kpiwko> eclipse exporter correctly ignores \ and simply puts /, as recommended in java
> <kpiwko> we can easily fix that in ShrinkWrap
> <jose_freitas> that would be nice
> <kpiwko> can you file a bug here at issues.jboss.org/browse/SHRINKRES and preferably paste our conversation? I think we can get it into next release
> <jose_freitas> thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (SHRINKRES-93) Tests fails under windows and RHEL 6
by Karel Piwko (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-93?page=com.atlassian.jira.plug... ]
Karel Piwko commented on SHRINKRES-93:
--------------------------------------
I applied following https://github.com/shrinkwrap/resolver/commit/28699514b1b136887506f8d37db..., since I have another issue on windows related to local repository not being picked up correctly.
> Tests fails under windows and RHEL 6
> ------------------------------------
>
> Key: SHRINKRES-93
> URL: https://issues.jboss.org/browse/SHRINKRES-93
> Project: ShrinkWrap Resolvers
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha-5
> Environment: win7 x64
> RHEL 6
> Reporter: Michal Matloka
> Assignee: Andrew Rubinger
>
> I've tried to build today resolvers from both linux and windows.
>
> On Linux build successfully! On Eclipse on windows all tests passes! but, when building on windows from maven (cmd/cygwin) some tests fails.
> {noformat}
> Tests in error:
> shouldBeAbleToLoadArtifactDirectlyFromClassPath(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
> shouldFailWhileNotReadingReactor(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
> shouldHaveCentralMavenRepositoryDisabled(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Unexpected exception, expected<org.jboss.shrinkwrap.resolver.api.NoResolvedResultException> but was<org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException>
> control(org.jboss.shrinkwrap.resolver.impl.maven.integration.DisabledCentralRepositoryTestCase): Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
> offlineProgramatically(org.jboss.shrinkwrap.resolver.impl.maven.integration.OfflineRepositoryTestCase): Unable to collect dependency tree for given dependencies, reason: Failed to collect dependencies for [junit:junit:jar:3.8.2 (compile)]
> {noformat}
> e.g.
> {noformat}
> shouldBeAbleToLoadArtifactDirectlyFromClassPath(org.jboss.shrinkwrap.resolver.impl.maven.integration.ClasspathWorkspaceReaderTestCase) Time elapsed: 0.696 sec <<< ERROR!
> org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException: Found 1 problems while building POM model from I:\Dev\JBoss\shrinkwrap resolver\impl-maven\pom.xml
> 1/ [FATAL] Non-resolvable parent POM for org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-parent:2.0.0-alpha-6-SNAPSHOT: Failed to resolve POM for org.jboss:jboss-parent:8 due to Could not find artifact org.jboss:jboss-parent:pom:8 in central (http://repo1.maven.org/maven2) and 'parent.relativePath' points at wrong local POM @ org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-parent:2.0.0-alpha-6-SNAPSHOT, I:\Dev\JBoss\shrinkwrap resolver\pom.xml
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months