March 2012 - shrinkwrap-issues - Jboss List Archives

[JBoss JIRA] (SHRINKWRAP-329) Arquillian should fail-fast when adding the same resource twice to an archive made with ExplodedImporter.class

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-329?page=com.atlassian.jira.pl... ] Andrew Rubinger resolved SHRINKWRAP-329. ---------------------------------------- Assignee: Andrew Rubinger Fix Version/s: 1.1.0-alpha-X Resolution: Done Upstream: https://github.com/shrinkwrap/shrinkwrap/commit/ec8f953a800fdf6ded0f185dd... > Arquillian should fail-fast when adding the same resource twice to an archive made with ExplodedImporter.class > -------------------------------------------------------------------------------------------------------------- > > Key: SHRINKWRAP-329 > URL: https://issues.jboss.org/browse/SHRINKWRAP-329 > Project: ShrinkWrap > Issue Type: Bug > Reporter: Geoffrey De Smet > Assignee: Andrew Rubinger > Priority: Minor > Fix For: 1.1.0-alpha-X > > > This didn't fail fast for me: > {code} > @Deployment > public static WebArchive createDeployment() { > WebArchive webArchive = ShrinkWrap.create(ExplodedImporter.class, "guvnor-webapp-5.3.0-SNAPSHOT.war") > .importDirectory(new File("target/guvnor-webapp-5.3.0-SNAPSHOT/")) // already contains WEB-INF/classes/META-INF/beans.xml > .as(WebArchive.class) > .addAsResource(new File("target/test-classes/META-INF/test-beans.xml"), "WEB-INF/classes/META-INF/beans.xml") > ... > return webArchive; > } > {code} > Surprisingly, the second beans.xml didn't even overwrite the first one either. The second beans.xml was just ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-329) Arquillian should fail-fast when adding the same resource twice to an archive made with ExplodedImporter.class

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-329?page=com.atlassian.jira.pl... ] Andrew Rubinger updated SHRINKWRAP-329: --------------------------------------- Comment: was deleted (was: Conflicts with current tests for SHRINKWRAP-187, which essentially put into place a no-op in case of overwrite. Change those tests to instead look for an exception.) > Arquillian should fail-fast when adding the same resource twice to an archive made with ExplodedImporter.class > -------------------------------------------------------------------------------------------------------------- > > Key: SHRINKWRAP-329 > URL: https://issues.jboss.org/browse/SHRINKWRAP-329 > Project: ShrinkWrap > Issue Type: Bug > Reporter: Geoffrey De Smet > Priority: Minor > > This didn't fail fast for me: > {code} > @Deployment > public static WebArchive createDeployment() { > WebArchive webArchive = ShrinkWrap.create(ExplodedImporter.class, "guvnor-webapp-5.3.0-SNAPSHOT.war") > .importDirectory(new File("target/guvnor-webapp-5.3.0-SNAPSHOT/")) // already contains WEB-INF/classes/META-INF/beans.xml > .as(WebArchive.class) > .addAsResource(new File("target/test-classes/META-INF/test-beans.xml"), "WEB-INF/classes/META-INF/beans.xml") > ... > return webArchive; > } > {code} > Surprisingly, the second beans.xml didn't even overwrite the first one either. The second beans.xml was just ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-329) Arquillian should fail-fast when adding the same resource twice to an archive made with ExplodedImporter.class

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-329?page=com.atlassian.jira.pl... ] Andrew Rubinger commented on SHRINKWRAP-329: -------------------------------------------- Requires API changes (ie introduction of an Exception to fail-fast), thus cannot take place in 1.0.0; instead to 1.1.x. > Arquillian should fail-fast when adding the same resource twice to an archive made with ExplodedImporter.class > -------------------------------------------------------------------------------------------------------------- > > Key: SHRINKWRAP-329 > URL: https://issues.jboss.org/browse/SHRINKWRAP-329 > Project: ShrinkWrap > Issue Type: Bug > Reporter: Geoffrey De Smet > Priority: Minor > > This didn't fail fast for me: > {code} > @Deployment > public static WebArchive createDeployment() { > WebArchive webArchive = ShrinkWrap.create(ExplodedImporter.class, "guvnor-webapp-5.3.0-SNAPSHOT.war") > .importDirectory(new File("target/guvnor-webapp-5.3.0-SNAPSHOT/")) // already contains WEB-INF/classes/META-INF/beans.xml > .as(WebArchive.class) > .addAsResource(new File("target/test-classes/META-INF/test-beans.xml"), "WEB-INF/classes/META-INF/beans.xml") > ... > return webArchive; > } > {code} > Surprisingly, the second beans.xml didn't even overwrite the first one either. The second beans.xml was just ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-329) Arquillian should fail-fast when adding the same resource twice to an archive made with ExplodedImporter.class

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-329?page=com.atlassian.jira.pl... ] Andrew Rubinger commented on SHRINKWRAP-329: -------------------------------------------- Conflicts with current tests for SHRINKWRAP-187, which essentially put into place a no-op in case of overwrite. Change those tests to instead look for an exception. > Arquillian should fail-fast when adding the same resource twice to an archive made with ExplodedImporter.class > -------------------------------------------------------------------------------------------------------------- > > Key: SHRINKWRAP-329 > URL: https://issues.jboss.org/browse/SHRINKWRAP-329 > Project: ShrinkWrap > Issue Type: Bug > Reporter: Geoffrey De Smet > Priority: Minor > > This didn't fail fast for me: > {code} > @Deployment > public static WebArchive createDeployment() { > WebArchive webArchive = ShrinkWrap.create(ExplodedImporter.class, "guvnor-webapp-5.3.0-SNAPSHOT.war") > .importDirectory(new File("target/guvnor-webapp-5.3.0-SNAPSHOT/")) // already contains WEB-INF/classes/META-INF/beans.xml > .as(WebArchive.class) > .addAsResource(new File("target/test-classes/META-INF/test-beans.xml"), "WEB-INF/classes/META-INF/beans.xml") > ... > return webArchive; > } > {code} > Surprisingly, the second beans.xml didn't even overwrite the first one either. The second beans.xml was just ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-329) Arquillian should fail-fast when adding the same resource twice to an archive made with ExplodedImporter.class

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-329?page=com.atlassian.jira.pl... ] Andrew Rubinger commented on SHRINKWRAP-329: -------------------------------------------- I think fail-fast is really what should be done, unless there's an overwrite flag in place. > Arquillian should fail-fast when adding the same resource twice to an archive made with ExplodedImporter.class > -------------------------------------------------------------------------------------------------------------- > > Key: SHRINKWRAP-329 > URL: https://issues.jboss.org/browse/SHRINKWRAP-329 > Project: ShrinkWrap > Issue Type: Bug > Reporter: Geoffrey De Smet > Priority: Minor > > This didn't fail fast for me: > {code} > @Deployment > public static WebArchive createDeployment() { > WebArchive webArchive = ShrinkWrap.create(ExplodedImporter.class, "guvnor-webapp-5.3.0-SNAPSHOT.war") > .importDirectory(new File("target/guvnor-webapp-5.3.0-SNAPSHOT/")) // already contains WEB-INF/classes/META-INF/beans.xml > .as(WebArchive.class) > .addAsResource(new File("target/test-classes/META-INF/test-beans.xml"), "WEB-INF/classes/META-INF/beans.xml") > ... > return webArchive; > } > {code} > Surprisingly, the second beans.xml didn't even overwrite the first one either. The second beans.xml was just ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 2 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues March 2012