[JBoss JIRA] (SHRINKRES-62) MavenImporter should support shrinkwrap filtering
by Bernard Labno (JIRA)
[ https://issues.jboss.org/browse/SHRINKRES-62?page=com.atlassian.jira.plug... ]
Bernard Labno edited comment on SHRINKRES-62 at 2/27/13 9:02 AM:
-----------------------------------------------------------------
maven-war-plugin has cute method [AbstractWarPackagingTask|http://svn.apache.org/viewvc/maven/plugins/tags/... on line 342.
It uses DirectoryScanner (plexus-utils) that scans directory and returns list of paths that match to both includes and excludes. It's smart enough to work with both regex and ant-like path expressions.
Besides it has pre-defined list of default excludes. I think this might be hard for us to copy this behavior. It would be best to reuse maven-war-plugin classes for our packaging, or at least DirectoryScanner?
What do you think Karel?
was (Author: blabno):
maven-war-plugin has cute method [AbstractWarPackagingTask|http://svn.apache.org/viewvc/maven/plugins/tags/... on line 342.
It uses DirectoryScanner (plexus-utils) that scans directory and returns list of paths that match to both includes and excludes. It's smart enough to work with both regex and ant-like path expressions.
Besides it has pre-defined list of default excludes. I think this might be hard for us to copy this behavior. It would be best to reuse maven-war-plugin classes for our packaging.
What do you think Karel?
> MavenImporter should support shrinkwrap filtering
> -------------------------------------------------
>
> Key: SHRINKRES-62
> URL: https://issues.jboss.org/browse/SHRINKRES-62
> Project: ShrinkWrap Resolvers
> Issue Type: Feature Request
> Components: api-maven
> Reporter: Karel Piwko
> Assignee: Bernard Labno
> Priority: Minor
> Labels: api-change
>
> Discussed with kpiwko while designing the api for SHRINKWRAP-325.
> Should be able to include/exclude any main/test class/resource/webapp-resource.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (SHRINKRES-112) MavenImporter ignores AcceptScopesStrategy for dependency inclusion
by Karel Piwko (JIRA)
Karel Piwko created SHRINKRES-112:
-------------------------------------
Summary: MavenImporter ignores AcceptScopesStrategy for dependency inclusion
Key: SHRINKRES-112
URL: https://issues.jboss.org/browse/SHRINKRES-112
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Components: impl-maven
Affects Versions: 2.0.0-beta-2
Reporter: Karel Piwko
AcceptScopesStrategy is not correctly propagated:
{code}
@Deployment(testable = false)
public static WebArchive createDeployment()
{
return ShrinkWrap.create(MavenImporter.class)
.loadPomFromFile("pom.xml")
.importBuildOutput(new AcceptScopesStrategy(ScopeType.COMPILE, ScopeType.RUNTIME))
.as(WebArchive.class);
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (SHRINKRES-111) MavenImporter does not handle overlays configuration from war-plugin
by Karel Piwko (JIRA)
Karel Piwko created SHRINKRES-111:
-------------------------------------
Summary: MavenImporter does not handle overlays configuration from war-plugin
Key: SHRINKRES-111
URL: https://issues.jboss.org/browse/SHRINKRES-111
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Components: impl-maven
Affects Versions: 2.0.0-beta-2
Reporter: Karel Piwko
When importing a pom.xml that defines an overlay via MavenImporter, this configuration is ignored.
{code:xml}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-war-plugin</artifactId>
<configuration>
<overlays>
<overlay>
<groupId>com.blah</groupId>
<artifactId>common-web-resources</artifactId>
<excludes>
<exclude>META-INF/**</exclude>
<exclude>WEB-INF/lib/**</exclude>
</excludes>
</overlay>
</overlays>
</configuration>
</plugin>
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (SHRINKWRAP-433) Race condition deadlock in TarGz Exporter
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/SHRINKWRAP-433?page=com.atlassian.jira.pl... ]
RH Bugzilla Integration commented on SHRINKWRAP-433:
----------------------------------------------------
Karel Piwko <kpiwko(a)redhat.com> made a comment on [bug 875031|https://bugzilla.redhat.com/show_bug.cgi?id=875031]
Marek, given the information we have we should update to 1.1.1. It should be compatible for our purposes.
> Race condition deadlock in TarGz Exporter
> -----------------------------------------
>
> Key: SHRINKWRAP-433
> URL: https://issues.jboss.org/browse/SHRINKWRAP-433
> Project: ShrinkWrap
> Issue Type: Bug
> Components: impl-base
> Affects Versions: 1.0.1
> Environment: RHEL6 32bit + Oracle JDK 6, Oracle JDK 7, OpenJDK 7
> Windows 2008 32 bit + Oracle JDK 7
> Solaris 10 32 bit + Oracle JDK 6, Oracle JDK 7
> Reporter: Karel Piwko
> Assignee: Michal Matloka
> Fix For: 1.1.1
>
>
> There is a deadlock which is triggered on various platforms concerning handling of TarGz archives. Concerned environments are listed in the environment field.
> Following error is logged by Jenkins
> {code}
> 11:48:05 Running org.jboss.shrinkwrap.impl.base.exporter.TarGzExporterTestCase
> 16:45:04 Build timed out (after 300 minutes). Marking the build as aborted.
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months