March 2014 - shrinkwrap-issues - Jboss List Archives

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-151: -------------------------------------------- Yes ! It's perfect! Excellent job Ralf! :D > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-151) Descriptors should generate a common parent for different spec versions

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-151?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-151: -------------------------------------------- Hi Lincoln and George Can you have a look in https://github.com/rbattenfeld/descriptors/tree/SHRINKDESC-151 ? Here you can see the common packages approach. It would be great if you can verify that this works in your environment. I will then finalize it, squash all sub commits into one commit, and finallly, sending a PR after months of weekend works :-) Tx, Ralf > Descriptors should generate a common parent for different spec versions > ----------------------------------------------------------------------- > > Key: SHRINKDESC-151 > URL: https://issues.jboss.org/browse/SHRINKDESC-151 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > This affects only the JavaEE API. Some usecases manipulate descriptors regardless of the version it is currently on. The API could be abstracted to a common interface so that common element types to the supported complex types could be used. > A sample is provided in https://github.com/forge/javaee-descriptors/. The IMPL remains untouched (as generated by the ShrinkWrap generator) and common types are refactored to a super interface: > Super Interface: https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Sub Interfaces: > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > The generated code doesn't need to change either. The existence of the super interface is what matters most. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-477) Provide addX that takes a collection

by Rich DiCroce (JIRA)

Rich DiCroce created SHRINKWRAP-477: --------------------------------------- Summary: Provide addX that takes a collection Key: SHRINKWRAP-477 URL: https://issues.jboss.org/browse/SHRINKWRAP-477 Project: ShrinkWrap Issue Type: Feature Request Affects Versions: 1.2.1 Reporter: Rich DiCroce It would be nice to have Collection overloads for all the addX methods that take varargs. For example, I wrote some utility methods that use Javassist to find all classes that a given class depends on, in order to simplify the process of constructing a deployment. These methods build up a Set<Class<?>>, which I then add to the Archive. But while there is an addClasses(Class<?>... classes) method, there's no addClasses(Collection<Class<?>> classes) method. Obviously, this can be worked around by iterating over a Collection and using addClass() or by converting the Set to an array and using addClasses(), but a Collection add method would be a nice convenience. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-476) Cannot delete nested archive if added asLibrary

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-476?page=com.atlassian.jira.pl... ] Andrew Rubinger resolved SHRINKWRAP-476. ---------------------------------------- Fix Version/s: 1.2.2 Resolution: Done Upstream: https://github.com/shrinkwrap/shrinkwrap/commit/024e3e4e87faf4593f20ea6bc... > Cannot delete nested archive if added asLibrary > ----------------------------------------------- > > Key: SHRINKWRAP-476 > URL: https://issues.jboss.org/browse/SHRINKWRAP-476 > Project: ShrinkWrap > Issue Type: Bug > Components: impl-base > Affects Versions: 1.2.1 > Reporter: Andrew Rubinger > Assignee: Andrew Rubinger > Fix For: 1.2.2 > > > Fails: > {code}String name = "test.jar"; > WebArchive war = ShrinkWrap.create(WebArchive.class) > .addAsLibraries( > ShrinkWrap.create(JavaArchive.class, name) > .add(EmptyAsset.INSTANCE, "some")); > ArchivePath path = ArchivePaths.create("WEB-INF/lib", name); > Assert.assertTrue(war.contains(path)); > war.delete(path); > Assert.assertFalse("Path should have been deleted", war.contains(path));{code} > From [~aslak] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-476) Cannot delete nested archive if added asLibrary

by Andrew Rubinger (JIRA)

Andrew Rubinger created SHRINKWRAP-476: ------------------------------------------ Summary: Cannot delete nested archive if added asLibrary Key: SHRINKWRAP-476 URL: https://issues.jboss.org/browse/SHRINKWRAP-476 Project: ShrinkWrap Issue Type: Bug Components: impl-base Affects Versions: 1.2.1 Reporter: Andrew Rubinger Assignee: Andrew Rubinger Fails: {code}String name = "test.jar"; WebArchive war = ShrinkWrap.create(WebArchive.class) .addAsLibraries( ShrinkWrap.create(JavaArchive.class, name) .add(EmptyAsset.INSTANCE, "some")); ArchivePath path = ArchivePaths.create("WEB-INF/lib", name); Assert.assertTrue(war.contains(path)); war.delete(path); Assert.assertFalse("Path should have been deleted", war.contains(path));{code} >From [~aslak] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-475) Fix docs in Archive API

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-475?page=com.atlassian.jira.pl... ] Andrew Rubinger resolved SHRINKWRAP-475. ---------------------------------------- Fix Version/s: 1.2.2 Resolution: Done Upstream: https://github.com/shrinkwrap/shrinkwrap/commit/67a9f5ae1fbb138bdaaa01430... > Fix docs in Archive API > ----------------------- > > Key: SHRINKWRAP-475 > URL: https://issues.jboss.org/browse/SHRINKWRAP-475 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.2.1 > Reporter: Andrew Rubinger > Assignee: Andrew Rubinger > Fix For: 1.2.2 > > > Outdated JavaDoc references to "archive" instead of "archiveFormat" in "getAsType" methods -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-475) Fix docs in Archive API

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-475?page=com.atlassian.jira.pl... ] Andrew Rubinger updated SHRINKWRAP-475: --------------------------------------- Assignee: Andrew Rubinger Affects Version/s: 1.2.1 Component/s: api > Fix docs in Archive API > ----------------------- > > Key: SHRINKWRAP-475 > URL: https://issues.jboss.org/browse/SHRINKWRAP-475 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.2.1 > Reporter: Andrew Rubinger > Assignee: Andrew Rubinger > > Outdated JavaDoc references to "archive" instead of "archiveFormat" in "getAsType" methods -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-475) Fix docs in Archive API

by Andrew Rubinger (JIRA)

Andrew Rubinger created SHRINKWRAP-475: ------------------------------------------ Summary: Fix docs in Archive API Key: SHRINKWRAP-475 URL: https://issues.jboss.org/browse/SHRINKWRAP-475 Project: ShrinkWrap Issue Type: Feature Request Reporter: Andrew Rubinger Outdated JavaDoc references to "archive" instead of "archiveFormat" in "getAsType" methods -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-474) getAsType fail if the ArchiveAsset exists

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-474?page=com.atlassian.jira.pl... ] Andrew Rubinger resolved SHRINKWRAP-474. ---------------------------------------- Fix Version/s: 1.2.2 Resolution: Done Upstream: https://github.com/shrinkwrap/shrinkwrap/commit/d867112e5f3c111fff4b995b5... > getAsType fail if the ArchiveAsset exists > ----------------------------------------- > > Key: SHRINKWRAP-474 > URL: https://issues.jboss.org/browse/SHRINKWRAP-474 > Project: ShrinkWrap > Issue Type: Bug > Components: impl-base > Affects Versions: 1.2.1 > Reporter: Aslak Knutsen > Assignee: Andrew Rubinger > Fix For: 1.2.2 > > > Two issues with the current impl: > 1. the represented ArchivePath already exists as ArchiveAsset, so there is no need to attempt to import it > 2. it silently fail to delete the existing ArchivePath after import, so it throws exception when trying to overwrite the existing path. > {code} > String path = "a.jar"; > ShrinkWrap.create(WebArchive.class) > .addAsLibraries( > ShrinkWrap.create(JavaArchive.class, path) > .add(EmptyAsset.INSTANCE, "something")) > .getAsType( > GenericArchive.class, > ArchivePaths.create("WEB-INF/lib", path), > ArchiveFormat.ZIP); > {code} > {code} > org.jboss.shrinkwrap.api.IllegalOverwriteException: Cannot add requested asset org.jboss.shrinkwrap.api.asset.ArchiveAsset@49873ad9 to path /WEB-INF/lib/a.jar to archive 77b80d55-7637-4b87-9ac6-802aab489af3.war; path already exists as directory > at org.jboss.shrinkwrap.impl.base.MemoryMapArchiveBase.addAsset(MemoryMapArchiveBase.java:195) > at org.jboss.shrinkwrap.impl.base.MemoryMapArchiveBase.add(MemoryMapArchiveBase.java:127) > at org.jboss.shrinkwrap.impl.base.ArchiveBase.getAsType(ArchiveBase.java:305) > at org.jboss.shrinkwrap.impl.base.container.ContainerBase.getAsType(ContainerBase.java:467) > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-474) getAsType fail if the ArchiveAsset exists

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-474?page=com.atlassian.jira.pl... ] Andrew Rubinger reassigned SHRINKWRAP-474: ------------------------------------------ Assignee: Andrew Rubinger > getAsType fail if the ArchiveAsset exists > ----------------------------------------- > > Key: SHRINKWRAP-474 > URL: https://issues.jboss.org/browse/SHRINKWRAP-474 > Project: ShrinkWrap > Issue Type: Bug > Components: impl-base > Affects Versions: 1.2.1 > Reporter: Aslak Knutsen > Assignee: Andrew Rubinger > > Two issues with the current impl: > 1. the represented ArchivePath already exists as ArchiveAsset, so there is no need to attempt to import it > 2. it silently fail to delete the existing ArchivePath after import, so it throws exception when trying to overwrite the existing path. > {code} > String path = "a.jar"; > ShrinkWrap.create(WebArchive.class) > .addAsLibraries( > ShrinkWrap.create(JavaArchive.class, path) > .add(EmptyAsset.INSTANCE, "something")) > .getAsType( > GenericArchive.class, > ArchivePaths.create("WEB-INF/lib", path), > ArchiveFormat.ZIP); > {code} > {code} > org.jboss.shrinkwrap.api.IllegalOverwriteException: Cannot add requested asset org.jboss.shrinkwrap.api.asset.ArchiveAsset@49873ad9 to path /WEB-INF/lib/a.jar to archive 77b80d55-7637-4b87-9ac6-802aab489af3.war; path already exists as directory > at org.jboss.shrinkwrap.impl.base.MemoryMapArchiveBase.addAsset(MemoryMapArchiveBase.java:195) > at org.jboss.shrinkwrap.impl.base.MemoryMapArchiveBase.add(MemoryMapArchiveBase.java:127) > at org.jboss.shrinkwrap.impl.base.ArchiveBase.getAsType(ArchiveBase.java:305) > at org.jboss.shrinkwrap.impl.base.container.ContainerBase.getAsType(ContainerBase.java:467) > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 2 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues March 2014