May 2014 - shrinkwrap-issues - Jboss List Archives

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-155: -------------------------------------------- And then we get much better quality. > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

9 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-155: -------------------------------------------- Main issue is how to verify these common fields. But I got an idea how to test it. It will take a little time. > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

9 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-155: -------------------------------------------- ParamValue is defined as xsd:string whereas ParamName is defined as xsd:token. Good example of the complexity... Wanted to make progress for the next major API redesign:-( Which would be a huge benefit for everyone. Any ideas how we can come to an end? Is it almost usable? Totally not usable? How far is it from you point of view usable in Forge? I'll certainly fix this with the xsd:token and other issues, no question. Thanks, Ralf > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

9 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-155: -------------------------------------------- Hi Ralf, Looks like {{JavaeeParamValueCommonType.getParamName()}} and {{JavaeeParamValueCommonType.paramName(String)}} are missing. Thanks! > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

9 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-180) transitive dependencies updated from provided to compile

by Markus Schulz (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-180?page=com.atlassian.jira.plu... ] Markus Schulz commented on SHRINKRES-180: ----------------------------------------- only with <exclusions> <exclusion> <groupId>org.hibernate</groupId> <artifactId>hibernate-core</artifactId> </exclusion> ... </exclusions> i got the expected behaviour...but that do not comply with the wanted "DRY" principle of the MavenResolver stuff. i've tried the other ways like ShrinkWrap.create(MavenImporter.class).loadPomFromClassLoaderResource("test-pom.xml").importBuildOutput(new AcceptScopesStrategy(ScopeType.COMPILE)) too but without success. > transitive dependencies updated from provided to compile > -------------------------------------------------------- > > Key: SHRINKRES-180 > URL: https://issues.jboss.org/browse/SHRINKRES-180 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Affects Versions: 2.2.0-alpha-2 > Reporter: Markus Schulz > Assignee: Andrew Rubinger > Attachments: deptree.txt, MavenResolverTest.java, transitivetest-pom.xml > > > i have a pom with something like: > <dependency> > <groupId>org.hibernate</groupId> > <artifactId>hibernate-search</artifactId> > <version>4.2.0.Final</version> > </dependency> > <dependency> > <groupId>org.hibernate</groupId> > <artifactId>hibernate-core</artifactId> > <scope>provided</scope> > </dependency> > hibernate-search internally dependes on hibernate-core (scope compile). But in don't want to get hbernate-core in my deployment, therefore it's forced to provided. > But: > File[] testLibs = Maven.configureResolver() > .workOffline() > .loadPomFromClassLoaderResource("transitivetest-pom.xml") > .importRuntimeDependencies() > .resolve() > .withTransitivity() > .asFile(); > still contains hibernate-core.jar -- This message was sent by Atlassian JIRA (v6.2.3#6260)

9 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-180) transitive dependencies updated from provided to compile

by Markus Schulz (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-180?page=com.atlassian.jira.plu... ] Markus Schulz updated SHRINKRES-180: ------------------------------------ Attachment: deptree.txt > transitive dependencies updated from provided to compile > -------------------------------------------------------- > > Key: SHRINKRES-180 > URL: https://issues.jboss.org/browse/SHRINKRES-180 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Affects Versions: 2.2.0-alpha-2 > Reporter: Markus Schulz > Assignee: Andrew Rubinger > Attachments: deptree.txt, MavenResolverTest.java, transitivetest-pom.xml > > > i have a pom with something like: > <dependency> > <groupId>org.hibernate</groupId> > <artifactId>hibernate-search</artifactId> > <version>4.2.0.Final</version> > </dependency> > <dependency> > <groupId>org.hibernate</groupId> > <artifactId>hibernate-core</artifactId> > <scope>provided</scope> > </dependency> > hibernate-search internally dependes on hibernate-core (scope compile). But in don't want to get hbernate-core in my deployment, therefore it's forced to provided. > But: > File[] testLibs = Maven.configureResolver() > .workOffline() > .loadPomFromClassLoaderResource("transitivetest-pom.xml") > .importRuntimeDependencies() > .resolve() > .withTransitivity() > .asFile(); > still contains hibernate-core.jar -- This message was sent by Atlassian JIRA (v6.2.3#6260)

9 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-180) transitive dependencies updated from provided to compile

by Markus Schulz (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-180?page=com.atlassian.jira.plu... ] Markus Schulz updated SHRINKRES-180: ------------------------------------ Attachment: transitivetest-pom.xml MavenResolverTest.java > transitive dependencies updated from provided to compile > -------------------------------------------------------- > > Key: SHRINKRES-180 > URL: https://issues.jboss.org/browse/SHRINKRES-180 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Affects Versions: 2.2.0-alpha-2 > Reporter: Markus Schulz > Assignee: Andrew Rubinger > Attachments: deptree.txt, MavenResolverTest.java, transitivetest-pom.xml > > > i have a pom with something like: > <dependency> > <groupId>org.hibernate</groupId> > <artifactId>hibernate-search</artifactId> > <version>4.2.0.Final</version> > </dependency> > <dependency> > <groupId>org.hibernate</groupId> > <artifactId>hibernate-core</artifactId> > <scope>provided</scope> > </dependency> > hibernate-search internally dependes on hibernate-core (scope compile). But in don't want to get hbernate-core in my deployment, therefore it's forced to provided. > But: > File[] testLibs = Maven.configureResolver() > .workOffline() > .loadPomFromClassLoaderResource("transitivetest-pom.xml") > .importRuntimeDependencies() > .resolve() > .withTransitivity() > .asFile(); > still contains hibernate-core.jar -- This message was sent by Atlassian JIRA (v6.2.3#6260)

9 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-180) transitive dependencies updated from provided to compile

by Markus Schulz (JIRA)

Markus Schulz created SHRINKRES-180: --------------------------------------- Summary: transitive dependencies updated from provided to compile Key: SHRINKRES-180 URL: https://issues.jboss.org/browse/SHRINKRES-180 Project: ShrinkWrap Resolvers Issue Type: Bug Affects Versions: 2.2.0-alpha-2 Reporter: Markus Schulz Assignee: Andrew Rubinger i have a pom with something like: <dependency> <groupId>org.hibernate</groupId> <artifactId>hibernate-search</artifactId> <version>4.2.0.Final</version> </dependency> <dependency> <groupId>org.hibernate</groupId> <artifactId>hibernate-core</artifactId> <scope>provided</scope> </dependency> hibernate-search internally dependes on hibernate-core (scope compile). But in don't want to get hbernate-core in my deployment, therefore it's forced to provided. But: File[] testLibs = Maven.configureResolver() .workOffline() .loadPomFromClassLoaderResource("transitivetest-pom.xml") .importRuntimeDependencies() .resolve() .withTransitivity() .asFile(); still contains hibernate-core.jar -- This message was sent by Atlassian JIRA (v6.2.3#6260)

9 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-155: -------------------------------------------- I added the two missing methods as mentioned. A pull request is already sent so I think my latest commit is already included in the PR. Regards, Ralf > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

9 years, 12 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-179) Build Fails in JDK8

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-179?page=com.atlassian.jira.plu... ] Karel Piwko commented on SHRINKRES-179: --------------------------------------- https://github.com/shrinkwrap/resolver/blob/master/maven-plugin/src/it/de... > Build Fails in JDK8 > ------------------- > > Key: SHRINKRES-179 > URL: https://issues.jboss.org/browse/SHRINKRES-179 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Affects Versions: 2.2.0-alpha-2 > Reporter: Andrew Rubinger > Assignee: Karel Piwko > > In environment: > {code}alr@distortion ~/business/jboss/git/shrinkwrap/resolver $ mvn -version > Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T12:37:52-05:00) > Maven home: /usr/local/Cellar/maven/3.2.1/libexec > Java version: 1.8.0_05, vendor: Oracle Corporation > Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_05.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.9.2", arch: "x86_64", family: "mac"{code} > The build fails due to: > {code}[INFO] Running post-build script: /Users/alr/business/jboss/git/shrinkwrap/resolver/maven-plugin/target/it/dependency-tree-scope/verify.bsh > [INFO] Finished post-build script: /Users/alr/business/jboss/git/shrinkwrap/resolver/maven-plugin/target/it/dependency-tree-scope/verify.bsh > [INFO] ..SUCCESS (1.4 s) > [INFO] ------------------------------------------------- > [INFO] Build Summary: > [INFO] Passed: 3, Failed: 1, Errors: 0, Skipped: 0 > [INFO] ------------------------------------------------- > [ERROR] The following builds failed: > [ERROR] * dependency-tree/pom.xml{code} > Available in the logs: > https://shrinkwrap.ci.cloudbees.com/view/SWR/job/ShrinkWrap_Resolver_upst... -- This message was sent by Atlassian JIRA (v6.2.3#6260)

9 years, 12 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues May 2014