June 2014 - shrinkwrap-issues - Jboss List Archives

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-155: -------------------------------------------- ok, I have to double check. Hmm, its done in the refactored branch. I will push the differences soon. > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Security Level: Public(Everyone can see) > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-155: -------------------------------------------- Hi Ralf, I checked with your branch in https://github.com/rbattenfeld/descriptors/tree/SHRINKDESC-155 > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Security Level: Public(Everyone can see) > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-155: -------------------------------------------- Hi George Sorry for the late response. I am busy with the API refactoring. Which version did you check? At least the first two points are available. The jee namespace is dictated by the spec version. In 1.4 and older, the namespace was defined as jee. From Java EE 5 onwards, the name space is javaee. > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Security Level: Public(Everyone can see) > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

11 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-183) Resolvers.configure(Class, ClassLoader) ignores ClassLoader?

by Thomas Maslen (JIRA)

Thomas Maslen created SHRINKRES-183: --------------------------------------- Summary: Resolvers.configure(Class,ClassLoader) ignores ClassLoader? Key: SHRINKRES-183 URL: https://issues.jboss.org/browse/SHRINKRES-183 Project: ShrinkWrap Resolvers Issue Type: Bug Components: api Affects Versions: 2.1.0 Reporter: Thomas Maslen Assignee: Andrew Rubinger [No, I wasn't trying to use this, I just noticed it while looking at the source. It looks to me like a regression, but you gents would be better judges of that than I am] The Resolvers.configure(Class,ClassLoader) method ignores its ClassLoader argument; the only argument that it passes to ResolverSystemFactory.createFromUserView() is the Class. Offhand it looks like a cut-and-paste from the method above? If I'm reading Git right this was introduced in the fix for SHRINKRES-173 that went into 2.1.0, and it's present in 2.1.0 and above, including the current master. Happily, Resolvers.use(Class,ClassLoader) passes both arguments to ResolverSystemFactory as expected. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

11 years, 10 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-155: -------------------------------------------- Yes, I mean the String getters/setters, as enum is not possible to merge. With exception of enums, unless I am missing something I think it's possible to match all possible common fields. By common fields I mean the fields available in the first version of a spec. Eg: With JPA, all fields in JPA 1.1 are perfectly valid in JPA 2.0, 2.1 > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

11 years, 10 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-155: -------------------------------------------- Hi Ralf, Still has some issues: - org.jboss.shrinkwrap.descriptor.api.persistence.PersistencePropertyCommType doesn't define name and value - org.jboss.shrinkwrap.descriptor.api.persistence.PersistencePersistenceUnitCommType doesn't define the excludeUnlistedClasses method. - org.jboss.shrinkwrap.descriptor.api.j2ee.JeeParamValueCommonType (Why Jee?) doesn't define the methods in org.jboss.shrinkwrap.descriptor.api.j2ee14.ParamValueType > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.3#6260)

11 years, 10 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues June 2014