July 2014 - shrinkwrap-issues - Jboss List Archives

[JBoss JIRA] (SHRINKRES-190) implements equals and hashCode methods in MavenResolvedArtifactImpl / MavenArtifactInfoImpl

by Mathieu Lachance (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-190?page=com.atlassian.jira.plu... ] Mathieu Lachance updated SHRINKRES-190: --------------------------------------- Description: I'm currently to find an effective way to filter out many dependencies that I could provide within a "dummy" pom.xml. I'd like to do the following: {code:java} public static List<MavenResolvedArtifact> resolveAllTestNonTransitiveDependencies() { return Arrays.asList( Maven.resolver() .loadPomFromFile("pom.xml") .importTestDependencies().resolve() .withoutTransitivity() .asResolvedArtifact()); } public static List<MavenResolvedArtifact> resolveAllArquillianDependencies() { return Arrays.asList( Maven.resolver() .loadPomFromFile("src/test/resources/arquillian.pom.xml") .importTestDependencies().resolve() .withoutTransitivity() .asResolvedArtifact()); } public static List<MavenResolvedArtifact> resolveAllTestNonTransitiveNonArquillianDependencies() { List<MavenResolvedArtifact> testDependencies = resolveAllTestNonTransitiveDependencies(); List<MavenResolvedArtifact> arquillianDependencies = resolveAllArquillianDependencies(); List<MavenResolvedArtifact> filteredTestDependencies = new ArrayList<MavenResolvedArtifact>(); for (MavenResolvedArtifact testDependency : testDependencies) { if (!arquillianDependencies.contains(testDependency)) { filteredTestDependencies.add(testDependency); } } return filteredTestDependencies; } {code} The problem is that MavenResolvedArtifactImpl does not implements equals and hashCode needed for using Collection::contains method. I think it would be safe to delegate MavenResolvedArtifactImpl / MavenArtifactInfoImpl equals and hashCode methods to MavenCoordinateImpl Thanks, was: I'm currently to find an effective way to filter out many dependencies that I could provide within a "dummy" pom.xml. I'd like to do the following: {code:java} public static List<MavenResolvedArtifact> resolveAllTestNonTransitiveDependencies() { return Arrays.asList( Maven.resolver() .loadPomFromFile("pom.xml") .importTestDependencies().resolve() .withoutTransitivity() .asResolvedArtifact()); } public static List<MavenResolvedArtifact> resolveAllArquillianDependencies() { return Arrays.asList( Maven.resolver() .loadPomFromFile("src/test/resources/arquillian.pom.xml") .importTestDependencies().resolve() .withoutTransitivity() .asResolvedArtifact()); } public static List<MavenResolvedArtifact> resolveAllTestNonTransitiveNonArquillianDependencies() { List<MavenResolvedArtifact> testDependencies = resolveAllTestNonTransitiveDependencies(); List<MavenResolvedArtifact> arquillianDependencies = resolveAllArquillianDependencies(); List<MavenResolvedArtifact> filteredTestDependencies = new ArrayList<MavenResolvedArtifact>(); for (MavenResolvedArtifact testDependency : testDependencies) { if (!arquillianDependencies.contains(testDependency)) { filteredTestDependencies.add(testDependency); } } return filteredTestDependencies; } {code} The problem is that MavenResolvedArtifactImpl does not implements equals and hashCode needed for using Collection::contains method. I think it would be safe to delegate MavenResolvedArtifactImpl / MavenArtifactInfoImpl equals and hashCode methods to MavenCoordinateImpl Thanks, see also: https://issues.jboss.org/browse/SHRINKRES-30 > implements equals and hashCode methods in MavenResolvedArtifactImpl / MavenArtifactInfoImpl > ------------------------------------------------------------------------------------------- > > Key: SHRINKRES-190 > URL: https://issues.jboss.org/browse/SHRINKRES-190 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Security Level: Public(Everyone can see) > Affects Versions: 2.1.1 > Reporter: Mathieu Lachance > > I'm currently to find an effective way to filter out many dependencies that I could provide within a "dummy" pom.xml. > I'd like to do the following: > {code:java} > public static List<MavenResolvedArtifact> resolveAllTestNonTransitiveDependencies() { > return Arrays.asList( > Maven.resolver() > .loadPomFromFile("pom.xml") > .importTestDependencies().resolve() > .withoutTransitivity() > .asResolvedArtifact()); > } > > public static List<MavenResolvedArtifact> resolveAllArquillianDependencies() { > return Arrays.asList( > Maven.resolver() > .loadPomFromFile("src/test/resources/arquillian.pom.xml") > .importTestDependencies().resolve() > .withoutTransitivity() > .asResolvedArtifact()); > } > > public static List<MavenResolvedArtifact> resolveAllTestNonTransitiveNonArquillianDependencies() { > List<MavenResolvedArtifact> testDependencies = resolveAllTestNonTransitiveDependencies(); > > List<MavenResolvedArtifact> arquillianDependencies = resolveAllArquillianDependencies(); > > List<MavenResolvedArtifact> filteredTestDependencies = new ArrayList<MavenResolvedArtifact>(); > for (MavenResolvedArtifact testDependency : testDependencies) { > if (!arquillianDependencies.contains(testDependency)) { > filteredTestDependencies.add(testDependency); > } > } > return filteredTestDependencies; > } > {code} > The problem is that MavenResolvedArtifactImpl does not implements equals and hashCode needed for using Collection::contains method. > I think it would be safe to delegate MavenResolvedArtifactImpl / MavenArtifactInfoImpl equals and hashCode methods to MavenCoordinateImpl > Thanks, -- This message was sent by Atlassian JIRA (v6.2.6#6264)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-190) implements equals and hashCode methods in MavenResolvedArtifactImpl / MavenArtifactInfoImpl

by Mathieu Lachance (JIRA)

Mathieu Lachance created SHRINKRES-190: ------------------------------------------ Summary: implements equals and hashCode methods in MavenResolvedArtifactImpl / MavenArtifactInfoImpl Key: SHRINKRES-190 URL: https://issues.jboss.org/browse/SHRINKRES-190 Project: ShrinkWrap Resolvers Issue Type: Feature Request Security Level: Public (Everyone can see) Affects Versions: 2.1.1 Reporter: Mathieu Lachance I'm currently to find an effective way to filter out many dependencies that I could provide within a "dummy" pom.xml. I'd like to do the following: {code:java} public static List<MavenResolvedArtifact> resolveAllTestNonTransitiveDependencies() { return Arrays.asList( Maven.resolver() .loadPomFromFile("pom.xml") .importTestDependencies().resolve() .withoutTransitivity() .asResolvedArtifact()); } public static List<MavenResolvedArtifact> resolveAllArquillianDependencies() { return Arrays.asList( Maven.resolver() .loadPomFromFile("src/test/resources/arquillian.pom.xml") .importTestDependencies().resolve() .withoutTransitivity() .asResolvedArtifact()); } public static List<MavenResolvedArtifact> resolveAllTestNonTransitiveNonArquillianDependencies() { List<MavenResolvedArtifact> testDependencies = resolveAllTestNonTransitiveDependencies(); List<MavenResolvedArtifact> arquillianDependencies = resolveAllArquillianDependencies(); List<MavenResolvedArtifact> filteredTestDependencies = new ArrayList<MavenResolvedArtifact>(); for (MavenResolvedArtifact testDependency : testDependencies) { if (!arquillianDependencies.contains(testDependency)) { filteredTestDependencies.add(testDependency); } } return filteredTestDependencies; } {code} The problem is that MavenResolvedArtifactImpl does not implements equals and hashCode needed for using Collection::contains method. I think it would be safe to delegate MavenResolvedArtifactImpl / MavenArtifactInfoImpl equals and hashCode methods to MavenCoordinateImpl Thanks, see also: https://issues.jboss.org/browse/SHRINKRES-30 -- This message was sent by Atlassian JIRA (v6.2.6#6264)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-189) Maven resolver unable to resolve test-jar artifacts without classifier

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-189?page=com.atlassian.jira.plu... ] Karel Piwko closed SHRINKRES-189. --------------------------------- Assignee: Karel Piwko Fix Version/s: 2.1.1 Resolution: Out of Date I'm marking this issue as out of date, it was fixed in 2.1.1 already and reported against an older version. > Maven resolver unable to resolve test-jar artifacts without classifier > ---------------------------------------------------------------------- > > Key: SHRINKRES-189 > URL: https://issues.jboss.org/browse/SHRINKRES-189 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: impl-maven > Affects Versions: 2.1.0 > Reporter: Marek Winkler > Assignee: Karel Piwko > Fix For: 2.1.1 > > > When resolving artifact specified in the pom.xml such as > {code:xml} > <dependency> > <groupId>org.drools</groupId> > <artifactId>drools-core</artifactId> > <type>test-jar</type> > </dependency> > {code} > the resolution fails to locate the artifact. The console output says that it tries to download the artifact with extension 'test-jar', which is wrong: > {{[java] WARNING: Failed downloading org/drools/drools-core/6.1.0.CR1-redhat-1/drools-core-6.1.0.CR1-redhat-1.test-jar from ...}} > When I declare the dependency with classifier, the resolution succeeds: > {code:xml} > <dependency> > <groupId>org.drools</groupId> > <artifactId>drools-core</artifactId> > <classifier>tests</classifier> > </dependency> > {code} -- This message was sent by Atlassian JIRA (v6.2.6#6264)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-189) Maven resolver unable to resolve test-jar artifacts without classifier

by Marek Winkler (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-189?page=com.atlassian.jira.plu... ] Marek Winkler commented on SHRINKRES-189: ----------------------------------------- I have tried with 2.1.1 and it works, thanks! > Maven resolver unable to resolve test-jar artifacts without classifier > ---------------------------------------------------------------------- > > Key: SHRINKRES-189 > URL: https://issues.jboss.org/browse/SHRINKRES-189 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: impl-maven > Affects Versions: 2.1.0 > Reporter: Marek Winkler > > When resolving artifact specified in the pom.xml such as > {code:xml} > <dependency> > <groupId>org.drools</groupId> > <artifactId>drools-core</artifactId> > <type>test-jar</type> > </dependency> > {code} > the resolution fails to locate the artifact. The console output says that it tries to download the artifact with extension 'test-jar', which is wrong: > {{[java] WARNING: Failed downloading org/drools/drools-core/6.1.0.CR1-redhat-1/drools-core-6.1.0.CR1-redhat-1.test-jar from ...}} > When I declare the dependency with classifier, the resolution succeeds: > {code:xml} > <dependency> > <groupId>org.drools</groupId> > <artifactId>drools-core</artifactId> > <classifier>tests</classifier> > </dependency> > {code} -- This message was sent by Atlassian JIRA (v6.2.6#6264)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-189) Maven resolver unable to resolve test-jar artifacts without classifier

by Karel Piwko (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-189?page=com.atlassian.jira.plu... ] Karel Piwko commented on SHRINKRES-189: --------------------------------------- Could you try with 2.1.1? I believe that SHRINKRES-162 and SHRINKRES-182 might have fixed the behavior. https://issues.jboss.org/browse/SHRINKRES/fixforversion/12324754/?selecte... > Maven resolver unable to resolve test-jar artifacts without classifier > ---------------------------------------------------------------------- > > Key: SHRINKRES-189 > URL: https://issues.jboss.org/browse/SHRINKRES-189 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: impl-maven > Affects Versions: 2.1.0 > Reporter: Marek Winkler > > When resolving artifact specified in the pom.xml such as > {code:xml} > <dependency> > <groupId>org.drools</groupId> > <artifactId>drools-core</artifactId> > <type>test-jar</type> > </dependency> > {code} > the resolution fails to locate the artifact. The console output says that it tries to download the artifact with extension 'test-jar', which is wrong: > {{[java] WARNING: Failed downloading org/drools/drools-core/6.1.0.CR1-redhat-1/drools-core-6.1.0.CR1-redhat-1.test-jar from ...}} > When I declare the dependency with classifier, the resolution succeeds: > {code:xml} > <dependency> > <groupId>org.drools</groupId> > <artifactId>drools-core</artifactId> > <classifier>tests</classifier> > </dependency> > {code} -- This message was sent by Atlassian JIRA (v6.2.6#6264)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-189) Maven resolver unable to resolve test-jar artifacts without classifier

by Marek Winkler (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-189?page=com.atlassian.jira.plu... ] Marek Winkler updated SHRINKRES-189: ------------------------------------ Component/s: impl-maven > Maven resolver unable to resolve test-jar artifacts without classifier > ---------------------------------------------------------------------- > > Key: SHRINKRES-189 > URL: https://issues.jboss.org/browse/SHRINKRES-189 > Project: ShrinkWrap Resolvers > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: impl-maven > Affects Versions: 2.1.0 > Reporter: Marek Winkler > > When resolving artifact specified in the pom.xml such as > {code:xml} > <dependency> > <groupId>org.drools</groupId> > <artifactId>drools-core</artifactId> > <type>test-jar</type> > </dependency> > {code} > the resolution fails to locate the artifact. The console output says that it tries to download the artifact with extension 'test-jar', which is wrong: > {{[java] WARNING: Failed downloading org/drools/drools-core/6.1.0.CR1-redhat-1/drools-core-6.1.0.CR1-redhat-1.test-jar from ...}} > When I declare the dependency with classifier, the resolution succeeds: > {code:xml} > <dependency> > <groupId>org.drools</groupId> > <artifactId>drools-core</artifactId> > <classifier>tests</classifier> > </dependency> > {code} -- This message was sent by Atlassian JIRA (v6.2.6#6264)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-189) Maven resolver unable to resolve test-jar artifacts without classifier

by Marek Winkler (JIRA)

Marek Winkler created SHRINKRES-189: --------------------------------------- Summary: Maven resolver unable to resolve test-jar artifacts without classifier Key: SHRINKRES-189 URL: https://issues.jboss.org/browse/SHRINKRES-189 Project: ShrinkWrap Resolvers Issue Type: Bug Security Level: Public (Everyone can see) Affects Versions: 2.1.0 Reporter: Marek Winkler When resolving artifact specified in the pom.xml such as {code:xml} <dependency> <groupId>org.drools</groupId> <artifactId>drools-core</artifactId> <type>test-jar</type> </dependency> {code} the resolution fails to locate the artifact. The console output says that it tries to download the artifact with extension 'test-jar', which is wrong: {{[java] WARNING: Failed downloading org/drools/drools-core/6.1.0.CR1-redhat-1/drools-core-6.1.0.CR1-redhat-1.test-jar from ...}} When I declare the dependency with classifier, the resolution succeeds: {code:xml} <dependency> <groupId>org.drools</groupId> <artifactId>drools-core</artifactId> <classifier>tests</classifier> </dependency> {code} -- This message was sent by Atlassian JIRA (v6.2.6#6264)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-155: -------------------------------------------- Sure, I am open to ideas. I think any proposal is still valid. > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Security Level: Public(Everyone can see) > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by Ralf Battenfeld (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] Ralf Battenfeld commented on SHRINKDESC-155: -------------------------------------------- I think your proposal is already present. You can use any descriptor and used it regardless of the target version. What I mean is for example, you can take WebAppDescriptor 2.5 for generating web.xml for version 3.0 and 3.1. I don't see a different by using a common descriptor which is basically a clone of the first version. I would like to introduce a new way of the common API for the next API, if that is happening... > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Security Level: Public(Everyone can see) > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

by George Gastaldi (JIRA)

[ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.pl... ] George Gastaldi commented on SHRINKDESC-155: -------------------------------------------- Hi Ralf, Can we make the common interface have the methods from the smallest version available (except methods using enums)? Eg: BeansCommonDescriptor contains all the mehods from BeanDescriptor from CDI 1.0. This could be enabled by a flag, I believe this behavior is common for most of the Java EE specs. > Missing methods in generated common parents > ------------------------------------------- > > Key: SHRINKDESC-155 > URL: https://issues.jboss.org/browse/SHRINKDESC-155 > Project: ShrinkWrap Descriptors > Issue Type: Feature Request > Security Level: Public(Everyone can see) > Components: api-javaee > Affects Versions: 2.0.0-alpha-6 > Reporter: George Gastaldi > Assignee: Ralf Battenfeld > > Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. > For example: > - JavaeeServletMappingCommonType > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > - WebAppCommonDescriptor > -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java... > Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. -- This message was sent by Atlassian JIRA (v6.2.6#6264)

9 years, 9 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues July 2014