May 2015 - shrinkwrap-issues - Jboss List Archives

[JBoss JIRA] (SHRINKRES-100) Allow Maven resource filtering to be applied for resources imported via MavenImporter

by Yannick Majoros (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-100?page=com.atlassian.jira.plu... ] Yannick Majoros commented on SHRINKRES-100: ------------------------------------------- It turns out that's just what addAsResource already does anyway, it just gets the resource from the classpath. So, if you don't use the File variants which would get it from the filesystem, it will already be filtered by maven. I suggest closing this bug as invalid. > Allow Maven resource filtering to be applied for resources imported via MavenImporter > ------------------------------------------------------------------------------------- > > Key: SHRINKRES-100 > URL: https://issues.jboss.org/browse/SHRINKRES-100 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Components: maven > Reporter: Karel Piwko > Labels: api-change > > When packaging resources to via MavenImporter, any filters defined on the path are ignored. Add support for applying filters. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

8 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-100) Allow Maven resource filtering to be applied for resources imported via MavenImporter

by Yannick Majoros (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-100?page=com.atlassian.jira.plu... ] Yannick Majoros edited comment on SHRINKRES-100 at 5/7/15 3:50 AM: ------------------------------------------------------------------- Better yet, it should be easy to add a method that just adds any test classpath resource to deployed archive. Here is a tested version, which I just call with this from @Deployment: {code:java} addClassPathResourceToArchive(webArchive, "test.properties"); {code} Here is the method code. I suggest adding a non-static version to ResourceContainer. {code:java} private static <T extends Archive<T>> T addClassPathResourceToArchive(ResourceContainer<T> webArchive, String resourceName) throws IOException { File targetFile = writeClassPathResourceToTempFile(resourceName); return webArchive.addAsResource(targetFile, resourceName); } private static File writeClassPathResourceToTempFile(String resourceName) throws IOException { ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); File targetFile = File.createTempFile("arquillian_test_", "." + resourceName); try (InputStream inputStream = contextClassLoader.getResourceAsStream(resourceName)) { Path targetPath = targetFile.toPath(); Files.copy(inputStream, targetPath, StandardCopyOption.REPLACE_EXISTING); } return targetFile; } {code} was (Author: ymajoros): Better yet, it should be easy to add a method that just adds any test classpath resource to deployed archive. Here is a tested version, which I just call with this from @Deployment: {code:java} addClassPathResourceToArchive(webArchive, "test.properties"); Here is the method code. I suggest adding a non-static version to ResourceContainer. private static <T extends Archive<T>> T addClassPathResourceToArchive(ResourceContainer<T> webArchive, String resourceName) throws IOException { File targetFile = writeClassPathResourceToTempFile(resourceName); return webArchive.addAsResource(targetFile, resourceName); } private static File writeClassPathResourceToTempFile(String resourceName) throws IOException { ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); File targetFile = File.createTempFile("arquillian_test_", "." + resourceName); try (InputStream inputStream = contextClassLoader.getResourceAsStream(resourceName)) { Path targetPath = targetFile.toPath(); Files.copy(inputStream, targetPath, StandardCopyOption.REPLACE_EXISTING); } return targetFile; } {code} > Allow Maven resource filtering to be applied for resources imported via MavenImporter > ------------------------------------------------------------------------------------- > > Key: SHRINKRES-100 > URL: https://issues.jboss.org/browse/SHRINKRES-100 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Components: maven > Reporter: Karel Piwko > Labels: api-change > > When packaging resources to via MavenImporter, any filters defined on the path are ignored. Add support for applying filters. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

8 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-100) Allow Maven resource filtering to be applied for resources imported via MavenImporter

by Yannick Majoros (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-100?page=com.atlassian.jira.plu... ] Yannick Majoros edited comment on SHRINKRES-100 at 5/7/15 3:49 AM: ------------------------------------------------------------------- Better yet, it should be easy to add a method that just adds any test classpath resource to deployed archive. Here is a tested version, which I just call with this from @Deployment: {code:java} addClassPathResourceToArchive(webArchive, "test.properties"); Here is the method code. I suggest adding a non-static version to ResourceContainer. private static <T extends Archive<T>> T addClassPathResourceToArchive(ResourceContainer<T> webArchive, String resourceName) throws IOException { File targetFile = writeClassPathResourceToTempFile(resourceName); return webArchive.addAsResource(targetFile, resourceName); } private static File writeClassPathResourceToTempFile(String resourceName) throws IOException { ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); File targetFile = File.createTempFile("arquillian_test_", "." + resourceName); try (InputStream inputStream = contextClassLoader.getResourceAsStream(resourceName)) { Path targetPath = targetFile.toPath(); Files.copy(inputStream, targetPath, StandardCopyOption.REPLACE_EXISTING); } return targetFile; } {code} was (Author: ymajoros): Better yet, it should be easy to add a method that just adds any test classpath resource to deployed archive. Here is a tested version, which I just call with this from @Deployment: addClassPathResourceToArchive(webArchive, "test.properties"); Here is the method code. I suggest adding a non-static version to ResourceContainer. private static <T extends Archive<T>> T addClassPathResourceToArchive(ResourceContainer<T> webArchive, String resourceName) throws IOException { File targetFile = writeClassPathResourceToTempFile(resourceName); return webArchive.addAsResource(targetFile, resourceName); } private static File writeClassPathResourceToTempFile(String resourceName) throws IOException { ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); File targetFile = File.createTempFile("arquillian_test_", "." + resourceName); try (InputStream inputStream = contextClassLoader.getResourceAsStream(resourceName)) { Path targetPath = targetFile.toPath(); Files.copy(inputStream, targetPath, StandardCopyOption.REPLACE_EXISTING); } return targetFile; } > Allow Maven resource filtering to be applied for resources imported via MavenImporter > ------------------------------------------------------------------------------------- > > Key: SHRINKRES-100 > URL: https://issues.jboss.org/browse/SHRINKRES-100 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Components: maven > Reporter: Karel Piwko > Labels: api-change > > When packaging resources to via MavenImporter, any filters defined on the path are ignored. Add support for applying filters. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

8 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-100) Allow Maven resource filtering to be applied for resources imported via MavenImporter

by Yannick Majoros (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-100?page=com.atlassian.jira.plu... ] Yannick Majoros edited comment on SHRINKRES-100 at 5/7/15 3:49 AM: ------------------------------------------------------------------- Here is a simpler version, that I suggest adding to the Arquillian API (ResourceContainer). {code:java} public static <T extends Archive<T>> T addClassPathResourceToArchive(ResourceContainer<T> webArchive, String resourceName) throws IOException { ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); URL testPropertiesURL = contextClassLoader.getResource(resourceName); return webArchive.addAsResource(testPropertiesURL, resourceName); } {code} was (Author: ymajoros): Here is a simpler version, that I suggest adding to the Arquillian API (ResourceContainer). public static <T extends Archive<T>> T addClassPathResourceToArchive(ResourceContainer<T> webArchive, String resourceName) throws IOException { ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); URL testPropertiesURL = contextClassLoader.getResource(resourceName); return webArchive.addAsResource(testPropertiesURL, resourceName); } > Allow Maven resource filtering to be applied for resources imported via MavenImporter > ------------------------------------------------------------------------------------- > > Key: SHRINKRES-100 > URL: https://issues.jboss.org/browse/SHRINKRES-100 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Components: maven > Reporter: Karel Piwko > Labels: api-change > > When packaging resources to via MavenImporter, any filters defined on the path are ignored. Add support for applying filters. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

8 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-100) Allow Maven resource filtering to be applied for resources imported via MavenImporter

by Yannick Majoros (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-100?page=com.atlassian.jira.plu... ] Yannick Majoros commented on SHRINKRES-100: ------------------------------------------- Here is a simpler version, that I suggest adding to the Arquillian API (ResourceContainer). public static <T extends Archive<T>> T addClassPathResourceToArchive(ResourceContainer<T> webArchive, String resourceName) throws IOException { ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); URL testPropertiesURL = contextClassLoader.getResource(resourceName); return webArchive.addAsResource(testPropertiesURL, resourceName); } > Allow Maven resource filtering to be applied for resources imported via MavenImporter > ------------------------------------------------------------------------------------- > > Key: SHRINKRES-100 > URL: https://issues.jboss.org/browse/SHRINKRES-100 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Components: maven > Reporter: Karel Piwko > Labels: api-change > > When packaging resources to via MavenImporter, any filters defined on the path are ignored. Add support for applying filters. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

8 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-100) Allow Maven resource filtering to be applied for resources imported via MavenImporter

by Yannick Majoros (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-100?page=com.atlassian.jira.plu... ] Yannick Majoros commented on SHRINKRES-100: ------------------------------------------- Better yet, it should be easy to add a method that just adds any test classpath resource to deployed archive. Here is a tested version, which I just call with this from @Deployment: addClassPathResourceToArchive(webArchive, "test.properties"); Here is the method code. I suggest adding a non-static version to ResourceContainer. private static <T extends Archive<T>> T addClassPathResourceToArchive(ResourceContainer<T> webArchive, String resourceName) throws IOException { File targetFile = writeClassPathResourceToTempFile(resourceName); return webArchive.addAsResource(targetFile, resourceName); } private static File writeClassPathResourceToTempFile(String resourceName) throws IOException { ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); File targetFile = File.createTempFile("arquillian_test_", "." + resourceName); try (InputStream inputStream = contextClassLoader.getResourceAsStream(resourceName)) { Path targetPath = targetFile.toPath(); Files.copy(inputStream, targetPath, StandardCopyOption.REPLACE_EXISTING); } return targetFile; } > Allow Maven resource filtering to be applied for resources imported via MavenImporter > ------------------------------------------------------------------------------------- > > Key: SHRINKRES-100 > URL: https://issues.jboss.org/browse/SHRINKRES-100 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Components: maven > Reporter: Karel Piwko > Labels: api-change > > When packaging resources to via MavenImporter, any filters defined on the path are ignored. Add support for applying filters. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

8 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-100) Allow Maven resource filtering to be applied for resources imported via MavenImporter

by Yannick Majoros (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-100?page=com.atlassian.jira.plu... ] Yannick Majoros commented on SHRINKRES-100: ------------------------------------------- As a workaround for my usage, I ended up with this in @Deployment: Properties testProperties = new Properties(); ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); InputStream testPropertiesInputStream = contextClassLoader.getResourceAsStream("test.properties"); testProperties.load(testPropertiesInputStream); File testPropertiesTargetFile = File.createTempFile("arquillian_test_", ".properties"); try (Writer testPropertiesWriter = Files.newBufferedWriter(testPropertiesTargetFile.toPath())) { testProperties.store(testPropertiesWriter, null); } webArchive.addAsResource(testPropertiesTargetFile, "test.properties"); And this in @Setup: private Properties testProperties; @Before public void setUp() throws IOException { testProperties = new Properties(); InputStream testPropertiesInputStream = this.getClass().getResourceAsStream("/test.properties"); testProperties.load(testPropertiesInputStream); }As a workaround, I ended up with this in @Deployment: Properties testProperties = new Properties(); ClassLoader contextClassLoader = Thread.currentThread().getContextClassLoader(); InputStream testPropertiesInputStream = contextClassLoader.getResourceAsStream("test.properties"); testProperties.load(testPropertiesInputStream); File testPropertiesTargetFile = File.createTempFile("arquillian_test_", ".properties"); try (Writer testPropertiesWriter = Files.newBufferedWriter(testPropertiesTargetFile.toPath())) { testProperties.store(testPropertiesWriter, null); } webArchive.addAsResource(testPropertiesTargetFile, "test.properties"); And this in @Setup: private Properties testProperties; @Before public void setUp() throws IOException { testProperties = new Properties(); InputStream testPropertiesInputStream = this.getClass().getResourceAsStream("/test.properties"); testProperties.load(testPropertiesInputStream); } > Allow Maven resource filtering to be applied for resources imported via MavenImporter > ------------------------------------------------------------------------------------- > > Key: SHRINKRES-100 > URL: https://issues.jboss.org/browse/SHRINKRES-100 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Components: maven > Reporter: Karel Piwko > Labels: api-change > > When packaging resources to via MavenImporter, any filters defined on the path are ignored. Add support for applying filters. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

8 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKRES-100) Allow Maven resource filtering to be applied for resources imported via MavenImporter

by Yannick Majoros (JIRA)

[ https://issues.jboss.org/browse/SHRINKRES-100?page=com.atlassian.jira.plu... ] Yannick Majoros commented on SHRINKRES-100: ------------------------------------------- Sure, there are many ways. I'm quite sure the best way to cover them is let maven do the filtering, and start later. Things like basic maven resource filtering should definitively work. > Allow Maven resource filtering to be applied for resources imported via MavenImporter > ------------------------------------------------------------------------------------- > > Key: SHRINKRES-100 > URL: https://issues.jboss.org/browse/SHRINKRES-100 > Project: ShrinkWrap Resolvers > Issue Type: Feature Request > Components: maven > Reporter: Karel Piwko > Labels: api-change > > When packaging resources to via MavenImporter, any filters defined on the path are ignored. Add support for applying filters. -- This message was sent by Atlassian JIRA (v6.3.15#6346)

8 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues May 2015