June 2016 - shrinkwrap-issues - Jboss List Archives

[JBoss JIRA] (SHRINKWRAP-508) URLPackageScanner prefix not correctly set when Classloader is not set to WAR root

by Ken Finnigan (JIRA)

Ken Finnigan created SHRINKWRAP-508: --------------------------------------- Summary: URLPackageScanner prefix not correctly set when Classloader is not set to WAR root Key: SHRINKWRAP-508 URL: https://issues.jboss.org/browse/SHRINKWRAP-508 Project: ShrinkWrap Issue Type: Bug Affects Versions: 1.2.5 Reporter: Ken Finnigan If a modular classloader for a WAR is set with a relative path instead of the root, i.e. starting at 'WEB-INF/classes', then URLPackageScanner.loadResources() successfully finds a resource without a 'prefix' being set. However, handleArchiveByFile() is then unable to find the class without a prefix being set to 'WEB-INF/classes' -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-507) addPackage() fails to find class if resources in WEB-INF

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-507?page=com.atlassian.jira.pl... ] Andrew Rubinger closed SHRINKWRAP-507. -------------------------------------- > addPackage() fails to find class if resources in WEB-INF > -------------------------------------------------------- > > Key: SHRINKWRAP-507 > URL: https://issues.jboss.org/browse/SHRINKWRAP-507 > Project: ShrinkWrap > Issue Type: Bug > Affects Versions: 1.2.4 > Reporter: Ken Finnigan > Assignee: Ken Finnigan > Fix For: 1.2.5 > > > With the change introduced by SHRINKWRAP-505, it doesn't cover the following situation. > If I have a JarArchive that contains classes at the root, as its a jar, but if it happens to have files places in '/WEB-INF/..' then this change makes the assumption that all classes should be found in '/WEB-INF/classes/'. > Where it scans for packages shouldn't rely on the presence of a file at a particular location, but try each and see which actually succeeds. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-507) addPackage() fails to find class if resources in WEB-INF

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-507?page=com.atlassian.jira.pl... ] Andrew Rubinger updated SHRINKWRAP-507: --------------------------------------- Status: Resolved (was: Pull Request Sent) Fix Version/s: 1.2.5 Resolution: Done https://github.com/shrinkwrap/shrinkwrap/commit/ea62a65d7765770e7c93f8872... > addPackage() fails to find class if resources in WEB-INF > -------------------------------------------------------- > > Key: SHRINKWRAP-507 > URL: https://issues.jboss.org/browse/SHRINKWRAP-507 > Project: ShrinkWrap > Issue Type: Bug > Affects Versions: 1.2.4 > Reporter: Ken Finnigan > Assignee: Ken Finnigan > Fix For: 1.2.5 > > > With the change introduced by SHRINKWRAP-505, it doesn't cover the following situation. > If I have a JarArchive that contains classes at the root, as its a jar, but if it happens to have files places in '/WEB-INF/..' then this change makes the assumption that all classes should be found in '/WEB-INF/classes/'. > Where it scans for packages shouldn't rely on the presence of a file at a particular location, but try each and see which actually succeeds. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-507) addPackage() fails to find class if resources in WEB-INF

by Ken Finnigan (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-507?page=com.atlassian.jira.pl... ] Ken Finnigan reassigned SHRINKWRAP-507: --------------------------------------- Assignee: Ken Finnigan > addPackage() fails to find class if resources in WEB-INF > -------------------------------------------------------- > > Key: SHRINKWRAP-507 > URL: https://issues.jboss.org/browse/SHRINKWRAP-507 > Project: ShrinkWrap > Issue Type: Bug > Affects Versions: 1.2.4 > Reporter: Ken Finnigan > Assignee: Ken Finnigan > > With the change introduced by SHRINKWRAP-505, it doesn't cover the following situation. > If I have a JarArchive that contains classes at the root, as its a jar, but if it happens to have files places in '/WEB-INF/..' then this change makes the assumption that all classes should be found in '/WEB-INF/classes/'. > Where it scans for packages shouldn't rely on the presence of a file at a particular location, but try each and see which actually succeeds. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-507) addPackage() fails to find class if resources in WEB-INF

by Ken Finnigan (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-507?page=com.atlassian.jira.pl... ] Ken Finnigan updated SHRINKWRAP-507: ------------------------------------ Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/shrinkwrap/shrinkwrap/pull/100 > addPackage() fails to find class if resources in WEB-INF > -------------------------------------------------------- > > Key: SHRINKWRAP-507 > URL: https://issues.jboss.org/browse/SHRINKWRAP-507 > Project: ShrinkWrap > Issue Type: Bug > Affects Versions: 1.2.4 > Reporter: Ken Finnigan > > With the change introduced by SHRINKWRAP-505, it doesn't cover the following situation. > If I have a JarArchive that contains classes at the root, as its a jar, but if it happens to have files places in '/WEB-INF/..' then this change makes the assumption that all classes should be found in '/WEB-INF/classes/'. > Where it scans for packages shouldn't rely on the presence of a file at a particular location, but try each and see which actually succeeds. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-507) addPackage() fails to find class if resources in WEB-INF

by Ken Finnigan (JIRA)

Ken Finnigan created SHRINKWRAP-507: --------------------------------------- Summary: addPackage() fails to find class if resources in WEB-INF Key: SHRINKWRAP-507 URL: https://issues.jboss.org/browse/SHRINKWRAP-507 Project: ShrinkWrap Issue Type: Bug Affects Versions: 1.2.4 Reporter: Ken Finnigan With the change introduced by SHRINKWRAP-505, it doesn't cover the following situation. If I have a JarArchive that contains classes at the root, as its a jar, but if it happens to have files places in '/WEB-INF/..' then this change makes the assumption that all classes should be found in '/WEB-INF/classes/'. Where it scans for packages shouldn't rely on the presence of a file at a particular location, but try each and see which actually succeeds. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-504) Add ZipStoredExporter

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-504?page=com.atlassian.jira.pl... ] Andrew Rubinger closed SHRINKWRAP-504. -------------------------------------- > Add ZipStoredExporter > --------------------- > > Key: SHRINKWRAP-504 > URL: https://issues.jboss.org/browse/SHRINKWRAP-504 > Project: ShrinkWrap > Issue Type: Enhancement > Reporter: Alex Soto > Priority: Blocker > Labels: enhancement, zip > Fix For: 1.2.4 > > > Add ZipStoredExporter class so instead of exporting files as zip with deflated compression, you can also output a zip in stored method. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-505) Allow archive.addPackage() flavors to slurp from a .war

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-505?page=com.atlassian.jira.pl... ] Andrew Rubinger closed SHRINKWRAP-505. -------------------------------------- > Allow archive.addPackage() flavors to slurp from a .war > ------------------------------------------------------- > > Key: SHRINKWRAP-505 > URL: https://issues.jboss.org/browse/SHRINKWRAP-505 > Project: ShrinkWrap > Issue Type: Feature Request > Reporter: Bob McWhirter > Assignee: Bob McWhirter > Fix For: 1.2.4 > > > In WildFly Swarm, we have the case where a .war is on the classpath or otherwise available for constructing subsequent ShrinkWrap archives. > In the case of > {code} > JavaArchive archive = ... > archive.addPacakge( "some.package.in.the.war" ); > {code} > ... the classes are not locatable from the .war, given the URL shenanigans that occur and the ClassLoader asset that is used ultimately to load them. > Ultimately URLPackageScanner should be smart enough to know that classes inside a .war-centric URL are relocated under {WEB-INF/classes}. > PR is en-route, please hold. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-503) Add Asset as parameter in startAsset AbstractOnDemandInputStream class

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-503?page=com.atlassian.jira.pl... ] Andrew Rubinger closed SHRINKWRAP-503. -------------------------------------- > Add Asset as parameter in startAsset AbstractOnDemandInputStream class > ---------------------------------------------------------------------- > > Key: SHRINKWRAP-503 > URL: https://issues.jboss.org/browse/SHRINKWRAP-503 > Project: ShrinkWrap > Issue Type: Enhancement > Reporter: Alex Soto > Priority: Minor > Fix For: 1.2.4 > > > Add Asset as parameter in startAsset AbstractOnDemandInputStream class (https://github.com/shrinkwrap/shrinkwrap/blob/master/impl-base/src/main/j...) > This is important because when you want to create a ZipExporter without using compression, you need to specify the size of the file or calculate the crc of the file. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

[JBoss JIRA] (SHRINKWRAP-505) Allow archive.addPackage() flavors to slurp from a .war

by Andrew Rubinger (JIRA)

[ https://issues.jboss.org/browse/SHRINKWRAP-505?page=com.atlassian.jira.pl... ] Andrew Rubinger updated SHRINKWRAP-505: --------------------------------------- Status: Resolved (was: Pull Request Sent) Fix Version/s: 1.2.4 Resolution: Done > Allow archive.addPackage() flavors to slurp from a .war > ------------------------------------------------------- > > Key: SHRINKWRAP-505 > URL: https://issues.jboss.org/browse/SHRINKWRAP-505 > Project: ShrinkWrap > Issue Type: Feature Request > Reporter: Bob McWhirter > Assignee: Bob McWhirter > Fix For: 1.2.4 > > > In WildFly Swarm, we have the case where a .war is on the classpath or otherwise available for constructing subsequent ShrinkWrap archives. > In the case of > {code} > JavaArchive archive = ... > archive.addPacakge( "some.package.in.the.war" ); > {code} > ... the classes are not locatable from the .war, given the URL shenanigans that occur and the ClassLoader asset that is used ultimately to load them. > Ultimately URLPackageScanner should be smart enough to know that classes inside a .war-centric URL are relocated under {WEB-INF/classes}. > PR is en-route, please hold. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

shrinkwrap-issues June 2016