[
https://jira.jboss.org/browse/SHRINKWRAP-232?page=com.atlassian.jira.plug...
]
Aslak Knutsen commented on SHRINKWRAP-232:
------------------------------------------
We need to return a disconnected Node. ArchivePath is a pointer to a Node, not an Asset. A
Node can contain multiple Assets.
Return asset removed by delete method instead of a boolean
----------------------------------------------------------
Key: SHRINKWRAP-232
URL:
https://jira.jboss.org/browse/SHRINKWRAP-232
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-11
Reporter: Dan Allen
Fix For: 1.0.0-alpha-12
The Archive#delete(ArchivePath) operation should return the Asset (or Node) being removed
(at the specified ArchivePath) rather than returning boolean. This both avoids having to
have an extra call to get the asset before removing it, and it's consistent with the
familiar behavior of the JDK Map API.
// Removes the Asset in the archive at the specified Path and returns the removed Asset
Node delete(ArchivePath path);
The only thing I'm not sure about is whether the Asset return type is sufficient for
when you delete a directory path.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira