[shrinkwrap-issues] [JBoss JIRA] Resolved: (SHRINKWRAP-106) ClassContainer "addClass" methods do not account for inner classes

ClassContainer "addClass" methods do not account for inner classes ------------------------------------------------------------------ Key: SHRINKWRAP-106 URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-106 Project: ShrinkWrap Issue Type: Bug Affects Versions: 1.0.0-alpha-2 Reporter: Andrew Lee Rubinger Assignee: Aslak Knutsen Fix For: 1.0.0-alpha-3 Assuming: public class TopLevelClass { private static class InnerClass{} } ...and: getClassContainer().addClasses(TopLevelClass.class); log.info(getArchive().toString(true)); ...output is: test@jboss:/$ ls -l f59005e3-0dcc-417e-84fd-2f35ab8ae18f.jar f59005e3-0dcc-417e-84fd-2f35ab8ae18f.jar: /org/jboss/shrinkwrap/impl/base/spec/TopLevelClass.class This is especially problematic where the caller cannot access the inner class due to visibility constraints. It'll be missing from the runtime. Discuss the rules we should apply (regarding hierarchy) on the forum.