[
https://issues.jboss.org/browse/SHRINKDESC-54?page=com.atlassian.jira.plu...
]
Ralf Battenfeld commented on SHRINKDESC-54:
-------------------------------------------
Thanks Aslak for the comments. I am trying to answer it:
* WebApp30Descriptor vs WebAppDescriptor
--> I will have a look but it should be simple to get rid of the version
* getAllServlet() removeAllServlet() vs getAllServlets() removeAllServlets()
--> To add (s) for plural works maybe for 70% for all cases but not for all in an
automanted way.
Do you have a better solution than getAllXX(), I will be very happy to implement
it
* unset distributable()
--> This I will correct. We agreed to support CRUD on all elements or
attributes.
* WebAppVersionType._3_0 vs WebAppVersionType.3_0
--> The extra underscore is related to some of the defined enums which cannot be
transfered 100%
to java enums. They start for example with numbers like 1.x or 2.x. I wanted to
have a procedure
that works for all enums. But if you wish, I can check if the enum name starts
with a number and
only then a underscore will be added.
* Missing some xml escape in javadoc comments
--> I am not sure what the problem is here. Looking at the original
documentation, it should be
one to one the same. Is it the '[' character?
* getOrCreate on elements that support multiple ?
--> Yes, in case of a multiple element, if returns the first one, if already
created or creates a new
one, if no element was defined before.
Develop/split EE Spec and JBoss-specific descriptors in API / Impl
Split
------------------------------------------------------------------------
Key: SHRINKDESC-54
URL:
https://issues.jboss.org/browse/SHRINKDESC-54
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Andrew Rubinger
Assignee: Ralf Battenfeld
Fix For: 1.2.0-alpha-1
This task to track the extensive refactoring and reworking of Descriptors as done through
the POC offered by Ralf Battenfeld.
--
This message is automatically generated by JIRA.
For more information on JIRA, see:
http://www.atlassian.com/software/jira