[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-240) addServiceProvider should add class to archive
[
https://jira.jboss.org/browse/SHRINKWRAP-240?page=com.atlassian.jira.plug...
]
Aslak Knutsen commented on SHRINKWRAP-240:
------------------------------------------
The reason why it's not like that is currently:
addServiceProvider is a feature of the ManifestContainer since it is adding to
META-INF/..
and addClass belongs to ClassContainer. I found it odd to by contract of
addServiceProvider link those two containers, even tho they are in our backing impl.
On another note.. a ServiceProvider file is really a Descriptor isn't it? Since it
operates on file content. And if moved to Descriptors, should the same rules for adding
classes apply?
addServiceProvider should add class to archive
----------------------------------------------
Key: SHRINKWRAP-240
URL: https://jira.jboss.org/browse/SHRINKWRAP-240
Project: ShrinkWrap
Issue Type: Feature Request
Components: api
Affects Versions: 1.0.0-alpha-11
Reporter: Dan Allen
Priority: Minor
My intuition tells me that addServiceProvider should add the service provider classes I
specify to the archive. To my surprise, it does not. I can't see any scenario in which
you specify a service provider for a class that isn't in the archive. For the edge
case, you could always extract it manually after the call to addServiceProvider.
Currently:
addClass(MyServiceImpl.class).addServiceProvider(Service.class, MyServiceImpl.class)
Proposed:
addServiceProvider(Service.class, MyServiceImpl.class)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira