[shrinkwrap-issues] [JBoss JIRA] (SHRINKRES-66) Allow "resolve" to take in Collections<String> and Collection<MavenDependency>
[
https://issues.jboss.org/browse/SHRINKRES-66?page=com.atlassian.jira.plug...
]
Andrew Rubinger commented on SHRINKRES-66:
------------------------------------------
We need to debate how to go about API name changes here. Collections<String> and
Collection<MavenDependency> will have the same erasure when the compiler is done
with them, so we might start to explore renaming all the "resolve" methods to be
specific as to their input types.
Allow "resolve" to take in Collections<String> and
Collection<MavenDependency>
------------------------------------------------------------------------------
Key: SHRINKRES-66
URL: https://issues.jboss.org/browse/SHRINKRES-66
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Affects Versions: 2.0.0-alpha-2, 2.0.0-alpha-3
Reporter: Andrew Rubinger
Labels: starter
From Craig Ringer:
-----------
Since `resolve(…)` doesn’t take a `Collection`, only an array, I have to accumulate in a
set or list then pass an array view of it to resolve(), eg given a Set artifacts:
{code}archive.addAsLibraries(resolver.resolve(artifacts.toArray(new
String[artifacts.size()])).withTransitivity().as(File.class));{code}
-----------
Save the user the extra step of having to convert Collections to an array by enhancing
the API to accept Collections natively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira