[
https://issues.jboss.org/browse/SHRINKDESC-54?page=com.atlassian.jira.plu...
]
Aslak Knutsen edited comment on SHRINKDESC-54 at 8/21/11 3:18 PM:
------------------------------------------------------------------
Just a few comments from the latest build:
* WebApp30Descriptor vs WebAppDescriptor
We have version in the PackageName already, org.jboss.shrinkwrap.descriptor.api.webapp30
* getAllServlet() removeAllServlet() vs getAllServlets() removeAllServlets()
Since we can remove multiple, the API should reflect that in plural form
* unset distributable()
Boolean distributable can be set and read(isDistributable), but not unset
* WebAppVersionType._3_0 vs WebAppVersionType.3_0
Why the extra underscore? And if we have one generated 'package' pr version, do we
need to set the version at all ?
* Missing some xml escape in javadoc comments
See the Example:
http://jboss.hudson.alrubinger.com/job/Descriptors_1.2.0-X/javadoc/org/jb...
* getOrCreate on elements that support multiple ?
getOrCreateFilter() get a previous created Filter if any or create one?
was (Author: aslak):
Just a few comments from the latest build:
* WebApp30Descriptor vs WebAppDescriptor
We have version in the PackageName already, org.jboss.shrinkwrap.descriptor.api.webapp30
* getAllServlet() removeAllServlet() vs getAllServlets() removeAllServlets()
Since we can remove multiple, the API should reflect that in plural form
* unset distributable()
Boolean distributable can be set and read(isDistributable), but not unset
* WebAppVersionType._3_0 vs WebAppVersionType.3_0
Why the extra underscore? And if we have one generated 'package' pr version, do we
need to set the version at all ?
* Missing some xml escape in javadoc comments
See the Example:
http://jboss.hudson.alrubinger.com/job/Descriptors_1.2.0-X/javadoc/org/jb...
Develop/split EE Spec and JBoss-specific descriptors in API / Impl
Split
------------------------------------------------------------------------
Key: SHRINKDESC-54
URL:
https://issues.jboss.org/browse/SHRINKDESC-54
Project: ShrinkWrap Descriptors
Issue Type: Task
Reporter: Andrew Rubinger
Assignee: Ralf Battenfeld
Fix For: 1.2.0-alpha-1
This task to track the extensive refactoring and reworking of Descriptors as done through
the POC offered by Ralf Battenfeld.
--
This message is automatically generated by JIRA.
For more information on JIRA, see:
http://www.atlassian.com/software/jira