[ https://issues.jboss.org/browse/SHRINKDESC-90?page=com.atlassian.jira.plu... ] Bartosz Majsak updated SHRINKDESC-90: ------------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/shrinkwrap/descriptors/pull/46 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-90?page=com.atlassian.jira.plu... ] Andrew Rubinger updated SHRINKDESC-90: -------------------------------------- Attachment: codecoverage.png Some more coverage missing on: NodeDescriptorExporterImpl NodeDescriptorImporterBase DescriptorImporterBase DescriptorImplBase -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-90?page=com.atlassian.jira.plu... ] Bartosz Majsak updated SHRINKDESC-90: ------------------------------------- Attachment: merged-coverage.png -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-90?page=com.atlassian.jira.plu... ] Andrew Rubinger commented on SHRINKDESC-90: ------------------------------------------- Yes, my shot just talks about coverage from the SPI module itself. If we take a strict definition of applying coverage at the unit/lowest-possible-level, then we should apply as much as we can in the SPI module. Though absolutely the project is well-covered when we take into account impl-base. See if you agree, weigh the effort involved in adding more, and you can either put some more stuff in or resolve this outright - your call. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-90?page=com.atlassian.jira.plu... ] Anonymous updated SHRINKDESC-90: -------------------------------- Status: Pull Request Sent (was: Reopened) Git Pull Request: https://github.com/shrinkwrap/descriptors/pull/47 (was: https://github.com/shrinkwrap/descriptors/pull/46) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SHRINKDESC-90?page=com.atlassian.jira.plu... ] Andrew Rubinger updated SHRINKDESC-90: -------------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done Second pull request upstream: https://github.com/shrinkwrap/descriptors/commit/4fa7fa1233d3006250780037... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira