6:48 p.m.
Create a Unified Importer API
-----------------------------
Key: SHRINKWRAP-112
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-112
Project: ShrinkWrap
Issue Type: Feature Request
Reporter: Aslak Knutsen
Importer
from(String)
from(new File(String))
from(File)
File.isFile -> LookupImporterType -> ZipImporter
File.isDirectory -> ExplodedImporter
from(URL)
URL.getFile.isDirectory -> ExplodedImporter
URL.getExtension -> LookupImporterType -> ZipImporter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:17 p.m.
New subject: [JBoss JIRA] Assigned: (SHRINKWRAP-112) Create a Unified Importer API
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-112?page=com.atlassian.jira...
]
Aslak Knutsen reassigned SHRINKWRAP-112:
----------------------------------------
Assignee: Aslak Knutsen
Create a Unified Importer API
-----------------------------
Key: SHRINKWRAP-112
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-112
Project: ShrinkWrap
Issue Type: Feature Request
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Importer
from(String)
from(new File(String))
from(File)
File.isFile -> LookupImporterType -> ZipImporter
File.isDirectory -> ExplodedImporter
from(URL)
URL.getFile.isDirectory -> ExplodedImporter
URL.getExtension -> LookupImporterType -> ZipImporter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:43 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-112) Create a Unified Importer API
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-112?page=com.atlassian.jira...
]
Andrew Lee Rubinger commented on SHRINKWRAP-112:
------------------------------------------------
Let's discuss on forum:
Why interpret String as new File() ?
Why assume a URL is local and can be represented as a File?
In an attempt to add user-friendly hooks I fear we become too opinionated at best and
unpredictable at worst.
Create a Unified Importer API
-----------------------------
Key: SHRINKWRAP-112
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-112
Project: ShrinkWrap
Issue Type: Feature Request
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Importer
from(String)
from(new File(String))
from(File)
File.isFile -> LookupImporterType -> ZipImporter
File.isDirectory -> ExplodedImporter
from(URL)
URL.getFile.isDirectory -> ExplodedImporter
URL.getExtension -> LookupImporterType -> ZipImporter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:39 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-112) Create a Unified Importer API
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-112?page=com.atlassian.jira...
]
Aslak Knutsen commented on SHRINKWRAP-112:
------------------------------------------
Easier said then done atm since the forums seems to be down.. :)
This is the current impl:
http://shrinkwrap.pastebin.com/m58f16a3a
from(String)
- from(new File(String))
from(File)
- File.isFile -> (should delegate to a lookup of a supported importer( based on
extension?)) -> ZipImporter
- File.isDirectory -> ExplodedImporter
from(URL)
- URL.getProtocol == file:// -> from(new File(url))
- URL.getName -> (should delegate to a lookup of a supported importer( based on
extension?)) -> ZipImporter
Looking at the current usage (http://pastie.org/763558); not supporting this creates a lot
of useless/boilerplate code. :)
It would be more consistent with the rest of the apis use of String if it is a lookup in
the ClassLoader instead..
Create a Unified Importer API
-----------------------------
Key: SHRINKWRAP-112
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-112
Project: ShrinkWrap
Issue Type: Feature Request
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Importer
from(String)
from(new File(String))
from(File)
File.isFile -> LookupImporterType -> ZipImporter
File.isDirectory -> ExplodedImporter
from(URL)
URL.getFile.isDirectory -> ExplodedImporter
URL.getExtension -> LookupImporterType -> ZipImporter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:48 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-112) Create a Unified Importer API
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-112?page=com.atlassian.jira...
]
Adrian Cole commented on SHRINKWRAP-112:
----------------------------------------
I think that from(String) should be reasonably capable of determining if it is a url or
not.
Having this in shrinkwrap would really help reduce the effort needed, and libraries
needed, for things like ant task writing dramatically
Create a Unified Importer API
-----------------------------
Key: SHRINKWRAP-112
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-112
Project: ShrinkWrap
Issue Type: Feature Request
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Importer
from(String)
from(new File(String))
from(File)
File.isFile -> LookupImporterType -> ZipImporter
File.isDirectory -> ExplodedImporter
from(URL)
URL.getFile.isDirectory -> ExplodedImporter
URL.getExtension -> LookupImporterType -> ZipImporter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:48 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-112) Create a Unified Importer API
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-112?page=com.atlassian.jira...
]
Andrew Lee Rubinger commented on SHRINKWRAP-112:
------------------------------------------------
Given:
from(String) > from(new File(String))
...what would you expect of:
from("http://mydomain.com/resource.xml")
...? We need to support both URL and File representations of the accepted String, and do
it correctly.
------
Given:
from(URL) > from(new File(URL))
...what would you expect of:
from(new URL("http://mydomain.com/resource.xml"))
...?
In short, I like this feature. Let's iron out a way to make it work consistently for
all cases when the forums become available again. :)
Create a Unified Importer API
-----------------------------
Key: SHRINKWRAP-112
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-112
Project: ShrinkWrap
Issue Type: Feature Request
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Importer
from(String)
from(new File(String))
from(File)
File.isFile -> LookupImporterType -> ZipImporter
File.isDirectory -> ExplodedImporter
from(URL)
URL.getFile.isDirectory -> ExplodedImporter
URL.getExtension -> LookupImporterType -> ZipImporter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:47 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-112) Create a Unified Importer API
[
https://jira.jboss.org/jira/browse/SHRINKWRAP-112?page=com.atlassian.jira...
]
Aslak Knutsen commented on SHRINKWRAP-112:
------------------------------------------
quote:
Given:
from(URL) > from(new File(URL))
...what would you expect of:
from(new URL("http://mydomain.com/resource.xml"))
...?
'http://mydomain.com/resource.xml' is not a file:// protocol, so it won't be
delegated to from(new File(url)).
It should try to get the file name 'resource.xml' and lookup the extension
'xml' for a known Import handler. and use url.openStream to fetch the content.
This will open up support for any URLStreamHandler(webdav, ssh, ftp) defined for the JVM.
If no one found, we could hope for Zip or fail..
Create a Unified Importer API
-----------------------------
Key: SHRINKWRAP-112
URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-112
Project: ShrinkWrap
Issue Type: Feature Request
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Importer
from(String)
from(new File(String))
from(File)
File.isFile -> LookupImporterType -> ZipImporter
File.isDirectory -> ExplodedImporter
from(URL)
URL.getFile.isDirectory -> ExplodedImporter
URL.getExtension -> LookupImporterType -> ZipImporter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5935
days inactive
5937
days old
shrinkwrap-issues@lists.jboss.org
6 comments
3 participants
participants (3)
-
Adrian Cole (JIRA) -
Andrew Lee Rubinger (JIRA)
-
Aslak Knutsen (JIRA)