12:16 a.m.
MavenDependencyResolver.artifact( Class cls )
---------------------------------------------
Key: SHRINKWRAP-270
URL: https://issues.jboss.org/browse/SHRINKWRAP-270
Project: ShrinkWrap
Issue Type: Feature Request
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Ondrej Zizka
Assignee: Karel Piwko
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:13 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-270) MavenDependencyResolver.artifact( Class cls )
[
https://issues.jboss.org/browse/SHRINKWRAP-270?page=com.atlassian.jira.pl...
]
Karel Piwko commented on SHRINKWRAP-270:
----------------------------------------
Hi Ondra,
although I can imagine that we can get META-INF content for a jar file from the class path
and if the archive contains pom.xml file
we can get GAV, but I would like to spawn a discussion with pros/cons.
I didn't do any research on this area, nevertheless it is true that I have developed
another tool for accessing such metadata.
Can you spawn such discussion in Arquillian forums on jboss.org?
MavenDependencyResolver.artifact( Class cls )
---------------------------------------------
Key: SHRINKWRAP-270
URL: https://issues.jboss.org/browse/SHRINKWRAP-270
Project: ShrinkWrap
Issue Type: Feature Request
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Ondrej Zizka
Assignee: Karel Piwko
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:03 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-270) MavenDependencyResolver.artifact( Class cls )
[
https://issues.jboss.org/browse/SHRINKWRAP-270?page=com.atlassian.jira.pl...
]
Karel Piwko commented on SHRINKWRAP-270:
----------------------------------------
Ondra,
did you generated some discussion for this?
MavenDependencyResolver.artifact( Class cls )
---------------------------------------------
Key: SHRINKWRAP-270
URL: https://issues.jboss.org/browse/SHRINKWRAP-270
Project: ShrinkWrap
Issue Type: Feature Request
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Ondrej Zizka
Assignee: Karel Piwko
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:57 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKWRAP-270) MavenDependencyResolver.artifact( Class cls )
[
https://issues.jboss.org/browse/SHRINKWRAP-270?page=com.atlassian.jira.pl...
]
Ondrej Zizka commented on SHRINKWRAP-270:
-----------------------------------------
Not in terms of creating a topic on JBoss.org.
MavenDependencyResolver.artifact( Class cls )
---------------------------------------------
Key: SHRINKWRAP-270
URL: https://issues.jboss.org/browse/SHRINKWRAP-270
Project: ShrinkWrap
Issue Type: Feature Request
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Ondrej Zizka
Assignee: Karel Piwko
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:34 p.m.
New subject: [JBoss JIRA] (SHRINKWRAP-270) MavenDependencyResolver.artifact( Class cls )
[
https://issues.jboss.org/browse/SHRINKWRAP-270?page=com.atlassian.jira.pl...
]
Karel Piwko updated SHRINKWRAP-270:
-----------------------------------
Assignee: (was: Karel Piwko)
MavenDependencyResolver.artifact( Class cls )
---------------------------------------------
Key: SHRINKWRAP-270
URL: https://issues.jboss.org/browse/SHRINKWRAP-270
Project: ShrinkWrap
Issue Type: Feature Request
Components: ext-resolver
Affects Versions: 1.0.0-alpha-12
Reporter: Ondrej Zizka
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:21 a.m.
New subject: [JBoss JIRA] (SHRINKRES-7) MavenDependencyResolver.artifact( Class cls )
[
https://issues.jboss.org/browse/SHRINKRES-7?page=com.atlassian.jira.plugi...
]
Andrew Rubinger commented on SHRINKRES-7:
-----------------------------------------
While this feature may be useful, I don't think this makes sense as
"artifact(Class<?>)" from an API perspective. I beleiev this looks more
analogous to yum's "whatprovides" command, where we attempt first to resolve
a GAV, and then resolve an artifact from that GAV.
MavenDependencyResolver.artifact( Class cls )
---------------------------------------------
Key: SHRINKRES-7
URL: https://issues.jboss.org/browse/SHRINKRES-7
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Reporter: Ondrej Zizka
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:59 p.m.
New subject: [JBoss JIRA] (SHRINKRES-7) MavenDependencyResolver.artifact( Class cls )
[
https://issues.jboss.org/browse/SHRINKRES-7?page=com.atlassian.jira.plugi...
]
Ondrej Zizka commented on SHRINKRES-7:
--------------------------------------
+1
MavenDependencyResolver.artifact( Class cls )
---------------------------------------------
Key: SHRINKRES-7
URL: https://issues.jboss.org/browse/SHRINKRES-7
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Reporter: Ondrej Zizka
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:48 a.m.
New subject: [JBoss JIRA] (SHRINKRES-7) MavenDependencyResolver.artifact( Class cls )
[
https://issues.jboss.org/browse/SHRINKRES-7?page=com.atlassian.jira.plugi...
]
Andrew Rubinger edited comment on SHRINKRES-7 at 9/22/12 5:47 AM:
------------------------------------------------------------------
While this feature may be useful, I don't think this makes sense as
"artifact(Class<?>)" from an API perspective. I believe this looks more
analogous to yum's "whatprovides" command, where we attempt first to resolve
a GAV, and then resolve an artifact from that GAV.
was (Author: alrubinger):
While this feature may be useful, I don't think this makes sense as
"artifact(Class<?>)" from an API perspective. I beleiev this looks more
analogous to yum's "whatprovides" command, where we attempt first to resolve
a GAV, and then resolve an artifact from that GAV.
MavenDependencyResolver.artifact( Class cls )
---------------------------------------------
Key: SHRINKRES-7
URL: https://issues.jboss.org/browse/SHRINKRES-7
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Reporter: Ondrej Zizka
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:48 a.m.
New subject: [JBoss JIRA] (SHRINKRES-7) Resolve GAV (ie. MavenDependency) from Class<?>
[
https://issues.jboss.org/browse/SHRINKRES-7?page=com.atlassian.jira.plugi...
]
Andrew Rubinger updated SHRINKRES-7:
------------------------------------
Summary: Resolve GAV (ie. MavenDependency) from Class<?> (was:
MavenDependencyResolver.artifact( Class cls ))
Resolve GAV (ie. MavenDependency) from Class<?>
-----------------------------------------------
Key: SHRINKRES-7
URL: https://issues.jboss.org/browse/SHRINKRES-7
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Reporter: Ondrej Zizka
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:53 a.m.
New subject: [JBoss JIRA] (SHRINKRES-7) Resolve GAV (ie. MavenDependency) from Class<?>
[
https://issues.jboss.org/browse/SHRINKRES-7?page=com.atlassian.jira.plugi...
]
Andrew Rubinger commented on SHRINKRES-7:
-----------------------------------------
I think it may make sense in the 2.0.0-alpha API to do something like:
{code}class MavenCoordinates{
public static MavenCoordinate whatProvides(Class<?> clazz) throws
IllegalArgumentException, SomeOtherNoResolvedGAVException(){...}{code}
Resolve GAV (ie. MavenDependency) from Class<?>
-----------------------------------------------
Key: SHRINKRES-7
URL: https://issues.jboss.org/browse/SHRINKRES-7
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Reporter: Ondrej Zizka
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:53 a.m.
New subject: [JBoss JIRA] (SHRINKRES-7) Resolve GAV (ie. MavenDependency) from Class<?>
[
https://issues.jboss.org/browse/SHRINKRES-7?page=com.atlassian.jira.plugi...
]
Andrew Rubinger edited comment on SHRINKRES-7 at 9/22/12 5:53 AM:
------------------------------------------------------------------
I think it may make sense in the 2.0.0-alpha API to do something like:
{code}class MavenCoordinates{
public static MavenCoordinate whatProvides(Class<?> clazz) throws
IllegalArgumentException, SomeOtherNoResolvedGAVException(){...}{code}
Then the returned MavenCoordinate can be used to make a MavenDependency, which can be used
to resolve.
...thoughts?
was (Author: alrubinger):
I think it may make sense in the 2.0.0-alpha API to do something like:
{code}class MavenCoordinates{
public static MavenCoordinate whatProvides(Class<?> clazz) throws
IllegalArgumentException, SomeOtherNoResolvedGAVException(){...}{code}
Resolve GAV (ie. MavenDependency) from Class<?>
-----------------------------------------------
Key: SHRINKRES-7
URL: https://issues.jboss.org/browse/SHRINKRES-7
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Reporter: Ondrej Zizka
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:44 a.m.
New subject: [JBoss JIRA] (SHRINKRES-7) Resolve GAV (ie. MavenDependency) from Class<?>
[
https://issues.jboss.org/browse/SHRINKRES-7?page=com.atlassian.jira.plugi...
]
Karel Piwko commented on SHRINKRES-7:
-------------------------------------
In general it should work. However, we need to handle (at least) two more scenarios:
* Class is on classpath but not provided by any GAV
- part of the project itself
- part of system java library
- added on classpath manually
* Class is on classpath multiple times
- there might be same class name in provided/test scope, it would be difficult to
distinguish between those
The difficult part is to figure out pom.xml/gav from classpath. The code for
ClasspathWorkspaceReader could be reused though.
Resolve GAV (ie. MavenDependency) from Class<?>
-----------------------------------------------
Key: SHRINKRES-7
URL: https://issues.jboss.org/browse/SHRINKRES-7
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Reporter: Ondrej Zizka
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:13 a.m.
New subject: [JBoss JIRA] (SHRINKRES-7) Resolve GAV (ie. MavenDependency) from Class<?>
[
https://issues.jboss.org/browse/SHRINKRES-7?page=com.atlassian.jira.plugi...
]
Andrew Rubinger commented on SHRINKRES-7:
-----------------------------------------
* Class on ClassPath but not provided by any GAV: unchecked exception, similar to
NoResolutionException
* Class on ClassPath many times: unchecked exception, similar to
NonUniqueResolutionException
* Same class name in different scopes: huh? A Class will resolve to a GAV based upon the
ClassLoader given to the "whatProvides" call (ie. Class.getClassLoader())
Makes sense?
Resolve GAV (ie. MavenDependency) from Class<?>
-----------------------------------------------
Key: SHRINKRES-7
URL: https://issues.jboss.org/browse/SHRINKRES-7
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Reporter: Ondrej Zizka
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:48 a.m.
New subject: [JBoss JIRA] (SHRINKRES-7) Resolve GAV (ie. MavenDependency) from Class<?>
[
https://issues.jboss.org/browse/SHRINKRES-7?page=com.atlassian.jira.plugi...
]
Karel Piwko commented on SHRINKRES-7:
-------------------------------------
Yes, all three make sense, Same class name in different scope is actually class on
classpath many times, scope defined in pom.xml does really not matter here.
Resolve GAV (ie. MavenDependency) from Class<?>
-----------------------------------------------
Key: SHRINKRES-7
URL: https://issues.jboss.org/browse/SHRINKRES-7
Project: ShrinkWrap Resolvers
Issue Type: Feature Request
Reporter: Ondrej Zizka
Currently, MavenDependencyResolver.artifact() only accepts String.
I suggest to add .artifact( Class cls ) which would seek the G:A:V in metadata of the jar
which contains this class's package.
I think Karel Piwko did some research on this recently, right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4236
days inactive
4774
days old
shrinkwrap-issues@lists.jboss.org
13 comments
4 participants
participants (4)
-
Andrew Rubinger (JIRA) -
Karel Piwko (JIRA)
-
Karel Piwko (Updated) (JIRA)
-
Ondrej Zizka (JIRA)