[JBoss JIRA] Created: (SHRINKDESC-41) PersistenceUnitDefImpl does not remove non-jta-data-source when configuring jta-data-source (and visa versa)
3:55 a.m.
PersistenceUnitDefImpl does not remove non-jta-data-source when configuring
jta-data-source (and visa versa)
------------------------------------------------------------------------------------------------------------
Key: SHRINKDESC-41
URL: https://issues.jboss.org/browse/SHRINKDESC-41
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: api
Affects Versions: 0.1.3
Reporter: Lincoln Baxter III
Assignee: Lincoln Baxter III
Setting the value to empty is as good as it gets, but it's not good enough because
this doesn't deploy.
unit.nonJtaDataSource("jndi:blah").jtaDataSource("jndi:blah")
Results in:
<jta-data-source>jndi:blah</jta-data-source>
<non-jta-data-source/>
But should be simply:
<jta-data-source>jndi:blah</jta-data-source>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:56 a.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-41) PersistenceUnitDefImpl does not remove non-jta-data-source when configuring jta-data-source (and visa versa)
[
https://issues.jboss.org/browse/SHRINKDESC-41?page=com.atlassian.jira.plu...
]
Lincoln Baxter III commented on SHRINKDESC-41:
----------------------------------------------
Fixed methods (depends on SHRINKDESC-39)
@Override
public PersistenceUnitDef nonJtaDataSource(String jndiName)
{
if (jndiName == null)
{
persistenceUnit.remove("non-jta-data-source");
}
else
{
persistenceUnit.removeSingle("jta-data-source");
persistenceUnit.getOrCreate("non-jta-data-source").text(jndiName);
}
return this;
}
@Override
public PersistenceUnitDef jtaDataSource(String jndiName)
{
if (jndiName == null)
{
persistenceUnit.remove("jta-data-source");
}
else
{
persistenceUnit.removeSingle("non-jta-data-source");
persistenceUnit.getOrCreate("jta-data-source").text(jndiName);
}
return this;
}
PersistenceUnitDefImpl does not remove non-jta-data-source when
configuring jta-data-source (and visa versa)
------------------------------------------------------------------------------------------------------------
Key: SHRINKDESC-41
URL: https://issues.jboss.org/browse/SHRINKDESC-41
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: api
Affects Versions: 0.1.3
Reporter: Lincoln Baxter III
Assignee: Lincoln Baxter III
Setting the value to empty is as good as it gets, but it's not good enough because
this doesn't deploy.
unit.nonJtaDataSource("jndi:blah").jtaDataSource("jndi:blah")
Results in:
<jta-data-source>jndi:blah</jta-data-source>
<non-jta-data-source/>
But should be simply:
<jta-data-source>jndi:blah</jta-data-source>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:07 a.m.
New subject: [JBoss JIRA] Updated: (SHRINKDESC-41) PersistenceUnitDefImpl does not remove non-jta-data-source when configuring jta-data-source (and visa versa)
[
https://issues.jboss.org/browse/SHRINKDESC-41?page=com.atlassian.jira.plu...
]
Lincoln Baxter III updated SHRINKDESC-41:
-----------------------------------------
Git Pull Request: https://github.com/shrinkwrap/descriptors/pull/19
PersistenceUnitDefImpl does not remove non-jta-data-source when
configuring jta-data-source (and visa versa)
------------------------------------------------------------------------------------------------------------
Key: SHRINKDESC-41
URL: https://issues.jboss.org/browse/SHRINKDESC-41
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: api
Affects Versions: 0.1.3
Reporter: Lincoln Baxter III
Assignee: Lincoln Baxter III
Setting the value to empty is as good as it gets, but it's not good enough because
this doesn't deploy.
unit.nonJtaDataSource("jndi:blah").jtaDataSource("jndi:blah")
Results in:
<jta-data-source>jndi:blah</jta-data-source>
<non-jta-data-source/>
But should be simply:
<jta-data-source>jndi:blah</jta-data-source>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:11 p.m.
New subject: [JBoss JIRA] Commented: (SHRINKDESC-41) PersistenceUnitDefImpl does not remove non-jta-data-source when configuring jta-data-source (and visa versa)
[
https://issues.jboss.org/browse/SHRINKDESC-41?page=com.atlassian.jira.plu...
]
Andrew Rubinger commented on SHRINKDESC-41:
-------------------------------------------
Lincoln: please verify the upstream satisfies this issue, then resolve.
PersistenceUnitDefImpl does not remove non-jta-data-source when
configuring jta-data-source (and visa versa)
------------------------------------------------------------------------------------------------------------
Key: SHRINKDESC-41
URL: https://issues.jboss.org/browse/SHRINKDESC-41
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: api
Affects Versions: 0.1.3
Reporter: Lincoln Baxter III
Assignee: Lincoln Baxter III
Setting the value to empty is as good as it gets, but it's not good enough because
this doesn't deploy.
unit.nonJtaDataSource("jndi:blah").jtaDataSource("jndi:blah")
Results in:
<jta-data-source>jndi:blah</jta-data-source>
<non-jta-data-source/>
But should be simply:
<jta-data-source>jndi:blah</jta-data-source>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:10 a.m.
New subject: [JBoss JIRA] Resolved: (SHRINKDESC-41) PersistenceUnitDefImpl does not remove non-jta-data-source when configuring jta-data-source (and visa versa)
[
https://issues.jboss.org/browse/SHRINKDESC-41?page=com.atlassian.jira.plu...
]
Lincoln Baxter III resolved SHRINKDESC-41.
------------------------------------------
Fix Version/s: 1.1.0-alpha-5
Resolution: Done
This is verified. Sorry, didn't see this notice.
PersistenceUnitDefImpl does not remove non-jta-data-source when
configuring jta-data-source (and visa versa)
------------------------------------------------------------------------------------------------------------
Key: SHRINKDESC-41
URL: https://issues.jboss.org/browse/SHRINKDESC-41
Project: ShrinkWrap Descriptors
Issue Type: Bug
Components: api
Affects Versions: 0.1.3
Reporter: Lincoln Baxter III
Assignee: Lincoln Baxter III
Fix For: 1.1.0-alpha-5
Setting the value to empty is as good as it gets, but it's not good enough because
this doesn't deploy.
unit.nonJtaDataSource("jndi:blah").jtaDataSource("jndi:blah")
Results in:
<jta-data-source>jndi:blah</jta-data-source>
<non-jta-data-source/>
But should be simply:
<jta-data-source>jndi:blah</jta-data-source>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4623
days inactive
4810
days old
shrinkwrap-issues@lists.jboss.org
4 comments
2 participants
participants (2)
-
Andrew Rubinger (JIRA) -
Lincoln Baxter III (JIRA)