[JBoss JIRA] (SHRINKWRAP-348) Deleting a directory specified by a File with a trailing slash does not work
9:28 a.m.
Deleting a directory specified by a File with a trailing slash does not work
----------------------------------------------------------------------------
Key: SHRINKWRAP-348
URL: https://issues.jboss.org/browse/SHRINKWRAP-348
Project: ShrinkWrap
Issue Type: Bug
Reporter: Geoffrey De Smet
Priority: Minor
We have a directory gwtutil with 10+ classes in there, which we want to delete from the
archive
This does nothing, it does not even fail-fast:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil/"));
{code}
This does work:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil"));
{code}
The difference is the absence of the trailing /.
Using arquillian bom CR5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:39 p.m.
[
https://issues.jboss.org/browse/SHRINKWRAP-348?page=com.atlassian.jira.pl...
]
Tommy Tynjä reassigned SHRINKWRAP-348:
--------------------------------------
Assignee: Tommy Tynjä
Deleting a directory specified by a File with a trailing slash does
not work
----------------------------------------------------------------------------
Key: SHRINKWRAP-348
URL: https://issues.jboss.org/browse/SHRINKWRAP-348
Project: ShrinkWrap
Issue Type: Bug
Reporter: Geoffrey De Smet
Assignee: Tommy Tynjä
Priority: Minor
We have a directory gwtutil with 10+ classes in there, which we want to delete from the
archive
This does nothing, it does not even fail-fast:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil/"));
{code}
This does work:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil"));
{code}
The difference is the absence of the trailing /.
Using arquillian bom CR5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:02 p.m.
[
https://issues.jboss.org/browse/SHRINKWRAP-348?page=com.atlassian.jira.pl...
]
Tommy Tynjä commented on SHRINKWRAP-348:
----------------------------------------
Paths wihtin archives are represented without the trailing slash, so the above mentioned
behaviour makes sense since the gwtutil path is represented within the archive as
"WEB-INF/classes/org/drools/guvnor/gwtutil" (without a trailing slash).
That's why the second operation works, while the first path won't match the path
within the archive.
It would be nice though if the first operation (path with trailing slash) would match the
path within the archive which has no trailing slash.
While writing a test case to reproduce/test this behaviour I found a bug in the
Archive.contains method, where deleted paths can still be indicated as present in the
archive, when they infact are not.
I'm working on a solution for both the handling of a possible trailing slash in the
path, as it would be a nice feature, as well as fixing the bug in the contains-method.
Deleting a directory specified by a File with a trailing slash does
not work
----------------------------------------------------------------------------
Key: SHRINKWRAP-348
URL: https://issues.jboss.org/browse/SHRINKWRAP-348
Project: ShrinkWrap
Issue Type: Bug
Reporter: Geoffrey De Smet
Assignee: Tommy Tynjä
Priority: Minor
We have a directory gwtutil with 10+ classes in there, which we want to delete from the
archive
This does nothing, it does not even fail-fast:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil/"));
{code}
This does work:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil"));
{code}
The difference is the absence of the trailing /.
Using arquillian bom CR5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:05 p.m.
[
https://issues.jboss.org/browse/SHRINKWRAP-348?page=com.atlassian.jira.pl...
]
Tommy Tynjä commented on SHRINKWRAP-348:
----------------------------------------
Pushed fix to fork: https://github.com/tommysdk/shrinkwrap/compare/SHRINKWRAP-348
Added two reproducing test cases which also discovered the suspicious behaviour in
Archive.contains. Added support for removing paths with trailing slash.
Deleting a directory specified by a File with a trailing slash does
not work
----------------------------------------------------------------------------
Key: SHRINKWRAP-348
URL: https://issues.jboss.org/browse/SHRINKWRAP-348
Project: ShrinkWrap
Issue Type: Bug
Reporter: Geoffrey De Smet
Assignee: Tommy Tynjä
Priority: Minor
We have a directory gwtutil with 10+ classes in there, which we want to delete from the
archive
This does nothing, it does not even fail-fast:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil/"));
{code}
This does work:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil"));
{code}
The difference is the absence of the trailing /.
Using arquillian bom CR5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:05 p.m.
[
https://issues.jboss.org/browse/SHRINKWRAP-348?page=com.atlassian.jira.pl...
]
Tommy Tynjä updated SHRINKWRAP-348:
-----------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/shrinkwrap/shrinkwrap/pull/51
Deleting a directory specified by a File with a trailing slash does
not work
----------------------------------------------------------------------------
Key: SHRINKWRAP-348
URL: https://issues.jboss.org/browse/SHRINKWRAP-348
Project: ShrinkWrap
Issue Type: Bug
Reporter: Geoffrey De Smet
Assignee: Tommy Tynjä
Priority: Minor
We have a directory gwtutil with 10+ classes in there, which we want to delete from the
archive
This does nothing, it does not even fail-fast:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil/"));
{code}
This does work:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil"));
{code}
The difference is the absence of the trailing /.
Using arquillian bom CR5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:05 p.m.
[
https://issues.jboss.org/browse/SHRINKWRAP-348?page=com.atlassian.jira.pl...
]
Work on SHRINKWRAP-348 started by Tommy Tynjä.
Deleting a directory specified by a File with a trailing slash does
not work
----------------------------------------------------------------------------
Key: SHRINKWRAP-348
URL: https://issues.jboss.org/browse/SHRINKWRAP-348
Project: ShrinkWrap
Issue Type: Bug
Reporter: Geoffrey De Smet
Assignee: Tommy Tynjä
Priority: Minor
We have a directory gwtutil with 10+ classes in there, which we want to delete from the
archive
This does nothing, it does not even fail-fast:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil/"));
{code}
This does work:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil"));
{code}
The difference is the absence of the trailing /.
Using arquillian bom CR5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:10 p.m.
[
https://issues.jboss.org/browse/SHRINKWRAP-348?page=com.atlassian.jira.pl...
]
Tommy Tynjä updated SHRINKWRAP-348:
-----------------------------------
Git Pull Request: https://github.com/shrinkwrap/shrinkwrap/pull/51 (was:
https://github.com/shrinkwrap/shrinkwrap/pull/51)
Affects Version/s: 1.0.0-cr-2
Deleting a directory specified by a File with a trailing slash does
not work
----------------------------------------------------------------------------
Key: SHRINKWRAP-348
URL: https://issues.jboss.org/browse/SHRINKWRAP-348
Project: ShrinkWrap
Issue Type: Bug
Affects Versions: 1.0.0-cr-2
Reporter: Geoffrey De Smet
Assignee: Tommy Tynjä
Priority: Minor
We have a directory gwtutil with 10+ classes in there, which we want to delete from the
archive
This does nothing, it does not even fail-fast:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil/"));
{code}
This does work:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil"));
{code}
The difference is the absence of the trailing /.
Using arquillian bom CR5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:26 p.m.
[
https://issues.jboss.org/browse/SHRINKWRAP-348?page=com.atlassian.jira.pl...
]
Andrew Rubinger updated SHRINKWRAP-348:
---------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 1.1.0-alpha-X
Resolution: Done
Upstream:
https://github.com/shrinkwrap/shrinkwrap/commit/2e7e2a234876fabccab348a6c...
Deleting a directory specified by a File with a trailing slash does
not work
----------------------------------------------------------------------------
Key: SHRINKWRAP-348
URL: https://issues.jboss.org/browse/SHRINKWRAP-348
Project: ShrinkWrap
Issue Type: Bug
Affects Versions: 1.0.0-cr-2
Reporter: Geoffrey De Smet
Assignee: Tommy Tynjä
Priority: Minor
Fix For: 1.1.0-alpha-X
We have a directory gwtutil with 10+ classes in there, which we want to delete from the
archive
This does nothing, it does not even fail-fast:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil/"));
{code}
This does work:
{code}
webArchive.delete(ArchivePaths.create("WEB-INF/classes/org/drools/guvnor/gwtutil"));
{code}
The difference is the absence of the trailing /.
Using arquillian bom CR5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4449
days inactive
4591
days old
shrinkwrap-issues@lists.jboss.org
7 comments
3 participants
participants (3)
-
Andrew Rubinger (JIRA) -
Geoffrey De Smet (Created) (JIRA)
-
Tommy Tynjä (JIRA)